Re: [Qemu-block] [PATCH for-2.12 0/2] qcow2: add overlap check for bitmap directory

2018-03-16 Thread John Snow
On 11/30/2017 11:47 AM, Vladimir Sementsov-Ogievskiy wrote: > Add simple constant overlap check. > > Vladimir Sementsov-Ogievskiy (2): > qcow2: add overlap check for bitmap directory > qcow2: fix indentation after previous patch > > block/qcow2.h | 45

Re: [Qemu-block] [PULL v2 00/44] Block layer patches

2018-03-16 Thread Peter Maydell
On 15 March 2018 at 17:18, Kevin Wolf wrote: > The following changes since commit 56e8698ffa8aba9f762f980bc21b5340b006f24b: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-travis-speedup-130318-1' into staging (2018-03-15 > 14:48:09 +) > > are available in

[Qemu-block] [PATCH] block/xen_disk: Convert atoi use to qemu_strtol to allow error checking

2018-03-16 Thread Nia Alarie
Signed-off-by: Nia Alarie --- hw/block/xen_disk.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index f74fcd42d1..a9ec0ad6eb 100644 --- a/hw/block/xen_disk.c +++ b/hw/block/xen_disk.c @@ -32,6 +32,7 @@

Re: [Qemu-block] [PATCH] block/xen_disk: Convert atoi use to qemu_strtol to allow error checking

2018-03-16 Thread nee
On Fri, Mar 16, 2018 at 2:43 PM, Nia Alarie wrote: > Signed-off-by: Nia Alarie > --- > hw/block/xen_disk.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c > index

Re: [Qemu-block] [PATCH v8 8/9] qcow2: skip writing zero buffers to empty COW areas

2018-03-16 Thread Anton Nefedov
On 16/3/2018 4:58 PM, Alberto Garcia wrote: On Mon 12 Mar 2018 11:16:57 AM CET, Anton Nefedov wrote: --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2584,6 +2584,8 @@ # # @cor_write: a write due to copy-on-read (since 2.11) # +# @cluster_alloc_space: an allocation of a cluster

Re: [Qemu-block] [PATCH v2 for-2.12] iotests: Avoid realpath, for CentOS 6

2018-03-16 Thread Kevin Wolf
Am 15.03.2018 um 12:51 hat Eric Blake geschrieben: > CentOS 6 lacks a realpath binary on the base install, which makes > all iotests runs fail since the 2.11 release: > > 001 - output mismatch (see 001.out.bad) > ./check: line 815: realpath: command not found > diff: missing operand after

Re: [Qemu-block] [PATCH v8 6/9] file-posix: support BDRV_REQ_ALLOCATE

2018-03-16 Thread Anton Nefedov
On 12/3/2018 1:16 PM, Anton Nefedov wrote: Current write_zeroes implementation is good enough to satisfy this flag too Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz strictly speaking this

Re: [Qemu-block] [Qemu-devel] [PULL 7/7] vl: introduce vm_shutdown()

2018-03-16 Thread Christian Borntraeger
On 03/12/2018 08:05 PM, John Snow wrote: > > > On 03/09/2018 08:19 AM, Stefan Hajnoczi wrote: >> Commit 00d09fdbbae5f7864ce754913efc84c12fdf9f1a ("vl: pause vcpus before >> stopping iothreads") and commit dce8921b2baaf95974af8176406881872067adfa >> ("iothread: Stop threads before main() quits")

Re: [Qemu-block] [PATCH v8 4/9] block: introduce BDRV_REQ_ALLOCATE flag

2018-03-16 Thread Anton Nefedov
On 16/3/2018 2:01 PM, Alberto Garcia wrote: On Mon 12 Mar 2018 11:16:53 AM CET, Anton Nefedov wrote: The flag is supposed to indicate that the region of the disk image has to be sufficiently allocated so it reads as zeroes. The call with the flag set must return -ENOTSUP if allocation cannot

Re: [Qemu-block] [PATCH] vvfat: Fix inherit_options flags

2018-03-16 Thread Stefan Hajnoczi
On Thu, Mar 15, 2018 at 11:45:07AM +0800, Fam Zheng wrote: > Overriding flags violates the precedence rules of > bdrv_reopen_queue_child. Just like the read-only option, no-flush should > be put into the options. The same is done in bdrv_temp_snapshot_options. > > Reported-by: Stefan Hajnoczi

[Qemu-block] [PULL 07/38] qapi: Replace qobject_to_X(o) by qobject_to(X, o)

2018-03-16 Thread Eric Blake
From: Max Reitz This patch was generated using the following Coccinelle script: @@ expression Obj; @@ ( - qobject_to_qnum(Obj) + qobject_to(QNum, Obj) | - qobject_to_qstring(Obj) + qobject_to(QString, Obj) | - qobject_to_qdict(Obj) + qobject_to(QDict, Obj) | -

Re: [Qemu-block] [PATCH v8 8/9] qcow2: skip writing zero buffers to empty COW areas

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:57 AM CET, Anton Nefedov wrote: > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2584,6 +2584,8 @@ > # > # @cor_write: a write due to copy-on-read (since 2.11) > # > +# @cluster_alloc_space: an allocation of a cluster file space (since 2.12) That doesn't

Re: [Qemu-block] [PATCH 1/1] block: fix iotest 146 output expectations

2018-03-16 Thread Kevin Wolf
Am 12.03.2018 um 22:29 hat Jeff Cody geschrieben: > Commit bff5554843 added "force_size" into the common.filter for > _filter_img_create(), but test 146 still expects it in the output. > > Signed-off-by: Jeff Cody Thanks, applied to the block branch. Kevin

Re: [Qemu-block] [PATCH v2 0/3] Add new CD-ROM related qtests

2018-03-16 Thread Michael S. Tsirkin
On Fri, Mar 16, 2018 at 06:39:52AM +0100, Thomas Huth wrote: > With one of my clean-up patches (see commit 1454509726719e0933c800), I > recently accidentially broke the "-cdrom" parameter (more precisely > "-drive if=scsi") on a couple of boards, since there was no error > detected during the

Re: [Qemu-block] [Qemu-devel] [PULL 00/41] Block layer patches

2018-03-16 Thread Kevin Wolf
Am 15.03.2018 um 18:55 hat John Snow geschrieben: > > > On 03/15/2018 12:56 PM, Kevin Wolf wrote: > > Am 15.03.2018 um 17:42 hat Peter Maydell geschrieben: > >> On 13 March 2018 at 16:17, Kevin Wolf wrote: > >>> The following changes since commit > >>>

Re: [Qemu-block] [PATCH v2 2/3] tests/cdrom-test: Test booting from CD-ROM ISO image file

2018-03-16 Thread Philippe Mathieu-Daudé
On 03/16/2018 06:39 AM, Thomas Huth wrote: > We already have the code for a boot file in tests/boot-sector.c, > so if the genisoimage program is available, we can easily create > a bootable CD ISO image that we can use for testing whether our > CD-ROM emulation and the BIOS CD-ROM boot works

Re: [Qemu-block] [PATCH v2 1/3] tests/boot-sector: Add magic bytes to s390x boot code header

2018-03-16 Thread Philippe Mathieu-Daudé
On 03/16/2018 06:39 AM, Thomas Huth wrote: > We're going to use the s390x boot code for testing CD-ROM booting. > But the ISO loader of the s390-ccw bios is a little bit more picky > than the network loader and expects some magic bytes in the header > of the file (see linux_s390_magic in

Re: [Qemu-block] [PATCH v8 7/9] block: support BDRV_REQ_ALLOCATE in passthrough drivers

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:56 AM CET, Anton Nefedov wrote: > Support the flag if the underlying BDS supports it > > Signed-off-by: Anton Nefedov > Reviewed-by: Alberto Garcia This is again not the patch that I reviewed (the quorum bits were not

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] Add new CD-ROM related qtests

2018-03-16 Thread Mark Cave-Ayland
On 16/03/18 05:39, Thomas Huth wrote: With one of my clean-up patches (see commit 1454509726719e0933c800), I recently accidentially broke the "-cdrom" parameter (more precisely "-drive if=scsi") on a couple of boards, since there was no error detected during the "make check" regression testing.

Re: [Qemu-block] [PATCH v8 4/9] block: introduce BDRV_REQ_ALLOCATE flag

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:53 AM CET, Anton Nefedov wrote: > The flag is supposed to indicate that the region of the disk image has > to be sufficiently allocated so it reads as zeroes. > > The call with the flag set must return -ENOTSUP if allocation cannot > be done efficiently. > This has to be

Re: [Qemu-block] [PATCH v8 3/9] quorum: set supported write/zero flags

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:52 AM CET, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

Re: [Qemu-block] [PATCH v8 1/9] mirror: inherit supported write/zero flags

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:50 AM CET, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov > --- > block/mirror.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/block/mirror.c b/block/mirror.c > index f5bf620..2fb786f 100644 > --- a/block/mirror.c