Re: [Qemu-block] [Qemu-devel] [PULL 00/19] Block layer patches

2018-03-27 Thread Peter Maydell
On 26 March 2018 at 15:35, Kevin Wolf wrote: > The following changes since commit 7b1db0908d88f0c9cfac24e214ff72a860692e23: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180323' into staging (2018-03-25 > 13:51:33 +0100) > > are available in the git repository at:

Re: [Qemu-block] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

2018-03-27 Thread Vladimir Sementsov-Ogievskiy
26.03.2018 21:06, Max Reitz wrote: On 2018-03-20 18:05, Vladimir Sementsov-Ogievskiy wrote: Hi all. This fixes bitmaps migration through shared storage. Look at 02 for details. The bug introduced in 2.10 with the whole qcow2 bitmaps feature, so qemu-stable in CC. However I doubt that someone r

Re: [Qemu-block] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

2018-03-27 Thread Vladimir Sementsov-Ogievskiy
27.03.2018 12:28, Vladimir Sementsov-Ogievskiy wrote: 26.03.2018 21:06, Max Reitz wrote: On 2018-03-20 18:05, Vladimir Sementsov-Ogievskiy wrote: Hi all. This fixes bitmaps migration through shared storage. Look at 02 for details. The bug introduced in 2.10 with the whole qcow2 bitmaps featur

Re: [Qemu-block] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

2018-03-27 Thread Vladimir Sementsov-Ogievskiy
27.03.2018 12:53, Vladimir Sementsov-Ogievskiy wrote: 27.03.2018 12:28, Vladimir Sementsov-Ogievskiy wrote: 26.03.2018 21:06, Max Reitz wrote: On 2018-03-20 18:05, Vladimir Sementsov-Ogievskiy wrote: Hi all. This fixes bitmaps migration through shared storage. Look at 02 for details. The bug

Re: [Qemu-block] [PATCH 0/3] coroutine: avoid co_queue_wakeup recursion

2018-03-27 Thread Stefan Hajnoczi
On Thu, Mar 22, 2018 at 03:28:31PM +, Stefan Hajnoczi wrote: > co_queue_wakeup is currently implemented in a recursive fashion. Pathological > patterns of aio_co_enter() between coroutines can cause stack exhaustion. > > This patch series implements co_queue_wakeup iteratively and avoids stac

[Qemu-block] [PATCH for 2.12 1/1] block: allow recursive calling of bdrv_set_aio_context

2018-03-27 Thread Denis V. Lunev
We have received the following assert on QEMU 2.9: (gdb) bt 0 0x7f6f67d281f7 in __GI_raise () 1 0x7f6f67d298e8 in __GI_abort () 2 0x7f6f67d21266 in __assert_fail_base () 3 0x7f6f67d21312 in __GI___assert_fail () 4 0x55a8faf76f9f in bdrv_detach_aio_context () 5 0x55a8f

Re: [Qemu-block] [PULL 0/4] Block patches for 2.12.0-rc1

2018-03-27 Thread Peter Maydell
On 26 March 2018 at 21:20, Max Reitz wrote: > The following changes since commit 7b93d78a04aa242d377ae213b79db6c319c71847: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-03-26 15:17:25 +0100) > > are available in the Git repository at: > > git://gith

[Qemu-block] [PULL 05/14] qdict: remove useless cast

2018-03-27 Thread Eric Blake
From: Laurent Vivier Re-run Coccinelle script scripts/coccinelle/qobject.cocci Signed-off-by: Laurent Vivier Message-Id: <20180323143202.28879-5-lviv...@redhat.com> Reviewed-by: Eric Blake Acked-by: Dr. David Alan Gilbert Acked-by: Fam Zheng Signed-off-by: Eric Blake --- block/nvme.c | 11

[Qemu-block] [PATCH] blockjob: use qapi enum helpers

2018-03-27 Thread Marc-André Lureau
QAPI generator provide #define helpers for looking up enum string. Signed-off-by: Marc-André Lureau --- blockjob.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/blockjob.c b/blockjob.c index ef3ed69ff1..11c9ce124d 100644 --- a/blockjob.c +++ b/blockjob.c @@ -

[Qemu-block] [PATCH] blockjob: leak fix, remove from txn when failing early

2018-03-27 Thread Marc-André Lureau
This fixes leaks found by ASAN such as: GTESTER tests/test-blockjob = ==31442==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f88483cba38 in __interceptor_calloc (/lib6

Re: [Qemu-block] [PATCH] blockjob: use qapi enum helpers

2018-03-27 Thread John Snow
On 03/27/2018 11:30 AM, Marc-André Lureau wrote: > QAPI generator provide #define helpers for looking up enum string. > > Signed-off-by: Marc-André Lureau > --- > blockjob.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/blockjob.c b/blockjob.c > index

Re: [Qemu-block] [Qemu-devel] [PATCH 5.5/7] dirty-bitmap: drop unused bdrv_undo_clear_dirty_bitmap

2018-03-27 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180326115346.11939-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH 5.5/7] dirty

Re: [Qemu-block] [PATCH] blockjob: leak fix, remove from txn when failing early

2018-03-27 Thread John Snow
On 03/27/2018 12:07 PM, Marc-André Lureau wrote: > This fixes leaks found by ASAN such as: > GTESTER tests/test-blockjob > = > ==31442==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 24 byte(s) in 1 object(s) alloc

Re: [Qemu-block] [PATCH] blockjob: leak fix, remove from txn when failing early

2018-03-27 Thread Jeff Cody
On Tue, Mar 27, 2018 at 06:07:36PM +0200, Marc-André Lureau wrote: > This fixes leaks found by ASAN such as: > GTESTER tests/test-blockjob > = > ==31442==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 24 byte(s) in 1

[Qemu-block] [PATCH for-2.12] nbd: Fix 32-bit compilation on BLOCK_STATUS

2018-03-27 Thread Eric Blake
iotests 123 and 209 fail on 32-bit platforms. The culprit: sizeof(extent) is wrong; we want sizeof(*extent). But since the struct is 8 bytes, it happened to work on 64-bit platforms where the pointer is also 8 bytes (nasty). Fixes: 78a33ab58 Reported-by: Max Reitz Signed-off-by: Eric Blake ---

Re: [Qemu-block] [PATCH for-2.12] nbd: Fix 32-bit compilation on BLOCK_STATUS

2018-03-27 Thread Paolo Bonzini
On 27/03/2018 23:05, Eric Blake wrote: > iotests 123 and 209 fail on 32-bit platforms. The culprit: > sizeof(extent) is wrong; we want sizeof(*extent). But since > the struct is 8 bytes, it happened to work on 64-bit platforms > where the pointer is also 8 bytes (nasty). > > Fixes: 78a33ab58 > R

Re: [Qemu-block] [PATCH] blockjob: leak fix, remove from txn when failing early

2018-03-27 Thread John Snow
On 03/27/2018 04:10 PM, Jeff Cody wrote: > On Tue, Mar 27, 2018 at 06:07:36PM +0200, Marc-André Lureau wrote: >> This fixes leaks found by ASAN such as: >> GTESTER tests/test-blockjob >> = >> ==31442==ERROR: LeakSanitizer: detected