Re: [Qemu-block] [PATCH v2 6/8] replication: Switch to byte-based calls

On Thu, May 31, 2018 at 03:50:44PM -0500, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the last few sector-based calls > into the block layer from the replication driver. > > Ideally, the replication driver should switch

Re: [Qemu-block] [PATCH v2 8/8] block: Remove unused sector-based vectored I/O

On Thu, May 31, 2018 at 03:50:46PM -0500, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Now that all callers of vectored I/O have been converted > to use our preferred byte-based bdrv_co_p{read,write}v(), we can > delete the unused

Re: [Qemu-block] [PATCH v2 7/8] vhdx: Switch to byte-based calls

On Thu, May 31, 2018 at 03:50:45PM -0500, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the last few sector-based calls > into the block layer from the vhdx driver. > > Ideally, the vhdx driver should switch to doing

Re: [Qemu-block] [PATCH v7 00/10] qemu-img convert with copy offloading

On Wed, 05/30 17:06, Stefan Hajnoczi wrote: > On Tue, May 29, 2018 at 01:59:49PM +0800, Fam Zheng wrote: > > v7: Fix qcow2. > > > > v6: Pick up rev-by from Stefan and Eric. > > Tweak patch 2 commit message. > > > > v5: - Fix raw offset/bytes check for read. [Eric] > > - Fix

Re: [Qemu-block] [PATCH v2 1/8] parallels: Switch to byte-based calls

On Thu, May 31, 2018 at 03:50:39PM -0500, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the last few sector-based calls > into the block layer from the parallels driver. > > Ideally, the parallels driver should switch to

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/4] Add new CD-ROM related qtests

On 04/27/2018 05:40 AM, Thomas Huth wrote: > With one of my clean-up patches (see commit 1454509726719e0933c800), I > recently accidentially broke the "-cdrom" parameter (more precisely > "-drive if=scsi") on a couple of boards, since there was no error > detected during the "make check"

Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/16] AHCI: tracing improvements

On 05/31/2018 06:28 PM, John Snow wrote: > This set just adds register names so that the read/write traces make > more sense on their own without having to memorize register offsets. > It also splits read/write traces into supported/unsupported subsets, > so you can just monitor for things that

Re: [Qemu-block] [PATCH 0/3] ahci: fix completion race condition

On 05/30/2018 08:43 PM, John Snow wrote: > Commit d759c951f changed the main thread lock release/reacquisition, > and in so doing apparently jostled loose a race condition in the AHCI > code. > > Patch 2 should be sufficient to fix this, and patches 1 and 3 are just > little trivial fixes. >

Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/16] AHCI: tracing improvements

On 05/31/2018 06:49 PM, no-re...@patchew.org wrote: > Hi, > > This series failed docker-mingw@fedora build test. Please find the testing > commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. > [ blah blah blah ] > In file included

Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/16] AHCI: tracing improvements

On 05/31/2018 06:47 PM, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180531222835.16558-1-js...@redhat.com > Subject: [Qemu-devel] [PATCH v2 00/16] AHCI: tracing

Re: [Qemu-block] [PATCH v2 00/16] AHCI: tracing improvements

On 05/31/2018 07:28 PM, John Snow wrote: > This set just adds register names so that the read/write traces make > more sense on their own without having to memorize register offsets. > It also splits read/write traces into supported/unsupported subsets, > so you can just monitor for things that

Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/16] AHCI: tracing improvements

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180531222835.16558-1-js...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/16] AHCI:

Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/16] AHCI: tracing improvements

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180531222835.16558-1-js...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/16] AHCI: tracing improvements === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-block] [PATCH v2 14/16] ahci: adjust ahci_mem_write to work on registers

Actually, this function looks pretty broken, but for now, let's finish up what this series of commits came here to do. Signed-off-by: John Snow --- hw/ide/ahci.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index

[Qemu-block] [PATCH v2 12/16] ahci: make mem_read_32 traces more descriptive

Signed-off-by: John Snow --- hw/ide/ahci.c | 7 +-- hw/ide/trace-events | 3 +++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 7edbb30f60..5e902c6615 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -47,7 +47,6 @@ static bool

[Qemu-block] [PATCH v2 13/16] ahci: fix spacing damage on ahci_mem_write

Signed-off-by: John Snow --- hw/ide/ahci.c | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 5e902c6615..568e6b848a 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -469,37 +469,36 @@ static

[Qemu-block] [PATCH v2 15/16] ahci: delete old host register address definitions

Signed-off-by: John Snow --- hw/ide/ahci_internal.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h index f9dcf8b6e6..2953243929 100644 --- a/hw/ide/ahci_internal.h +++ b/hw/ide/ahci_internal.h @@ -55,12 +55,6 @@ #define RX_FIS_UNK

[Qemu-block] [PATCH v2 16/16] ahci: make ahci_mem_write traces more descriptive

Signed-off-by: John Snow --- hw/ide/ahci.c | 13 - hw/ide/trace-events | 4 +++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 1309f80458..6cab853741 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -494,13 +494,24 @@

[Qemu-block] [PATCH v2 10/16] ahci: fix host register max address

Yes, comment, it ought to be 0x2C. Signed-off-by: John Snow --- hw/ide/ahci_internal.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h index af366db6f3..f9dcf8b6e6 100644 --- a/hw/ide/ahci_internal.h +++

[Qemu-block] [PATCH v2 11/16] ahci: modify ahci_mem_read_32 to work on register numbers

Signed-off-by: John Snow --- hw/ide/ahci.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index f2e8bce797..7edbb30f60 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -386,22 +386,27 @@ static uint64_t ahci_mem_read_32(void

[Qemu-block] [PATCH v2 09/16] ahci: add host register enumeration

Signed-off-by: John Snow --- hw/ide/ahci.c | 15 +++ hw/ide/ahci_internal.h | 15 +++ 2 files changed, 30 insertions(+) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 01463f0f51..f2e8bce797 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -47,6 +47,21 @@

[Qemu-block] [PATCH v2 07/16] ahci: make port write traces more descriptive

Signed-off-by: John Snow --- hw/ide/ahci.c | 8 +++- hw/ide/trace-events | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index efecf849a9..01463f0f51 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -27,6 +27,7 @@ #include

[Qemu-block] [PATCH v2 08/16] ahci: delete old port register address definitions

They're now unused. Signed-off-by: John Snow --- hw/ide/ahci_internal.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h index eb7e1eefc0..db00c9aa39 100644 --- a/hw/ide/ahci_internal.h +++ b/hw/ide/ahci_internal.h @@ -102,24

[Qemu-block] [PATCH v2 04/16] ahci: fix spacing damage on ahci_port_write

Churn. Signed-off-by: John Snow --- hw/ide/ahci.c | 142 +- 1 file changed, 71 insertions(+), 71 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 5b5ab823f4..92780990a3 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@

[Qemu-block] [PATCH v2 00/16] AHCI: tracing improvements

This set just adds register names so that the read/write traces make more sense on their own without having to memorize register offsets. It also splits read/write traces into supported/unsupported subsets, so you can just monitor for things that QEMU is likely doing wrong. v2: - Added

[Qemu-block] [PATCH v2 01/16] ahci: add port register enumeration

Instead of tracking offsets, lets count the registers. Signed-off-by: John Snow --- hw/ide/ahci.c | 25 + hw/ide/ahci_internal.h | 29 + 2 files changed, 54 insertions(+) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index

[Qemu-block] [PATCH v2 02/16] ahci: modify ahci_port_read to use register numbers

Signed-off-by: John Snow --- hw/ide/ahci.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 48130c6439..5187bf34ad 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -93,41 +93,42 @@ static const char

[Qemu-block] [PATCH v2 06/16] ahci: modify ahci_port_write to use register numbers

Signed-off-by: John Snow --- hw/ide/ahci.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 476841df58..efecf849a9 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -282,30 +282,32 @@ static int

[Qemu-block] [PATCH v2 03/16] ahci: make port read traces more descriptive

A trace is added to let us watch unimplemented registers specifically, as these are more likely to cause us trouble. Otherwise, the port read traces now tell us what register is getting hit, which is nicer. Signed-off-by: John Snow --- hw/ide/ahci.c | 5 +++-- hw/ide/trace-events | 3 ++-

[Qemu-block] [PATCH v2 05/16] ahci: combine identical clauses in port write

Signed-off-by: John Snow --- hw/ide/ahci.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 92780990a3..476841df58 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -330,11 +330,7 @@ static void ahci_port_write(AHCIState *s, int port, int offset,

Re: [Qemu-block] [PATCH] block: Ignore generated job QAPI files

On Thu, May 31, 2018 at 04:24:35PM -0500, Eric Blake wrote: > Commit bf42508f introduced new generated files; make sure they > don't get accidentally committed from an in-tree build. > > Signed-off-by: Eric Blake Reviewed-by: Jeff Cody > --- > .gitignore | 4 > 1 file changed, 4

[Qemu-block] [PATCH] block: Ignore generated job QAPI files

Commit bf42508f introduced new generated files; make sure they don't get accidentally committed from an in-tree build. Signed-off-by: Eric Blake --- .gitignore | 4 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 81e1f2fb0f1..9da3b3e6267 100644 --- a/.gitignore

Re: [Qemu-block] [PATCH v2 34/40] job: Introduce qapi/job.json

On 05/18/2018 08:21 AM, Kevin Wolf wrote: This adds a separate schema file for all job-related definitions that aren't tied to the block layer. For a start, move the enums JobType, JobStatus and JobVerb. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 90

[Qemu-block] [PATCH 5/5] block/blklogwrites: Use the block device logical sector size when logging writes

The guest OS may perform writes which are aligned to the logical sector size instead of the physical one, so logging at this granularity records the writes performed on the block device most faithfully. Signed-off-by: Ari Sundholm --- block/blklogwrites.c | 43

[Qemu-block] [PATCH 4/5] block/blklogwrites: Use block limits from the backend block configuration

This is to ensure that writes are aligned properly for logging writes to the virtual block device. This is important because the dm-log-writes log format has a granularity of one sector for both the offset and the size of each write. By using the logical sector size for alignment, the log records

[Qemu-block] [PATCH 1/5] block: Add blklogwrites

From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel device mapper dm-log-writes. The write operations that are performed on a block device are logged to a file or another block device. The write log format is identical to the dm-log-writes format.

[Qemu-block] [PATCH 2/5] block: Add a mechanism for passing a block driver a block configuration

A block driver may need to know about the block configuration, most critically the sector sizes, of a block backend for alignment purposes or for some other reason. It doesn't seem like qemu has an existing mechanism for a block backend to convey the required information to the relevant block

[Qemu-block] [PATCH v2 7/8] vhdx: Switch to byte-based calls

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based calls into the block layer from the vhdx driver. Ideally, the vhdx driver should switch to doing everything byte-based, but that's a more invasive change that requires a

[Qemu-block] [PATCH v2 6/8] replication: Switch to byte-based calls

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based calls into the block layer from the replication driver. Ideally, the replication driver should switch to doing everything byte-based, but that's a more invasive change

[Qemu-block] [PATCH v2 5/8] qcow: Switch to a byte-based driver

We are gradually moving away from sector-based interfaces, towards byte-based. The qcow driver is now ready to fully utilize the byte-based callback interface, as long as we override the default alignment to still be 512 (needed at least for asserts present because of encryption, but easier to do

[Qemu-block] [PATCH v2 4/8] qcow: Switch qcow_co_writev to byte-based calls

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the internals of the qcow driver write function, by iterating over offset/bytes instead of sector_num/nb_sectors, and with a rename of index_in_cluster and repurposing of n to track bytes instead of

[Qemu-block] [PATCH v2 0/8] block: more byte-based cleanups: vectored I/O

My quest continues. I spent some time pruning sector-based usage out of qcow as far as possible (and was dismayed at how long it took to prove no iotests regressions); so for the other drivers, I did the bare minimum to get rid of an interface, but will leave it to those file owners if they want

[Qemu-block] [PATCH v2 3/8] qcow: Switch qcow_co_readv to byte-based calls

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the internals of the qcow driver read function, by iterating over offset/bytes instead of sector_num/nb_sectors, and with a rename of index_in_cluster and repurposing of n to track bytes instead of

[Qemu-block] [PATCH v2 2/8] qcow: Switch get_cluster_offset to be byte-based

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the internal helper function get_cluster_offset(), by changing n_start and n_end to by byte offsets rather than sector indices within the cluster being allocated. However, assert that these values

[Qemu-block] [PATCH v2 1/8] parallels: Switch to byte-based calls

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based calls into the block layer from the parallels driver. Ideally, the parallels driver should switch to doing everything byte-based, but that's a more invasive change that

Re: [Qemu-block] [ovirt-users] Re: Debugging ceph access

On Thu, May 31, 2018 at 1:55 AM Bernhard Dick wrote: > Hi, > > I found the reason for my timeout problems: It is the version of librbd1 > (which is 0.94.5) in conjunction with my CEPH test-environment which is > running the luminous release. > When I install the librbd1 (and librados2) packages

Re: [Qemu-block] [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

On 05/30/2018 05:28 PM, Philippe Mathieu-Daudé wrote: > On 05/30/2018 05:17 PM, John Snow wrote: >> On 05/26/2018 12:44 AM, Philippe Mathieu-Daudé wrote: >>> Hi John, >>> >>> On 05/25/2018 08:54 PM, John Snow wrote: A trace is added to let us watch unimplemented registers specifically,

Re: [Qemu-block] [PATCH 3/3] ahci: don't schedule unnecessary BH

On Wed, May 30, 2018 at 08:43:23PM -0400, John Snow wrote: > The comment gives us a hint. *Maybe* we still have something to > process. Well, why not check? Heh :) Reviewed-by: Jeff Cody > > Signed-off-by: John Snow > --- > hw/ide/ahci.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [Qemu-block] [PATCH 2/3] ahci: fix PxCI register race

On Wed, May 30, 2018 at 08:43:22PM -0400, John Snow wrote: > AHCI presently signals completion prior to the PxCI register being > cleared to indicate completion. If a guest driver attempts to issue > a new command in its IRQ handler, it might be surprised to learn there > is still a command

Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] ahci: fix PxCI register race

>From comments on the cover letter, I am adding: Fixes: https://bugs.launchpad.net/qemu/+bug/1769189 On 05/30/2018 08:43 PM, John Snow wrote: > AHCI presently signals completion prior to the PxCI register being > cleared to indicate completion. If a guest driver attempts to issue > a new command

Re: [Qemu-block] [PATCH 1/3] ahci: trim signatures on raise/lower

On Wed, May 30, 2018 at 08:43:21PM -0400, John Snow wrote: > These functions work on the AHCI device, not the individual > AHCI devices, so trim the AHCIDevice argument. > > Signed-off-by: John Snow > --- > hw/ide/ahci.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff

Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower

On 05/31/2018 10:56 AM, Eric Blake wrote: > On 05/30/2018 07:43 PM, John Snow wrote: >> These functions work on the AHCI device, not the individual > > s/device/state/ ? > It's confusing; the AHCI device itself (the HBA) is represented by the struct AHCIState. the SATA devices are referred

Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower

On 05/30/2018 07:43 PM, John Snow wrote: These functions work on the AHCI device, not the individual s/device/state/ ? AHCI devices, so trim the AHCIDevice argument. Signed-off-by: John Snow --- hw/ide/ahci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Eric

Re: [Qemu-block] [PATCH] main-loop: drop spin_counter

On Wed, May 30, 2018 at 08:42:38PM +0100, Stefan Hajnoczi wrote: > Commit d759c951f3287fad04210a52f2dc93f94cf58c7f ("replay: push > replay_mutex_lock up the call tree") removed the !timeout lock > optimization in the main loop. > > The idea of the optimization was to avoid ping-pongs between

Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition

>>> On 5/31/2018 at 7:06 AM, Philippe Mathieu-Daudé wrote: > Hi Bruce, > > On 05/31/2018 09:21 AM, Bruce Rogers wrote: > On 5/30/2018 at 6:43 PM, John Snow wrote: >>> Commit d759c951f changed the main thread lock release/reacquisition, >>> and in so doing apparently jostled loose a race

Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition

Hi Bruce, On 05/31/2018 09:21 AM, Bruce Rogers wrote: On 5/30/2018 at 6:43 PM, John Snow wrote: >> Commit d759c951f changed the main thread lock release/reacquisition, >> and in so doing apparently jostled loose a race condition in the AHCI >> code. >> >> Patch 2 should be sufficient to fix

Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition

>>> On 5/30/2018 at 6:43 PM, John Snow wrote: > Commit d759c951f changed the main thread lock release/reacquisition, > and in so doing apparently jostled loose a race condition in the AHCI > code. > > Patch 2 should be sufficient to fix this, and patches 1 and 3 are just > little trivial fixes.

Re: [Qemu-block] [PATCH] main-loop: drop spin_counter

On 30/05/2018 21:42, Stefan Hajnoczi wrote: > Commit d759c951f3287fad04210a52f2dc93f94cf58c7f ("replay: push > replay_mutex_lock up the call tree") removed the !timeout lock > optimization in the main loop. > > The idea of the optimization was to avoid ping-pongs between threads by > keeping the

Re: [Qemu-block] [Qemu-devel] Some question about savem/qcow2 incremental snapshot

On Wed, May 30, 2018 at 06:07:19PM +0200, Kevin Wolf wrote: > Am 30.05.2018 um 16:44 hat Stefan Hajnoczi geschrieben: > > On Mon, May 14, 2018 at 02:48:47PM +0100, Stefan Hajnoczi wrote: > > > On Fri, May 11, 2018 at 07:25:31PM +0200, Kevin Wolf wrote: > > > > Am 10.05.2018 um 10:26 hat Stefan

Re: [Qemu-block] [Qemu-devel] [PULL 00/17] Block layer patches

On 30 May 2018 at 16:56, Kevin Wolf wrote: > Merge remote-tracking branch > 'remotes/edgar/tags/edgar/xilinx-next-2018-05-29-v1.for-upstream' into > staging (2018-05-29 13:01:11 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for

Re: [Qemu-block] [PATCH 0/3] ahci: fix completion race condition

On Thu, May 31, 2018 at 1:43 AM, John Snow wrote: > Commit d759c951f changed the main thread lock release/reacquisition, > and in so doing apparently jostled loose a race condition in the AHCI > code. > > Patch 2 should be sufficient to fix this, and patches 1 and 3 are just > little trivial