On 10.07.2018 17:24, Peter Krempa wrote:
> On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
>> On Tue, 10 Jul 2018 16:39:31 +0200
>> Peter Krempa wrote:
>>> On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote:
On Tue, 10 Jul 2018 07:59:15 +0200
Markus Armbruster wrot
197 is one example where _make_test_img is used twice without stopping
the NBD server in between. An error will occur like this:
@@ -26,9 +26,13 @@
=== Partial final cluster ===
+qemu-img: TEST_DIR/t.IMGFMT: Failed to get "resize" lock
+Is another process using the image?
F
Explicitly enabling zero detection or compression suppresses copy
offloading during convert. Document it.
Suggested-by: Kevin Wolf
Signed-off-by: Fam Zheng
---
qemu-img.texi | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qemu-img.texi b/qemu-img.texi
index aeb1b9e66c.
> Am 10.07.2018 um 17:31 schrieb Kevin Wolf :
>
> Am 10.07.2018 um 17:05 hat Peter Lieven geschrieben:
>> We currently don't enforce that the sparse segments we detect during convert
>> are
>> aligned. This leads to unnecessary and costly read-modify-write cycles either
>> internally in Qemu o
On 10 July 2018 at 16:42, Kevin Wolf wrote:
> The following changes since commit b34181056c04e05db6c632063012beaee7006a37:
>
> Merge remote-tracking branch 'remotes/rth/tags/pull-sh4-20180709' into
> staging (2018-07-09 22:44:22 +0100)
>
> are available in the git repository at:
>
> git://rep
Adjust each caller of raw_open_common to specify if they are expecting
host and character devices or not. Tighten expectations of file types upon
open in the common code and refuse types that are not expected.
This has two effects:
(1) Character and block devices are now considered deprecated for
On Tue, Jul 10, 2018 at 05:01:22PM +0200, Cornelia Huck wrote:
> Who is, in general, testing which libvirt version? I can think of:
> - libvirt developers, which will probably run libvirt current git, but
> more likely a released QEMU?
In general libvirt devs tend to run a mixture of whatever th
Test that we're rejecting what we ought to for file,
host_driver and host_cdrom drivers. Test that we're
seeing the deprecated message for block and chardevs
on the file driver.
Signed-off-by: John Snow
---
tests/qemu-iotests/226 | 66 ++
tests/qem
Tighten which types of files we'll allow you to specify for the various
file drivers (file, host_device, host_cdrom).
v6:
- Rebased for 3.0
- Actually set ret (Kevin)
- Added test (Thanks, Kevin!)
- Modified error messages somewhat to include driver name
John Snow (2):
file-posix: specify e
On Tue, Jul 10, 2018 at 04:09:38PM +0100, Peter Maydell wrote:
> On 10 July 2018 at 15:22, Cornelia Huck wrote:
> > On Tue, 10 Jul 2018 07:59:15 +0200
> > Markus Armbruster wrote:
> >
> >> In addition to actively pulling libvirt developers into review of
> >> deprecation patches, we should pursue
From: Fam Zheng
Reuse the new bdrv_co_write_req_prepare/finish helpers. The variation
here is that discard requests don't affect bs->wr_highest_offset, and it
cannot extend the image.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/io.c | 33 +++--
1 f
From: Fam Zheng
Two problems exist when a write request that enlarges the image (i.e.
write beyond EOF) finishes:
1) parent is not notified about size change;
2) dirty bitmap is not resized although we try to set the dirty bits;
Fix them just like how bdrv_co_truncate works.
Reported-by: Kevin
From: Fam Zheng
Other I/O functions are already using a BdrvChild pointer in the API, so
make discard do the same. It makes it possible to initiate the same
permission checks before doing I/O, and much easier to share the
helper functions for this, which will be added and used by write,
truncate
From: Fam Zheng
With in one module, trace points usually have a common prefix named
after the module name. paio_submit and paio_submit_co are the only two
trace points so far in the two file protocol drivers. As we are adding
more, having a common prefix here is better so that trace points can be
From: Cornelia Huck
This reverts commit eae3bd1eb7c6b105d30ec06008b3bc3dfc5f45bb.
Reverted to avoid conflicts for geometry options revert.
Signed-off-by: Cornelia Huck
Signed-off-by: Kevin Wolf
---
include/sysemu/blockdev.h | 1 +
blockdev.c| 17 -
device-hot
From: Vladimir Sementsov-Ogievskiy
Pass read flags and write flags separately. This is needed to handle
coming BDRV_REQ_NO_SERIALISING clearly in following patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
include/block/block.h
Am 10.07.2018 um 17:34 hat John Snow geschrieben:
>
>
> On 07/10/2018 05:38 AM, Fam Zheng wrote:
> > Luks needs special parameters to operate the image. Since this test is
> > focusing on image fleecing, skip skip that format.
> >
> > Signed-off-by: Fam Zheng
> > ---
> > tests/qemu-iotests/222
From: Fam Zheng
Truncation is the last to convert from open coded req handling to
reusing helpers. This time the permission check in prepare has to adapt
to the new caller: it checks a different permission bit, and doesn't
trigger the before write notifier.
Also, truncation should always trigger
From: Vladimir Sementsov-Ogievskiy
Here two things are fixed:
1. Architecture
On each recursion step, we go to the child of src or dst, only for one
of them. So, it's wrong to create tracked requests for both on each
step. It leads to tracked requests duplication.
2. Wait for serializing reque
From: Fam Zheng
As a mechanical refactoring patch, this is the first step towards
unified and more correct write code paths. This is helpful because
multiple BlockDriverState fields need to be updated after modifying
image data, and it's hard to maintain in multiple places such as copy
offload, d
From: Fam Zheng
If we are growing the image and potentially using preallocation for the
new area, we need to make sure that no write requests are made to the
"preallocated" area which is [@old_size, @offset), not
[@offset, offset * 2 - @old_size).
Signed-off-by: Fam Zheng
Reviewed-by: Eric Blak
From: Fam Zheng
This matches the types used for bytes in the rest parts of block layer.
In the case of bdrv_co_truncate, new_bytes can be the image size which
probably doesn't fit in a 32 bit int.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
include/block/block_int.h | 4 ++--
block
On 07/10/2018 05:38 AM, Fam Zheng wrote:
> Luks needs special parameters to operate the image. Since this test is
> focusing on image fleecing, skip skip that format.
>
> Signed-off-by: Fam Zheng
> ---
> tests/qemu-iotests/222 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/
From: Fam Zheng
This brings the request handling logic inline with write and discard,
fixing write_gen, resize_cb, dirty bitmaps and image size refreshing.
The last of these issues broke iotest case 222, which is now fixed.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/io.c | 2
From: Cornelia Huck
This reverts commit a7aff6dd10b16b67e8b142d0c94c5d92c3fe88f6.
Hold off removing this for one more QEMU release (current libvirt
release still uses it.)
Signed-off-by: Cornelia Huck
Signed-off-by: Kevin Wolf
---
include/sysemu/blockdev.h | 1 +
blockdev.c|
From: Cornelia Huck
This reverts commit 6266e900b8083945cb766b45c124fb3c42932cb3.
Some deprecated -drive options were still in use by libvirt, only
fixed with libvirt commit b340c6c614 ("qemu: format serial and geometry
on frontend disk device"), which is not yet in any released version
of libvi
From: Ari Sundholm
This was accidentally omitted. Thanks to Eric Blake for spotting this.
Signed-off-by: Ari Sundholm
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
qapi/block-core.json | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
i
From: Fam Zheng
A few trace points that can help reveal what is happening in a copy
offloading I/O path.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/file-posix.c | 2 ++
block/io.c | 4
block/iscsi.c | 3 +++
block/trace-events | 6 ++
4 files changed, 1
From: Vladimir Sementsov-Ogievskiy
Fleecing scheme works as follows: we want a kind of temporary snapshot
of active drive A. We create temporary image B, with B->backing = A.
Then we start backup(sync=none) from A to B. From this point, B reads
as point-in-time snapshot of A (A continues to be ac
From: Cornelia Huck
This reverts commit b0083267444a5e0f28391f6c2831a539f878d424.
Hold off removing this for one more QEMU release (current libvirt
release still uses it.)
Signed-off-by: Cornelia Huck
Signed-off-by: Kevin Wolf
---
include/hw/block/block.h | 1 +
include/sysemu/blockdev.h |
From: Ari Sundholm
The sector size needs to be large enough to accommodate the data
structures for the log super block and log write entries. This was
previously not properly checked, which made it possible to cause
QEMU to badly misbehave.
Signed-off-by: Ari Sundholm
Signed-off-by: Kevin Wolf
From: Vladimir Sementsov-Ogievskiy
Serialized writes should be used in copy-on-write of backup(sync=none)
for image fleecing scheme.
We need to change an assert in bdrv_aligned_pwritev, added in
28de2dcd88de. The assert may fail now, because call to
wait_serialising_requests here may become firs
Commit dcf94a23b1 ('block: Don't poll in parent drain callbacks')
removed polling in bdrv_child_cb_drained_begin() on the grounds that the
original bdrv_drain() already will poll and BdrvChildRole.drained_begin
calls must not cause graph changes (and therefore must not call
aio_poll() or the recurs
The following changes since commit b34181056c04e05db6c632063012beaee7006a37:
Merge remote-tracking branch 'remotes/rth/tags/pull-sh4-20180709' into
staging (2018-07-09 22:44:22 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 43 +++
1 file changed, 43 insertions(+)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index 291a050f86..17bb8508ae 100644
--- a/tests/test-bdrv-drain.c
+++ b/tests/test-bdrv-drain.c
From: Fam Zheng
Luks needs special parameters to operate the image. Since this test is
focusing on image fleecing, skip skip that format.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/222 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/222
If the virtual disk size isn't aligned to full clusters,
bdrv_co_do_copy_on_readv() may get pnum == 0 before having the full
cluster completed, which will let it run into an assertion failure:
qemu-io: block/io.c:1203: bdrv_co_do_copy_on_readv: Assertion `skip_bytes <
pnum' failed.
Check for EOF
Am 10.07.2018 um 17:05 hat Peter Lieven geschrieben:
> We currently don't enforce that the sparse segments we detect during convert
> are
> aligned. This leads to unnecessary and costly read-modify-write cycles either
> internally in Qemu or in the background on the storage device as nearly all
>
On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
> On Tue, 10 Jul 2018 16:39:31 +0200
> Peter Krempa wrote:
> > On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote:
> > > On Tue, 10 Jul 2018 07:59:15 +0200
> > > Markus Armbruster wrote:
[...]
> > > "ERROR: 'old_option' is de
On 10 July 2018 at 15:22, Cornelia Huck wrote:
> On Tue, 10 Jul 2018 07:59:15 +0200
> Markus Armbruster wrote:
>
>> In addition to actively pulling libvirt developers into review of
>> deprecation patches, we should pursue the idea to optionally let QEMU
>> fail on use of deprecated features, the
We currently don't enforce that the sparse segments we detect during convert are
aligned. This leads to unnecessary and costly read-modify-write cycles either
internally in Qemu or in the background on the storage device as nearly all
modern filesystems or hardware have a 4k alignment internally.
On Tue, 10 Jul 2018 16:39:31 +0200
Peter Krempa wrote:
> On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote:
> > On Tue, 10 Jul 2018 07:59:15 +0200
> > Markus Armbruster wrote:
> >
> > > In addition to actively pulling libvirt developers into review of
> > > deprecation patches, we s
Am 10.07.2018 um 08:31 hat Fam Zheng geschrieben:
> Based-on: 20180709163719.87107-1-vsement...@virtuozzo.com
>
> v3: - Rebase onto Vladmir's:
> [PATCH v5 0/4] fix image fleecing
> on top of master, which has blklogwrites to be converted to BdrvChild
> for
> the bdrv_co_pdiscard
Am 10.07.2018 um 08:31 hat Fam Zheng geschrieben:
> Reuse the new bdrv_co_write_req_prepare/finish helpers. The variation
> here is that discard requests don't affect bs->wr_highest_offset, and it
> cannot extend the image.
>
> Signed-off-by: Fam Zheng
> ---
> block/io.c | 32 +++
On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote:
> On Tue, 10 Jul 2018 07:59:15 +0200
> Markus Armbruster wrote:
>
> > In addition to actively pulling libvirt developers into review of
> > deprecation patches, we should pursue the idea to optionally let QEMU
> > fail on use of depreca
Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben:
> On Tue, 10 Jul 2018 07:59:15 +0200
> Markus Armbruster wrote:
>
> > In addition to actively pulling libvirt developers into review of
> > deprecation patches, we should pursue the idea to optionally let QEMU
> > fail on use of deprecated fea
04.07.2018 14:23, Vladimir Sementsov-Ogievskiy wrote:
This is necessary for efficient block-status export, for clients which
support it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
nbd/server.c | 77 +---
1 file changed, 58 insertio
On Tue, 10 Jul 2018 07:59:15 +0200
Markus Armbruster wrote:
> In addition to actively pulling libvirt developers into review of
> deprecation patches, we should pursue the idea to optionally let QEMU
> fail on use of deprecated features, then have libvirt run its test suite
> that way.
What abou
Hi
On Tue, Jul 10, 2018 at 3:20 PM, Kevin Wolf wrote:
> Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben:
>> handle_qmp_command() reports JSON syntax errors right away. This is
>> wrong when OOB is enabled, because the errors can "jump the queue"
>> then.
>>
>> The previous commit fixed
Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben:
> handle_qmp_command() reports JSON syntax errors right away. This is
> wrong when OOB is enabled, because the errors can "jump the queue"
> then.
>
> The previous commit fixed the same bug for semantic errors, by
> delaying the checking u
Am 10.07.2018 um 14:36 hat Peter Lieven geschrieben:
> Am 10.07.2018 um 14:28 schrieb Kevin Wolf:
> > Am 07.07.2018 um 13:42 hat Peter Lieven geschrieben:
> > > We currently don't enforce that the sparse segments we detect during
> > > convert are
> > > aligned. This leads to unnecessary and costl
Am 06.07.2018 um 15:06 hat Cornelia Huck geschrieben:
> Several -drive options had been marked as deprecated for two releases
> and had therefore been removed; unfortunately, libvirt still used at
> least two of them (serial number and disk geometry) and the patch
> switching away from it is not ye
Am 10.07.2018 um 14:28 schrieb Kevin Wolf:
Am 07.07.2018 um 13:42 hat Peter Lieven geschrieben:
We currently don't enforce that the sparse segments we detect during convert are
aligned. This leads to unnecessary and costly read-modify-write cycles either
internally in Qemu or in the background o
Am 07.07.2018 um 13:42 hat Peter Lieven geschrieben:
> We currently don't enforce that the sparse segments we detect during convert
> are
> aligned. This leads to unnecessary and costly read-modify-write cycles either
> internally in Qemu or in the background on the storage device as nearly all
>
Am 09.07.2018 um 17:01 hat Ari Sundholm geschrieben:
> Would there be a chance of getting this included in 3.0?
Sure, this is clearly a bug fix.
Thanks, applied to the block branch.
Kevin
> On 07/06/2018 03:00 PM, Ari Sundholm wrote:
> > The sector size needs to be large enough to accommodate t
Am 06.07.2018 um 16:01 hat Ari Sundholm geschrieben:
> This was accidentally omitted. Thanks to Eric Blake for spotting this.
>
> Signed-off-by: Ari Sundholm
Thanks, applied to the block branch.
Kevin
Am 09.07.2018 um 18:37 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all.
>
> This fixes image fleecing scheme for 3.0, details are in 04 patch.
> 01 is a significant fix too.
>
> v5: - keep one _internal recursive function like in original code [Fam]
> - grammar and rewording [Eric] (a
Am 10.07.2018 um 11:38 hat Fam Zheng geschrieben:
> Luks needs special parameters to operate the image. Since this test is
> focusing on image fleecing, skip skip that format.
>
> Signed-off-by: Fam Zheng
Thanks, applied to the block branch.
Kevin
Luks needs special parameters to operate the image. Since this test is
focusing on image fleecing, skip skip that format.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/222 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
index ff3bfc1470..0e
On 9 July 2018 at 19:58, Max Reitz wrote:
> The following changes since commit ec7eb2ae77cc207064e17ace048f7ec0c4b85d6f:
>
> translate-all: honour CF_NOCACHE in tb_gen_code (2018-07-09 16:14:36 +0100)
>
> are available in the Git repository at:
>
> https://git.xanclic.moe/XanClic/qemu.git tags
Am 03.07.2018 um 19:50 hat Kevin Wolf geschrieben:
> This fixes the following case that was reported by Max and was caused by
> not correctly waiting for activity to cease on the parent node before
> attaching a drained child node:
>
> $ ./qemu-img create -f qed foo.qed 64M
> Formatting 'foo.qed',
10.07.2018 02:25, John Snow wrote:
On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote:
This variable doesn't work as it should, because it is actually cleared
in qcow2_co_invalidate_cache() by memset(). Drop it, as the following
patch will introduce new behavior.
Signed-off-by: Vladimi
62 matches
Mail list logo
