Hi, on Fedora 28 x64 host, as of 68f1b569 I'm seeing:
`./check -v -qcow`
- occasional stall on 052
- stalls on 216
`./check -v -qed`
- stalls on 200
`./check -v -luks`
- failures on 226.
052 is something I can't reproduce. The test takes quite a while, so
maybe
This test doesn't actually care about the format anyway, it just
supports "all formats" as a convenience. LUKS however does not use a
simple image filename which confuses this iotest.
We can simply remove the LUKS "support" and be happier for it.
Signed-off-by: John Snow
---
On Thu, Jul 12, 2018 at 09:51:20PM +0200, Stefan Weil wrote:
> Signed-off-by: Stefan Weil
> ---
> block.c | 2 +-
> block/backup.c | 4 ++--
> block/curl.c| 2 +-
> block/gluster.c | 2 +-
> block/vhdx.c| 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git
On 07/12/2018 03:51 PM, Stefan Weil wrote:
> Signed-off-by: Stefan Weil
> ---
> block.c | 2 +-
> block/backup.c | 4 ++--
> block/curl.c| 2 +-
> block/gluster.c | 2 +-
> block/vhdx.c| 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/block.c
On 07/12/2018 03:00 PM, Vladimir Sementsov-Ogievskiy wrote:
> Hi, what about this?
> I'll be on vacation next two weeks.
> Best regards, Vladimir.
By the end of today.
If there are fixes necessary I will take over the series if necessary so
you can enjoy your vacation, if that's OK with you?
Signed-off-by: Stefan Weil
---
block.c | 2 +-
block/backup.c | 4 ++--
block/curl.c| 2 +-
block/gluster.c | 2 +-
block/vhdx.c| 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index a2fe05ea96..39f373e035 100644
--- a/block.c
+++
the min_sparse convert parameter can overflow (e.g. -S 1024G)
in the conversion from int64_t to int resulting in a negative
min_sparse parameter. Avoid this by limiting the valid parameters
to sane values. In fact anything exceeding the convert buffer size
is also pointless. While at it also
Hi, what about this?
I'll be on vacation next two weeks.
Best regards, Vladimir.
От: Vladimir Sementsov-Ogievskiy
Отправлено: 26 июня 2018 г. 16:50:29
Кому: qemu-de...@nongnu.org; qemu-block@nongnu.org
Копия: dgilb...@redhat.com; quint...@redhat.com;
On 12 July 2018 at 17:31, Kevin Wolf wrote:
> The following changes since commit dc3c89d612252fc461a65f54885a1fe108e9ec05:
>
> ui/cocoa.m: replace scrollingDeltaY with deltaY (2018-07-12 16:03:50 +0100)
>
> are available in the git repository at:
>
> git://repo.or.cz/qemu/kevin.git
From: Fam Zheng
This step was left behind my mistake. As suggested by the echoed text,
the intention was to test two devices with the same image, with
different options. The behavior should be the same as two QEMU
processes. Complete it.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
From: John Snow
Adjust each caller of raw_open_common to specify if they are expecting
host and character devices or not. Tighten expectations of file types upon
open in the common code and refuse types that are not expected.
This has two effects:
(1) Character and block devices are now
From: John Snow
Test that we're rejecting what we ought to for file,
host_driver and host_cdrom drivers. Test that we're
seeing the deprecated message for block and chardevs
on the file driver.
Signed-off-by: John Snow
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/226 | 66
From: Daniel Henrique Barboza
The current BDC VPD page (page 0xb1) is too short. This can be
seen running sg_utils:
$ sg_vpd --page=bdc /dev/sda
Block device characteristics VPD page (SBC):
Block device characteristics VPD page length too short=8
By the SCSI spec, the expected size of the SBC
The following changes since commit dc3c89d612252fc461a65f54885a1fe108e9ec05:
ui/cocoa.m: replace scrollingDeltaY with deltaY (2018-07-12 16:03:50 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to
From: Peter Lieven
We currently don't enforce that the sparse segments we detect during convert are
aligned. This leads to unnecessary and costly read-modify-write cycles either
internally in Qemu or in the background on the storage device as nearly all
modern filesystems or hardware have a 4k
From: Fam Zheng
197 is one example where _make_test_img is used twice without stopping
the NBD server in between. An error will occur like this:
@@ -26,9 +26,13 @@
=== Partial final cluster ===
+qemu-img: TEST_DIR/t.IMGFMT: Failed to get "resize" lock
+Is another process
From: Fam Zheng
Explicitly enabling zero detection or compression suppresses copy
offloading during convert. Document it.
Suggested-by: Kevin Wolf
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
qemu-img.texi | 6 --
1 file changed, 4 insertions(+),
On Wed, Jul 11, 2018 at 03:33:21PM +0200, Cornelia Huck wrote:
> The other qemu-nbds (the inet and the unix socket ones from the first
> run, the second inet one from the second run) have a single thread with
> the same backtrace I posted above.
We just discussed this on IRC, but for the record:
Am 12.07.2018 um 15:00 hat Peter Lieven geschrieben:
> We currently don't enforce that the sparse segments we detect during convert
> are
> aligned. This leads to unnecessary and costly read-modify-write cycles either
> internally in Qemu or in the background on the storage device as nearly all
>
On 12.07.2018 08:32, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
[...]
>> For libvirt, I think whenever something is proposed for deprecation
>> we could just CC libvir-list, or ask one of the libvirt people to
>> confirm its not being used. If it is, then we should file BZ against
>>
Am 12.07.2018 um 16:53 hat Paolo Bonzini geschrieben:
> On 11/07/2018 22:58, Daniel Henrique Barboza wrote:
> > The current BDC VPD page (page 0xb1) is too short. This can be
> > seen running sg_utils:
> >
> > $ sg_vpd --page=bdc /dev/sda
> > Block device characteristics VPD page (SBC):
> > Block
On 11/07/2018 22:58, Daniel Henrique Barboza wrote:
> The current BDC VPD page (page 0xb1) is too short. This can be
> seen running sg_utils:
>
> $ sg_vpd --page=bdc /dev/sda
> Block device characteristics VPD page (SBC):
> Block device characteristics VPD page length too short=8
>
> By the SCSI
We currently don't enforce that the sparse segments we detect during convert are
aligned. This leads to unnecessary and costly read-modify-write cycles either
internally in Qemu or in the background on the storage device as nearly all
modern filesystems or hardware have a 4k alignment internally.
Peter Krempa writes:
> On Thu, Jul 12, 2018 at 08:59:44 +0200, Markus Armbruster wrote:
>> Peter Krempa writes:
>> > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
>> >> On Tue, 10 Jul 2018 16:39:31 +0200
>> >> Peter Krempa wrote:
>
> [...]
>
>> > An option is to do a automatic
Cornelia Huck writes:
> On Thu, 12 Jul 2018 08:51:16 +0200
> Markus Armbruster wrote:
>
>> Markus Armbruster writes:
>>
>> > Kevin Wolf writes:
>> >
>> >> I think the function should just take a message:
>> >>
>> >> /* Works like error_report(), except for the WARNING/ERROR prefix
>>
Peter Krempa writes:
> On Thu, Jul 12, 2018 at 08:38:25 +0200, Markus Armbruster wrote:
>> Kevin Wolf writes:
>> > Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben:
>> >> On Tue, 10 Jul 2018 07:59:15 +0200
>> >> Markus Armbruster wrote:
>> >> Would that be workable?
>> >
>> > I think the
Am 11.07.2018 um 10:25 schrieb Kevin Wolf:
Am 10.07.2018 um 22:16 hat Peter Lieven geschrieben:
Am 10.07.2018 um 17:31 schrieb Kevin Wolf :
Am 10.07.2018 um 17:05 hat Peter Lieven geschrieben:
We currently don't enforce that the sparse segments we detect during convert are
aligned. This
Am 11.07.2018 um 10:25 schrieb Kevin Wolf:
Am 10.07.2018 um 22:16 hat Peter Lieven geschrieben:
Am 10.07.2018 um 17:31 schrieb Kevin Wolf :
Am 10.07.2018 um 17:05 hat Peter Lieven geschrieben:
We currently don't enforce that the sparse segments we detect during convert are
aligned. This
Am 12.07.2018 um 09:48 hat Cornelia Huck geschrieben:
> On Thu, 12 Jul 2018 08:51:16 +0200
> Markus Armbruster wrote:
>
> > Markus Armbruster writes:
> >
> > > Kevin Wolf writes:
> > >
> > >> Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben:
> > >>> On Tue, 10 Jul 2018 07:59:15 +0200
On Thu, 12 Jul 2018 08:51:16 +0200
Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Kevin Wolf writes:
> >
> >> Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben:
> >>> On Tue, 10 Jul 2018 07:59:15 +0200
> >>> Markus Armbruster wrote:
> >>>
> >>> > In addition to actively
On Thu, Jul 12, 2018 at 08:59:44 +0200, Markus Armbruster wrote:
> Peter Krempa writes:
> > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
> >> On Tue, 10 Jul 2018 16:39:31 +0200
> >> Peter Krempa wrote:
[...]
> > An option is to do a automatic testing where one of this
On Thu, Jul 12, 2018 at 08:38:25 +0200, Markus Armbruster wrote:
> Kevin Wolf writes:
> > Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben:
> >> On Tue, 10 Jul 2018 07:59:15 +0200
> >> Markus Armbruster wrote:
> >> Would that be workable?
> >
> > I think the function should just take a
Peter Krempa writes:
> On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
>> On Tue, 10 Jul 2018 16:39:31 +0200
>> Peter Krempa wrote:
>> > On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote:
>> > > On Tue, 10 Jul 2018 07:59:15 +0200
>> > > Markus Armbruster wrote:
>
> [...]
Markus Armbruster writes:
> Kevin Wolf writes:
>
>> Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben:
>>> On Tue, 10 Jul 2018 07:59:15 +0200
>>> Markus Armbruster wrote:
>>>
>>> > In addition to actively pulling libvirt developers into review of
>>> > deprecation patches, we should pursue
Thomas Huth writes:
> On 10.07.2018 17:24, Peter Krempa wrote:
>> On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
>>> On Tue, 10 Jul 2018 16:39:31 +0200
>>> Peter Krempa wrote:
On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote:
> On Tue, 10 Jul 2018 07:59:15
Kevin Wolf writes:
> Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben:
>> On Tue, 10 Jul 2018 07:59:15 +0200
>> Markus Armbruster wrote:
>>
>> > In addition to actively pulling libvirt developers into review of
>> > deprecation patches, we should pursue the idea to optionally let QEMU
>> >
Daniel P. Berrangé writes:
> On Mon, Jul 09, 2018 at 01:08:38PM +0200, Cornelia Huck wrote:
>> On Mon, 09 Jul 2018 08:33:05 +0200
>> Markus Armbruster wrote:
>>
>> > Peter Maydell writes:
>> >
>> > > On 6 July 2018 at 15:56, Kevin Wolf wrote:
>> > >> Am 06.07.2018 um 13:11 hat Cornelia
37 matches
Mail list logo