Thanks for the review and for the comments, Eric!
One quick remark: I do usually leave blank lines around inline
replies, but this time Thunderbird made it look as if there are
blank lines when I was writing, when apparently there were not. :]
Leonid.
On 07/24/2018 05:20 PM, Leonid Bloch wrote:
meta-comment: a hint for more effective emails below
-
Differences from v2:
1) A separate patch for the grammar fix for 3.0
2) A separate patch for existing documentation fixes for 3.0
3) Separated back the iotests patch,
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 3 +++
qemu-options.hx | 10 ++
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index 8a09a5cc5f..3673f2be0e 100644
--- a/docs/qcow2-cache.txt
+++
Signed-off-by: Leonid Bloch
---
tests/qemu-iotests/103 | 6 ++
tests/qemu-iotests/103.out | 2 ++
tests/qemu-iotests/137 | 2 ++
tests/qemu-iotests/137.out | 2 ++
4 files changed, 12 insertions(+)
diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103
index
On 07/25/2018 01:17 AM, Leonid Bloch wrote:
This series introduces an option to calculate and allocate
automatically enough qcow2 L2 cache to cover the entire image.
Using cache that covers the entire image can benefit performance,
while having only a small memory overhead
Signed-off-by: Leonid Bloch
---
block/qcow2.c | 2 +-
tests/qemu-iotests/103.out | 2 +-
tests/qemu-iotests/137.out | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 6162ed8be2..ec9e6238a0 100644
--- a/block/qcow2.c
+++
An option "l2-cache-full" is introduced to automatically set the qcow2
L2 cache to a sufficient value for covering the entire image. The memory
overhead when using this option is not big (1 MB for each 8 GB of
virtual image size with the default cluster size) and it can noticeably
improve
This series introduces an option to calculate and allocate
automatically enough qcow2 L2 cache to cover the entire image.
Using cache that covers the entire image can benefit performance,
while having only a small memory overhead (just 1 MB for every 8 GB
of virtual image size with the default
On 07/24/2018 03:03 PM, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
I'd probably squash this with 3/5 introducing the option.
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
On 07/24/2018 03:03 PM, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 3 +++
qemu-options.hx | 15 +++
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index 8a09a5cc5f..9d261b7da9
On 07/24/2018 03:03 PM, Leonid Bloch wrote:
Subject line is rather vague; at a bare minimum, mentioning 'qcow2:'
might be helpful. But the maintainer can improve that. My suggestion:
qcow2: grammar fix for conflicting cache sizing
Signed-off-by: Leonid Bloch
---
block/qcow2.c
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 3 +++
qemu-options.hx | 15 +++
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index 8a09a5cc5f..9d261b7da9 100644
--- a/docs/qcow2-cache.txt
+++
This series introduces an option to calculate and allocate
automatically enough qcow2 L2 cache to cover the entire image.
Using cache that covers the entire image can benefit performance,
while having only a small memory overhead (just 1 MB for every 8 GB
of virtual image size with the default
Signed-off-by: Leonid Bloch
---
block/qcow2.c | 2 +-
tests/qemu-iotests/103.out | 2 +-
tests/qemu-iotests/137.out | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 6162ed8be2..ec9e6238a0 100644
--- a/block/qcow2.c
+++
Signed-off-by: Leonid Bloch
---
tests/qemu-iotests/103 | 6 ++
tests/qemu-iotests/103.out | 2 ++
tests/qemu-iotests/137 | 2 ++
tests/qemu-iotests/137.out | 2 ++
4 files changed, 12 insertions(+)
diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103
index
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index 9d261b7da9..ea61585a4b 100644
--- a/docs/qcow2-cache.txt
+++ b/docs/qcow2-cache.txt
@@ -110,11 +110,12 @@
An option "l2-cache-full" is introduced to automatically set the qcow2
L2 cache to a sufficient value for covering the entire image. The memory
overhead when using this option is not big (1 MB for each 8 GB of
virtual image size with the default cluster size) and it can noticeably
improve
On 07/24/2018 04:47 AM, Fam Zheng wrote:
> Something has locked /dev/null on my system (I still don't know what to do
> with
> the annoying incapability of lslocks, or more precisely /proc/locks, on
> inspecting OFD lock information), and as a result 226 cannot pass due to the
> unexpected
On 07/24/2018 12:02 PM, Leonid Bloch wrote:
An option "l2-cache-full" is introduced to automatically set the qcow2
L2 cache to a sufficient value for covering the entire image. The memory
overhead when using this option is not big (1 MB for each 8 GB of
virtual image size with the default
An option "l2-cache-full" is introduced to automatically set the qcow2
L2 cache to a sufficient value for covering the entire image. The memory
overhead when using this option is not big (1 MB for each 8 GB of
virtual image size with the default cluster size) and it can noticeably
improve
This series introduces an option to calculate and allocate
automatically enough qcow2 L2 cache to cover the entire image.
Using cache that covers the entire image can benefit performance,
while having only a small memory overhead (just 1 MB for every 8 GB
of virtual image size with the default
This documents the new "l2-cache-full" option, and sharpens the
documentation of the related options.
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index
On 07/24/2018 06:21 PM, Eric Blake wrote:
On
07/24/2018 07:17 AM, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 12
1 file changed, 8 insertions(+), 4
On 07/24/2018 06:20 PM, Eric Blake wrote:
On
07/24/2018 07:17 AM, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
On 07/24/2018 07:17 AM, Leonid Bloch wrote:
This patch adds tests for the l2-cache-full option, and also intcoduces
s/intcoduces/introduces/
a small change due to a grammar fix in block/qcow2.c
Signed-off-by: Leonid Bloch
---
tests/qemu-iotests/103 | 6 ++
On 07/24/2018 07:17 AM, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index a0a1267482..43c0faaddb 100644
--- a/docs/qcow2-cache.txt
+++
On 07/24/2018 07:17 AM, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Updating the subject line, since this doc fix is appropriate for 3.0, if
it is correct.
diff --git a/docs/qcow2-cache.txt
On 07/24/2018 07:17 AM, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index 8a09a5cc5f..a0a1267482 100644
--- a/docs/qcow2-cache.txt
+++
On 07/24/2018 05:49 PM, Eric Blake wrote:
On
07/24/2018 07:17 AM, Leonid Bloch wrote:
This series introduces an option to
calculate and allocate
automatically enough qcow2 L2 cache to cover the entire image.
Using cache
On 24 July 2018 at 15:23, Stefan Hajnoczi wrote:
> The following changes since commit 768cef2974fb1fa30dd188b043ea737e13fea477:
>
> Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request'
> into staging (2018-07-24 10:37:52 +0100)
>
> are available in the Git repository at:
On 07/24/2018 07:17 AM, Leonid Bloch wrote:
An option "l2-cache-full" is introduced to automatically set the qcow2
L2 cache to a sufficient value for covering the entire image. The memory
overhead when using this option is not big (1 MB for each 8 GB of
virtual image size with the default
On 07/24/2018 07:17 AM, Leonid Bloch wrote:
This series introduces an option to calculate and allocate
automatically enough qcow2 L2 cache to cover the entire image.
Using cache that covers the entire image can benefit performance,
while having only a small memory overhead (just 1 MB for every 8
On 07/24/2018 03:47 AM, Fam Zheng wrote:
Something has locked /dev/null on my system (I still don't know what to do with
the annoying incapability of lslocks, or more precisely /proc/locks, on
inspecting OFD lock information), and as a result 226 cannot pass due to the
unexpected image locking
From: Nishanth Aravamudan
In ed6e2161 ("linux-aio: properly bubble up errors from initialzation"),
I only added a bdrv_attach_aio_context callback for the bdrv_file
driver. There are several other drivers that use the shared
aio_plug callback, though, and they will trip the assertion added to
The following changes since commit 768cef2974fb1fa30dd188b043ea737e13fea477:
Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request'
into staging (2018-07-24 10:37:52 +0100)
are available in the Git repository at:
git://github.com/stefanha/qemu.git
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index a0a1267482..43c0faaddb 100644
--- a/docs/qcow2-cache.txt
+++ b/docs/qcow2-cache.txt
@@ -110,11 +110,12 @@ How to
This series introduces an option to calculate and allocate
automatically enough qcow2 L2 cache to cover the entire image.
Using cache that covers the entire image can benefit performance,
while having only a small memory overhead (just 1 MB for every 8 GB
of virtual image size with the default
This patch adds tests for the l2-cache-full option, and also intcoduces
a small change due to a grammar fix in block/qcow2.c
Signed-off-by: Leonid Bloch
---
tests/qemu-iotests/103 | 6 ++
tests/qemu-iotests/103.out | 4 +++-
tests/qemu-iotests/137 | 2 ++
tests/qemu-iotests/137.out
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index 8a09a5cc5f..a0a1267482 100644
--- a/docs/qcow2-cache.txt
+++ b/docs/qcow2-cache.txt
@@ -97,9 +97,9 @@ need:
An option "l2-cache-full" is introduced to automatically set the qcow2
L2 cache to a sufficient value for covering the entire image. The memory
overhead when using this option is not big (1 MB for each 8 GB of
virtual image size with the default cluster size) and it can noticeably
improve
On Mon, Jul 23, 2018 at 06:22:03PM -0400, John Snow wrote:
> This is an updated version of Vladimir's proposal for fixing the
> handling around migration and persistent dirty bitmaps.
>
> Patches 1, 4, 6, and 7 update the testing for this feature.
> Patch 2 touches up an error message.
> Patch 3
When using the vvfat driver with a directory that contains too many files,
QEMU currently crashes. This can be triggered like this for example:
mkdir /tmp/vvfattest
cd /tmp/vvfattest
for ((x=0;x<=513;x++)); do mkdir $x; done
qemu-system-x86_64 -drive \
On 24.07.2018 12:49, Kevin Wolf wrote:
> Am 24.07.2018 um 11:56 hat Thomas Huth geschrieben:
>> On 23.07.2018 16:33, Kevin Wolf wrote:
>>> Am 18.07.2018 um 17:28 hat Thomas Huth geschrieben:
When using the vvfat driver with a directory that contains too many files,
QEMU currently
Am 24.07.2018 um 11:56 hat Thomas Huth geschrieben:
> On 23.07.2018 16:33, Kevin Wolf wrote:
> > Am 18.07.2018 um 17:28 hat Thomas Huth geschrieben:
> >> When using the vvfat driver with a directory that contains too many files,
> >> QEMU currently crashes. We are trying to print the wrong path
On 23.07.2018 16:33, Kevin Wolf wrote:
> Am 18.07.2018 um 17:28 hat Thomas Huth geschrieben:
>> When using the vvfat driver with a directory that contains too many files,
>> QEMU currently crashes. We are trying to print the wrong path variable here.
>>
>> Signed-off-by: Thomas Huth
>> ---
>>
On my system (Fedora 28), this script reports a 'failed to get
"consistent read" lock' error. Following docs/devel/testing.rst, it's
better to add locking=off here.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/226 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Something has locked /dev/null on my system (I still don't know what to do with
the annoying incapability of lslocks, or more precisely /proc/locks, on
inspecting OFD lock information), and as a result 226 cannot pass due to the
unexpected image locking error.
Fix the test case by disabling
Signed-off-by: Fam Zheng
---
docs/devel/testing.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 5e19cd50da..8e1fa3a66e 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -255,6 +255,17 @@ comparable
48 matches
Mail list logo
