Eric brought to my attention that we don't currently allow
incremental backups made to a node. There's no reason we can't,
though, so enable this.
A better test in en-route, this is mostly a PoC chainsaw job
on the second patch to see if patchew knows something I don't.
--js
John Snow (2):
It is only an oversight that we don't allow incremental backup with
blockdev-backup. Add the bitmap argument which enables this.
Signed-off-by: John Snow
---
blockdev.c | 16 +++-
qapi/block-core.json | 7 ++-
2 files changed, 21 insertions(+), 2 deletions(-)
diff
This is just a real chainsaw job on 124 to prove that we can
indeed use blockdev-backup interchangeably with drive-backup
for incremental backups.
A nicer test will follow once I refactor this a bit to look
a little less like the Texas Chainsaw Massacre.
Signed-off-by: John Snow
---
On 08/29/2018 08:57 PM, John Snow wrote:
Jobs presently use both an Error object in the case of the create job,
and char strings in the case of generic errors elsewhere.
Unify the two paths as just j->err, and remove the extra argument from
job_completed. The integer error code for
Hi Shimi,
On Sun, Aug 26, 2018 at 2:50 PM Gersner wrote:
>
> Hi Daniel,
> Thanks for taking a look. Comments are inline.
>
> Gersner.
>
> On Sun, Jul 15, 2018 at 9:21 AM Daniel Verkamp wrote:
>>
>> On Fri, Jun 22, 2018 at 4:22 AM, Shimi Gersner wrote:
>> > PCI/e configuration currently does
On Wed 29 Aug 2018 01:39:10 PM CEST, Max Reitz wrote:
> On 2018-08-26 16:09, Alberto Garcia wrote:
>> 'discard' is one of the basic BlockdevOptions available for all
>> drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so
>> the user cannot change it and doesn't get an error
On Wed 29 Aug 2018 01:39:10 PM CEST, Max Reitz wrote:
> On 2018-08-26 16:09, Alberto Garcia wrote:
>> 'discard' is one of the basic BlockdevOptions available for all
>> drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so
>> the user cannot change it and doesn't get an error
