Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180817190457.8292-1-js...@redhat.com
Subject: [Qemu-devel] [PATCH 0/7] jobs: remove
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180817190457.8292-1-js...@redhat.com
Subject: [Qemu-devel] [PATCH 0/7] jobs: remove
On Fri, 08/24 10:43, Fam Zheng wrote:
> All callers have acquired ctx already. Doing that again results in
> aio_poll() hang. This fixes the problem that a BDRV_POLL_WHILE() in the
> callback cannot make progress because ctx is recursively locked, for
> example, when drive-backup finishes.
>
>
Am 28.08.2018 um 16:26 hat Peter Krempa geschrieben:
> On Fri, Aug 10, 2018 at 18:26:57 +0200, Kevin Wolf wrote:
> > The block-commit QMP command required specifying the top and base nodes
> > of the commit jobs using the file name of that node. While this works
> > in simple cases (local files
"qemu-io reopen" doesn't allow changing the writethrough setting of
the cache, but the check is wrong, causing an error even on a simple
reopen with the default parameters:
$ qemu-img create -f qcow2 hd.qcow2 1M
$ qemu-system-x86_64 -monitor stdio -drive if=virtio,file=hd.qcow2
(qemu)
'force-share' is one of the basic BlockdevOptions available for all
drivers, but it's not handled by bdrv_reopen_prepare() so any attempt
to change it results in a "Cannot change the option" error:
(qemu) qemu-io virtio0 "reopen -o force-share=on"
Cannot change the option 'force-share'
Block drivers allow opening their children using a reference to an
existing BlockDriverState. These references remain stored in the
'options' and 'explicit_options' QDicts, but we don't need to keep
them once everything is open.
What is more important, these values can become wrong if the
The bdrv_reopen_prepare() function checks all options passed to each
BlockDriverState (in the reopen_state->options QDict) and makes all
necessary preparations to apply the option changes requested by the
user.
Options are removed from the QDict as they are processed, so at the
end of
Hi,
as part of my blockdev-reopen work here's a new set of patches. This
doesn't implement yet the core functionality of the new reopen
command, but it does fix a few things that help us pave the way.
I believe that the next series after this one will be the last.
The main change is the removal
Am 10.08.2018 um 18:26 hat Kevin Wolf geschrieben:
> Kevin Wolf (2):
> commit: Add top-node/base-node options
> qemu-iotests: Test commit with top-node/base-node
Fixed the version numbers in the QMP documentation and applied to the
block branch.
I'll still have to look into Peter's problem,
The file-posix code is used for the "file", "host_device" and
"host_cdrom" drivers, and it allows reopening images. However the only
option that is actually processed is "x-check-cache-dropped", and
changes in all other options (e.g. "filename") are silently ignored:
(qemu) qemu-io virtio0
'detect-zeroes' is one of the basic BlockdevOptions available for all
drivers, but it's not handled by bdrv_reopen_prepare(), so any attempt
to change it results in an error:
(qemu) qemu-io virtio0 "reopen -o detect-zeroes=on"
Cannot change the option 'detect-zeroes'
Since there's no
'discard' is one of the basic BlockdevOptions available for all
drivers, but it's not handled by bdrv_reopen_prepare() so any attempt
to change it results in an error:
(qemu) qemu-io virtio0 "reopen -o discard=on"
Cannot change the option 'discard'
Since there's no reason why we shouldn't
In the previous patches we removed all child references from
bs->{options,explicit_options} because keeping them is useless and
wrong.
Because of this, any attempt to reopen a BlockDriverState using a
child reference as one of its options would result in a failure,
because bdrv_reopen_prepare()
In the previous patch we removed child references from bs->options, so
there's no need to look for them here anymore.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
block.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/block.c b/block.c
index
The default value of x-check-cache-dropped is false. There's no reason
to use the previous value as a default in raw_reopen_prepare() because
bdrv_reopen_queue_child() already takes care of putting the old
options in the BDRVReopenState.options QDict.
If x-check-cache-dropped was previously set
Kevin Wolf writes:
> Am 01.09.2018 um 09:54 hat Markus Armbruster geschrieben:
>> John Snow writes:
>>
>> > On 08/31/2018 02:08 AM, Markus Armbruster wrote:
>> >> Eric Blake writes:
>> >>
>> >>> On 08/29/2018 08:57 PM, John Snow wrote:
>> Jobs presently use both an Error object in the
Am 01.09.2018 um 09:54 hat Markus Armbruster geschrieben:
> John Snow writes:
>
> > On 08/31/2018 02:08 AM, Markus Armbruster wrote:
> >> Eric Blake writes:
> >>
> >>> On 08/29/2018 08:57 PM, John Snow wrote:
> Jobs presently use both an Error object in the case of the create job,
>
On Fri, Aug 31, 2018 at 04:53:12PM +0200, Marc-André Lureau wrote:
> There are variants of qemu_create_pidfile() in qemu-pr-helper and
> qemu-ga. Let's have a common implementation in libqemuutil.
>
> The code is initially based from pr-helper write_pidfile(), with
> various improvements and
On 2018-09-01 00:29, John Snow wrote:
> The exit callback in this test actually only performs cleanup.
>
> Signed-off-by: John Snow
> ---
> tests/test-blockjob-txn.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP
On 2018-09-01 00:28, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
> ---
> block/stream.c | 23 +++
> 1 file changed, 15 insertions(+), 8 deletions(-)
You forgot to fix the commit title. ;-)
Max
signature.asc
Description: OpenPGP digital signature
On 2018-09-01 00:28, John Snow wrote:
> For purposes of minimum code movement, refactor the mirror_exit
> callback to use the post-finalization callbacks in a trivial way.
>
> Signed-off-by: John Snow
> ---
> block/mirror.c | 31 +--
> 1 file changed, 25
On 2018-09-01 00:28, John Snow wrote:
> In cases where we abort the block/mirror job, there's no point in
> installing the new backing chain before we finish aborting.
>
> Move this to the "success" portion of mirror_exit.
>
> Signed-off-by: John Snow
> ---
> block/mirror.c | 27
23 matches
Mail list logo
