On 09/05/2018 06:27 AM, Max Reitz wrote:
> On 2018-09-04 22:32, John Snow wrote:
>>
>>
>> On 09/04/2018 02:46 PM, Jeff Cody wrote:
>>> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote:
Use the component callbacks; prepare, abort, and clean.
NB: prepare is only called
On Mon 03 Sep 2018 04:34:06 PM CEST, Alberto Garcia wrote:
> +value = qemu_opt_get_del(opts, "discard");
> +if (value != NULL) {
> +if (bdrv_parse_discard_flags(value, _state->flags) != 0) {
> +error_setg(errp, "Invalid discard option");
> +ret = -EINVAL;
On 09/05/2018 08:09 AM, John Snow wrote:
On 09/05/2018 06:43 AM, Max Reitz wrote:
On 2018-09-04 19:09, John Snow wrote:
For purposes of minimum code movement, refactor the mirror_exit
callback to use the post-finalization callbacks in a trivial way.
Signed-off-by: John Snow
---
On 09/05/2018 06:40 AM, Max Reitz wrote:
> On 2018-09-04 19:09, John Snow wrote:
>> In cases where we abort the block/mirror job, there's no point in
>> installing the new backing chain before we finish aborting.
>>
>> Move this to the "success" portion of mirror_exit.
>
> Sounds a bit weird
Am 05.09.2018 um 16:02 hat Peter Krempa geschrieben:
> On Wed, Sep 05, 2018 at 08:48:15 -0500, Eric Blake wrote:
> > On 09/05/2018 07:38 AM, Peter Krempa wrote:
> >
> > > block-commit is able to reopen the format layers and works as expected.
> > >
> > > Unfortunately though the 'read-only'
On Thu 09 Aug 2018 11:35:28 PM CEST, Max Reitz wrote:
> +vm.shutdown()
> +
> +#assert top_name[:5] == 'json:'
> +#top_options = json.loads(top_name[5:])
> +
> +#if filter_node_name:
> +## This should be present and set
> +#assert
On Thu 09 Aug 2018 11:35:05 PM CEST, Max Reitz wrote:
> Signed-off-by: Max Reitz
Reviewed-by: Alberto Garcia
Berto
On Thu 09 Aug 2018 11:35:01 PM CEST, Max Reitz wrote:
> If the backing file is overridden, this most probably does change the
> guest-visible data of a BDS. Therefore, we will need to consider this
> in bdrv_refresh_filename().
>
> To see whether it has been overridden, we might want to compare
>
On Wed, Sep 05, 2018 at 08:48:15 -0500, Eric Blake wrote:
> On 09/05/2018 07:38 AM, Peter Krempa wrote:
>
> > block-commit is able to reopen the format layers and works as expected.
> >
> > Unfortunately though the 'read-only' option is actually useful as the
> > curl-driver does not work
On 09/05/2018 07:38 AM, Peter Krempa wrote:
block-commit is able to reopen the format layers and works as expected.
Unfortunately though the 'read-only' option is actually useful as the
curl-driver does not work without it:
-blockdev
On Thu 09 Aug 2018 11:35:22 PM CEST, Max Reitz wrote:
> If a format BDS's file BDS is in turn a format BDS, we cannot simply use
> the same filename, because when opening a BDS tree based on a filename
> alone, qemu will create only one format node on top of one protocol node
> (disregarding a
On 09/05/2018 06:43 AM, Max Reitz wrote:
> On 2018-09-04 19:09, John Snow wrote:
>> For purposes of minimum code movement, refactor the mirror_exit
>> callback to use the post-finalization callbacks in a trivial way.
>>
>> Signed-off-by: John Snow
>> ---
>> block/mirror.c | 34
On 09/05/2018 05:54 AM, Kevin Wolf wrote:
> Am 04.09.2018 um 21:30 hat Eric Blake geschrieben:
>> On 09/04/2018 02:15 PM, John Snow wrote:
>>
>>>
>>> post-script: I really, really hate the "fake cancel" we've implemented
>>> for mirror. It makes the job logic so much worse.
>>
>> Mirror really
On 2018-09-03 16:34, Alberto Garcia wrote:
> 'force-share' is one of the basic BlockdevOptions available for all
> drivers, but it's not handled by bdrv_reopen_prepare() so any attempt
> to change it results in a "Cannot change the option" error:
>
>(qemu) qemu-io virtio0 "reopen -o
On 2018-09-03 16:34, Alberto Garcia wrote:
> 'detect-zeroes' is one of the basic BlockdevOptions available for all
> drivers, but it's not handled by bdrv_reopen_prepare(), so any attempt
> to change it results in an error:
>
>(qemu) qemu-io virtio0 "reopen -o detect-zeroes=on"
>Cannot
On 2018-09-03 16:34, Alberto Garcia wrote:
> 'discard' is one of the basic BlockdevOptions available for all
> drivers, but it's not handled by bdrv_reopen_prepare() so any attempt
> to change it results in an error:
>
>(qemu) qemu-io virtio0 "reopen -o discard=on"
>Cannot change the
On 2018-09-03 16:34, Alberto Garcia wrote:
> The file-posix code is used for the "file", "host_device" and
> "host_cdrom" drivers, and it allows reopening images. However the only
> option that is actually processed is "x-check-cache-dropped", and
> changes in all other options (e.g. "filename")
On 2018-09-03 16:34, Alberto Garcia wrote:
> The bdrv_reopen_prepare() function checks all options passed to each
> BlockDriverState (in the reopen_state->options QDict) and makes all
> necessary preparations to apply the option changes requested by the
> user.
>
> Options are removed from the
On Thu 09 Aug 2018 11:35:20 PM CEST, Max Reitz wrote:
> Instead of having every block driver which implements
> bdrv_refresh_filename() copy all of the strong runtime options over to
> bs->full_open_options, implement this process generically in
> bdrv_refresh_filename().
>
> This patch only adds
On Thu 09 Aug 2018 11:35:19 PM CEST, Max Reitz wrote:
> Some follow-up patches will rework the way bs->full_open_options is
> refreshed in bdrv_refresh_filename(). The new implementation will remove
> the need for the block drivers' bdrv_refresh_filename() implementations
> to set
On 2018-09-03 16:34, Alberto Garcia wrote:
> In the previous patches we removed all child references from
> bs->{options,explicit_options} because keeping them is useless and
> wrong.
>
> Because of this, any attempt to reopen a BlockDriverState using a
> child reference as one of its options
On Tue, Sep 04, 2018 at 17:34:36 +0200, Kevin Wolf wrote:
> Am 04.09.2018 um 17:00 hat Peter Krempa geschrieben:
> > On Tue, Sep 04, 2018 at 16:42:17 +0200, Alberto Garcia wrote:
> > > On Tue 04 Sep 2018 04:17:30 PM CEST, Peter Krempa wrote:
[...]
> > I remember being told some time ago to
On 2018-09-03 16:34, Alberto Garcia wrote:
> Block drivers allow opening their children using a reference to an
> existing BlockDriverState. These references remain stored in the
> 'options' and 'explicit_options' QDicts, but we don't need to keep
> them once everything is open.
>
> What is more
On 2018-09-05 13:53, Kevin Wolf wrote:
> Am 05.09.2018 um 13:37 hat Max Reitz geschrieben:
>> On 2018-09-05 12:49, Kevin Wolf wrote:
>>> Am 05.09.2018 um 12:27 hat Max Reitz geschrieben:
On 2018-09-04 22:32, John Snow wrote:
>
>
> On 09/04/2018 02:46 PM, Jeff Cody wrote:
>> On
Am 05.09.2018 um 13:37 hat Max Reitz geschrieben:
> On 2018-09-05 12:49, Kevin Wolf wrote:
> > Am 05.09.2018 um 12:27 hat Max Reitz geschrieben:
> >> On 2018-09-04 22:32, John Snow wrote:
> >>>
> >>>
> >>> On 09/04/2018 02:46 PM, Jeff Cody wrote:
> On Tue, Sep 04, 2018 at 01:09:19PM -0400,
On 2018-09-05 12:49, Kevin Wolf wrote:
> Am 05.09.2018 um 12:27 hat Max Reitz geschrieben:
>> On 2018-09-04 22:32, John Snow wrote:
>>>
>>>
>>> On 09/04/2018 02:46 PM, Jeff Cody wrote:
On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote:
> Use the component callbacks; prepare,
In qemu_laio_process_completions_and_submit, the AioContext is acquired
before the ioq_submit iteration and after qemu_laio_process_completions,
but the latter is not thread safe either.
This change avoids a number of random crashes when the Main Thread and
an IO Thread collide processing
Am 05.09.2018 um 12:27 hat Max Reitz geschrieben:
> On 2018-09-04 22:32, John Snow wrote:
> >
> >
> > On 09/04/2018 02:46 PM, Jeff Cody wrote:
> >> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote:
> >>> Use the component callbacks; prepare, abort, and clean.
> >>>
> >>> NB: prepare is
On 2018-09-04 19:09, John Snow wrote:
> The exit callback in this test actually only performs cleanup.
>
> Signed-off-by: John Snow
> ---
> tests/test-blockjob-txn.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP
On 2018-09-04 19:09, John Snow wrote:
> For purposes of minimum code movement, refactor the mirror_exit
> callback to use the post-finalization callbacks in a trivial way.
>
> Signed-off-by: John Snow
> ---
> block/mirror.c | 34 +++---
> 1 file changed, 27
On 2018-09-04 19:09, John Snow wrote:
> In cases where we abort the block/mirror job, there's no point in
> installing the new backing chain before we finish aborting.
>
> Move this to the "success" portion of mirror_exit.
Sounds a bit weird now that you don't do any moving.
> Signed-off-by:
On 2018-09-04 22:32, John Snow wrote:
>
>
> On 09/04/2018 02:46 PM, Jeff Cody wrote:
>> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote:
>>> Use the component callbacks; prepare, abort, and clean.
>>>
>>> NB: prepare is only called when the job has not yet failed;
>>> and abort can be
Am 04.09.2018 um 21:30 hat Eric Blake geschrieben:
> On 09/04/2018 02:15 PM, John Snow wrote:
>
> >
> > post-script: I really, really hate the "fake cancel" we've implemented
> > for mirror. It makes the job logic so much worse.
>
> Mirror really does have a tri-state way to end the job (and
AIO Coroutines shouldn't by managed by an AioContext different than the
one assigned when they are created. aio_co_enter avoids entering a
coroutine from a different AioContext, calling aio_co_schedule instead.
Scheduled coroutines are then entered by co_schedule_bh_cb using
qemu_coroutine_enter,
34 matches
Mail list logo
