On Tue, 09/25 07:00, Markus Armbruster wrote:
> Jeff Cody writes:
>
> > I'll not be involved in day-to-day qemu development. Remove
> > myself as maintainer from the remainder of the network block drivers
> > (and vhdx), and revert them to the general block layer maintainership.
> >
> > Signed-o
Image locking errors happening at device initialization time doesn't say
which file cannot be locked, for instance,
-device scsi-disk,drive=drive-1: Failed to get shared "write" lock
Is another process using the image?
could refer to either the overlay image or its backing image.
Hoist t
Jeff Cody writes:
> I'll not be involved in day-to-day qemu development. Remove
> myself as maintainer from the remainder of the network block drivers
> (and vhdx), and revert them to the general block layer maintainership.
>
> Signed-off-by: Jeff Cody
> ---
> MAINTAINERS | 14 --
>
On Tue, Sep 25, 2018 at 12:09:15AM -0400, Jeff Cody wrote:
> I'll not be involved with day-to-day qemu development, and John
> Snow is a block jobs wizard. Have him take over block job
> maintainership duties.
>
> Signed-off-by: Jeff Cody
> ---
> MAINTAINERS | 4 ++--
> 1 file changed, 2 insert
I'll not be involved with day-to-day qemu development, and John
Snow is a block jobs wizard. Have him take over block job
maintainership duties.
Signed-off-by: Jeff Cody
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index aa1dd
I'll not be involved in day-to-day qemu development. Remove
myself as maintainer from the remainder of the network block drivers
(and vhdx), and revert them to the general block layer maintainership.
Signed-off-by: Jeff Cody
---
MAINTAINERS | 14 --
1 file changed, 14 deletions(-)
This is a small test that will check for the ability to parse
both legacy and modern options for rbd.
The way the test is set up is for failure to occur, but without
having to wait to timeout on a non-existent rbd server. The error
messages in the success path show that the arguments were parsed.
I'm not going to be involved with day-to-day qemu development, so
this necessitates some changes.
Jeff Cody (2):
MAINTAINERS: Replace myself with John Snow for block jobs
MAINTAINERS: Remove myself as block maintainer
MAINTAINERS | 18 ++
1 file changed, 2 insertions(+), 16 d
From: "Richard W.M. Jones"
The sslverify setting is supposed to turn off all TLS certificate
checks in libcurl. However because of the way we use it, it only
turns off peer certificate authenticity checks
(CURLOPT_SSL_VERIFYPEER). This patch makes it also turn off the check
that the server name
When we converted rbd to get rid of the older key/value-centric
encoding format, we broke compatibility with image files with backing
file strings encoded in the old format.
This leaves a bit of an ugly conundrum, and a hacky solution.
If the initial attempt to parse the "proper" options fails, i
On Wed, Sep 12, 2018 at 09:18:49AM -0400, Jeff Cody wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the Git repo
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
Message-id:
5b49a980f2cde6610ab1df41bb0277d00b5db893.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
block/rbd.c
The following changes since commit 741e1a618b126e664f7b723e6fe1b7ace511caf7:
Merge remote-tracking branch
'remotes/stefanberger/tags/pull-tpm-2018-09-07-1' into staging (2018-09-24
18:12:54 +0100)
are available in the Git repository at:
git://github.com/codyprime/qemu-kvm-jtc.git tags/bloc
Signed-off-by: Jeff Cody
Message-id:
647f5b5ab7efd8bf567a504c832b1d2d6f719b23.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
qemu-deprecated.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index a43fcf4835..2283
On Sat, Sep 22, 2018 at 08:18:26AM +0200, Markus Armbruster wrote:
> Jeff Cody writes:
>
> > When we converted rbd to get rid of the older key/value-centric
> > encoding format, we broke compatibility with image files with backing
> > file strings encoded in the old format.
> >
> > This leaves a
On Fri, Sep 14, 2018 at 10:56:22AM +0100, Richard W.M. Jones wrote:
> The sslverify setting is supposed to turn off all TLS certificate
> checks in libcurl. However because of the way we use it, it only
> turns off peer certificate authenticity checks
> (CURLOPT_SSL_VERIFYPEER). This patch makes
On 9/24/18 10:34 PM, Max Reitz wrote:
On 24.09.18 18:53, Leonid Bloch wrote:
On 9/24/18 6:04 PM, Alberto Garcia wrote:
On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 20 +---
qemu-options.hx | 9 ++
This series makes the qcow2 L2 cache assignment aware of the image size,
with the intention for it to cover the entire image. The importance of
this change is in noticeable performance improvement, especially with
heavy random I/O. The memory overhead is not big in most cases, as only
1 MB of cache
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 2 +-
block/qcow2.h | 9 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index c13153735a..d2c07ce9fe 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -830,7 +830,7
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 21 ++---
qemu-options.hx | 9 ++---
2 files changed, 20 insertions(+), 10 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index 8a09a5cc5f..7e28b41bd3 100644
--- a/docs/qcow2-cache.txt
+++ b/d
Sufficient L2 cache can noticeably improve the performance when using
large images with frequent I/O.
Previously, unless 'cache-size' was specified and was large enough, the
L2 cache was set to a certain size without taking the virtual image size
into account.
Now, the L2 cache assignment is awar
Adding a lookup table for the powers of two, with the appropriate size
prefixes. This is needed when a size has to be stringified, in which
case something like '(1 * KiB)' would become a literal '(1 * (1L << 10))'
string. Powers of two are used very often for sizes, so such a table
will also make i
The refcount cache size does not need to be set to its minimum value in
read_cache_sizes(), as it is set to at least its minimum value in
qcow2_update_options_prepare().
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 5 ++---
1 file changed, 2 insertions(+), 3 delet
The upper limit on the L2 cache size is increased from 1 MB to 32 MB
on Linux platforms, and to 8 MB on other platforms (this difference is
caused by the ability to set intervals for cache cleaning on Linux
platforms only).
This is done in order to allow default full coverage with the L2 cache
for
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 3c1859f9cc..983d4361d7 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1324,7 +1324,7 @@ static int coroutine_f
The caches are now recalculated upon image resizing. This is done
because the new default behavior of assigning L2 cache relatively to
the image size, implies that the cache will be adapted accordingly
after an image resize.
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow
The default cache-clean-interval is set to 10 minutes, in order to lower
the overhead of the qcow2 caches (before the default was 0, i.e.
disabled).
* For non-Linux platforms the default is kept at 0, because
cache-clean-interval is not supported there yet.
Signed-off-by: Leonid Bloch
Reviewed
On 24.09.18 18:53, Leonid Bloch wrote:
> On 9/24/18 6:04 PM, Alberto Garcia wrote:
>> On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote:
>>> Signed-off-by: Leonid Bloch
>>> ---
>>> docs/qcow2-cache.txt | 20 +---
>>> qemu-options.hx | 9 ++---
>>> 2 files change
On 9/24/18 7:59 PM, Eric Blake wrote:
On 9/21/18 12:23 PM, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 2 +-
block/qcow2.h | 9 +
2 files changed, 6 insertions(+), 5 deletions(-)
+++ b/block/qcow2.h
@@ -27,6 +27,7 @@
#includ
On 20.09.18 18:19, Kevin Wolf wrote:
> For the block job drain test, don't only test draining the source and
> the target node, but create a backing chain for the source
> (source_backing <- source <- source_overlay) and test draining each of
> the nodes in it.
>
> When using iothreads, the source
On 20.09.18 18:19, Kevin Wolf wrote:
> When draining a block node, we recurse to its parent and for subtree
> drains also to its children. A single AIO_WAIT_WHILE() is then used to
> wait for bdrv_drain_poll() to become true, which depends on all of the
> nodes we recursed to. However, if the respe
On 9/21/18 12:23 PM, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 2 +-
block/qcow2.h | 9 +
2 files changed, 6 insertions(+), 5 deletions(-)
+++ b/block/qcow2.h
@@ -27,6 +27,7 @@
#include "crypto/block.h"
#include "qemu
On 9/24/18 6:04 PM, Alberto Garcia wrote:
> On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote:
>> Signed-off-by: Leonid Bloch
>> ---
>> docs/qcow2-cache.txt | 20 +---
>> qemu-options.hx | 9 ++---
>> 2 files changed, 19 insertions(+), 10 deletions(-)
>>
>> diff
On Fri 21 Sep 2018 07:23:07 PM CEST, Leonid Bloch wrote:
> The upper limit on the L2 cache size is increased from 1 MB to 32 MB
> on Linux platforms, and to 8 MB on other platforms (this difference is
> caused by the ability to set intervals for cache cleaning on Linux
> platforms only).
>
> This i
On 9/24/18 5:09 PM, Eric Blake wrote:
> On 9/21/18 12:23 PM, Leonid Bloch wrote:
>> Adding a lookup table for the powers of two, with the appropriate size
>> prefixes. This is needed when a size has to be stringified, in which
>> case something like '(1 * KiB)' would become a literal '(1 * (1L << 1
On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote:
> Signed-off-by: Leonid Bloch
> ---
> docs/qcow2-cache.txt | 20 +---
> qemu-options.hx | 9 ++---
> 2 files changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
>
On 31 August 2018 at 15:32, Max Reitz wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the Git repository at:
>
>
On 9/21/18 12:23 PM, Leonid Bloch wrote:
Adding a lookup table for the powers of two, with the appropriate size
prefixes. This is needed when a size has to be stringified, in which
case something like '(1 * KiB)' would become a literal '(1 * (1L << 10))'
string. Powers of two are used very often
On Fri 21 Sep 2018 07:23:03 PM CEST, Leonid Bloch wrote:
> Adding a lookup table for the powers of two, with the appropriate size
> prefixes. This is needed when a size has to be stringified, in which
> case something like '(1 * KiB)' would become a literal '(1 * (1L << 10))'
> string. Powers of tw
On Mon 24 Sep 2018 03:43:10 PM CEST, Max Reitz wrote:
> On 19.09.18 11:18, Alberto Garcia wrote:
>> On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote:
>>> 'discard' is one of the basic BlockdevOptions available for all
>>> drivers, but it's not handled by bdrv_reopen_prepare() so any attem
On 19.09.18 11:18, Alberto Garcia wrote:
> On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote:
>> 'discard' is one of the basic BlockdevOptions available for all
>> drivers, but it's not handled by bdrv_reopen_prepare() so any attempt
>> to change it results in an error:
>>
>>(qemu) qem
On Fri 21 Sep 2018 07:23:09 PM CEST, Leonid Bloch wrote:
> The default cache-clean-interval is set to 10 minutes, in order to lower
> the overhead of the qcow2 caches (before the default was 0, i.e.
> disabled).
>
> * For non-Linux platforms the default is kept at 0, because
> cache-clean-interva
42 matches
Mail list logo
