Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] tests/tcg/README: fix location for lm32 tests

On 2018-10-04 18:18, Cleber Rosa wrote: > Point to the right and obvious location for lm32 tests. > > Signed-off-by: Cleber Rosa > --- > tests/tcg/README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/tcg/README b/tests/tcg/README > index a5643d33e7..2a58f9a058 1

Re: [Qemu-block] [PATCH v3] vmdk: align end of file to a sector boundary

Ping? On 2018-09-13 16:34, Fam Zheng wrote: On Thu, 09/13 16:29, yuchen...@synology.com wrote: From: yuchenlin There is a rare case which the size of last compressed cluster is larger than the cluster size, which will cause the file is not aligned at the sector boundary. There are three reas

Re: [Qemu-block] [PATCH v3 13/18] block: introduce new filter driver: fleecing-hook

On 10/04/2018 05:52 PM, Kevin Wolf wrote: Am 04.10.2018 um 15:59 hat Vladimir Sementsov-Ogievskiy geschrieben: 04.10.2018 15:44, Kevin Wolf wrote: Am 01.10.2018 um 12:29 hat Vladimir Sementsov-Ogievskiy geschrieben: Fleecing-hook filter does copy-before-write operation. It should be inserted a

Re: [Qemu-block] [Qemu-devel] [PATCH 09/10] scripts/qemu.py: use a more consistent docstring style

On 10/4/18 12:50 PM, Eric Blake wrote: > On 10/4/18 11:18 AM, Cleber Rosa wrote: >> Signed-off-by: Cleber Rosa >> --- >>   dtc |  2 +- >>   scripts/qemu.py | 65 +++-- >>   2 files changed, 42 insertions(+), 25 deletions(-) >> >> diff --git

Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] qemu-img.c: comment typo fix

On 10/4/18 12:48 PM, Eric Blake wrote: > On 10/4/18 11:18 AM, Cleber Rosa wrote: >> A trivial comment typo fix. >> >> Signed-off-by: Cleber Rosa >> --- >>   qemu-img.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index b12f4cd19b..a96b7

Re: [Qemu-block] [Qemu-devel] [PATCH 09/10] scripts/qemu.py: use a more consistent docstring style

On 10/4/18 11:18 AM, Cleber Rosa wrote: Signed-off-by: Cleber Rosa --- dtc | 2 +- scripts/qemu.py | 65 +++-- 2 files changed, 42 insertions(+), 25 deletions(-) diff --git a/dtc b/dtc index 88f18909db..e54388015a 16 --- a/dtc +++

Re: [Qemu-block] [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable

On 10/4/18 11:18 AM, Cleber Rosa wrote: Commit 990dc39c made all tests executable at the time, but 218 came in later, and missing those permissions. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/218 | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tests

Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] qemu-img.c: comment typo fix

On 10/4/18 11:18 AM, Cleber Rosa wrote: A trivial comment typo fix. Signed-off-by: Cleber Rosa --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index b12f4cd19b..a96b76c187 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1085,7 +1085,7 @

Re: [Qemu-block] [PATCH 06/10] thunk.c: clean up commented out definition

Le 04/10/2018 à 18:31, Cleber Rosa a écrit : > > > On 10/4/18 12:24 PM, Laurent Vivier wrote: >> Le 04/10/2018 à 18:18, Cleber Rosa a écrit : >>> Signed-off-by: Cleber Rosa >>> --- >>> thunk.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/thunk.c b/thunk.c >>> index d5d8645cd4

Re: [Qemu-block] [PATCH 06/10] thunk.c: clean up commented out definition

On 10/4/18 12:24 PM, Laurent Vivier wrote: > Le 04/10/2018 à 18:18, Cleber Rosa a écrit : >> Signed-off-by: Cleber Rosa >> --- >> thunk.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/thunk.c b/thunk.c >> index d5d8645cd4..e351ae53af 100644 >> --- a/thunk.c >> +++ b/thunk.c >> @

Re: [Qemu-block] [PATCH 06/10] thunk.c: clean up commented out definition

Le 04/10/2018 à 18:18, Cleber Rosa a écrit : > Signed-off-by: Cleber Rosa > --- > thunk.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/thunk.c b/thunk.c > index d5d8645cd4..e351ae53af 100644 > --- a/thunk.c > +++ b/thunk.c > @@ -21,8 +21,6 @@ > #include "qemu.h" > #include "exec/u

[Qemu-block] [PATCH 09/10] scripts/qemu.py: use a more consistent docstring style

Signed-off-by: Cleber Rosa --- dtc | 2 +- scripts/qemu.py | 65 +++-- 2 files changed, 42 insertions(+), 25 deletions(-) diff --git a/dtc b/dtc index 88f18909db..e54388015a 16 --- a/dtc +++ b/dtc @@ -1 +1 @@ -Subproject commit 88f1890

[Qemu-block] [PATCH 10/10] scripts/qemu.py: remove trailing quotes on docstring

Signed-off-by: Cleber Rosa --- scripts/qemu.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index 7abe26de69..676eb9709a 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -88,7 +88,7 @@ class QEMUMachine(object): @param name: p

[Qemu-block] [PATCH 07/10] scripts/decodetree.py: remove unused imports

Signed-off-by: Cleber Rosa --- scripts/decodetree.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 277f9a9bba..457cffea90 100755 --- a/scripts/decodetree.py +++ b/scripts/decodetree.py @@ -149,12 +149,10 @@ # trans_addl_i(ctx, &arg_opi

[Qemu-block] [PATCH 05/10] docs/devel/testing.rst: add missing newlines after code block

The line immediate following a ".. code::" block is considered to contains arguments to the "code directive". The lack of a new line gives me during at parse time: testing.rst:63: (ERROR/3) Error in "code" directive: maximum 1 argument(s) allowed, 3 supplied. .. code:: make check-u

[Qemu-block] [PATCH 04/10] qemu-iotests: fix filename containing checks

Commit cce293a2945 moved some functions from common.config to common.rc, but the error messages still reference the old file location. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/common.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/common.rc

[Qemu-block] [PATCH 01/10] qemu-img.c: comment typo fix

A trivial comment typo fix. Signed-off-by: Cleber Rosa --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index b12f4cd19b..a96b76c187 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1085,7 +1085,7 @@ static int64_t find_nonzero(const uint8_t

[Qemu-block] [PATCH 02/10] tests/tcg/README: fix location for lm32 tests

Point to the right and obvious location for lm32 tests. Signed-off-by: Cleber Rosa --- tests/tcg/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/README b/tests/tcg/README index a5643d33e7..2a58f9a058 100644 --- a/tests/tcg/README +++ b/tests/tcg/README @@ -10

[Qemu-block] [PATCH 06/10] thunk.c: clean up commented out definition

Signed-off-by: Cleber Rosa --- thunk.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/thunk.c b/thunk.c index d5d8645cd4..e351ae53af 100644 --- a/thunk.c +++ b/thunk.c @@ -21,8 +21,6 @@ #include "qemu.h" #include "exec/user/thunk.h" -//#define DEBUG - static unsigned int max_struct_ent

[Qemu-block] [PATCH 08/10] scripts/decodetree.py: fix reference to attributes

Signed-off-by: Cleber Rosa --- scripts/decodetree.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 457cffea90..37c76b5507 100755 --- a/scripts/decodetree.py +++ b/scripts/decodetree.py @@ -298,7 +298,7 @@ class Field:

[Qemu-block] [PATCH 03/10] qemu-iotests: make 218 executable

Commit 990dc39c made all tests executable at the time, but 218 came in later, and missing those permissions. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/218 | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tests/qemu-iotests/218 diff --git a/tests/qemu-io

[Qemu-block] [PATCH 00/10] Trivial fixes and clean ups

Just a collection of trivial fixes and clean ups that have been lying around here for some time. Cleber Rosa (10): qemu-img.c: comment typo fix tests/tcg/README: fix location for lm32 tests qemu-iotests: make 218 executable qemu-iotests: fix filename containing checks docs/devel/testing.

Re: [Qemu-block] [PATCH v4 7/8] file-posix: account discard operations

Am 21.08.2018 um 11:46 hat Anton Nefedov geschrieben: > This will help to identify how many of the user-issued discard operations > (accounted on a device level) have actually suceeded down on the host file > (even though the numbers will not be exactly the same if non-raw format > driver is used (

Re: [Qemu-block] [PATCH v4 6/8] scsi: account unmap operations

Am 21.08.2018 um 11:46 hat Anton Nefedov geschrieben: > Signed-off-by: Anton Nefedov > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Alberto Garcia > --- > hw/scsi/scsi-disk.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/hw/scsi/scsi-disk.c b/hw/s

Re: [Qemu-block] [PATCH v4 3/8] ide: account UNMAP (TRIM) operations

Am 21.08.2018 um 11:46 hat Anton Nefedov geschrieben: > Signed-off-by: Anton Nefedov > Reviewed-by: Alberto Garcia > --- > hw/ide/core.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 2c62efc..352429b 100644 > --- a/hw/ide/core.c > +

Re: [Qemu-block] [PATCH v3 13/18] block: introduce new filter driver: fleecing-hook

Am 04.10.2018 um 15:59 hat Vladimir Sementsov-Ogievskiy geschrieben: > 04.10.2018 15:44, Kevin Wolf wrote: > > Am 01.10.2018 um 12:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> Fleecing-hook filter does copy-before-write operation. It should be > >> inserted above active disk and has a targ

[Qemu-block] [PULL v2 6/6] nbd: fix NBD_FLAG_SEND_CACHE value

From: "Denis V. Lunev" Commit bc37b06a5 added NBD_CMD_CACHE support, but used the wrong value for NBD_FLAG_SEND_CACHE flag for negotiation. That commit picked bit 8, which had already been assigned by the NBD specification to mean NBD_FLAG_CAN_MULTI_CONN, and which was already implemented in the

Re: [Qemu-block] [PATCH] nbd/server: fix NBD_CMD_CACHE

On 10/4/18 8:02 AM, Kevin Wolf wrote: Am 03.10.2018 um 17:10 hat Vladimir Sementsov-Ogievskiy geschrieben: 03.10.2018 17:57, Eric Blake wrote: On 10/3/18 9:47 AM, Vladimir Sementsov-Ogievskiy wrote: We should not go to structured-read branch on CACHE command, fix that. Bug intoroduced in bc37

Re: [Qemu-block] [PATCH v4 0/8] discard blockstats

ping-2 On 18/9/2018 11:12 AM, Anton Nefedov wrote: > ping > > do you think we might proceed with this? or is there any general doubt > about the idea? > > thanks, > > On 21/8/2018 12:46 PM, Anton Nefedov wrote: >> new in v4: >> - patch 7: discard and write-zeroes code paths had been separa

Re: [Qemu-block] [PATCH v3 13/18] block: introduce new filter driver: fleecing-hook

04.10.2018 15:44, Kevin Wolf wrote: > Am 01.10.2018 um 12:29 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Fleecing-hook filter does copy-before-write operation. It should be >> inserted above active disk and has a target node for CBW, like the >> following: >> >> +---+ >> | Guest

Re: [Qemu-block] [PATCH] block: replace "discard" literal with BDRV_OPT_DISCARD macro

Am 03.10.2018 um 12:23 hat Alberto Garcia geschrieben: > Signed-off-by: Alberto Garcia Thanks, applied to the block branch. Kevin

Re: [Qemu-block] [PATCH] nbd/server: fix NBD_CMD_CACHE

Am 03.10.2018 um 17:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > 03.10.2018 17:57, Eric Blake wrote: > > On 10/3/18 9:47 AM, Vladimir Sementsov-Ogievskiy wrote: > >> We should not go to structured-read branch on CACHE command, fix that. > >> > >> Bug intoroduced in bc37b06a5cde24 "nbd/server:

Re: [Qemu-block] [PATCH v3 14/18] block/fleecing-hook: internal api

Am 01.10.2018 um 12:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add some functions to use fleecing-hook internally from backup job in > further commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block.h | 9 > block/fleecing-hook.c | 51 +++

Re: [Qemu-block] [PATCH v3 13/18] block: introduce new filter driver: fleecing-hook

Am 01.10.2018 um 12:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > Fleecing-hook filter does copy-before-write operation. It should be > inserted above active disk and has a target node for CBW, like the > following: > > +---+ > | Guest | > +---+---+ > |r,w > v

Re: [Qemu-block] [PATCH 0/2] nbd server: drop old-style negotiation

On Thu, Oct 04, 2018 at 12:10:17PM +, Vladimir Sementsov-Ogievskiy wrote: > this is a bit more difficult and more overhead than option in Qemu.. But > I don't sure we should care about I think Eric's point is that dropping oldstyle in qemu-nbd isn't really a problem because nbdkit has no plan

Re: [Qemu-block] [PATCH v2] block/vvfat: Fix crash when reporting error about too many files in directory

Am 24.07.2018 um 13:52 hat Thomas Huth geschrieben: > When using the vvfat driver with a directory that contains too many files, > QEMU currently crashes. This can be triggered like this for example: > > mkdir /tmp/vvfattest > cd /tmp/vvfattest > for ((x=0;x<=513;x++)); do mkdir $x; done > qem

Re: [Qemu-block] [PATCH 0/2] nbd server: drop old-style negotiation

03.10.2018 21:08, Eric Blake wrote: > On 10/3/18 12:59 PM, Vladimir Sementsov-Ogievskiy wrote: >> 03.10.2018 20:32, Eric Blake wrote: >> On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote: >> It's unexpected behavior that without -x option qemu-nbd do old-style >> negotiation. Let's use "" as

Re: [Qemu-block] [PATCH v2] bitmap: Update count after a merge

03.10.2018 23:01, Eric Blake wrote: > On 10/3/18 2:57 PM, John Snow wrote: >     - I always forget to update this field.. We definitely should add some generic check on it somewhere, at least in tests. >>> >>> My suggestion (in another thread) was to enhance >>> x-debug-block-dirty-

Re: [Qemu-block] [Qemu-devel] [PATCH v2] block/vvfat: Fix crash when reporting error about too many files in directory

On 2018-07-24 13:52, Thomas Huth wrote: > When using the vvfat driver with a directory that contains too many files, > QEMU currently crashes. This can be triggered like this for example: > > mkdir /tmp/vvfattest > cd /tmp/vvfattest > for ((x=0;x<=513;x++)); do mkdir $x; done > qemu-system-x86