Re: [Qemu-block] [PATCH v3] vmdk: align end of file to a sector boundary

2018-10-07 Thread yuchenlin
On 2018-10-08 10:38, Fam Zheng wrote: On Fri, 10/05 10:00, yuchenlin wrote: Ping? Hi, This was merged as 51b3c6b73acae1e3fd3c7d441fc86dd17356695f. Fam Hi, Thank you for your information. yuchenlin On 2018-09-13 16:34, Fam Zheng wrote: > On Thu, 09/13 16:29, yuchen...@synology.com

Re: [Qemu-block] [PATCH 14/14] block: Stop passing flags to bdrv_reopen_queue_child()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > Now that all callers are passing the new options using the QDict we no > longer need the 'flags' parameter. > > This patch makes the following changes: > >1) The update_options_from_flags() call is no longer necessary > so it can be removed. >

Re: [Qemu-block] [PATCH 13/14] block: Remove flags parameter from bdrv_reopen_queue()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > Now that all callers are passing all flag changes as QDict options, > the flags parameter is no longer necessary, so we can get rid of it. > > Signed-off-by: Alberto Garcia > --- > block.c | 5 +++-- > block/replication.c | 6 ++ >

Re: [Qemu-block] [PATCH 12/14] block: Clean up reopen_backing_file() in block/replication.c

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > This function is used to put the hidden and secondary disks in > read-write mode before launching the backup job, and back in read-only > mode afterwards. > > This patch does the following changes: > > - Use an options QDict with the "read-only"

Re: [Qemu-block] [PATCH v3] vmdk: align end of file to a sector boundary

2018-10-07 Thread Fam Zheng
On Fri, 10/05 10:00, yuchenlin wrote: > Ping? Hi, This was merged as 51b3c6b73acae1e3fd3c7d441fc86dd17356695f. Fam > > On 2018-09-13 16:34, Fam Zheng wrote: > > On Thu, 09/13 16:29, yuchen...@synology.com wrote: > > > From: yuchenlin > > > > > > There is a rare case which the size of last

Re: [Qemu-block] [PATCH 11/14] qemu-io: Put flag changes in the options QDict in reopen_f()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > When reopen_f() puts a block device in the reopen queue, some of the > new options are passed using a QDict, but others ("read-only" and the > cache options) are passed as flags. > > This patch puts those flags in the QDict. This way the flags parameter

Re: [Qemu-block] [PATCH 10/14] block: Drop bdrv_reopen()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > No one is using this function anymore, so we can safely remove it Is this such a minor action to you that you think it doesn't need a full stop? ;-) > Signed-off-by: Alberto Garcia > --- > block.c | 21 - >

Re: [Qemu-block] [PATCH 09/14] block: Use bdrv_reopen_set_read_only() in the mirror driver

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > The 'block-commit' QMP command is implemented internally using two > different drivers. If the source image is the active layer then the > mirror driver is used (commit_active_start()), otherwise the commit > driver is used (commit_start()). > > In both

Re: [Qemu-block] [PATCH 07/14] block: Use bdrv_reopen_set_read_only() in qmp_change_backing_file()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > This patch replaces the bdrv_reopen() calls that set and remove the > BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. > > Signed-off-by: Alberto Garcia > --- > blockdev.c | 8 ++-- > 1 file changed, 2 insertions(+), 6

Re: [Qemu-block] [PATCH 08/14] block: Use bdrv_reopen_set_read_only() in external_snapshot_commit()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > This patch replaces the bdrv_reopen() calls that set and remove the > BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Ha! Got you! It's just one call this time, not "calls"! :-) > Signed-off-by: Alberto Garcia > --- > blockdev.c

Re: [Qemu-block] [PATCH 06/14] block: Use bdrv_reopen_set_read_only() in stream_start/complete()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > This patch replaces the bdrv_reopen() calls that set and remove the > BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. > > Signed-off-by: Alberto Garcia > --- > block/stream.c | 20 ++-- > 1 file changed, 10

Re: [Qemu-block] [PATCH 05/14] block: Use bdrv_reopen_set_read_only() in bdrv_commit()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > This patch replaces the bdrv_reopen() calls that set and remove the > BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. > > Signed-off-by: Alberto Garcia > --- > block/commit.c | 7 +++ > 1 file changed, 3 insertions(+), 4

Re: [Qemu-block] [PATCH 04/14] block: Use bdrv_reopen_set_read_only() in commit_start/complete()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > This patch replaces the bdrv_reopen() calls that set and remove the > BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. > > Signed-off-by: Alberto Garcia > --- > block/commit.c | 16 ++-- > 1 file changed, 6 insertions(+),

Re: [Qemu-block] [PATCH 02/14] block: Add bdrv_reopen_set_read_only()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > Most callers of bdrv_reopen() only use it to switch a BlockDriverState > between read-only and read-write, so this patch adds a new function > that does just that. > > We also want to get rid of the flags parameter in the bdrv_reopen() > API, so this

Re: [Qemu-block] [PATCH 03/14] block: Use bdrv_reopen_set_read_only() in bdrv_backing_update_filename()

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > This patch replaces the bdrv_reopen() calls that set and remove the > BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. > > Signed-off-by: Alberto Garcia > --- > block.c | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [Qemu-block] [PATCH 01/14] block: Don't call update_flags_from_options() if the options are wrong

2018-10-07 Thread Max Reitz
On 19.09.18 16:47, Alberto Garcia wrote: > If qemu_opts_absorb_qdict() fails and we carry on and call > update_flags_from_options() then that can result on a failed > assertion: > >$ qemu-io -c 'reopen -o read-only=foo' hd.qcow2 >block.c:1101: update_flags_from_options: Assertion

Re: [Qemu-block] [PATCH v2 2/2] MAINTAINERS: Remove myself as block maintainer

2018-10-07 Thread Max Reitz
On 26.09.18 20:05, Jeff Cody wrote: > I'll not be involved in day-to-day qemu development. Remove myself as > maintainer from the remainder of the network block drivers, and revert > them to the general block layer maintainership. > > Move 'sheepdog' to the 'Odd Fixes' support level. > > For

Re: [Qemu-block] [Qemu-trivial] [PATCH] qemu-io-cmds: Fix two format strings

2018-10-07 Thread Philippe Mathieu-Daudé
On 10/6/18 8:38 PM, Stefan Weil wrote: > Use %zu instead of %zd for unsigned numbers. > > This fixes two error messages from the LSTM static code analyzer: > > This argument should be of type 'ssize_t' but is of type 'unsigned long' Eventually prepend some spaces to have the difference between