Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Richard Henderson
On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: > You can install your own disk using debian-installer, with: > > ... > -M q800 \ > -serial none -serial mon:stdio \ > -m 1000M -drive file=m68k.qcow2,format=qcow2 \ > -net nic,model=dp83932,addr=09:00:07:12:34:57 \ > -append "co

Re: [Qemu-block] [PATCH v2 0/4] Adding LZFSE compression support for DMG block driver.

2018-10-30 Thread Stefan Hajnoczi
On Thu, Aug 16, 2018 at 10:58:33AM -0300, Julio Faracco wrote: > Since Mac OS X El Capitain (v10.11), Apple uses LZFSE compression to > generate compressed DMGs as an alternative to BZIP2. Possible, Apple > want to keep this algorithm as default in long term. Some years ago, > Apple opened the LZ

Re: [Qemu-block] [Qemu-devel] [PATCH v5 03/11] escc: introduce a selector for the register bit

2018-10-30 Thread Mark Cave-Ayland
On 29/10/2018 23:36, Philippe Mathieu-Daudé wrote: > Hi Marc, Laurent. > > On Mon, Oct 29, 2018 at 2:43 PM Mark Cave-Ayland > wrote: >> >> From: Laurent Vivier >> >> On Sparc and PowerMac, the bit 0 of the address >> selects the register type (control or data) and >> bit 1 selects the channel (

Re: [Qemu-block] [Qemu-devel] [PATCH v5 06/11] esp: add pseudo-DMA as used by Macintosh

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:47, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/scsi/esp.c | 292 >> +

Re: [Qemu-block] [Qemu-devel] [PATCH v5 07/11] hw/m68k: add Nubus support

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:47, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/Makefile.objs    |   1 + >>   hw/n

Re: [Qemu-block] [Qemu-devel] [PATCH v5 09/11] hw/m68k: add a dummy SWIM floppy controller

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:48, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/block/Makefile.objs  |   1 + >>   hw/block/swim.c 

Re: [Qemu-block] [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:46, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> This is broken as the linux driver seems broken too... >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> -

[Qemu-block] [PULL v2 01/20] configs/alpha: Remove unused CONFIG_PARALLEL_ISA switch

2018-10-30 Thread Laurent Vivier
From: Thomas Huth We don't use CONFIG_PARALLEL_ISA in any of our Makefiles, so this is just a dead config option which can be removed. Fixes: a4cb773928e047b137c6998209cf2eec857fac6b Signed-off-by: Thomas Huth Acked-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <154037

[Qemu-block] [PULL v2 06/20] docs/devel/testing.rst: add missing newlines after code block

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa The line immediate following a ".. code::" block is considered to contains arguments to the "code directive". The lack of a new line gives me during at parse time: testing.rst:63: (ERROR/3) Error in "code" directive: maximum 1 argument(s) allowed, 3 supplied. .. code

[Qemu-block] [PULL v2 02/20] vga_int: remove unused function protype

2018-10-30 Thread Laurent Vivier
From: yuchenlin Signed-off-by: yuchenlin Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181022080053.9379-1-yuchen...@synology.com> Signed-off-by: Laurent Vivier --- hw/display/vga_int.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h index 6

[Qemu-block] [PULL v2 14/20] qobject: Catch another straggler for use of qdict_put_str()

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: Mi

[Qemu-block] [PULL v2 04/20] tests/tcg/README: fix location for lm32 tests

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Point to the right and obvious location for lm32 tests. Signed-off-by: Cleber Rosa Reviewed-by: Thomas Huth Acked-by: Alex Bennée Message-Id: <20181004161852.11673-3-cr...@redhat.com> Signed-off-by: Laurent Vivier --- tests/tcg/README | 2 +- 1 file changed, 1 insertion(+)

[Qemu-block] [PULL v2 07/20] scripts/decodetree.py: remove unused imports

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-8-cr...@redhat.com> Signed-off-by: Laurent Vivier --- scripts/decodetree.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py ind

[Qemu-block] [PULL v2 05/20] qemu-iotests: fix filename containing checks

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Commit cce293a2945 moved some functions from common.config to common.rc, but the error messages still reference the old file location. Signed-off-by: Cleber Rosa Reviewed-by: Max Reitz Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-5-cr...@redhat.com>

[Qemu-block] [PULL v2 19/20] ppc: move at24c to its own CONFIG_ symbol

2018-10-30 Thread Laurent Vivier
From: Paolo Bonzini AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is being included in all emulators that use I2C, even if they do not really need it. Separate it and, since it was added for the e500 machines, add it to qemu-system-ppc and qemu-system-ppc64. Signed-off-by: Paolo

[Qemu-block] [PULL v2 09/20] qemu-iotests: make 218 executable

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Commit 990dc39c made all tests executable at the time, but 218 came in later, and missing those permissions. Signed-off-by: Cleber Rosa Message-Id: <20181004161852.11673-4-cr...@redhat.com> Signed-off-by: Laurent Vivier --- tests/qemu-iotests/218 | 0 1 file changed, 0 inser

[Qemu-block] [PULL v2 17/20] hw/pci-host: Remove useless parenthesis around DIV_ROUND_UP macro

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: Mich

[Qemu-block] [PULL v2 10/20] linux-user: fix comment s/atomic_write/atomic_set/

2018-10-30 Thread Laurent Vivier
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <20180811211011.6277-1-c...@braap.org> Signed-off-by: Laurent Vivier --- linux-user/qemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 1beb6a2cfc..dde3f26f5a 100

[Qemu-block] [PULL v2 11/20] cpu.h: fix a typo in comment

2018-10-30 Thread Laurent Vivier
From: Li Qiang Found by reading the code. Signed-off-by: Li Qiang Message-Id: <1536150548-2797-1-git-send-email-liq...@gmail.com> Signed-off-by: Laurent Vivier --- include/qom/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index

[Qemu-block] [PULL v2 15/20] xen: Use the PCI_DEVICE macro

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé TYPE_XEN_PT_DEVICE is a subclass of TYPE_PCI_DEVICE, the clean way to access the PCIDevice pointer is using the PCI_DEVICE() macro. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: Anthony PERARD Acked-by:

[Qemu-block] [PULL v2 03/20] memory.h: fix typos in comments

2018-10-30 Thread Laurent Vivier
From: Li Qiang Signed-off-by: Li Qiang Reviewed-by: Peter Maydell Message-Id: <1539080467-2976-1-git-send-email-liq...@gmail.com> [lv: s/types/typos/] Signed-off-by: Laurent Vivier --- include/exec/memory.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/exec

[Qemu-block] [PULL v2 00/20] Qemu trivial for 3.1 patches

2018-10-30 Thread Laurent Vivier
The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' into staging (2018-10-25 17:41:03 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/qemu-trivial-for-3.1

[Qemu-block] [PULL v2 16/20] tests/bios-tables-test: Remove an useless cast

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/typecast.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: M

[Qemu-block] [PULL v2 18/20] hw/intc/gicv3: Remove useless parenthesis around DIV_ROUND_UP macro

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Message-Id: <201

[Qemu-block] [PULL v2 12/20] tests: Fix typos in comments and help message (found by codespell)

2018-10-30 Thread Laurent Vivier
From: Stefan Weil Fix also a grammar issue. Signed-off-by: Stefan Weil Reviewed-by: Alex Bennée Message-Id: <20180713054755.23323-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- tests/bios-tables-test.c | 2 +- tests/docker/Makefile.include | 2 +- tests/docker/docke

[Qemu-block] [PULL v2 13/20] configure: Support pkg-config for zlib

2018-10-30 Thread Laurent Vivier
From: Stefan Weil This is needed for builds with the mingw64-* packages from Cygwin, but also works for Linux. Move the zlib test also more to the end because users should get information on the really important missing packages (which also require zlib) first. Signed-off-by: Stefan Weil Revie

[Qemu-block] [PULL v2 08/20] scripts/qemu.py: remove trailing quotes on docstring

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-11-cr...@redhat.com> Signed-off-by: Laurent Vivier --- scripts/qemu.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index

[Qemu-block] [PULL v2 20/20] milkymist-minimac2: Use qemu_log_mask(GUEST_ERROR) instead of error_report

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé qemu_log_mask(GUEST_ERROR) is more appropriate: $ qemu -d help Log items (comma separated): guest_errorslog when the guest OS does something invalid (eg accessing a non-existent register) Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle Mes

Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 08:15, Richard Henderson wrote: > On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: >> You can install your own disk using debian-installer, with: >> >> ... >> -M q800 \ >> -serial none -serial mon:stdio \ >> -m 1000M -drive file=m68k.qcow2,format=qcow2 \ >> -net nic,m

Re: [Qemu-block] [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-30 Thread Laurent Vivier
Le 30/10/2018 à 11:46, Mark Cave-Ayland a écrit : > On 30/10/2018 06:46, Hervé Poussineau wrote: > >> Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >>> From: Laurent Vivier >>> >>> This is broken as the linux driver seems broken too... >>> >>> Co-developed-by: Mark Cave-Ayland >>> Signed-off

Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Laurent Vivier
Le 30/10/2018 à 12:48, Mark Cave-Ayland a écrit : > On 30/10/2018 08:15, Richard Henderson wrote: > >> On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: >>> You can install your own disk using debian-installer, with: >>> >>> ... >>> -M q800 \ >>> -serial none -serial mon:stdio \ >>> -m

Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 12:49, Laurent Vivier wrote: > Le 30/10/2018 à 12:48, Mark Cave-Ayland a écrit : >> On 30/10/2018 08:15, Richard Henderson wrote: >> >>> On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: You can install your own disk using debian-installer, with: ... -M q800 \

Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Laurent Vivier
Le 30/10/2018 à 14:12, Mark Cave-Ayland a écrit : > On 30/10/2018 12:49, Laurent Vivier wrote: > >> Le 30/10/2018 à 12:48, Mark Cave-Ayland a écrit : >>> On 30/10/2018 08:15, Richard Henderson wrote: >>> On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: > You can install your own disk using de

Re: [Qemu-block] [PULL v2 00/20] Qemu trivial for 3.1 patches

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:23, Laurent Vivier wrote: > The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' > into staging (2018-10-25 17:41:03 +0100) > > are available in the Git repository at:

Re: [Qemu-block] [PATCH v5 06/11] esp: add pseudo-DMA as used by Macintosh

2018-10-30 Thread Laurent Vivier
On 30/10/2018 07:47, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/scsi/esp.c | 292 >> +++

Re: [Qemu-block] [Qemu-devel] [PATCH v5 06/11] esp: add pseudo-DMA as used by Macintosh

2018-10-30 Thread Laurent Vivier
On 30/10/2018 11:09, Mark Cave-Ayland wrote: > On 30/10/2018 06:47, Hervé Poussineau wrote: > >> Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >>> From: Laurent Vivier >>> >>> Co-developed-by: Mark Cave-Ayland >>> Signed-off-by: Mark Cave-Ayland >>> Signed-off-by: Laurent Vivier >>> --- >>

[Qemu-block] [PULL 02/15] iotests: Make nbd-fault-injector flush

2018-10-30 Thread Eduardo Habkost
From: Max Reitz When closing a connection, make the nbd-fault-injector flush the socket. Without this, the output is a bit unreliable with Python 3. Signed-off-by: Max Reitz Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Reviewed-by: Eric Blake Message-Id: <20181022135307.14398-2-mre.

[Qemu-block] [PULL 00/15] Python queue, 2018-10-30

2018-10-30 Thread Eduardo Habkost
Sorry for submitting this at the last minute. The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: Merge remote-tracking branch 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging (2018-10-30 15:49:55 +) are available in the Git repository at:

[Qemu-block] [PULL 01/15] scripts/device-crash-test: Remove devices that are not user_creatable anymore

2018-10-30 Thread Eduardo Habkost
From: Thomas Huth Devices that are derived from TYPE_SYS_BUS_DEVICE are not user_creatable anymore by default, and some others have been marked as non-user_creatable manually, so we can remove these devices from the "ignore"-list in the device-crash-test script. Signed-off-by: Thomas Huth Messa

[Qemu-block] [PULL 09/15] iotests: Modify imports for Python 3

2018-10-30 Thread Eduardo Habkost
From: Max Reitz There are two imports that need to be modified when running the iotests under Python 3: One is StringIO, which no longer exists; instead, the StringIO class comes from the io module, so import it from there (and use the BytesIO class for Python 2). The other is the ConfigParser,

[Qemu-block] [PULL 03/15] iotests: Flush in iotests.py's QemuIoInteractive

2018-10-30 Thread Eduardo Habkost
From: Max Reitz After issuing a command, flush the pipe. This does not change anything in Python 2, but it makes a difference in Python 3. Signed-off-by: Max Reitz Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Message-Id: <20181022135307.14398-3-mre...@redhat.com> Signed-off-by: Edua

[Qemu-block] [PULL 05/15] iotests: Use // for Python integer division

2018-10-30 Thread Eduardo Habkost
From: Max Reitz In Python 3, / is always a floating-point division. We usually do not want this, and as Python 2.7 understands // as well, change all integer divisions to use that. Signed-off-by: Max Reitz Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Message-Id: <20181022135307.1439

[Qemu-block] [PULL 06/15] iotests: Different iterator behavior in Python 3

2018-10-30 Thread Eduardo Habkost
From: Max Reitz In Python 3, several functions now return iterators instead of lists. This includes range(), items(), map(), and filter(). This means that if we really want a list, we have to wrap those instances with list(). But then again, the two instances where this is the case for map() an

[Qemu-block] [PULL 11/15] Bootstrap Python venv for tests

2018-10-30 Thread Eduardo Habkost
From: Cleber Rosa A number of QEMU tests are written in Python, and may benefit from an untainted Python venv. By using make rules, tests that depend on specific Python libs can set that rule as a requirement, along with rules that require the presence or installation of specific libraries. The

[Qemu-block] [PULL 14/15] scripts/decodetree.py: fix reference to attributes

2018-10-30 Thread Eduardo Habkost
From: Cleber Rosa Signed-off-by: Cleber Rosa Message-Id: <20181004161852.11673-9-cr...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost --- scripts/decodetree.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/decodetree.py b/scripts/d

[Qemu-block] [PULL 07/15] iotests: Explicitly bequeath FDs in Python

2018-10-30 Thread Eduardo Habkost
From: Max Reitz Python 3.4 introduced the inheritable attribute for FDs. At the same time, it changed the default so that all FDs are not inheritable by default, that only inheritable FDs are inherited to subprocesses, and only if close_fds is explicitly set to False. Adhere to this by setting

[Qemu-block] [PULL 04/15] iotests: Use Python byte strings where appropriate

2018-10-30 Thread Eduardo Habkost
From: Max Reitz Since byte strings are no longer the default in Python 3, we have to explicitly use them where we need to, which is mostly when working with structures. It also means that we need to open a file in binary mode when we want to use structures. On the other hand, we have to accomod

[Qemu-block] [PULL 15/15] scripts/qemu.py: use a more consistent docstring style

2018-10-30 Thread Eduardo Habkost
From: Cleber Rosa Signed-off-by: Cleber Rosa Message-Id: <20181004161852.11673-10-cr...@redhat.com> [ehabkost: reverted unintentional submodule update] Signed-off-by: Eduardo Habkost --- scripts/qemu.py | 65 +++-- 1 file changed, 41 insertions(+), 2

[Qemu-block] [PULL 13/15] Travis support for the acceptance tests

2018-10-30 Thread Eduardo Habkost
From: Cleber Rosa This enables the execution of the acceptance tests on Travis. Because the Travis environment is based on Ubuntu Trusty, it requires the python3-pip and python3.4-venv packages. Signed-off-by: Cleber Rosa Tested-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Acked-by: S

[Qemu-block] [PULL 12/15] Acceptance tests: add make rule for running them

2018-10-30 Thread Eduardo Habkost
From: Cleber Rosa The acceptance (aka functional, aka Avocado-based) tests are Python files located in "tests/acceptance" that need to be run with the Avocado libs and test runner. Let's provide a convenient way for QEMU developers to run them, by making use of the tests-venv with the required s

[Qemu-block] [PULL 08/15] iotests: 'new' module replacement in 169

2018-10-30 Thread Eduardo Habkost
From: Max Reitz iotest 169 uses the 'new' module to add methods to a class. This module no longer exists in Python 3. Instead, we can use a lambda. Best of all, this works in 2.7 just as well. Signed-off-by: Max Reitz Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Message-Id: <20181

[Qemu-block] [PULL 10/15] iotests: Unify log outputs between Python 2 and 3

2018-10-30 Thread Eduardo Habkost
From: Max Reitz When dumping an object into the log, there are differences between Python 2 and 3. First, unicode strings are prefixed by 'u' in Python 2 (they are no longer in 3, because unicode strings are the default there). Second, the order of keys in dicts may differ. Third, especially l

[Qemu-block] [PATCH v2] file-posix: Use error API properly

2018-10-30 Thread Fam Zheng
Use error_report for situations that affect user operation (i.e. we're actually returning error), and warn_report/warn_report_err when some less critical error happened but the user operation can still carry on. For raw_normalize_devicepath, add Error parameter to propagate to its callers. Sugge