On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be
On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be
On 11/12/18 17:43, Vladimir Sementsov-Ogievskiy wrote:
> +ThreadPool *pool = aio_get_thread_pool(bdrv_get_aio_context(bs));
> +
> +while (s->nb_threads >= QCOW2_MAX_THREADS) {
> +qemu_co_queue_wait(&s->thread_task_queue, NULL);
> +}
> +
> +s->nb_threads++;
> +ret = threa
On 12/13/18 4:37 PM, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
Acked-by: Richard Henderson
r~
Most files that have TABs only contain a handful of them. Change
them to spaces so that we don't confuse people.
disas, standard-headers, linux-headers and libdecnumber are imported
from other projects and probably should be exempted from the check.
Outside those, after this patch the following f
On Thu, Dec 13, 2018 at 11:27 PM Eric Blake wrote:
> On 12/13/18 11:44 AM, Nir Soffer wrote:
>
> >> The things is, qemu-io was never meant to be used by other
> >> applications that need to process the results, it's a tool for testing
> >> and debugging. If we had meant it to be used by other pro
On Thu, Dec 13, 2018 at 11:14 PM De Backer, Fred (Nokia - BE/Antwerp) <
fred.de_bac...@nokia.com> wrote:
> > Indeed, performance traces are important for issues like this.
> See strace of both FC27 and FC29 attached
>
Looks like you traced only the main thread. All the I/O is done in other
thread
On 12/13/18 11:51 AM, Markus Armbruster wrote:
Patch created mechanically by rerunning:
$ spatch --sp-file scripts/coccinelle/qobject.cocci \
--macro-file scripts/cocci-macro-file.h \
--dir block --in-place
Signed-off-by: Markus Armbruster
---
block/blklogwrites.c
On 12/13/18 11:44 AM, Nir Soffer wrote:
The things is, qemu-io was never meant to be used by other
applications that need to process the results, it's a tool for testing
and debugging. If we had meant it to be used by other programs, we would
have given it a machine-friendly interface.
The mach
On 12/13/18 9:18 PM, John Snow wrote:
>
> On 12/13/18 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 12.12.2018 23:41, John Snow wrote:
>>>
>>> On 12/12/18 4:27 AM, Vladimir Sementsov-Ogievskiy wrote:
ping. No dependencies, apply to master.
>>> Sure thing.
>>>
>>> Staged to jsnow/bitmaps
On 12/13/18 8:50 AM, Vladimir Sementsov-Ogievskiy wrote:
> 13.12.2018 4:50, John Snow wrote:
>> New interface, new smoke test.
>>
>> Signed-off-by: John Snow
>> ---
>> tests/qemu-iotests/236 | 123 +
>> tests/qemu-iotests/236.out | 265
On 12/12/18 9:27 PM, Eric Blake wrote:
> On 12/12/18 7:50 PM, John Snow wrote:
>> New interface, new smoke test.
>>
>> Signed-off-by: John Snow
>> ---
>> tests/qemu-iotests/236 | 123 +
>> tests/qemu-iotests/236.out | 265 +
>> tests/q
On 12/12/18 9:20 PM, Eric Blake wrote:
> On 12/12/18 7:50 PM, John Snow wrote:
>> If iotests have lines exceeding >998 characters long, git doesn't
>> want to send it plaintext to the list. We can solve this by allowing
>> the iotests to use pretty printed QMP output that we can match against
>>
On 12/13/18 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
> 12.12.2018 23:41, John Snow wrote:
>>
>>
>> On 12/12/18 4:27 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> ping. No dependencies, apply to master.
>>>
>>
>> Sure thing.
>>
>> Staged to jsnow/bitmaps.
>
>
> Thank you!
>
> Oops, I've miss
Patch created mechanically by rerunning:
$ spatch --sp-file scripts/coccinelle/qobject.cocci \
--macro-file scripts/cocci-macro-file.h \
--dir block --in-place
Signed-off-by: Markus Armbruster
---
block/blklogwrites.c | 5 ++---
1 file changed, 2 insertions(+), 3 dele
On Thu, Dec 13, 2018 at 4:05 PM Kevin Wolf wrote:
> Am 13.12.2018 um 11:47 hat Daniel P. Berrangé geschrieben:
> > On Thu, Dec 13, 2018 at 01:52:29AM +0200, Nir Soffer wrote:
> > > On Thu, Dec 13, 2018 at 12:13 AM Eric Blake wrote:
> > > >
> > > > When a qemu-io command fails, it's best if the f
On Thu, Dec 13, 2018 at 12:47 PM Daniel P. Berrangé
wrote:
> On Thu, Dec 13, 2018 at 01:52:29AM +0200, Nir Soffer wrote:
> > On Thu, Dec 13, 2018 at 12:13 AM Eric Blake wrote:
> > >
> > > When a qemu-io command fails, it's best if the failure message
> > > goes to stderr rather than stdout.
> >
On 13/12/2018 17:34, Eric Blake wrote:
> On 12/13/18 10:27 AM, Laurent Vivier wrote:
>> Signed-off-by: Laurent Vivier
>> Reviewed-by: Richard W.M. Jones
>> Reviewed-by: Philippe Mathieu-Daudé
>> ---
>>
>> Notes:
>> v2: use %zu with size_t
>> change an uint64_t to int64_t to match %
On 12/13/18 10:27 AM, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier
Reviewed-by: Richard W.M. Jones
Reviewed-by: Philippe Mathieu-Daudé
---
Notes:
v2: use %zu with size_t
change an uint64_t to int64_t to match % PRIi64
Why PRIi64? It's identical to PRId64, but the sourc
Signed-off-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
---
block/file-posix.c | 25 ++---
block/trace-events | 7 +++
2 files changed, 13 insertions(+), 19 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 07bbdab953..cf90899a6e 100644
-
Signed-off-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
---
Notes:
v2: replace "sd_" prefix by "sheepdog_"
remove the dot at the end of the text strings
block/sheepdog.c | 47 +-
block/trace-events | 14 ++
2 files
Signed-off-by: Laurent Vivier
Reviewed-by: Richard W.M. Jones
Reviewed-by: Philippe Mathieu-Daudé
---
Notes:
v2: use %zu with size_t
change an uint64_t to int64_t to match % PRIi64
block/ssh.c| 46 +-
block/trace-events | 17
Convert all the remaining uses of DPRINTF() in the directory block.
Compiled for all target but only tested with "make check"
v2: replace "sd_" prefix by "sheepdog_"
remove the dot at the end of the text strings
use %zu with size_t
change an uint64_t to int64_t to match % PRIi64
Laur
Signed-off-by: Laurent Vivier
Reviewed-by: Richard W.M. Jones
Reviewed-by: Philippe Mathieu-Daudé
---
Notes:
v2: use %zu with size_t
block/curl.c | 29 -
block/trace-events | 9 +
2 files changed, 17 insertions(+), 21 deletions(-)
diff --git a/b
Anton Nefedov writes:
> On 13/12/2018 3:20 PM, Markus Armbruster wrote:
>> I'm reviewing just the QAPI schema today.
>>
>> Anton Nefedov writes:
>>
>>> A block driver can provide a callback to report driver-specific
>>> statistics.
>>>
>>> file-posix driver now reports discard statistics
>>>
>
On Thu, Dec 13, 2018 at 03:22:10PM +0100, Kevin Wolf wrote:
> Am 13.12.2018 um 11:11 hat Daniel P. Berrangé geschrieben:
> > On Wed, Dec 12, 2018 at 04:04:10PM -0600, Eric Blake wrote:
> > > When a qemu-io command fails, it's best if the failure message
> > > goes to stderr rather than stdout.
> >
On 12/13/18 8:49 AM, Kevin Wolf wrote:
We observe that in Fedora 29 the qemu-img, before imaging the disk, it fully
zeroes it. Taking into account the disk size, the whole process now takes 35
minutes instead of 50 seconds. This causes the ironic-python-agent operation to
time-out. The Fedora
Am 13.12.2018 um 13:44 hat Paul Durrant geschrieben:
> > Essentially, what I'm wondering is whether we have anything that could
> > be treated more or less like another monitor besides QMP and HMP, which
> > would internally work similar to HMP, i.e. map (almost) everything to
> > QMP commands.
>
On 13/12/2018 3:20 PM, Markus Armbruster wrote:
> I'm reviewing just the QAPI schema today.
>
> Anton Nefedov writes:
>
>> A block driver can provide a callback to report driver-specific
>> statistics.
>>
>> file-posix driver now reports discard statistics
>>
>> Signed-off-by: Anton Nefedov
>>
Am 13.12.2018 um 15:17 hat Eric Blake geschrieben:
> On 12/13/18 7:12 AM, De Backer, Fred (Nokia - BE/Antwerp) wrote:
> > Hi,
> >
> > We're using Openstack Ironic to deploy baremetal servers. During the
> > deployment process an agent (ironic-python-agent) running on Fedora linux
> > uses qemu-i
Am 12.12.2018 um 23:04 hat Eric Blake geschrieben:
> When a qemu-io command fails, it's best if the failure message
> goes to stderr rather than stdout.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Eric Blake
> ---
>
> RFC because at least iotest 60 (found by -qcow2 -g quick) breaks due
Am 13.12.2018 um 15:23 hat Eric Blake geschrieben:
> On 12/13/18 8:05 AM, Kevin Wolf wrote:
> > Am 13.12.2018 um 11:47 hat Daniel P. Berrangé geschrieben:
> > > On Thu, Dec 13, 2018 at 01:52:29AM +0200, Nir Soffer wrote:
> > > > On Thu, Dec 13, 2018 at 12:13 AM Eric Blake wrote:
> > > > >
> > > >
On 12/13/18 8:05 AM, Kevin Wolf wrote:
Am 13.12.2018 um 11:47 hat Daniel P. Berrangé geschrieben:
On Thu, Dec 13, 2018 at 01:52:29AM +0200, Nir Soffer wrote:
On Thu, Dec 13, 2018 at 12:13 AM Eric Blake wrote:
When a qemu-io command fails, it's best if the failure message
goes to stderr rathe
Am 13.12.2018 um 11:11 hat Daniel P. Berrangé geschrieben:
> On Wed, Dec 12, 2018 at 04:04:10PM -0600, Eric Blake wrote:
> > When a qemu-io command fails, it's best if the failure message
> > goes to stderr rather than stdout.
> >
> > Reported-by: Richard W.M. Jones
> > Signed-off-by: Eric Blake
On 12/13/18 7:12 AM, De Backer, Fred (Nokia - BE/Antwerp) wrote:
Hi,
We're using Openstack Ironic to deploy baremetal servers. During the deployment
process an agent (ironic-python-agent) running on Fedora linux uses qemu-img to
write a qcow2 file to a blockdevice.
Recently we saw a change in
Am 13.12.2018 um 11:47 hat Daniel P. Berrangé geschrieben:
> On Thu, Dec 13, 2018 at 01:52:29AM +0200, Nir Soffer wrote:
> > On Thu, Dec 13, 2018 at 12:13 AM Eric Blake wrote:
> > >
> > > When a qemu-io command fails, it's best if the failure message
> > > goes to stderr rather than stdout.
> >
>
On 12/13/18 6:21 AM, Wainer dos Santos Moschetta wrote:
On 12/12/2018 08:04 PM, Eric Blake wrote:
When a qemu-io command fails, it's best if the failure message
goes to stderr rather than stdout.
Reported-by: Richard W.M. Jones
Signed-off-by: Eric Blake
---
RFC because at least iotest 60 (f
On 13/12/2018 3:02 PM, Vladimir Sementsov-Ogievskiy wrote:
> 03.12.2018 13:14, Anton Nefedov wrote:
>> If COW areas of the newly allocated clusters are zeroes on the backing image,
>> efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole
>> cluster instead of writing explici
13.12.2018 4:50, John Snow wrote:
> New interface, new smoke test.
>
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/236 | 123 +
> tests/qemu-iotests/236.out | 265 +
> tests/qemu-iotests/group | 1 +
> 3 files changed, 389 i
13.12.2018 4:50, John Snow wrote:
> If iotests have lines exceeding >998 characters long, git doesn't
> want to send it plaintext to the list. We can solve this by allowing
> the iotests to use pretty printed QMP output that we can match against
> instead.
>
> As a bonus, it's much nicer for human
On Wed, 12 Dec 2018 at 09:53, Stefan Hajnoczi wrote:
>
> The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
>
> Merge remote-tracking branch
> 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11
> 19:18:58 +)
>
> are available in the Git rep
13.12.2018 4:50, John Snow wrote:
> To mimic the common filter of the same name, but for the python tests.
>
> Signed-off-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/iotests.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/qemu-iot
> -Original Message-
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Sent: 13 December 2018 11:52
> To: Paul Durrant
> Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen-
> de...@lists.xenproject.org; Max Reitz ; Stefano
> Stabellini
> Subject: Re: [PATCH v4 16/18] xen: automatically cr
13.12.2018 4:50, John Snow wrote:
> Instead of using os.environ[], use .get with a default of empty string
> to match the setup in check to allow us to import the iotests module
> (for debugging, say) without needing a crafted environment just to
> import the module.
>
> Signed-off-by: John Snow
13.12.2018 4:50, John Snow wrote:
> The 'x' prefix was added because I was uncertain of the direction we'd
> take for the libvirt API. With the general approach solidified, I feel
> comfortable committing to this API for 4.0.
>
> Signed-off-by: John Snow
> Reviewed-by: Eric Blake
Reviewed-by: Vl
13.12.2018 4:50, John Snow wrote:
> Especially outside of transactions, it is helpful to provide
> all-or-nothing semantics for bitmap merges. This facilitates
> the coalescing of multiple bitmaps into a single target for
> the "checkpoint" interpretation when assembling bitmaps that
> represent ar
On Wed, Dec 12, 2018 at 11:16:23AM +, Paul Durrant wrote:
> This series is a re-base of Tim's v2 series [1] on top of my series [2].
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg00243.html
> [2] https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg02271.html
For the se
On 12/12/2018 08:04 PM, Eric Blake wrote:
When a qemu-io command fails, it's best if the failure message
goes to stderr rather than stdout.
Reported-by: Richard W.M. Jones
Signed-off-by: Eric Blake
---
RFC because at least iotest 60 (found by -qcow2 -g quick) breaks due
to reordering of out
Am 13.12.2018 um 12:07 hat Denis Plotnikov geschrieben:
> On 12.12.2018 15:24, Kevin Wolf wrote:
> > Am 11.12.2018 um 17:55 hat Denis Plotnikov geschrieben:
> >>> Why involve the AioContext at all? This could all be kept at the
> >>> BlockBackend level without extending the layering violation that
I'm reviewing just the QAPI schema today.
Anton Nefedov writes:
> A block driver can provide a callback to report driver-specific
> statistics.
>
> file-posix driver now reports discard statistics
>
> Signed-off-by: Anton Nefedov
> ---
> qapi/block-core.json | 38 +
> -Original Message-
> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf
> Of Anthony PERARD
> Sent: 13 December 2018 11:34
> To: Olaf Hering
> Cc: Kevin Wolf ; Stefano Stabellini
> ; open list:Block layer core bl...@nongnu.org>; qemu-de...@nongnu.org; Max Reitz ;
03.12.2018 13:14, Anton Nefedov wrote:
> If COW areas of the newly allocated clusters are zeroes on the backing image,
> efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole
> cluster instead of writing explicit zero buffers later in perform_cow().
>
[...]
> --- a/block/
Am 13.12.2018 um 12:24 hat Stefan Hajnoczi geschrieben:
> Marking a function coroutine_fn currently has no effect on the compiler,
> but it documents that this function must be called from coroutine
> context and it may yield. This is important information for the
> programmer.
>
> Also, if we ev
On 12/12/2018 8:19 PM, Vladimir Sementsov-Ogievskiy wrote:
> 05.12.2018 17:11, Anton Nefedov wrote:
>> On 5/12/2018 4:25 PM, Vladimir Sementsov-Ogievskiy wrote:
>>> 03.12.2018 13:14, Anton Nefedov wrote:
}
#endif
-bs->supported_zero_flags = BDRV_REQ_MAY_U
On 12/12/2018 3:48 PM, Vladimir Sementsov-Ogievskiy wrote:
> 05.12.2018 17:01, Anton Nefedov wrote:
>> --- a/include/block/block.h
>> +++ b/include/block/block.h
>> @@ -87,6 +87,9 @@ typedef enum {
>> * efficiently allocate the space so it reads as zeroes, or return
>> an error.
>>
Am 11.12.2018 um 16:57 hat Paul Durrant geschrieben:
> This patch adds a creator function for XenBlockDevice-s so that they can
> be created automatically when the Xen toolstack instantiates a new
> PV backend. When the XenBlockDevice is created this way it is also
> necessary to create a drive whi
On Tue, Dec 11, 2018 at 05:02:24PM +0100, Olaf Hering wrote:
> There are some code paths that clobber ioreq->buf, which leads to a huge
> memory leak after a few hours of runtime. One code path is
> qemu_aio_complete, which might be called recursive. Another one is
I think it's s/recursive/recursi
Marking a function coroutine_fn currently has no effect on the compiler,
but it documents that this function must be called from coroutine
context and it may yield. This is important information for the
programmer.
Also, if we ever transition to a stackless coroutine implementation,
then it's lik
12.12.2018 23:41, John Snow wrote:
>
>
> On 12/12/18 4:27 AM, Vladimir Sementsov-Ogievskiy wrote:
>> ping. No dependencies, apply to master.
>>
>
> Sure thing.
>
> Staged to jsnow/bitmaps.
Thank you!
Oops, I've missed your email about s/firt_dirty_off/first_dirty_off
I can resend, or you ca
On 12.12.2018 15:24, Kevin Wolf wrote:
> Am 11.12.2018 um 17:55 hat Denis Plotnikov geschrieben:
>>> Why involve the AioContext at all? This could all be kept at the
>>> BlockBackend level without extending the layering violation that
>>> aio_disable_external() is.
>>>
>>> BlockBackends get notif
In the 'Format specific information' section of the 'qemu-img info'
command output, the supplemental information about existing QCOW2
bitmaps will be shown, such as a bitmap name, flags and granularity:
image: /vz/vmprivate/VM1/harddisk.hdd
file format: qcow2
virtual size: 64G (68719476736 bytes)
On Thu, Dec 13, 2018 at 01:52:29AM +0200, Nir Soffer wrote:
> On Thu, Dec 13, 2018 at 12:13 AM Eric Blake wrote:
> >
> > When a qemu-io command fails, it's best if the failure message
> > goes to stderr rather than stdout.
>
> This makes sense, but it will break users like this:
>
> https://gith
On Tue 11 Dec 2018 05:43:10 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> qcow2.h depends on block_int.h. Compilation isn't broken currently only
> due to block_int.h always included before qcow2.h. Though, it seems
> better to directly include block_int.h in qcow2.h.
If you include block_int.h in
On Wed, Dec 12, 2018 at 04:04:10PM -0600, Eric Blake wrote:
> When a qemu-io command fails, it's best if the failure message
> goes to stderr rather than stdout.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Eric Blake
> ---
>
> RFC because at least iotest 60 (found by -qcow2 -g quick) b
On 12/12/18 8:40 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> block/curl.c | 29 -
> block/trace-events | 9 +
> 2 files changed, 17 insertions(+), 21 deletions(-)
>
> diff --git a/block/curl.c b/block/curl.c
> index db5d2bd8ef..b7a
Hi Laurent,
On 12/12/18 8:40 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> block/sheepdog.c | 47 +-
> block/trace-events | 14 ++
> 2 files changed, 31 insertions(+), 30 deletions(-)
>
> diff --git a/block/sheepdog.c
On 12/12/18 8:40 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
> ---
> block/file-posix.c | 25 ++---
> block/trace-events | 7 +++
> 2 files changed, 13 insertions(+), 19 deletions(-)
>
> diff --git a/block/file-posix.c
On 12/12/18 8:40 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> block/ssh.c| 46 +-
> block/trace-events | 17 +
> 2 files changed, 34 insertions(+), 29 deletions(-)
>
> diff --git a/block/ssh.c b/block/ssh.c
68 matches
Mail list logo
