Patchew URL:
https://patchew.org/QEMU/20190102100415.24680-1-mahaocong_w...@163.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
Patchew URL:
https://patchew.org/QEMU/20190102100415.24680-1-mahaocong_w...@163.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
On 12/30/18 12:09 PM, Richard W.M. Jones wrote:
> On FreeBSD 11.2:
>
> $ ./qemu-io -f raw -c "aio_write 0 512" "nbd:localhost:10809"
> Parsing error: non-numeric argument, or extraneous/unrecognized suffix --
> aio_write
>
> After main option parsing, we reinitialize optind so we can parse e
On 1/2/19 4:04 AM, mahaocong wrote:
> From: mahaocong
>
> This patch adds possibility to start mirroring with user-created-bitmap.
> Compare with v1, this patch fix some shortcomings.
> 1.separate feature about copy dirty-bitmap to an individual patch.
> 2.remove checking for cancelled after mirr
On 1/2/19 4:04 AM, mahaocong wrote:
> From: mahaocong
>
> Signed-off-by: mahaocong
The subject line says "what" changed, but you are missing a commit body
that says "why" the change is useful. Much of the content in your cover
letter should be copied into this commit body, as the cover letter
Hi Stefan,
I created a simple DMG file from MacOS to reproduce the problem:
https://bugs.launchpad.net/qemu/+bug/1809304
Em qua, 2 de jan de 2019 às 08:47, Stefan Hajnoczi
escreveu:
> On Fri, Dec 21, 2018 at 09:58:03PM +0800, yuchenlin wrote:
> > There is a possible hang in original binary sear
On Fri, Dec 28, 2018 at 12:50:55PM -0200, Julio Faracco wrote:
> This is a trivial patch to fix a wrong value for block terminator.
> The old value was 0x7fff which is wrong. It was not affecting the
> code because QEMU dmg block is not handling block terminator right now.
> Neverthless, it sho
On Sun, Dec 23, 2018 at 10:59:39AM +0800, yuchenlin wrote:
> The dmg file has many tables which describe: "start from sector XXX to
> sector XXX, the compression method is XXX and where the compressed data
> resides on".
>
> Each sector in the expanded file should be covered by a table. The table
Hi, Stefan
Thank you for your reviewing.
This series is focus on fixing bug #1809304 (see:
https://bugs.launchpad.net/qemu/+bug/1809304).
There is an example dmg file in #1809304 which will trigger this bug.
About your case, I think we can simply check whether chunk3 is zero before
we decrease i
On Sun, Dec 23, 2018 at 10:59:38AM +0800, yuchenlin wrote:
> Signed-off-by: yuchenlin
> ---
> block/dmg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Sun, Dec 23, 2018 at 10:59:37AM +0800, yuchenlin wrote:
> There is a possible hang in original binary search implementation. That is
> if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case.
>
> The chunk1 will be still 4, and so on.
>
> Signed-off-by: yuchenlin
> ---
> block/dmg.c | 6 +
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> GCC 8 added a -Wstringop-truncation warning:
>
> The -Wstringop-truncation warning added in GCC 8.0 via r254630 for
> bug 81117 is specifically intended to highlight likely unintended
> uses of the strncpy function that truncate the termi
The lookup table for power-of-two sizes is now auto-generated during the
build, and not hard-coded into the units.h file.
Signed-off-by: Leonid Bloch
---
.gitignore | 1 +
Makefile | 5 +++
block/qcow2.h| 2 +-
block/vdi.c | 1 +
include/qemu/units.h |
Following the conversations here:
https://patchwork.kernel.org/patch/10665157
and here:
https://patchwork.kernel.org/patch/10666975
Making the lookup table for power-of-two sizes auto-generated, instead
of being hard-coded into the units.h file.
I'm not sure if the changes I've made to Makefile h
On Fri, Dec 21, 2018 at 09:58:03PM +0800, yuchenlin wrote:
> There is a possible hang in original binary searsh implemtation. That is
> if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case.
>
> The chunk1 will be still 4, and so on.
>
> Signed-off-by: yuchenlin
> ---
> block/dmg.c | 6 +++
From: mahaocong
Signed-off-by: mahaocong
---
block/mirror.c| 55 ---
blockdev.c| 37 +--
include/block/block_int.h | 3 ++-
qapi/block-core.json | 9 +++-
4 files changed, 88 insertion
From: mahaocong
This patch adds possibility to start mirroring with user-created-bitmap.
Compare with v1, this patch fix some shortcomings.
1.separate feature about copy dirty-bitmap to an individual patch.
2.remove checking for cancelled after mirror_dirty_init_incremental for bitmap
copyimg d
From: mahaocong
This patch adds new function to copy the hbitmap from an exist dirty-bitmap to
another. The destination bitmap should have the same size and granularity with
the source bitmap, or the copy will fail.
Signed-off-by: mahaocong
---
block/dirty-bitmap.c | 14 ++
On 2018-12-28 22:50, Julio Faracco wrote:
This is a trivial patch to fix a wrong value for block terminator.
The old value was 0x7fff which is wrong. It was not affecting the
code because QEMU dmg block is not handling block terminator right now.
Neverthless, it should be fixed.
Signed-off-b
19 matches
Mail list logo
