Re: [Qemu-block] [Qemu-devel] [PATCH 0/1] block: Eliminate the S_1KiB, S_2KiB, ... macros

Leonid Bloch writes: > On 1/11/19 9:14 PM, Markus Armbruster wrote: >> Back in September, Leonid Block added a whole bunch of macros (commit > > * Bloch. :) I apologize for my carelessness. Explanation, no excuse: $ git-log --author=armbru -Sblock -i --oneline | wc -l 167 $ git-log

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/6] include: Auto-generate the sizes lookup table

Patchew URL: https://patchew.org/QEMU/20190110191901.5082-1-ebl...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190110191901.5082-1-ebl...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/6] include: Auto-generate the si

Re: [Qemu-block] [PATCH 0/1] block: Eliminate the S_1KiB, S_2KiB, ... macros

On 1/11/19 9:14 PM, Markus Armbruster wrote: > Back in September, Leonid Block added a whole bunch of macros (commit * Bloch. :) > 540b8492618) to improve readability of qcow2.h a bit (commit > b6a95c6d100). He later used them to fix the "vdi" driver's parameter > cluster_size's default value (c

Re: [Qemu-block] [PATCH 1/1] block: Eliminate the S_1KiB, S_2KiB, ... macros

Hi, On 1/11/19 9:14 PM, Markus Armbruster wrote: > We define 54 macros for the powers of two >= 1024. We use six, in six > macro definitions. Four of them could just as well use the common MiB > macro, so do that. The remaining two can't, because they get passed > to stringify. Replace the mac