Re: [Qemu-block] [Qemu-devel] [PATCH RFC] migration/dirty-bitmaps: change bitmap enumeration method

Patchew URL: https://patchew.org/QEMU/20190430231536.25353-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190430231536.25353-1-js...@redhat.com Subject: [Qemu-devel] [PATCH RFC] migration/dirty-bit

[Qemu-block] [PATCH RFC] migration/dirty-bitmaps: change bitmap enumeration method

Shift from looking at every root BDS to *every* BDS. Tested only lightly via iotests. Counter-examples that break this approach welcome. --- migration/block-dirty-bitmap.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/migration/block-dirty-bitmap.c b/migratio

Re: [Qemu-block] [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

On 11/20/18 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.11.2018 21:43, John Snow wrote: >> Coverity warns that backing_bs() could give us a NULL pointer, which >> we then use without checking that it isn't. >> >> In our loop condition, we check bs && bs->drv as a point of habit, but >> by

Re: [Qemu-block] [PATCH v3 1/2] Makefile: add nit-picky mode to sphinx-build

On 4/29/19 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: > 27.04.2019 1:15, John Snow wrote: >> If we add references that don't resolve (or accidentally remove them), >> it will be helpful to have an error message alerting us to that. > > the wording still a bit in conflict with the fact that -n

Re: [Qemu-block] [PATCH v3 2/2] docs/interop/bitmaps: rewrite and modernize doc

On 4/29/19 9:44 AM, Kashyap Chamarthy wrote: > On Fri, Apr 26, 2019 at 06:15:28PM -0400, John Snow wrote: >> This just about rewrites the entirety of the bitmaps.rst document to >> make it consistent with the 4.0 release. I have added new features seen >> in the 4.0 release, as well as tried to

Re: [Qemu-block] [PATCH v2 5/8] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD

On Mon, Apr 29, 2019 at 12:55 AM Thomas Huth wrote: > > We are going to enable the qemu-iotests during "make check" again, > and for running the iotests, we need bash and gnu-sed. > > Signed-off-by: Thomas Huth Reviewed-by: Li-Wen Hsu

Re: [Qemu-block] [PATCH 1/6] tests/qemu-iotests/check: Pick a default machine if necessary

Thomas Huth writes: > qemu-system-arm, qemu-system-aarch64 and qemu-system-tricore do not have > a default machine, so when running the qemu-iotests with such a binary, > lots of tests are failing. Fix it by picking a default machine in the > "check" script instead. > > Signed-off-by: Thomas Hu

Re: [Qemu-block] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash

Thomas Huth writes: > bash is installed in a different directory on non-Linux systems like > FreeBSD. Do not hard-code /bin/bash here so that the tests can run > there, too. > > Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée > --- > tests/qemu-iotests/239 | 2 +- > tests/qemu-iotests/

Re: [Qemu-block] [PATCH v6 0/7] NBD reconnect

Ping Best regards, Vladimir

Re: [Qemu-block] [Qemu-devel] [PULL 00/27] Block layer patches

On Tue, 30 Apr 2019 at 17:01, Kevin Wolf wrote: > > The following changes since commit 22d96eac64877c4d96f9928babb6f2fcc68faacf: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2019-04-29 19:11:15 +0100) > > are available in the Git repository at: >

[Qemu-block] [PULL 22/27] block/commit: use buffer-based io

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Signed-off-by: Kevin Wolf --- block/commit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/commit.c b/block/commit.c in

[Qemu-block] [PULL 27/27] block/qed: add missed coroutine_fn markers

From: Vladimir Sementsov-Ogievskiy qed_read_table and qed_write_table use coroutine-only interfaces but are not marked coroutine_fn. Happily, they are called only from coroutine context, so we only need to add missed markers. Reported-by: Kevin Wolf Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-block] [PULL 26/27] iotests: Check that images are in read-only mode after block-commit

From: Alberto Garcia This tests the fix from the previous patch. Signed-off-by: Alberto Garcia Signed-off-by: Kevin Wolf --- tests/qemu-iotests/249 | 115 + tests/qemu-iotests/249.out | 35 +++ tests/qemu-iotests/group | 1 + 3 files change

[Qemu-block] [PULL 25/27] commit: Make base read-only if there is an early failure

From: Alberto Garcia You can reproduce this by passing an invalid filter-node-name (like "1234") to block-commit. In this case the base image is put in read-write mode but is never reset back to read-only. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- blo

[Qemu-block] [PULL 21/27] block/backup: use buffer-based io

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Signed-off-by: Kevin Wolf --- block/backup.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/block/backup.c b/block/b

[Qemu-block] [PULL 23/27] block/stream: use buffer-based io

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Signed-off-by: Kevin Wolf --- block/stream.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/stream.c b/block/stream.c inde

[Qemu-block] [PULL 19/27] block/qed: use buffer-based io

From: Vladimir Sementsov-Ogievskiy Move to _co_ versions of io functions qed_read_table() and qed_write_table(), as we use qemu_co_mutex_unlock() anyway. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Signed-off-by: Kevin Wolf --- bl

[Qemu-block] [PULL 18/27] block/qcow: use buffer-based io

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Signed-off-by: Kevin Wolf --- block/qcow.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/block/qcow.c b/block

[Qemu-block] [PULL 20/27] block/parallels: use buffer-based io

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Signed-off-by: Kevin Wolf --- block/parallels.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/block/parallels.c b/b

[Qemu-block] [PULL 24/27] qemu-img: use buffer-based io

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Signed-off-by: Kevin Wolf --- qemu-img.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index

[Qemu-block] [PULL 13/27] qemu-img: Make create hint at protocol options

From: Max Reitz qemu-img create allows giving just a format and "-o help" to get a list of the options supported by that format. Users may not realize that the protocol level may offer even more options, which they only get to see by specifying a filename. This patch adds a note to hint at that

[Qemu-block] [PULL 16/27] block: introduce byte-based io helpers

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Signed-off-by: Kevin Wolf --- include/block/block_int.h | 16 include/sysemu/block-backend.h | 19 +++ 2 files cha

[Qemu-block] [PULL 15/27] qcow2: Fix error handling in the compression code

From: Alberto Garcia This patch fixes a few things in the way error codes are handled in the qcow2 compression code: a) qcow2_co_pwritev_compressed() expects qcow2_co_compress() to only return -1 or -2 on failure, but this is not correct. Since the change from qcow2_compress() to qcow2_co_

[Qemu-block] [PULL 14/27] qcow2: Fix qcow2_make_empty() with external data file

make_completely_empty() is an optimisated path for bdrv_make_empty() where completely new metadata is created inside the image file instead of going through all clusters and discarding them. For an external data file, however, we actually need to do discard operations on the data file; just overwri

[Qemu-block] [PULL 17/27] block/qcow2: use buffer-based io

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Signed-off-by: Kevin Wolf --- block/qcow2.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c i

[Qemu-block] [PULL 12/27] iotests: Perform the correct test in 082

From: Max Reitz In the "amend" section of 082, we perform a single "convert" test (namely "convert -o help"). That does not make sense, especially because we have done exactly that "convert" test earlier in 082 already. Replacing "convert" by "amend" yields an error, which is correct because th

[Qemu-block] [PULL 10/27] qcow2: Add errp to preallocate_co()

We'll add a bdrv_co_truncate() call in the next patch which can return an Error that we don't want to discard. So add an errp parameter to preallocate_co(). Cc: qemu-sta...@nongnu.org Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/qcow2.c | 11 ++- 1 file changed, 6 inserti

[Qemu-block] [PULL 06/27] block/vhdx: Use IEC binary prefixes for size constants

From: Stefano Garzarella Using IEC binary prefixes in order to make the code more readable, with the exception of DEFAULT_LOG_SIZE because it's passed to stringify(). Signed-off-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: John Snow Signed-off-by: Kevin Wolf --- b

[Qemu-block] [PULL 11/27] qcow2: Fix full preallocation with external data file

preallocate_co() already gave the data file the full size without forwarding the requested preallocation mode to the protocol. When bdrv_co_truncate() was called later with the preallocation mode, the file didn't actually grow any more, so the data file stayed unallocated even if full preallocation

[Qemu-block] [PULL 09/27] qcow2: Avoid COW during metadata preallocation

Limiting the allocation to INT_MAX bytes isn't particularly clever because it means that the final cluster will be a partial cluster which will be completed through a COW operation. This results in unnecessary data read and write requests which lead to an unwanted non-sparse filesystem block for me

[Qemu-block] [PULL 01/27] tests/qemu-iotests: Fix output of qemu-io related tests

From: Thomas Huth One of the recent commits changed the way qemu-io prints out its errors and warnings - they are now prefixed with the program name. We've got to adapt the iotests accordingly to prevent that they are failing. Fixes: 99e98d7c9fc1a1639fad ("qemu-io: Use error_[gs]et_progname()")

[Qemu-block] [PULL 04/27] vmdk: Set vmdk parent backing_format to vmdk

From: Sam Eiderman Commit b69864e5a ("vmdk: Support version=3 in VMDK descriptor files") fixed the probe function to correctly guess vmdk descriptors with version=3. This solves the issue where vmdk snapshot with parent vmdk descriptor containing "version=3" would be treated as raw instead vmdk.

[Qemu-block] [PULL 07/27] cutils: Fix size_to_str() on 32-bit platforms

From: Eric Blake When extracting a human-readable size formatter, we changed 'uint64_t div' pre-patch to 'unsigned long div' post-patch. Which breaks on 32-bit platforms, resulting in 'inf' instead of intended values larger than 999GB. Fixes: 22951aaa CC: qemu-sta...@nongnu.org Reported-by: Max

[Qemu-block] [PULL 02/27] block: Fix AioContext switch for bs->drv == NULL

Even for block nodes with bs->drv == NULL, we can't just ignore a bdrv_set_aio_context() call. Leaving the node in its old context can mean that it's still in an iothread context in bdrv_close_all() during shutdown, resulting in an attempted unlock of the AioContext lock which we don't hold. This

Re: [Qemu-block] [Qemu-devel] [PATCH] qcow2: Fix qcow2_make_empty() with external data file

On 4/30/19 8:54 AM, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190429105741.31033-1-kw...@redhat.com/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the > testing commands and > their output below. If you have Docker installed, you

[Qemu-block] [PULL 08/27] qemu-img: Saner printing of large file sizes

From: Eric Blake Disk sizes close to INT64_MAX cause overflow, for some pretty ridiculous output: $ ./nbdkit -U - memory size=$((2**63 - 512)) --run 'qemu-img info $nbd' image: nbd+unix://?socket=/tmp/nbdkitHSAzNz/socket file format: raw virtual size: -8388607T (9223372036854775296 bytes

Re: [Qemu-block] [Qemu-devel] [PATCH v5 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter

On 4/30/19 6:09 AM, Kevin Wolf wrote: > Am 30.04.2019 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 30.04.2019 12:24, Stefano Garzarella wrote: >>> On Tue, Apr 23, 2019 at 03:57:05PM +0300, Vladimir Sementsov-Ogievskiy >>> wrote: This fixes at least one overflow in qcow2_process_d

[Qemu-block] [PULL 00/27] Block layer patches

The following changes since commit 22d96eac64877c4d96f9928babb6f2fcc68faacf: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2019-04-29 19:11:15 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

[Qemu-block] [PULL 05/27] block/vhdx: Remove redundant IEC binary prefixes definition

From: Stefano Garzarella IEC binary prefixes are already defined in "qemu/units.h", so we can remove redundant definitions in "block/vhdx.h". Signed-off-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: John Snow Signed-off-by: Kevin Wolf --- block/vhdx.h | 6 +- b

[Qemu-block] [PULL 03/27] vpc: unlock Coroutine lock to make IO submit Concurrently

From: Zhengui li Concurrent IO becomes serial IO because of the qemu Coroutine lock, which reduce IO performance severely. So unlock Coroutine lock before bdrv_co_pwritev and bdrv_co_preadv to fix it. Signed-off-by: Zhengui li Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/v

Re: [Qemu-block] [Qemu-devel] [PATCH] qcow2: Fix qcow2_make_empty() with external data file

Patchew URL: https://patchew.org/QEMU/20190429105741.31033-1-kw...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time ma

Re: [Qemu-block] [PATCH] [RFC] qcow2: add compression type feature

On 2/5/19 3:08 AM, Denis Plotnikov wrote: > The patch adds some preparation parts for incompatible compression type > feature into QCOW2 header that indicates that *all* compressed clusters > must be (de)compressed using a certain compression type. > > It is implied that the compression type is se

Re: [Qemu-block] [PATCH v2 0/3] hw/arm/virt: Support firmware configuration with -blockdev

On Tue, 16 Apr 2019 at 10:13, Markus Armbruster wrote: > > László asked for feature parity with the PC machine types. > > v2: > * PATCH 1: Split off PATCH 2 [László] > * PATCH 2: Factor out the loop body, not the whole loop > * PATCH 3: Rebase on previous change >More detailed commit m

Re: [Qemu-block] [Qemu-devel] [PATCH v5 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter

On Tue, Apr 30, 2019 at 10:03:08AM +, Vladimir Sementsov-Ogievskiy wrote: > 30.04.2019 12:24, Stefano Garzarella wrote: > > On Tue, Apr 23, 2019 at 03:57:05PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > >> This fixes at least one overflow in qcow2_process_discards, which > >> passes 64bit

Re: [Qemu-block] [Qemu-devel] [PATCH] qcow2: Fix qcow2_make_empty() with external data file

Patchew URL: https://patchew.org/QEMU/20190429105741.31033-1-kw...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

Re: [Qemu-block] [PATCH] block/qed: add missed coroutine_fn markers

Am 30.04.2019 um 14:36 hat Vladimir Sementsov-Ogievskiy geschrieben: > qed_read_table and qed_write_table use coroutine-only interfaces but > are not marked coroutine_fn. Happily, they are called only from > coroutine context, so we only need to add missed markers. > > Reported-by: Kevin Wolf > S

[Qemu-block] [PATCH] block/qed: add missed coroutine_fn markers

qed_read_table and qed_write_table use coroutine-only interfaces but are not marked coroutine_fn. Happily, they are called only from coroutine context, so we only need to add missed markers. Reported-by: Kevin Wolf Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi! This is a follow-up for my

Re: [Qemu-block] [PATCH v2 10/10] file-posix: Make auto-read-only dynamic

Am 29.04.2019 um 22:16 hat Max Reitz geschrieben: > On 11.03.19 17:50, Kevin Wolf wrote: > > Until now, with auto-read-only=on we tried to open the file read-write > > first and if that failed, read-only was tried. This is actually not good > > enough for libvirt, which gives QEMU SELinux permissio

Re: [Qemu-block] [PATCH v3 0/2] commit: Make base read-only if there is an early failure

Am 29.04.2019 um 15:51 hat Alberto Garcia geschrieben: > Hi, > > Here's v3 of this series, the only changes are the corrections in the > iotest suggested by Max. Thanks, applied to the block branch. Kevin

Re: [Qemu-block] [Qemu-devel] [PATCH v5 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter

Am 30.04.2019 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben: > 30.04.2019 12:24, Stefano Garzarella wrote: > > On Tue, Apr 23, 2019 at 03:57:05PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > >> This fixes at least one overflow in qcow2_process_discards, which > >> passes 64bit region l

Re: [Qemu-block] [PATCH 0/9] block: buffer-based io

Am 22.04.2019 um 16:58 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > We often need to do read/write with buffer, not qiov. Instead of > creating qiov in such cases, let's introduce corresponding helpers. Thanks, applied to the block branch. As I wrote in patch 4, a follow-up that a

Re: [Qemu-block] [PATCH 4/9] block/qed: use buffer-based io

Am 22.04.2019 um 16:58 hat Vladimir Sementsov-Ogievskiy geschrieben: > Move to _co_ versions of io functions qed_read_table() and > qed_write_table(), as we use qemu_co_mutex_unlock() > anyway. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qed-table.c | 12 +--- > block/q

Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] buffer and delay backup COW write operation

28.04.2019 13:01, Liang Li wrote: > If the backup target is a slow device like ceph rbd, the backup > process will affect guest BLK write IO performance seriously, > it's cause by the drawback of COW mechanism, if guest overwrite the > backup BLK area, the IO can only be processed after the data ha

Re: [Qemu-block] [PATCH] qcow2: Fix error handling in the compression code

Am 30.04.2019 um 12:08 hat Alberto Garcia geschrieben: > This patch fixes a few things in the way error codes are handled in > the qcow2 compression code: > > a) qcow2_co_pwritev_compressed() expects qcow2_co_compress() to only >return -1 or -2 on failure, but this is not correct. Since the >

Re: [Qemu-block] [Qemu-devel] [PATCH v5 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter

30.04.2019 12:24, Stefano Garzarella wrote: > On Tue, Apr 23, 2019 at 03:57:05PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> This fixes at least one overflow in qcow2_process_discards, which >> passes 64bit region length to bdrv_pdiscard where bytes (or sectors in >> the past) parameter is int si

[Qemu-block] [PATCH] qcow2: Fix error handling in the compression code

This patch fixes a few things in the way error codes are handled in the qcow2 compression code: a) qcow2_co_pwritev_compressed() expects qcow2_co_compress() to only return -1 or -2 on failure, but this is not correct. Since the change from qcow2_compress() to qcow2_co_compress() in commit

Re: [Qemu-block] [PATCH 2/5] vdi: Replace bdrv_{read, write}() with bdrv_{pread, pwrite}()

Am 29.04.2019 um 20:42 hat Alberto Garcia geschrieben: > There's only a couple of bdrv_read() and bdrv_write() calls left in > the vdi code, and they can be trivially replaced with the byte-based > bdrv_pread() and bdrv_pwrite(). > > Signed-off-by: Alberto Garcia > --- > block/vdi.c | 11 ++-

Re: [Qemu-block] [Qemu-devel] [PATCH] [RFC] qcow2: add compression type feature

Hi Denis, few simple comments below regarding the CODING_STYLE (point 7. Comment style) On Tue, Feb 05, 2019 at 12:08:25PM +0300, Denis Plotnikov wrote: > The patch adds some preparation parts for incompatible compression type > feature into QCOW2 header that indicates that *all* compressed cluste

Re: [Qemu-block] [PATCH 3/5] vvfat: Replace bdrv_{read, write}() with bdrv_{pread, pwrite}()

Am 29.04.2019 um 20:42 hat Alberto Garcia geschrieben: > There's only a couple of bdrv_read() and bdrv_write() calls left in > the vvfat code, and they can be trivially replaced with the byte-based > bdrv_pread() and bdrv_pwrite(). > > Signed-off-by: Alberto Garcia > --- > block/vvfat.c | 10 +++

Re: [Qemu-block] [Qemu-devel] [PATCH 0/9] block: buffer-based io

30.04.2019 12:38, Stefano Garzarella wrote: > On Mon, Apr 22, 2019 at 05:58:29PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> We often need to do read/write with buffer, not qiov. Instead of >> creating qiov in such cases, let's introduce corresponding helpers. >> >> Vladimir Sements

Re: [Qemu-block] [PATCH v5 07/10] qcow2: qcow2_co_preadv: improve locking

30.04.2019 11:38, Vladimir Sementsov-Ogievskiy wrote: > 29.04.2019 19:37, Max Reitz wrote: >> On 02.04.19 17:37, Vladimir Sementsov-Ogievskiy wrote: >>> Background: decryption will be done in threads, to take benefit of it, >>> we should move it out of the lock first. >> >> ...which is safe after y

Re: [Qemu-block] [Qemu-devel] [PATCH 0/9] block: buffer-based io

On Mon, Apr 22, 2019 at 05:58:29PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > We often need to do read/write with buffer, not qiov. Instead of > creating qiov in such cases, let's introduce corresponding helpers. > > Vladimir Sementsov-Ogievskiy (9): > block: introduce byte-based

Re: [Qemu-block] [Qemu-devel] [PATCH v5 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter

On Tue, Apr 23, 2019 at 03:57:05PM +0300, Vladimir Sementsov-Ogievskiy wrote: > This fixes at least one overflow in qcow2_process_discards, which > passes 64bit region length to bdrv_pdiscard where bytes (or sectors in > the past) parameter is int since its introduction in 0b919fae. > > Signed-off

Re: [Qemu-block] [PATCH v5 01/10] tests/perf: Test qemu-img convert from raw to encrypted qcow2

29.04.2019 1:55, Max Reitz wrote: > On 02.04.19 17:37, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/perf/block/qcow2/convert-to-encrypted | 48 + >> 1 file changed, 48 insertions(+) >> create mode 100755 tests/perf/bloc

Re: [Qemu-block] [PATCH v5 07/10] qcow2: qcow2_co_preadv: improve locking

29.04.2019 19:37, Max Reitz wrote: > On 02.04.19 17:37, Vladimir Sementsov-Ogievskiy wrote: >> Background: decryption will be done in threads, to take benefit of it, >> we should move it out of the lock first. > > ...which is safe after your commit c972fa123c73501b4, I presume. > > (At first glan

Re: [Qemu-block] [Qemu-devel] [PATCH v6 30/30] hw/arm: Remove hard-enablement of the remaining PCI devices

On 4/30/19 9:14 AM, Thomas Huth wrote: > The PCI devices should be pulled in by default if PCI_DEVICES > is set, so there is no need anymore to enforce them in the configs > file. > > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 8

Re: [Qemu-block] [Qemu-devel] [PATCH v6 11/30] hw/arm: Express dependencies of stellaris with Kconfig

On 4/30/19 9:13 AM, Thomas Huth wrote: > This patch is slightly based on earlier work by Ákos Kovács (i.e. > his "hw/arm/Kconfig: Add ARM Kconfig" patch). > > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé > --- > default-configs/arm-softmm

[Qemu-block] [PATCH v6 30/30] hw/arm: Remove hard-enablement of the remaining PCI devices

The PCI devices should be pulled in by default if PCI_DEVICES is set, so there is no need anymore to enforce them in the configs file. Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 8 1 file changed, 8 deletions(-) diff --git a/defa

[Qemu-block] [PATCH v6 24/30] hw/arm: Express dependencies of the MSF2 / EMCRAFT_SF2 machine with Kconfig

Add Kconfig dependencies for the emcraft-sf2 machine - we also distinguish between the machine (CONFIG_EMCRAFT_SF2) and the SoC (CONFIG_MSF2) now. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 3 +-- hw/ar

[Qemu-block] [PATCH v6 26/30] hw/arm: Express dependencies of the microbit / nrf51 machine with Kconfig

Add Kconfig dependencies for the NRF51 / microbit machine. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 3 +-- hw/arm/Kconfig | 6 ++ hw/arm/Makefile.ob

[Qemu-block] [PATCH v6 20/30] hw/arm: Express dependencies of the MPS2 boards with Kconfig

Add Kconfig dependencies for the mps2-an* machines. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 20 +--- hw/arm/Kconfig | 19 +++ 2 files changed, 20 inse

[Qemu-block] [PATCH v6 18/30] hw/arm: Express dependencies of netduino / stm32f2xx with Kconfig

Netduino only depends on the stm32f205 SoC which in turn depends on its components. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 9 + hw/arm/Kconfig

[Qemu-block] [PATCH v6 28/30] hw/arm: Express dependencies of the xlnx-versal-virt machine with Kconfig

Dependencies have been determined with trial-and-error and by looking at the xlnx-versal.c source file. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/arm/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/Kconfig b/h

[Qemu-block] [PATCH v6 29/30] hw/arm: Express dependencies of the musca machines with Kconfig

Dependencies have been determined with trial-and-error and by looking at the musca.c source file. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/arm/Kconfig | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/

[Qemu-block] [PATCH v6 23/30] hw/arm: Express dependencies of sabrelite with Kconfig

Add Kconfig dependencies for the Sabrelite / iMX6 machine. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 4 +--- hw/arm/Kconfig | 9 + hw/arm/Makefile.objs| 3 ++- 3 fi

[Qemu-block] [PATCH v6 17/30] hw/arm: Express dependencies of the virt machine with Kconfig

Dependencies have been determined by looking at hw/arm/virt.c Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/aarch64-softmmu.mak | 1 - default-configs/arm-softmmu.mak | 11 +-- hw/arm/Kconfig

[Qemu-block] [PATCH v6 16/30] hw/arm: Express dependencies of the aspeed boards with Kconfig

Dependencies have been determined by looking at hw/arm/aspeed.c Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 7 +-- hw/arm/Kconfig | 10 ++ 2 f

[Qemu-block] [PATCH v6 13/30] hw/arm: Express dependencies of the PXA2xx machines with Kconfig

Add Kconfig dependencies for the PXA2xx machines (akita, borzoi, connex and verdex gumstix, tosa, mainstone, spitz, terrier and z2). This patch is based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathi

[Qemu-block] [PATCH v6 25/30] hw/arm: Express dependencies of the remaining IMX boards with Kconfig

IMX25, IMX7 and IMX6UL were still missing the Kconfig dependencies. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 2 -- hw/arm/Kconfig | 19 +++ 2 files changed, 19 insert

[Qemu-block] [PATCH v6 27/30] hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfig

This cleans up most settings in default-configs/aarch64-softmmu.mak. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/aarch64-softmmu.mak | 4 hw/arm/Kconfig | 11 +

[Qemu-block] [PATCH v6 21/30] hw/arm: Express dependencies of the raspi machines with Kconfig

Most of the code is directly controlled by the CONFIG_RASPI switch, so not much to add here additionally. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 4 +--- hw/arm/Kconfig

[Qemu-block] [PATCH v6 22/30] hw/arm: Express dependencies of canon-a1100 with Kconfig

Add Kconfig dependencies for the DIGIC / canon-a1100 machine. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 2 +- hw/arm/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) dif

[Qemu-block] [PATCH v6 10/30] hw/arm: Express dependencies of the OMAP machines with Kconfig

Add Kconfig dependencies for the OMAP machines (cheetah, n800, n810, sx1 and sx1-v1). This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth

[Qemu-block] [PATCH v6 19/30] hw/arm: Express dependencies of allwinner / cubieboard with Kconfig

Add dependencies for the Cubitech Cubieboard. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 6 +- hw/arm/Kconfig | 9 + 2 files changed, 10 insertions(+), 5 deletions(-) diff

[Qemu-block] [PATCH v6 15/30] hw/arm: Express dependencies of collie with Kconfig

Add Kconfig dependencies for the Strongarm collie machine. This patch is based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak

[Qemu-block] [PATCH v6 08/30] hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig

Add Kconfig dependencies for the fsl-imx31 / kzm machine. This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Peter Chubb Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --

[Qemu-block] [PATCH v6 14/30] hw/arm: Express dependencies of xilinx-zynq with Kconfig

Add Kconfig dependencies for the xilinx-zynq-a9 board. This patch is based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- defa

[Qemu-block] [PATCH v6 12/30] hw/arm: Express dependencies of realview, versatile and vexpress with Kconfig

This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 24 - hw/arm/Kconfig

[Qemu-block] [PATCH v6 07/30] hw/arm: Express dependencies of integratorcp with Kconfig

This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 8 +--- hw/arm/Kconfig | 8

[Qemu-block] [PATCH v6 05/30] hw/arm: Express dependencies of the exynos machines with Kconfig

Add Kconfig dependencies for the Exynos-related boards (nuri and smdkc210). This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- defau

[Qemu-block] [PATCH v6 02/30] hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device

Some of our machines (like the ARM cubieboard) use CONFIG_AHCI for an AHCI sysbus device, but do not use CONFIG_PCI since they do not feature a PCI bus. With CONFIG_AHCI but without CONFIG_PCI, currently linking fails: ../hw/ide/ich.o: In function `pci_ich9_ahci_realize': hw/ide/ich.c:124:

[Qemu-block] [PATCH v6 11/30] hw/arm: Express dependencies of stellaris with Kconfig

This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 7 +-- hw/arm/Kconfig | 11 +++ 2 files changed, 12 in

[Qemu-block] [PATCH v6 09/30] hw/arm: Express dependencies of musicpal with Kconfig

This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 6 +- hw/arm/Kconfig | 5 +

[Qemu-block] [PATCH v6 06/30] hw/arm: Express dependencies of the highbank machines with Kconfig

Add Kconfig dependencies for the highbank machine (and the midway machine). This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- defau

[Qemu-block] [PATCH v6 04/30] hw/usb/hcd-ohci: Move PCI-related code into a separate file

Some machines (like the pxa2xx-based ARM machines) only have a sysbus OHCI controller, but no PCI. With the new Kconfig-style build system, it will soon be possible to create QEMU binaries that only contain such PCI-less machines. However, the two OHCI controllers, for sysbus and for PCI, are curre

[Qemu-block] [PATCH v6 03/30] hw/usb/hcd-ohci: Do not use PCI functions with sysbus devices in ohci_die()

The ohci_die() function always assumes to be running with a PCI OHCI controller and calls the PCI-specific functions pci_set_word(). However, this function might also get called for the sysbus OHCI devices, so it likely fails in that case. To fix this issue, change the code now, so that there are t

[Qemu-block] [PATCH v6 01/30] hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs

Some machines have an AHCI adapter, but no PCI. To be able to compile hw/ide/ahci.c without CONFIG_PCI, we still need the two functions msi_enabled() and msi_notify() for linking. This is required for the new Kconfig-like build system, if a user wants to compile a QEMU binary with just one machine

[Qemu-block] [PATCH v6 00/30] Kconfig dependencies for ARM machines

This series reworks the default-configs/arm-softmmu.mak and default-configs/aarch64-softmmu.mak files to use the new Kconfig-style dependencies instead. Some of the patches are slightly based on the work by Ákos Kovács: https://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg03730.html The

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/2] commit: Make base read-only if there is an early failure

Patchew URL: https://patchew.org/QEMU/cover.1556540297.git.be...@igalia.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time make