On 5/17/2019 12:24 AM, Klaus Birkelund wrote:
On Fri, May 17, 2019 at 07:35:04AM +0200, Klaus Birkelund wrote:
Hi Kenneth,
On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote:
Hi Klaus, thank you for you review. I have one comment inline
On 5/14/2019 12:02 AM, Klaus Birkelund w
On 5/17/19 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
> This test shows that external snapshots and incremental backups are
> friends.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/254 | 52 ++
> tests/qemu-iotests/254.ou
On 5/17/19 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
> Add new optional parameter making possible to merge bitmaps from
> different nodes. It is needed to maintain external snapshots during
> incremental backup chain history.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> qapi/bl
On 5/17/19 4:05 AM, Denis Plotnikov wrote:
>
>
> On 17.05.2019 2:25, John Snow wrote:
>>
>>
>> On 5/16/19 9:48 AM, Denis Plotnikov wrote:
>>> The patch adds some preparation parts for incompatible compression type
>>> feature into QCOW2 header that indicates that *all* compressed clusters
>>>
On 5/17/19 7:18 AM, Max Reitz wrote:
> On 10.05.19 21:03, John Snow wrote:
>> Signed-off-by: John Snow
>> ---
>> tests/qemu-iotests/250 | 129 +
>> tests/qemu-iotests/250.out | 119 ++
>> tests/qemu-iotests/group | 1 +
On 5/17/19 10:09 AM, Vladimir Sementsov-Ogievskiy wrote:
> 17.05.2019 16:50, Eric Blake wrote:
>> On 5/16/19 7:32 PM, John Snow wrote:
>>>
>>>
>>> On 5/16/19 8:27 AM, Vladimir Sementsov-Ogievskiy wrote:
Add new optional parameter making possible to merge bitmaps from
different nodes. I
Peter Krempa writes:
> On Wed, May 15, 2019 at 15:48:29 +0200, Markus Armbruster wrote:
>> Kevin Wolf writes:
>> > Am 18.04.2019 um 22:03 hat Markus Armbruster geschrieben:
>> >> Kevin Wolf writes:
>
> [...]
>
>> > Do you expect libvirt to check a full list of all QMP commands, types,
>> > etc.
On 5/17/2019 12:24 AM, Klaus Birkelund wrote:
On Fri, May 17, 2019 at 07:35:04AM +0200, Klaus Birkelund wrote:
Hi Kenneth,
On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote:
Hi Klaus, thank you for you review. I have one comment inline
On 5/14/2019 12:02 AM, Klaus Birkelund w
Hi all!
We need to copy bitmaps to new top node on external snapshot, to
not break incremental backup chain.
The only thing to do is to allow block-dirty-bitmap-merge to work
with different nodes, here it is.
v2: use 'alternate' type in qapi for specifying source bitmap
instead of adding new
This test shows that external snapshots and incremental backups are
friends.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/254 | 52 ++
tests/qemu-iotests/254.out | 52 ++
tests/qemu-iotests/group
Add new optional parameter making possible to merge bitmaps from
different nodes. It is needed to maintain external snapshots during
incremental backup chain history.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 22 ---
block/dirty-bitmap.c | 9 +---
10.04.2019 23:20, Max Reitz wrote:
> What bs->file and bs->backing mean depends on the node. For filter
> nodes, both signify a node that will eventually receive all R/W
> accesses. For format nodes, bs->file contains metadata and data, and
> bs->backing will not receive writes -- instead, writes
In commit 23dece19da4 ('file-posix: Make auto-read-only dynamic') ,
auto-read-only=on changed its behaviour in file-posix for the 4.0
release. This change cannot be detected through the usual mechanisms
like schema introspection. Add a new feature flag to the schema to
allow libvirt to detect the p
Signed-off-by: Kevin Wolf
---
tests/qapi-schema/features-bad-type.json | 3 +++
tests/qapi-schema/features-duplicate-name.json | 3 +++
tests/qapi-schema/features-missing-name.json | 3 +++
tests/qapi-schema/features-name-bad-type.json | 3 +++
tests/qapi-schema/features-no-list.json
Documentation comment follow a certain structure: First, we have a text
with a general description (called QAPIDoc.body). After this,
descriptions of the arguments follow. Finally, we have part that
contains various named sections.
The code doesn't show this structure but just checks the right sid
This series adds optional feature lists to struct definitions in the
QAPI schema and makes use of them to advertise the new behaviour of
auto-read-only=on in file-posix.
v2:
- Check that features have well-formed names instead of just checking
that they are strings
- Use QAPISchemaFeature object
Features will be documented in a new part introduced by a "Features:"
line, after arguments and before named sections.
Signed-off-by: Kevin Wolf
---
scripts/qapi/common.py | 43 ++
scripts/qapi/doc.py| 11 +++
2 files changed, 50 insertions(+),
Sometimes, the behaviour of QEMU changes compatibly, but without a
change in the QMP syntax (usually by allowing values or operations that
previously resulted in an error). QMP clients may still need to know
whether the extension is available.
This allows to add a list of features to struct defini
Signed-off-by: Kevin Wolf
---
tests/qapi-schema/qapi-schema-test.json | 30 +++
tests/qapi-schema/qapi-schema-test.out | 32 +
tests/qapi-schema/test-qapi.py | 4
3 files changed, 66 insertions(+)
diff --git a/tests/qapi-schema/qapi-sch
17.05.2019 16:50, Eric Blake wrote:
> On 5/16/19 7:32 PM, John Snow wrote:
>>
>>
>> On 5/16/19 8:27 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> Add new optional parameter making possible to merge bitmaps from
>>> different nodes. It is needed to maintain external snapshots during
>>> incremental ba
On 5/16/19 7:32 PM, John Snow wrote:
>
>
> On 5/16/19 8:27 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Add new optional parameter making possible to merge bitmaps from
>> different nodes. It is needed to maintain external snapshots during
>> incremental backup chain history.
>>
>> Signed-off-by: V
On Wed, May 15, 2019 at 15:48:29 +0200, Markus Armbruster wrote:
> Kevin Wolf writes:
> > Am 18.04.2019 um 22:03 hat Markus Armbruster geschrieben:
> >> Kevin Wolf writes:
[...]
> > Do you expect libvirt to check a full list of all QMP commands, types,
> > etc. it ever uses against the schema a
07.05.2019 18:13, Max Reitz wrote:
> On 07.05.19 15:30, Vladimir Sementsov-Ogievskiy wrote:
>> 10.04.2019 23:20, Max Reitz wrote:
>>> What bs->file and bs->backing mean depends on the node. For filter
>>> nodes, both signify a node that will eventually receive all R/W
>>> accesses. For format nod
On 17.05.19 13:00, Kevin Wolf wrote:
> Am 17.05.2019 um 11:56 hat Max Reitz geschrieben:
>> null-aio may not be whitelisted. If it is not, fall back to null-co.
>> This may run tests twice in the same configuration, but this is the
>> simplest way to effectively skip the tests in setUp() (without
On 10.05.19 21:03, John Snow wrote:
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/250 | 129 +
> tests/qemu-iotests/250.out | 119 ++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 249 insertions(+)
> creat
Am 17.05.2019 um 11:56 hat Max Reitz geschrieben:
> null-aio may not be whitelisted. If it is not, fall back to null-co.
> This may run tests twice in the same configuration, but this is the
> simplest way to effectively skip the tests in setUp() (without changing
> the output, and while having th
Max Reitz writes:
> Without this argument, qemu will print an angry message about not being
> able to connect to a display server if $DISPLAY is not set. For me,
> that breaks iotests.supported_formats() because it thus only sees
> ["Could", "not", "connect"] as the supported formats.
>
> Sign
16.05.2019 22:03, John Snow wrote:
>
>
> On 5/16/19 6:12 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 14.05.2019 23:19, John Snow wrote:
>>> Shift from looking at every root BDS to *every* BDS. This will migrate
>>> bitmaps that are attached to blockdev created nodes instead of just ones
>>> attach
On 17/05/2019 11.56, Max Reitz wrote:
> Without this argument, qemu will print an angry message about not being
> able to connect to a display server if $DISPLAY is not set. For me,
> that breaks iotests.supported_formats() because it thus only sees
> ["Could", "not", "connect"] as the supported f
null-aio may not be whitelisted. If it is not, fall back to null-co.
This may run tests twice in the same configuration, but this is the
simplest way to effectively skip the tests in setUp() (without changing
the output, and while having the respective driver in a class
attribute).
Signed-off-by:
Hi,
These are some rather selfish iotests patches. The first patch helps me
personally because I tend to run the tests over SSH and forget to set
$DISPLAY. That makes test 139 skip the tests annotated with
skip_if_unsupprted(), because iotests.py can no longer determine the
list of whitelisted f
Without this argument, qemu will print an angry message about not being
able to connect to a display server if $DISPLAY is not set. For me,
that breaks iotests.supported_formats() because it thus only sees
["Could", "not", "connect"] as the supported formats.
Signed-off-by: Max Reitz
---
tests/
We use null-co basically everywhere in the iotests. Unless we want to
test null-aio specifically, we should use it instead (for consistency).
Signed-off-by: Max Reitz
---
tests/qemu-iotests/093 | 7 +++
tests/qemu-iotests/245 | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --
null-aio may not be whitelisted. If it is not, fall back to null-co.
This may run tests twice in the same configuration, but this is the
simplest way to effectively skip the tests in setUp() (without changing
the output, and while having the respective driver in a class
attribute).
Signed-off-by:
On 16.05.2019 17:42, Eric Blake wrote:
> On 5/16/19 8:48 AM, Denis Plotnikov wrote:
>> The patch adds some preparation parts for incompatible compression type
>> feature into QCOW2 header that indicates that *all* compressed clusters
>> must be (de)compressed using a certain compression type.
>>
Bump the supported NVMe version to 1.3. To do so, this patch adds a
number of missing 'Mandatory' features from the spec:
* Support for returning a Namespace Identification Descriptor List in
the Identify command (CNS 03h).
* Support for the Asynchronous Event Request command.
* Support
Add partial SGL support. For now, only support a single data block or
last segment descriptor. This is in line with what, for instance, SPDK
currently supports.
Signed-off-by: Klaus Birkelund Jensen
---
block/nvme.c | 18 ++--
hw/block/nvme.c | 242 +++
The new `ms` parameter may be used to indicate the number of metadata
bytes provided per LBA.
Signed-off-by: Klaus Birkelund Jensen
---
hw/block/nvme.c | 31 +--
hw/block/nvme.h | 11 ++-
2 files changed, 39 insertions(+), 3 deletions(-)
diff --git a/hw/block
Instead of handling both QSGs and IOVs in multiple places, simply use
QSGs everywhere by assuming that the request does not involve the
controller memory buffer (CMB). If the request is found to involve the
CMB, convert the QSG to an IOV and issue the I/O.
The QSG is converted to an IOV by the dma
Signed-off-by: Klaus Birkelund Jensen
---
hw/block/nvme.c | 4 ++--
hw/block/nvme.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 81201a8b4834..5cd593806701 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -184,7 +184,7 @@ st
Move device configuration parameters to separate struct to make it
explicit what is configurable and what is set internally.
Also, clean up some includes.
Signed-off-by: Klaus Birkelund Jensen
---
hw/block/nvme.c | 53 +++--
hw/block/nvme.h | 16 +
Hi,
This series of patches contains a number of refactorings to the emulated
nvme device, adds additional features, such as support for metadata and
scatter gather lists, and bumps the supported NVMe version to 1.3.
Lastly, it contains a new 'ocssd' device.
The motivation for the first seven patc
Introduce a new NvmeBlockBackendRequest and move the QEMUSGList and
QEMUIOVector from the NvmeRequest.
This is in preparation for metadata support and makes it easier to
handle multiple block backend requests to different offsets.
Signed-off-by: Klaus Birkelund Jensen
---
hw/block/nvme.c
On 17.05.2019 2:25, John Snow wrote:
>
>
> On 5/16/19 9:48 AM, Denis Plotnikov wrote:
>> The patch adds some preparation parts for incompatible compression type
>> feature into QCOW2 header that indicates that *all* compressed clusters
>> must be (de)compressed using a certain compression type.
44 matches
Mail list logo
