Re: [Qemu-block] [Qemu-devel] [PATCH v4 2/9] qapi/block-core: add option for io_uring

Aarushi Mehta writes: > Option only enumerates for hosts that support it. Blank line here, please. Same in other patches. > Signed-off-by: Aarushi Mehta > --- > qapi/block-core.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/2] qapi/block-core: Overlays are not snapshots

Max Reitz writes: > A snapshot is something that reflects the state of something at a > certain point in time. It does not change. > > The file our snapshot commands create (or the node they install) is not > a snapshot, as it does change over time. It is an overlay. We cannot > do anything ab

Re: [Qemu-block] [PATCH v2] nvme: add Get/Set Feature Timestamp support

On 6/4/2019 3:13 AM, Klaus Birkelund wrote: On Tue, Jun 04, 2019 at 10:46:45AM +0200, Kevin Wolf wrote: Am 04.06.2019 um 10:28 hat Klaus Birkelund geschrieben: On Mon, Jun 03, 2019 at 09:30:53AM -0600, Heitke, Kenneth wrote: On 6/3/2019 5:14 AM, Kevin Wolf wrote: Am 28.05.2019 um 08:18 h

Re: [Qemu-block] [PULL v2 00/29] Block layer patches

On Tue, 4 Jun 2019 at 17:14, Kevin Wolf wrote: > > The following changes since commit e2a58ff493a2e00db3e963c1839c5374500110f2: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2019-06-03 18:26:21 +0100) > > are available in the Git repository at: > > git:/

Re: [Qemu-block] [PATCH v7 0/9] discard blockstats

On 3/6/2019 1:09 PM, Stefano Garzarella wrote: > On Tue, May 14, 2019 at 12:10:40PM +, Anton Nefedov wrote: >> hi, >> >> yet another take for this patch series; please kindly consider these for 4.1 >> >> Just a few cosmetic comments were received for v6 so this is mostly >> a rebase+ping. >> >>

[Qemu-block] [PATCH v2 11/12] block/qcow2: implement .bdrv_co_preadv_part

Implement and use new interface to get rid of hd_qiov. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-cluster.c | 5 +++-- block/qcow2.c | 49 +++ 2 files changed, 25 insertions(+), 29 deletions(-) diff --git a/block/qcow2-cluster.c

[Qemu-block] [PATCH v2 04/12] block: define .*_part io handlers in BlockDriver

Add handlers supporting qiov_offset parameter: bdrv_co_preadv_part bdrv_co_pwritev_part bdrv_co_pwritev_compressed_part This is used to reduce need of defining local_qiovs and hd_qiovs in all corners of block layer code. The following patches will increase usage of this new API part by

[Qemu-block] [PATCH v2 02/12] util/iov: improve qemu_iovec_is_zero

We'll need to check a part of qiov soon, so implement it now. Optimization with align down to 4 * sizeof(long) is dropped due to: 1. It is strange: it aligns length of the buffer, but where is a guarantee that buffer pointer is aligned itself? 2. buffer_is_zero() is a better place for optimizat

[Qemu-block] [PATCH v2 00/12] block: qiov_offset parameter for io

Hi all! Here is new parameter qiov_offset for io path, to avoid a lot of places with same pattern of creating local_qiov or hd_qiov variables. These series also includes my "[Qemu-devel] [PATCH 0/2] block/io: refactor padding" with some changes [described in 01 and 03 emails] Vladimir Sementsov-

[Qemu-block] [PATCH v2 09/12] block/io: introduce bdrv_co_p{read, write}v_part

Introduce extended variants of bdrv_co_preadv and bdrv_co_pwritev with qiov_offset parameter. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 6 ++ block/io.c| 29 +++-- 2 files changed, 29 insertions(+), 6 deletions(-) di

[Qemu-block] [PATCH v2 03/12] block/io: refactor padding

We have similar padding code in bdrv_co_pwritev, bdrv_co_do_pwrite_zeroes and bdrv_co_preadv. Let's combine and unify it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 355 - 1 file changed, 190 insertions(+), 165 deletions(-) d

[Qemu-block] [PATCH v2 01/12] util/iov: introduce qemu_iovec_init_extended

Introduce new initialization API, to create requests with padding. Will be used in the following patch. New API uses qemu_iovec_init_buf if resulting io vector has only one element, to avoid extra allocations. So, we need to update qemu_iovec_destroy to support destroying such QIOVs. Signed-off-by

[Qemu-block] [PATCH v2 05/12] block/io: bdrv_co_do_copy_on_readv: use and support qiov_offset

Use and support new API in bdrv_co_do_copy_on_readv. Note that in case of allocated-in-top we need to shrink read size to MIN(..) by hand, as pre-patch this was actually done implicitly by qemu_iovec_concat (and we used local_qiov.size). Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c

[Qemu-block] [PATCH v2 06/12] block/io: bdrv_co_do_copy_on_readv: lazy allocation

Allocate bounce_buffer only if it is really needed. Also, sub-optimize allocation size (why not?). Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/block/io.c b/block/io.c index efd2b80293..a4f67

[Qemu-block] [PATCH v2 07/12] block/io: bdrv_aligned_preadv: use and support qiov_offset

Use and support new API in bdrv_co_do_copy_on_readv. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/block/io.c b/block/io.c index a4f67aca47..0cc80e2d5a 100644 --- a/block/io.c +++ b/block/io.c

[Qemu-block] [PATCH v2 10/12] block/qcow2: refactor qcow2_co_preadv to use buffer-based io

Use buffer based io in encrypted case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index f2cb131048..8a033ae08c 100644 --- a/block/qcow2.c +++ b/bloc

[Qemu-block] [PATCH v2 12/12] block/qcow2: implement .bdrv_co_pwritev(_compressed)_part

Implement and use new interface to get rid of hd_qiov. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 1 + include/qemu/iov.h| 1 + block/qcow2-cluster.c | 9 --- block/qcow2.c | 60 +-- util/iov.c| 1

[Qemu-block] [PATCH v2 08/12] block/io: bdrv_aligned_pwritev: use and support qiov_offset

Use and support new API in bdrv_aligned_pwritev. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/block/io.c b/block/io.c index 0cc80e2d5a..660c96527d 100644 --- a/block/io.c +++ b/block/i

[Qemu-block] [PULL v2 00/29] Block layer patches

The following changes since commit e2a58ff493a2e00db3e963c1839c5374500110f2: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2019-06-03 18:26:21 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch

Re: [Qemu-block] [PATCH v2] nvme: add Get/Set Feature Timestamp support

Am 04.06.2019 um 11:13 hat Klaus Birkelund geschrieben: > On Tue, Jun 04, 2019 at 10:46:45AM +0200, Kevin Wolf wrote: > > Am 04.06.2019 um 10:28 hat Klaus Birkelund geschrieben: > > > On Mon, Jun 03, 2019 at 09:30:53AM -0600, Heitke, Kenneth wrote: > > > > > > > > > > > > On 6/3/2019 5:14 AM, Kev

Re: [Qemu-block] [PATCH v6] iotests: test big qcow2 shrink

Am 04.06.2019 um 14:39 hat Vladimir Sementsov-Ogievskiy geschrieben: > This test checks bug in qcow2_process_discards, fixed by previous > commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Thanks, applied to the block branch. Kevin

[Qemu-block] [PATCH v6] iotests: test big qcow2 shrink

This test checks bug in qcow2_process_discards, fixed by previous commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! This is a continuation of [PATCH v5 0/3] Fix overflow bug in qcow2 discard Two first patches are in Kevin's block branch, and here is fixed third. v6: calculate

[Qemu-block] ping Re: [PATCH v6 0/7] NBD reconnect

ping 11.04.2019 20:27, Vladimir Sementsov-Ogievskiy wrote: > Here is NBD reconnect. Previously, if connection failed all current > and future requests will fail. After the series, nbd-client driver > will try to reconnect unlimited times. During first @reconnect-delay > seconds of reconnecting all

Re: [Qemu-block] [PATCH v2] nvme: add Get/Set Feature Timestamp support

On Tue, Jun 04, 2019 at 10:46:45AM +0200, Kevin Wolf wrote: > Am 04.06.2019 um 10:28 hat Klaus Birkelund geschrieben: > > On Mon, Jun 03, 2019 at 09:30:53AM -0600, Heitke, Kenneth wrote: > > > > > > > > > On 6/3/2019 5:14 AM, Kevin Wolf wrote: > > > > Am 28.05.2019 um 08:18 hat Klaus Birkelund ge

[Qemu-block] virtual machine cpu soft lockup when qemu attach disk

Hi,  I found a problem that virtual machine cpu soft lockup when I attach a disk to the vm in the case that backend storage network has a large delay or IO pressure is too large. 1) The disk xml which I attached is:                     2) The bt of qemu main

Re: [Qemu-block] [PATCH v2] nvme: add Get/Set Feature Timestamp support

Am 04.06.2019 um 10:28 hat Klaus Birkelund geschrieben: > On Mon, Jun 03, 2019 at 09:30:53AM -0600, Heitke, Kenneth wrote: > > > > > > On 6/3/2019 5:14 AM, Kevin Wolf wrote: > > > Am 28.05.2019 um 08:18 hat Klaus Birkelund geschrieben: > > > > On Mon, May 20, 2019 at 11:40:30AM -0600, Kenneth Hei

[Qemu-block] virtual machine cpu soft lock when qemu attach disk

Hi,  I found a problem that virtual machine cpu soft lock when I attach a disk to the vm in the case that backend storage network has a large delay or IO pressure is too large. 1) The disk xml which I attached is:                     2) The bt of qemu main thre

Re: [Qemu-block] [PATCH v2 0/2] blockdev: Overlays are not snapshots

On Mon 03 Jun 2019 10:22:34 PM CEST, Max Reitz wrote: > QEMU’s always been confused over what a snapshot is: Is it the overlay? > Is it the backing image? > > Confusion is rarely a good thing. I can’t think of any objective reason > why the overlay would be a snapshot. A snapshot is something tha

Re: [Qemu-block] [PATCH v2] nvme: add Get/Set Feature Timestamp support

On Mon, Jun 03, 2019 at 09:30:53AM -0600, Heitke, Kenneth wrote: > > > On 6/3/2019 5:14 AM, Kevin Wolf wrote: > > Am 28.05.2019 um 08:18 hat Klaus Birkelund geschrieben: > > > On Mon, May 20, 2019 at 11:40:30AM -0600, Kenneth Heitke wrote: > > > > Signed-off-by: Kenneth Heitke > > > > > > diff

[Qemu-block] [PING] [Qemu-devel] [PATCH v0 0/3] add zstd cluster compression

On 28.05.2019 17:37, Denis Plotnikov wrote: > The goal of the patch-set is to enable qcow2 to use zstd compression for > clusters. ZSTD provides better (de)compression performance than currently > used ZLIB. Using it will improve perforamnce (reduce compression time) > when the compressed cluster