Re: [Qemu-block] [Qemu-devel] [PATCH v3 09/15] monitor: Create monitor-internal.h with common definitions

2019-06-14 Thread Kevin Wolf
Am 14.06.2019 um 08:37 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Before we can split monitor/misc.c, we need to create a header file that > > contains the common definitions that will be used by multiple source > > files. > > > > For a start, add the type definitions for Monit

Re: [Qemu-block] [PATCH 2/6] configure: Link test before auto-enabling glusterfs libraries

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 9:24 AM, Philippe Mathieu-Daudé wrote: > Similarly to commit a73e82ef912, test the libraries link correctly > before considering them as usable. > > This fixes using ./configure --static on Ubuntu 18.04: > > $ make subdir-aarch64-softmmu > [...] > LINKaarch64-softmmu/qemu-s

Re: [Qemu-block] [Qemu-devel] [PATCH v3 12/15] monitor: Split out monitor/monitor.c

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > Move the monitor core infrastructure from monitor/misc.c to > monitor/monitor.c. This is code that can be shared for all targets, so > compile it only once. > > What remains in monitor/misc.c after this patch is mostly monitor > command implementations (which could move to hm

Re: [Qemu-block] [Qemu-devel] [PATCH v3 11/15] monitor: Split out monitor/hmp.c

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > Move HMP infrastructure from monitor/misc.c to monitor/hmp.c. This is > code that can be shared for all targets, so compile it only once. > > The amount of function and particularly extern variables in > monitor_int.h is probably a bit larger than it needs to be, but this way

Re: [Qemu-block] [PATCH 1/6] configure: Only generate GLUSTERFS variables if glusterfs is usable

2019-06-14 Thread Niels de Vos
On Fri, Jun 14, 2019 at 09:24:27AM +0200, Philippe Mathieu-Daudé wrote: > It is pointless and confusing to have GLUSTERFS variables > in config-host.mak when glusterfs is not usable. > > Signed-off-by: Philippe Mathieu-Daudé Looks good to me, thanks. Reviewed-by: Niels de Vos > --- > configu

[Qemu-block] [PATCH 6/6] .travis.yml: Test static linking

2019-06-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- This job currently fails: LINKlm32-softmmu/qemu-system-lm32 /usr/bin/ld: cannot find -lgtk-3 /usr/bin/ld: cannot find -latk-bridge-2.0 /usr/bin/ld: cannot find -latspi /usr/bin/ld: cannot find -lsystemd /usr/bin/ld: cannot fi

[Qemu-block] [PATCH 3/6] configure: Link test before auto-enabling the libusb library

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the library links correctly before considering it as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -ludev collect2: error: ld

[Qemu-block] [PATCH 5/6] configure: Link test before auto-enabling the pulseaudio library

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the library links correctly before considering it as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -lpulse /usr/bin/ld: canno

[Qemu-block] [PATCH 2/6] configure: Link test before auto-enabling glusterfs libraries

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the libraries link correctly before considering them as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -lgfapi /usr/bin/ld: ca

[Qemu-block] [PATCH 4/6] configure: Link test before auto-enabling the libusbredir library

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the library links correctly before considering it as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -lusbredirparser collect2:

[Qemu-block] [PATCH 1/6] configure: Only generate GLUSTERFS variables if glusterfs is usable

2019-06-14 Thread Philippe Mathieu-Daudé
It is pointless and confusing to have GLUSTERFS variables in config-host.mak when glusterfs is not usable. Signed-off-by: Philippe Mathieu-Daudé --- configure | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/configure b/configure index b0

[Qemu-block] [PATCH 0/6] configure: Try to fix --static linking

2019-06-14 Thread Philippe Mathieu-Daudé
Hi, Apparently QEMU static linking is slowly bitroting. Obviously it depends the libraries an user has installed, anyway it seems there are not much testing done. This series fixes few issues, enough to build QEMU on a Ubuntu aarch64 host, but not yet on a x86_64 host: LINKx86_64-softmmu

<    1   2