commit a6f230c move blockbackend back to main AioContext on unplug. It set the
AioContext of
SCSIDevice to the main AioContex, but s->ctx is still the iothread AioContex(if
the scsi controller
is configure with iothread). So if there are having in-flight requests during
unplug, a failing asserti
On Fri, Jul 19, 2019 at 03:14:22PM +0200, Philippe Mathieu-Daudé wrote:
> GCC9 is confused by this comment when building with CFLAG
> -Wimplicit-fallthrough=2:
>
> hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’:
> hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through
> [-
Patchew URL:
https://patchew.org/QEMU/1563693178-23328-1-git-send-email-lizhen...@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1563693178-23328-1-git-send-email-lizhen...@huawei.com
Type: series
Subject: [Qemu-devel]
commit a6f230c move blockbackend back to main AioContext on unplug. It set the
AioContext of
SCSIDevice to the main AioContex, but s->ctx is still the iothread AioContex(if
the scsi controller
is configure with iothread). So if there are having in-flight requests during
unplug, a failing asserti
On Fri, 2019-07-19 at 11:51 +0200, Max Reitz wrote:
> On 16.07.19 18:30, Maxim Levitsky wrote:
> > This is reduced version of patch series for userspace nvme driver,
> > that only includes the bugfixes I made.
> >
> > Best regards,
> > Maxim Levitsky
> >
> > Maxim Levitsky (3):
> > block/nv
On Fri, 2019-07-19 at 12:28 +0200, Max Reitz wrote:
> On 16.07.19 18:19, Maxim Levitsky wrote:
> > preallocation=off and preallocation=metadata
> > both allocate luks header only, and preallocation=falloc/full
> > is passed to underlying file.
> >
> > Fixes: https://bugzilla.redhat.com/show_bug.cg
Currently if you attampt to create too large file with luks you
get the following error message:
Formatting 'test.luks', fmt=luks size=17592186044416 key-secret=sec0
qemu-img: test.luks: Could not resize file: File too large
While for raw format the error message is
qemu-img: test.img: The image
Currently we print message like that:
"
new_file.qcow2 : error message
"
However the error could have come from opening the backing file (e.g when it
missing encryption keys),
thus try to clarify this by using this format:
"
qemu-img: error creating new_file.qcow2: base_file.qcow2: error messag
These are attempts to improve a bit error message
based on bunch of luks related bugzillas assigned to me.
Feel free to reject these if you think that it doesn't
make the messages better.
Best regards,
Maxim Levitsky
Maxim Levitsky (2):
LUKS: better error message when creating too large