Re: [Qemu-block] [PATCH v3 08/33] Add function to control reset with gpio inputs

2019-08-08 Thread David Gibson
On Wed, Aug 07, 2019 at 11:37:51AM +0100, Peter Maydell wrote: > On Wed, 31 Jul 2019 at 07:33, David Gibson > wrote: > > > > On Mon, Jul 29, 2019 at 04:56:29PM +0200, Damien Hedde wrote: > > > It adds the possibility to add 2 gpios to control the warm and cold reset. > > > With theses ios, the re

Re: [Qemu-block] [PATCH v3 05/33] Switch to new api in qdev/bus

2019-08-08 Thread David Gibson
On Wed, Jul 31, 2019 at 11:29:36AM +0200, Damien Hedde wrote: > > > On 7/31/19 8:05 AM, David Gibson wrote: > > On Mon, Jul 29, 2019 at 04:56:26PM +0200, Damien Hedde wrote: > >> Deprecate old reset apis and make them use the new one while they > >> are still used somewhere. > >> > >> Signed-off-

Re: [Qemu-block] [PATCH v3 09/33] add doc about Resettable interface

2019-08-08 Thread David Gibson
On Wed, Aug 07, 2019 at 11:34:41AM +0100, Peter Maydell wrote: > On Wed, 31 Jul 2019 at 07:33, David Gibson > wrote: > > > > On Mon, Jul 29, 2019 at 04:56:30PM +0200, Damien Hedde wrote: > > > +The function *resettable_reset* is used to trigger a reset on a given > > > +object. > > > +void resett

Re: [Qemu-block] [Qemu-devel] [PATCH v3 05/33] Switch to new api in qdev/bus

2019-08-08 Thread David Gibson
On Wed, Jul 31, 2019 at 01:31:28PM +0200, Philippe Mathieu-Daudé wrote: > On 7/31/19 11:29 AM, Damien Hedde wrote: > > On 7/31/19 8:05 AM, David Gibson wrote: > >> On Mon, Jul 29, 2019 at 04:56:26PM +0200, Damien Hedde wrote: > >>> Deprecate old reset apis and make them use the new one while they >

Re: [Qemu-block] [Qemu-devel] [PATCH] hw/ide/atapi: Use the ldst API

2019-08-08 Thread John Snow
On 8/8/19 9:04 AM, Philippe Mathieu-Daudé wrote: > The big-endian load/store functions are already provided > by "qemu/bswap.h". > Avoid code duplication, use the generic API. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ide/atapi.c | 80 ++-

Re: [Qemu-block] [Qemu-devel] [PATCH] ide: ahci: add check to avoid null dereference (CVE-2019-12067)

2019-08-08 Thread John Snow
On 8/8/19 5:11 AM, Philippe Mathieu-Daudé wrote: > Hi Prasad, > > On 8/8/19 8:56 AM, P J P wrote: >> From: Prasad J Pandit >> >> AHCI emulator while committing DMA buffer in ahci_commit_buf() >> may do a NULL dereference if the command header 'ad->cur_cmd' >> is null. Add check to avoid it. >>

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-08 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > > > This add the reset related sections for every QOM > > device. > > A bit more detail in the commit message would help, I think -- > this is adding extra machinery which has to copy and mod

Re: [Qemu-block] [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size with MO_{8|16|32|64}

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 08:30:04 + wrote: > Temporarily no-op size_memop was introduced to aid the conversion of > memory_region_dispatch_{read|write} operand "unsigned size" into > "MemOp op". > > Now size_memop is implemented, again hard coded size but with "Now that size_memop has been implem

Re: [Qemu-block] [PATCH v2 3/3] qcow2: add zstd cluster compression

2019-08-08 Thread Max Reitz
On 04.07.19 15:09, Denis Plotnikov wrote: > zstd significantly reduces cluster compression time. > It provides better compression performance maintaining > the same level of compression ratio in comparison with > zlib, which, by the moment, has been the only compression > method available. > > The

Re: [Qemu-block] [PATCH v2 2/3] qcow2: rework the cluster compression routine

2019-08-08 Thread Max Reitz
On 04.07.19 15:09, Denis Plotnikov wrote: > The patch allow to process image compression type defined > in the image header and choose an appropriate method for > image clusters (de)compression. > > Signed-off-by: Denis Plotnikov > --- > block/qcow2.c | 93 +++

Re: [Qemu-block] [Qemu-devel] [PATCH v6 08/26] hw/vfio: Access MemoryRegion with MemOp

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 08:28:40 + wrote: > The memory_region_dispatch_{read|write} operand "unsigned size" is > being converted into a "MemOp op". > > Convert interfaces by using no-op size_memop. > > After all interfaces are converted, size_memop will be implemented > and the memory_region_dis

Re: [Qemu-block] [Qemu-devel] [PATCH v6 07/26] hw/virtio: Access MemoryRegion with MemOp

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 08:28:16 + wrote: > The memory_region_dispatch_{read|write} operand "unsigned size" is > being converted into a "MemOp op". > > Convert interfaces by using no-op size_memop. > > After all interfaces are converted, size_memop will be implemented > and the memory_region_dis

Re: [Qemu-block] [Qemu-devel] [PATCH v6 05/26] hw/s390x: Access MemoryRegion with MemOp

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 08:27:35 + wrote: > The memory_region_dispatch_{read|write} operand "unsigned size" is > being converted into a "MemOp op". > > Convert interfaces by using no-op size_memop. > > After all interfaces are converted, size_memop will be implemented > and the memory_region_dis

Re: [Qemu-block] [Qemu-devel] [PATCH v6 02/26] tcg: TCGMemOp is now accelerator independent MemOp

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 08:26:23 + wrote: > Preparation for collapsing the two byte swaps, adjust_endianness and > handle_bswap, along the I/O path. > > Target dependant attributes are conditionalize upon NEED_CPU_H. s/conditionalize/conditionalized/ ? > > Signed-off-by: Tony Nguyen > Acked-b

Re: [Qemu-block] [Qemu-devel] [PATCH v6 01/26] configure: Define TARGET_ALIGNED_ONLY

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 08:25:37 + wrote: > Rename ALIGNED_ONLY to TARGET_ALIGNED_ONLY for clarity and move > defines out of target/foo/cpu.h into configure, as we do with > TARGET_WORDS_BIGENDIAN, so that it is always defined early. > > Poisoned TARGET_ALIGNED_ONLY to prevent use in common code.

Re: [Qemu-block] [PATCH v2 1/3] qcow2: introduce compression type feature

2019-08-08 Thread Kevin Wolf
Am 08.08.2019 um 14:50 hat Max Reitz geschrieben: > On 08.08.19 02:18, Eric Blake wrote: > > On 7/4/19 8:09 AM, Denis Plotnikov wrote: > >> The patch adds some preparation parts for incompatible compression type > >> feature to QCOW2 header that indicates that *all* compressed clusters > >> must be

Re: [Qemu-block] [PATCH v2 2/3] qcow2: rework the cluster compression routine

2019-08-08 Thread Max Reitz
On 04.07.19 15:09, Denis Plotnikov wrote: > The patch allow to process image compression type defined > in the image header and choose an appropriate method for > image clusters (de)compression. > > Signed-off-by: Denis Plotnikov > --- > block/qcow2.c | 93 +++

[Qemu-block] [PATCH] hw/ide/atapi: Use the ldst API

2019-08-08 Thread Philippe Mathieu-Daudé
The big-endian load/store functions are already provided by "qemu/bswap.h". Avoid code duplication, use the generic API. Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/atapi.c | 80 ++ 1 file changed, 28 insertions(+), 52 deletions(-) diff --git

Re: [Qemu-block] [PATCH v2 1/3] qcow2: introduce compression type feature

2019-08-08 Thread Max Reitz
On 08.08.19 02:18, Eric Blake wrote: > On 7/4/19 8:09 AM, Denis Plotnikov wrote: >> The patch adds some preparation parts for incompatible compression type >> feature to QCOW2 header that indicates that *all* compressed clusters >> must be (de)compressed using a certain compression type. >> >> It i

Re: [Qemu-block] [PATCH v2 1/3] qcow2: introduce compression type feature

2019-08-08 Thread Max Reitz
On 08.08.19 02:09, Eric Blake wrote: > On 8/7/19 6:12 PM, Max Reitz wrote: > >>> >>> +static int check_compression_type(BDRVQcow2State *s, Error **errp) >>> +{ >>> +switch (s->compression_type) { >>> +case QCOW2_COMPRESSION_TYPE_ZLIB: >>> +break; >>> + >>> +default: >>> +

Re: [Qemu-block] [PATCH v3 26/33] hw/s390x/s390-pci-inst.c: remove device_legacy_reset call

2019-08-08 Thread Cornelia Huck
On Mon, 29 Jul 2019 16:56:47 +0200 Damien Hedde wrote: > Replace S390PCIBusDevice legacy reset by device_reset_warm. > > The new function propagates also the reset to the sub-buses tree. > I'm not sure whether S390PCIBusDevice has bus children or not. This should be fine, I think. > > Signed-

Re: [Qemu-block] [PATCH v3 14/33] hw/s390x/s390-virtio-ccw.c: remove qdev_reset_all call

2019-08-08 Thread Cornelia Huck
On Mon, 29 Jul 2019 16:56:35 +0200 Damien Hedde wrote: > Replace deprecated qdev_reset_all by device_reset_warm. > > This does not impact the behavior. Not so sure about that; see below. > > Signed-off-by: Damien Hedde > --- > hw/s390x/s390-virtio-ccw.c | 2 +- > 1 file changed, 1 insertion

Re: [Qemu-block] [PATCH v3 11/33] hw/s390x/ipl.c: remove qbus_reset_all registration

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 16:24:30 +0100 Peter Maydell wrote: > On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > > > Replace deprecated qbus_reset_all by resettable_reset_cold_fn for > > the ipl registration in the main reset handlers. > > > > This does not impact the behavior. > > > > Signed-off-