Re: [Qemu-block] [PATCH] block: posix: Always allocate the first block

2019-08-24 Thread Nir Soffer
On Fri, Aug 23, 2019 at 8:53 PM Max Reitz wrote: > On 23.08.19 18:48, Nir Soffer wrote: > > On Fri, Aug 23, 2019 at 4:58 PM Max Reitz > > wrote: > > [...] > > > If you have a format layer that truncates the image to a fixed size > and > > does not write anything

[Qemu-block] [PATCH v2 2/2] nbd: Tolerate more errors to structured reply request

2019-08-24 Thread Eric Blake
A server may have a reason to reject a request for structured replies, beyond just not recognizing them as a valid request; similarly, it may have a reason for rejecting a request for a meta context. It doesn't hurt us to continue talking to such a server; otherwise 'qemu-nbd --list' of such a ser

[Qemu-block] [PATCH v2 1/2] nbd: Use g_autofree in a few places

2019-08-24 Thread Eric Blake
Thanks to our recent move to use glib's g_autofree, I can join the bandwagon. Getting rid of gotos is fun ;) There are probably more places where we could register cleanup functions and get rid of more gotos; this patch just focuses on the labels that existed merely to call g_free. Signed-off-by

Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/12] block: qiov_offset parameter for io

2019-08-24 Thread Vladimir Sementsov-Ogievskiy
23.08.2019 19:21, Stefan Hajnoczi wrote: > On Thu, Aug 22, 2019 at 05:59:43PM +, Vladimir Sementsov-Ogievskiy wrote: >> 22.08.2019 20:39, Vladimir Sementsov-Ogievskiy wrote: >>> 22.08.2019 20:24, Vladimir Sementsov-Ogievskiy wrote: 22.08.2019 18:50, Stefan Hajnoczi wrote: > On Tue, Jun

[Qemu-block] [PATCH] block: fix permission update in bdrv_replace_node

2019-08-24 Thread Vladimir Sementsov-Ogievskiy
It's wrong to OR shared permissions. It may lead to crash on further permission updates. Also, no needs to consider previously calculated permissions, as at this point we already bind all new parents and bdrv_get_cumulative_perm result is enough. So fix the bug by just set permissions by bdrv_get_c

Re: [Qemu-block] [PATCH v4 01/10] add device_legacy_reset function to prepare for reset api change

2019-08-24 Thread David Gibson
On Wed, Aug 21, 2019 at 06:33:32PM +0200, Damien Hedde wrote: > Provide a temporary device_legacy_reset function doing what > device_reset does to prepare for the transition with Resettable > API. > > All occurrence of device_reset in the code tree are also replaced > by device_legacy_reset. > >

Re: [Qemu-block] [PATCH 1/1] protocol: Add NBD_CMD_FLAG_FAST_ZERO

2019-08-24 Thread Wouter Verhelst
On Fri, Aug 23, 2019 at 01:58:44PM -0500, Eric Blake wrote: > On 8/23/19 1:48 PM, Wouter Verhelst wrote: > > On Fri, Aug 23, 2019 at 09:34:26AM -0500, Eric Blake wrote: > >> +- bit 4, `NBD_CMD_FLAG_FAST_ZERO`; valid during > >> + `NBD_CMD_WRITE_ZEROES`. If set, but the server cannot perform the >