On Tue, Nov 12, 2019 at 03:24:00PM +, Beata Michalska wrote:
> Hi Klaus,
>
> On Tue, 15 Oct 2019 at 11:50, Klaus Jensen wrote:
> > #define DEFINE_NVME_NS_PROPERTIES(_state, _props) \
> > -DEFINE_PROP_UINT32("nsid", _state, _props.nsid, 0)
> > +DEFINE_PROP_UINT32("nsid", _state,
On Tue, Nov 12, 2019 at 03:04:45PM +, Beata Michalska wrote:
> Hi Klaus
>
> On Tue, 15 Oct 2019 at 11:42, Klaus Jensen wrote:
> > +n->bar.vs = 0x00010201;
>
> Very minor:
>
> The version number is being set twice in the patch series already.
> And it is being set in two places.
> It
On Tue, Nov 12, 2019 at 03:04:38PM +, Beata Michalska wrote:
> Hi Klaus
>
Hi Beata,
Thank you very much for your thorough reviews! I'll start going through
them one by one :) You might have seen that I've posted a v3, but I will
make sure to consolidate between v2 and v3!
> On Tue, 15 Oct
Patchew URL: https://patchew.org/QEMU/20191112113012.71136-1-...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On Fri, Nov 08, 2019 at 09:53:12 +0100, Kevin Wolf wrote:
> Test that doing a second blockdev-snapshot doesn't make the first
> overlay's backing file go away.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/273 | 76 +
> tests/qemu-iotests/273.out | 337
On Fri, Nov 08, 2019 at 09:53:11 +0100, Kevin Wolf wrote:
> bs->options and bs->explicit_options shouldn't contain any options for
> child nodes. bdrv_open_inherited() takes care to remove any options that
> match a child name after opening the image and the same is done when
> reopening.
>
>
12.11.2019 16:46, Cornelia Huck wrote:
> On Fri, 8 Nov 2019 22:57:25 +0400
> Marc-André Lureau wrote:
>
>> Hi
>>
>> On Fri, Nov 8, 2019 at 7:31 PM Vladimir Sementsov-Ogievskiy
>> wrote:
>>>
>>> Finally, what is the plan?
>>>
>>> Markus what do you think?
>>>
>>> Now a lot of patches are
Hi Klaus,
On Tue, 15 Oct 2019 at 11:57, Klaus Jensen wrote:
>
> For now, support the Data Block, Segment and Last Segment descriptor
> types.
>
> See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)").
>
> Signed-off-by: Klaus Jensen
> ---
> block/nvme.c | 18 +-
>
Hi Klaus,
On Tue, 15 Oct 2019 at 11:55, Klaus Jensen wrote:
>
> This refactors how the device issues asynchronous block backend
> requests. The NvmeRequest now holds a queue of NvmeAIOs that are
> associated with the command. This allows multiple aios to be issued for
> a command. Only when all
Hi Klaus,
On Tue, 15 Oct 2019 at 11:50, Klaus Jensen wrote:
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme-ns.c | 2 +-
> hw/block/nvme-ns.h | 4 +++-
> hw/block/nvme.c| 1 +
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c
Hi Klaus,
On Tue, 15 Oct 2019 at 11:57, Klaus Jensen wrote:
>
> Instead of handling both QSGs and IOVs in multiple places, simply use
> QSGs everywhere by assuming that the request does not involve the
> controller memory buffer (CMB). If the request is found to involve the
> CMB, convert the
Hi Klaus,
On Tue, 15 Oct 2019 at 11:52, Klaus Jensen wrote:
>
> Add the new Namespace Identification Descriptor List (CNS 03h) and track
> creation of queues to enable the controller to return Command Sequence
> Error if Set Features is called for Number of Queues after any queues
> have been
Hi Klaus,
On Tue, 15 Oct 2019 at 11:45, Klaus Jensen wrote:
>
> Add support for the Get Log Page command and basic implementations
> of the mandatory Error Information, SMART/Health Information and
> Firmware Slot Information log pages.
>
> In violation of the specification, the SMART/Health
Hi Klaus
On Tue, 15 Oct 2019 at 11:42, Klaus Jensen wrote:
>
> Required for compliance with NVMe revision 1.2.1 or later. See NVM
> Express 1.2.1, Section 5.11 ("Identify command"), Figure 90 and Section
> 7.9 ("NVMe Qualified Names").
>
> This also bumps the supported version to 1.2.1.
>
>
Hi Klaus,
On Tue, 15 Oct 2019 at 11:49, Klaus Jensen wrote:
>
> Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1,
> Section 5.2 ("Asynchronous Event Request command").
>
> Mostly imported from Keith's qemu-nvme tree. Modified to not enqueue
> events if something of the
Hi Klaus
On Tue, 15 Oct 2019 at 11:41, Klaus Jensen wrote:
>
> Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1,
> Section 5.1 ("Abort command").
>
> The Abort command is a best effort command; for now, the device always
> fails to abort the given command.
>
>
Kevin Wolf writes:
> This adds and parses the --monitor option, so that a QMP monitor can be
> used in the storage daemon. The monitor offers commands defined in the
> QAPI schema at storage-daemon/qapi/qapi-schema.json.
I feel we should explain the module sharing between the two QAPI
schemata
On Fri, 8 Nov 2019 22:57:25 +0400
Marc-André Lureau wrote:
> Hi
>
> On Fri, Nov 8, 2019 at 7:31 PM Vladimir Sementsov-Ogievskiy
> wrote:
> >
> > Finally, what is the plan?
> >
> > Markus what do you think?
> >
> > Now a lot of patches are reviewed, but a lot of are not.
> >
> > Is there any
On Fri, 11 Oct 2019 19:04:12 +0300
Vladimir Sementsov-Ogievskiy wrote:
> Add script to automatically commit tree-wide changes per-subsystem.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
I think this still needs some notes as to the supposed usage.
On Tue, 2019-11-12 at 12:58 +0100, Max Reitz wrote:
> On 08.11.19 16:07, Maxim Levitsky wrote:
> > On Fri, 2019-10-04 at 21:10 +0200, Max Reitz wrote:
> > > On 13.09.19 00:30, Maxim Levitsky wrote:
> > > > This patch series is continuation of my work to add encryption
> > > > key managment to
On 08.11.19 16:07, Maxim Levitsky wrote:
> On Fri, 2019-10-04 at 21:10 +0200, Max Reitz wrote:
>> On 13.09.19 00:30, Maxim Levitsky wrote:
>>> This patch series is continuation of my work to add encryption
>>> key managment to luks/qcow2 with luks.
>>>
>>> This is second version of this patch set.
Move drive_backup_prepare() to be side by side with the other
related transaction helper functions.
Signed-off-by: Sergio Lopez
---
blockdev.c | 247 +++--
1 file changed, 125 insertions(+), 122 deletions(-)
diff --git a/blockdev.c b/blockdev.c
Consolidate blockdev_backup_prepare() with do_blockdev_backup() as a
first step towards streamlining all functionality through
transactions.
Signed-off-by: Sergio Lopez
---
blockdev.c | 64 +-
1 file changed, 15 insertions(+), 49 deletions(-)
Move blockdev_backup_prepare() to be side by side with the other
related transaction helper functions.
Signed-off-by: Sergio Lopez
---
blockdev.c | 70 +++---
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/blockdev.c b/blockdev.c
bdrv_try_set_aio_context() requires that the old context is held, and
the new context is not held. Fix all the occurrences where it's not
done this way.
Suggested-by: Max Reitz
Signed-off-by: Sergio Lopez
---
blockdev.c | 67 ++
1 file
Change qmp_blockdev_backup() to create and start a transaction instead
of calling do_blockdev_backup() directly.
Signed-off-by: Sergio Lopez
---
blockdev.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index f94aaa98f0..152a0f7454
Fix a couple of minor coding style issues in drive_backup_prepare.
Signed-off-by: Sergio Lopez
---
blockdev.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 5d30aff1e5..e8b673c5f3 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3592,7
Change qmp_drive_backup() to create and start a transaction instead of
calling do_drive_backup directly.
Signed-off-by: Sergio Lopez
---
blockdev.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index b32855f702..5e85fc042e 100644
---
do_drive_backup() acquires the AioContext lock of the corresponding
BlockDriverState. This is not a problem when it's called from
qmp_drive_backup(), but drive_backup_prepare() also acquires the lock
before calling it. The same things happens with do_blockdev_backup()
and
Consolidate drive_backup_prepare() with do_drive_backup() as a first
step towards streamlining all functionality through transactions.
Signed-off-by: Sergio Lopez
---
blockdev.c | 58 +++---
1 file changed, 16 insertions(+), 42 deletions(-)
diff
On Tue, Nov 12, 2019 at 10:12:45AM +0100, Kevin Wolf wrote:
> Am 11.11.2019 um 19:34 hat Daniel P. Berrangé geschrieben:
> > On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote:
> > > One of the concerns that was raised during the review was that amend
> > > interface for luks that I
On 12.11.19 10:12, Kevin Wolf wrote:
> Am 11.11.2019 um 19:34 hat Daniel P. Berrangé geschrieben:
>> On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote:
>>> One of the concerns that was raised during the review was that amend
>>> interface for luks that I propose is
>>> different from
11.11.2019 19:04, Andrey Shinkevich wrote:
> Allow writing all the data compressed through the filter driver.
> The written data will be aligned by the cluster size.
> Based on the QEMU current implementation, that data can be written to
> unallocated clusters only. May be used for a backup job.
>
12.11.2019 13:07, Andrey Shinkevich wrote:
> On 12/11/2019 12:39, Kevin Wolf wrote:
>> Am 11.11.2019 um 17:04 hat Andrey Shinkevich geschrieben:
>>> Allow writing all the data compressed through the filter driver.
>>> The written data will be aligned by the cluster size.
>>> Based on the QEMU
On 12/11/2019 12:39, Kevin Wolf wrote:
> Am 11.11.2019 um 17:04 hat Andrey Shinkevich geschrieben:
>> Allow writing all the data compressed through the filter driver.
>> The written data will be aligned by the cluster size.
>> Based on the QEMU current implementation, that data can be written to
On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote:
> I will try to explain the interface with bunch of examples:
I want to fill in equiv examples from cryptsetup for sake
of comparison
> # adds a new password, defined by qemu secret 'sec0' to first unused slot
> # give user a error
Kevin Wolf writes:
> We want to share the whitelists between the system emulator schema and
> the storage daemon schema, so move all the pragmas from the main schema
> file into a separate file that can be included from both.
Confusing because the storage daemon schema doesn't exist at this
Am 11.11.2019 um 17:04 hat Andrey Shinkevich geschrieben:
> Allow writing all the data compressed through the filter driver.
> The written data will be aligned by the cluster size.
> Based on the QEMU current implementation, that data can be written to
> unallocated clusters only. May be used for
Am 11.11.2019 um 19:34 hat Daniel P. Berrangé geschrieben:
> On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote:
> > One of the concerns that was raised during the review was that amend
> > interface for luks that I propose is
> > different from the amend inteface used currently for
11.11.2019 23:47, Eric Blake wrote:
> On 11/11/19 10:04 AM, Andrey Shinkevich wrote:
>> Allow writing all the data compressed through the filter driver.
>> The written data will be aligned by the cluster size.
>> Based on the QEMU current implementation, that data can be written to
>> unallocated
Am 12.11.2019 um 01:33 hat Liu Jaloo geschrieben:
> thanks Kevin for reply.
> I want to create a slackware usb-installer disk, with usbimg2disk.sh
> I create a disk with command:
> $ qemu-img create slackware64-current-udisk.img 8G
> then in slackware source directory:
> $ sudo ./usbimg2disk.sh -i
Kevin Wolf writes:
> If you added an include file that doesn't contain any definitions, no
> source files would be generated for it. However, in other source files,
> you would still get an #include for the header files of the empty
> module.
Bug.
Cause: we generate #include module.h always,
42 matches
Mail list logo
