Re: [PATCH v3 for-4.2 0/4] Better NBD string length handling

2019-11-13 Thread Eric Blake
On 11/13/19 9:00 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20191114024635.11363-1-ebl...@redhat.com/ from /tmp/qemu-test/src/include/qemu/osdep.h:140, from /tmp/qemu-test/src/nbd/server.c:20: /tmp/qemu-test/src/nbd/server.c: In

Re: [PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-13 Thread Eric Blake
On 11/13/19 8:46 PM, Eric Blake wrote: As long as we limit NBD names to 256 bytes (the bare minimum permitted by the standard), stack-allocation works for parsing a name received from the client. But as mentioned in a comment, we eventually want to permit up to the 4k maximum of the NBD

Re: [PATCH v3 for-4.2 0/4] Better NBD string length handling

2019-11-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191114024635.11363-1-ebl...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v3 for-4.2 0/4] Better NBD string length handling

2019-11-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191114024635.11363-1-ebl...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH v3 3/4] nbd: Don't send oversize strings

2019-11-13 Thread Eric Blake
Qemu as server currently won't accept export names larger than 256 bytes, nor create dirty bitmap names longer than 1023 bytes, so most uses of qemu as client or server have no reason to get anywhere near the NBD spec maximum of a 4k limit per string. However, we weren't actually enforcing

[PATCH v3 2/4] bitmap: Enforce maximum bitmap name length

2019-11-13 Thread Eric Blake
We document that for qcow2 persistent bitmaps, the name cannot exceed 1023 bytes. It is inconsistent if transient bitmaps do not have to abide by the same limit, and it is unlikely that any existing client even cares about using bitmap names this long. It's time to codify that ALL bitmaps

[PATCH v3 for-5.0 4/4] nbd: Allow description when creating NBD blockdev

2019-11-13 Thread Eric Blake
Allow blockdevs to match the feature already present in qemu-nbd -D. Enhance iotest 223 to cover it. Signed-off-by: Eric Blake Reviewed-by: Maxim Levitsky Reviewed-by: Vladimir Sementsov-Ogievskiy --- qapi/block.json| 9 ++--- blockdev-nbd.c | 9 -

[PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-13 Thread Eric Blake
As long as we limit NBD names to 256 bytes (the bare minimum permitted by the standard), stack-allocation works for parsing a name received from the client. But as mentioned in a comment, we eventually want to permit up to the 4k maximum of the NBD standard, which is too large for stack

[PATCH v3 for-4.2 0/4] Better NBD string length handling

2019-11-13 Thread Eric Blake
This series was originally posted before soft freeze, but then KVM Forum interfered. I think that patches 1-3 are bug fixes still appropriate for -rc2 if they get good reviews, but patch 4 is a new feature and now only appropriate for 5.0. Since v2: - Patch 1, 2: new [Vladimir] - Patch 3: improve

[PATCH v7 0/3] qcow2: advanced compression options

2019-11-13 Thread Andrey Shinkevich
The compression filter driver is introduced as suggested by Max. A sample usage of the filter can be found in the test #214. Now, multiple clusters can be written compressed. It is useful for the backup job. v7: 01: The 'zip_' prefix for the compression filter functions replaced with

[PATCH v7 3/3] tests/qemu-iotests: add case to write compressed data of multiple clusters

2019-11-13 Thread Andrey Shinkevich
Add the case to the iotest #214 that checks possibility of writing compressed data of more than one cluster size. The test case involves the compress filter driver showing a sample usage of that. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/214 | 43

[PATCH v7 1/3] block: introduce compress filter driver

2019-11-13 Thread Andrey Shinkevich
Allow writing all the data compressed through the filter driver. The written data will be aligned by the cluster size. Based on the QEMU current implementation, that data can be written to unallocated clusters only. May be used for a backup job. Suggested-by: Max Reitz Signed-off-by: Andrey

[PATCH v7 2/3] qcow2: Allow writing compressed data of multiple clusters

2019-11-13 Thread Andrey Shinkevich
QEMU currently supports writing compressed data of the size equal to one cluster. This patch allows writing QCOW2 compressed data that exceed one cluster. Now, we split buffered data into separate clusters and write them compressed using the existing functionality. Suggested-by: Pavel Butsykin

Re: [PATCH v7 0/4] colo: Add support for continuous replication

2019-11-13 Thread Lukas Straub
On Fri, 25 Oct 2019 19:06:31 +0200 Lukas Straub wrote: > Hello Everyone, > These Patches add support for continuous replication to colo. This means > that after the Primary fails and the Secondary did a failover, the Secondary > can then become Primary and resume replication to a new Secondary.

Re: [PATCH v2 1/2] nbd: Don't send oversize strings

2019-11-13 Thread Eric Blake
On 10/15/19 11:16 AM, Vladimir Sementsov-Ogievskiy wrote: @@ -1561,6 +1569,8 @@ NBDExport *nbd_export_new(BlockDriverState *bs, uint64_t dev_offset,    exp->export_bitmap = bm;    exp->export_bitmap_context = g_strdup_printf("qemu:dirty-bitmap:%s",    

Re: [RFC PATCH v2 03/26] qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied()

2019-11-13 Thread Alberto Garcia
On Wed 30 Oct 2019 03:24:08 PM CET, Max Reitz wrote: >> static void calculate_l2_meta(BlockDriverState *bs, uint64_t host_offset, >>uint64_t guest_offset, uint64_t bytes, >> - QCowL2Meta **m, bool keep_old) >> +

Re: [RFC PATCH 01/18] qemu-storage-daemon: Add barebone tool

2019-11-13 Thread Kevin Wolf
Am 24.10.2019 um 15:50 hat Eric Blake geschrieben: > On 10/17/19 8:01 AM, Kevin Wolf wrote: > > This adds a new binary qemu-storage-daemon that doesn't yet do more than > > some typical initialisation for tools and parsing the basic command > > options --version, --help and --trace. > > > >

Re: [RFC PATCH 18/18] qemu-storage-daemon: Add --monitor option

2019-11-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.11.2019 um 15:25 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > This adds and parses the --monitor option, so that a QMP monitor can be >> > used in the storage daemon. The monitor offers commands defined in the >> > QAPI schema at

Re: [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-13 Thread Sergio Lopez
Sergio Lopez writes: > no-re...@patchew.org writes: > >> Patchew URL: https://patchew.org/QEMU/20191112113012.71136-1-...@redhat.com/ >> >> >> >> Hi, >> >> This series failed the docker-quick@centos7 build test. Please find the >> testing commands and >> their output below. If you have Docker

Re: [PATCH v2 00/15] io_uring: add Linux io_uring AIO engine

2019-11-13 Thread Stefan Hajnoczi
On Mon, Nov 04, 2019 at 11:32:33AM +0100, Stefan Hajnoczi wrote: > On Fri, Oct 25, 2019 at 06:04:29PM +0200, Stefan Hajnoczi wrote: > > v11: > > * Drop fd registration because it breaks QEMU's file locking and will need > > to > >be resolved in a separate patch series > > * Drop

Re: [PATCH v2 05/15] stubs: add stubs for io_uring interface

2019-11-13 Thread Stefan Hajnoczi
On Mon, Nov 11, 2019 at 12:13:47PM +0100, Kevin Wolf wrote: > Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben: > > From: Aarushi Mehta > > > > Signed-off-by: Aarushi Mehta > > Signed-off-by: Stefan Hajnoczi > > This commit message needs to answer at least where these stubs are >

Re: [PATCH v2 03/15] block/block: add BDRV flag for io_uring

2019-11-13 Thread Stefan Hajnoczi
On Mon, Nov 11, 2019 at 05:25:04PM +0100, Max Reitz wrote: > On 11.11.19 11:57, Kevin Wolf wrote: > > Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben: > >> From: Aarushi Mehta > >> > >> Signed-off-by: Aarushi Mehta > >> Reviewed-by: Maxim Levitsky > >> Signed-off-by: Stefan Hajnoczi >

Re: [RFC PATCH 18/18] qemu-storage-daemon: Add --monitor option

2019-11-13 Thread Kevin Wolf
Am 12.11.2019 um 15:25 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > This adds and parses the --monitor option, so that a QMP monitor can be > > used in the storage daemon. The monitor offers commands defined in the > > QAPI schema at storage-daemon/qapi/qapi-schema.json. > > I

Re: [PATCH 2/2] iotests: Test multiple blockdev-snapshot calls

2019-11-13 Thread Kevin Wolf
Am 08.11.2019 um 15:32 hat Alberto Garcia geschrieben: > On Fri 08 Nov 2019 09:53:12 AM CET, Kevin Wolf wrote: > > +# Test large write to a qcow2 image > > This doesn't belong here I guess :) Yes, fixed. > I wonder if this test could go in 245 instead. The headline for 245 is "Test cases for

Re: [PATCH 2/2] iotests: Test multiple blockdev-snapshot calls

2019-11-13 Thread Kevin Wolf
Am 12.11.2019 um 17:07 hat Peter Krempa geschrieben: > On Fri, Nov 08, 2019 at 09:53:12 +0100, Kevin Wolf wrote: > > Test that doing a second blockdev-snapshot doesn't make the first > > overlay's backing file go away. > > > > Signed-off-by: Kevin Wolf > > --- > > tests/qemu-iotests/273 |

Re: [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-13 Thread Sergio Lopez
no-re...@patchew.org writes: > Patchew URL: https://patchew.org/QEMU/20191112113012.71136-1-...@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker installed, you can probably