Re: [PULL for-4.2-rc2 0/2] Tracing patches

2019-11-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191119204551.240792-1-stefa...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL for-4.2-rc2 0/2] Tracing patches Type: series Message-id:

RE: [PATCH v7 0/4] colo: Add support for continuous replication

2019-11-19 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, November 19, 2019 11:03 PM > To: Zhang, Chen ; Lukas Straub > ; qemu-devel > Cc: Kevin Wolf ; qemu-block bl...@nongnu.org>; Wen Congyang ; Max > Reitz ; Xie Changlong > Subject: Re: [PATCH v7 0/4] colo: Add support for

Re: [PULL for-4.2-rc2 0/2] Tracing patches

2019-11-19 Thread Aleksandar Markovic
On Tue, Nov 19, 2019 at 10:14 PM Aleksandar Markovic wrote: > > On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi wrote: > > > > The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: > > > > Merge remote-tracking branch > > 'remotes/awilliam/tags/vfio-fixes-20191118.0'

Re: [PULL for-4.2-rc2 0/2] Tracing patches

2019-11-19 Thread Aleksandar Markovic
On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi wrote: > > The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' > into staging (2019-11-18 21:35:48 +) > > are available in the Git

[PULL for-4.2-rc2 2/2] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-19 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of hex characters to display (the dynamic field width). We don't

[PULL for-4.2-rc2 1/2] hw/block/pflash: Remove dynamic field width from trace events

2019-11-19 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of hex characters to display (the dynamic field width). We don't

[PULL for-4.2-rc2 0/2] Tracing patches

2019-11-19 Thread Stefan Hajnoczi
The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' into staging (2019-11-18 21:35:48 +) are available in the Git repository at: https://github.com/stefanha/qemu.git

Re: [PATCH v2 08/20] nvme: add support for the get log page command

2019-11-19 Thread Klaus Birkelund
On Tue, Nov 12, 2019 at 03:04:52PM +, Beata Michalska wrote: > Hi Klaus, > > > On Tue, 15 Oct 2019 at 11:45, Klaus Jensen wrote: > > +if (!nsid || (nsid != 0x && nsid > n->num_namespaces)) { > > +trace_nvme_err_invalid_ns(nsid, n->num_namespaces); > > +return

Re: [PATCH v2 09/20] nvme: add support for the asynchronous event request command

2019-11-19 Thread Klaus Birkelund
On Tue, Nov 12, 2019 at 03:04:59PM +, Beata Michalska wrote: > Hi Klaus, > > On Tue, 15 Oct 2019 at 11:49, Klaus Jensen wrote: > > @@ -1188,6 +1326,9 @@ static int nvme_start_ctrl(NvmeCtrl *n) > > > > nvme_set_timestamp(n, 0ULL); > > > > +n->aer_timer =

Re: [PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
On 19/11/2019 18.50, Daniel P. Berrangé wrote: > On Tue, Nov 19, 2019 at 06:38:20PM +0100, Philippe Mathieu-Daudé wrote: >> On 11/19/19 6:34 PM, Thomas Huth wrote: >>> On 19/11/2019 18.29, Philippe Mathieu-Daudé wrote: On 11/19/19 6:08 PM, Thomas Huth wrote: > Test 079 fails in the arm64,

Re: [PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Daniel P . Berrangé
On Tue, Nov 19, 2019 at 06:38:20PM +0100, Philippe Mathieu-Daudé wrote: > On 11/19/19 6:34 PM, Thomas Huth wrote: > > On 19/11/2019 18.29, Philippe Mathieu-Daudé wrote: > > > On 11/19/19 6:08 PM, Thomas Huth wrote: > > > > Test 079 fails in the arm64, s390x and ppc64le LXD containers, which > > >

Re: [PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Philippe Mathieu-Daudé
On 11/19/19 6:34 PM, Thomas Huth wrote: On 19/11/2019 18.29, Philippe Mathieu-Daudé wrote: On 11/19/19 6:08 PM, Thomas Huth wrote: Test 079 fails in the arm64, s390x and ppc64le LXD containers, which apparently do not allow large files to be created. Test 079 tries to create a 4G sparse file,

Re: [PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
On 19/11/2019 18.29, Philippe Mathieu-Daudé wrote: > On 11/19/19 6:08 PM, Thomas Huth wrote: >> Test 079 fails in the arm64, s390x and ppc64le LXD containers, which >> apparently do not allow large files to be created. Test 079 tries to >> create a 4G sparse file, so check first whether we can

Re: [PATCH 5/6] travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS

2019-11-19 Thread Philippe Mathieu-Daudé
On 11/19/19 6:08 PM, Thomas Huth wrote: From: Alex Bennée The older clangs are still struggling to build and run everything withing the 50 minute timeout so lets lighten the load a bit more. We still have coverage for GCC and hopefully no obscure 32 bit guest only breakages slip through the

Re: [PATCH 4/6] tests/test-util-filemonitor: Skip test on non-x86 Travis containers

2019-11-19 Thread Philippe Mathieu-Daudé
On 11/19/19 6:08 PM, Thomas Huth wrote: test-util-filemonitor fails in restricted non-x86 Travis containers since they apparently blacklisted some required system calls there. Let's simply skip the test if we detect such an environment. Signed-off-by: Thomas Huth ---

Re: [PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Philippe Mathieu-Daudé
On 11/19/19 6:08 PM, Thomas Huth wrote: Test 079 fails in the arm64, s390x and ppc64le LXD containers, which apparently do not allow large files to be created. Test 079 tries to create a 4G sparse file, so check first whether we can really create such files before executing the test.

Re: [PATCH 3/6] tests/hd-geo-test: Skip test when images can not be created

2019-11-19 Thread Philippe Mathieu-Daudé
On 11/19/19 6:08 PM, Thomas Huth wrote: In certain environments like restricted containers, we can not create huge test images. To be able to use "make check" in such container environments, too, let's skip the hd-geo-test instead of failing when the test images could not be created.

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Vladimir Sementsov-Ogievskiy
19.11.2019 19:58, Stefan Hajnoczi wrote: > On Sat, Nov 16, 2019 at 07:34:06PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> I wanted to understand, what is the real difference between >> bdrv_block_status_above >> and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above should work

[PATCH 6/6] travis.yml: Enable builds on arm64, ppc64le and s390x

2019-11-19 Thread Thomas Huth
Travis recently added the possibility to test on these architectures, too, so let's enable them in our travis.yml file to extend our test coverage. Unfortunately, the libssh in this Ubuntu version (bionic) is in a pretty unusable Frankenstein state and libspice-server-dev is not available here,

[PATCH 3/6] tests/hd-geo-test: Skip test when images can not be created

2019-11-19 Thread Thomas Huth
In certain environments like restricted containers, we can not create huge test images. To be able to use "make check" in such container environments, too, let's skip the hd-geo-test instead of failing when the test images could not be created. Signed-off-by: Thomas Huth --- tests/hd-geo-test.c

[PATCH 5/6] travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS

2019-11-19 Thread Thomas Huth
From: Alex Bennée The older clangs are still struggling to build and run everything withing the 50 minute timeout so lets lighten the load a bit more. We still have coverage for GCC and hopefully no obscure 32 bit guest only breakages slip through the cracks. Signed-off-by: Alex Bennée

[PATCH 4/6] tests/test-util-filemonitor: Skip test on non-x86 Travis containers

2019-11-19 Thread Thomas Huth
test-util-filemonitor fails in restricted non-x86 Travis containers since they apparently blacklisted some required system calls there. Let's simply skip the test if we detect such an environment. Signed-off-by: Thomas Huth --- tests/test-util-filemonitor.c | 11 +++ 1 file changed, 11

[PATCH 1/6] iotests: Skip test 060 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
Test 060 fails in the arm64, s390x and ppc64le LXD containers, which apparently do not allow large files to be created. The repair process in test 060 creates a file of 64 GiB, so test first whether such large files are possible and skip the test if that's not the case. Signed-off-by: Thomas Huth

[PATCH 0/6] Enable Travis builds on arm64, ppc64le and s390x

2019-11-19 Thread Thomas Huth
Travis recently added build hosts for arm64, ppc64le and s390x, so this is a welcome addition to our Travis testing matrix. Unfortunately, the builds are running in quite restricted LXD containers there, for example it is not possible to create huge files there (even if they are just sparse), and

[PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
Test 079 fails in the arm64, s390x and ppc64le LXD containers, which apparently do not allow large files to be created. Test 079 tries to create a 4G sparse file, so check first whether we can really create such files before executing the test. Signed-off-by: Thomas Huth ---

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Stefan Hajnoczi
On Sat, Nov 16, 2019 at 07:34:06PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > I wanted to understand, what is the real difference between > bdrv_block_status_above > and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above should work through > bdrv_block_status_above.. > > And I

Re: [PULL 0/2] mips-next patches for 4.2-rc2

2019-11-19 Thread Peter Maydell
emote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-11-19' into > staging (2019-11-19 09:17:24 +) > > are available in the Git repository at: > > https://gitlab.com/philmd/qemu.git tags/mips-next-20191119 > > for you to fetch changes up to abc7cf36559f953777faf27d2e0df

Re: [PATCH v4 0/2] hw: Remove dynamic field width from trace events

2019-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2019 at 11:27:44PM +0100, Philippe Mathieu-Daudé wrote: > This series fixes LP#1844817 [2]. > > (Eric noted in [1] the dtrace via stap backend can not support > the dynamic '*' width format.) > > If they are trivial/block/tracing pull in preparation, this > series will be happy

Re: [PATCH v4 0/2] hw: Remove dynamic field width from trace events

2019-11-19 Thread Philippe Mathieu-Daudé
On 11/19/19 5:21 PM, Stefan Hajnoczi wrote: On Mon, Nov 18, 2019 at 11:27:44PM +0100, Philippe Mathieu-Daudé wrote: This series fixes LP#1844817 [2]. (Eric noted in [1] the dtrace via stap backend can not support the dynamic '*' width format.) If they are trivial/block/tracing pull in

Re: [PATCH v7 0/4] colo: Add support for continuous replication

2019-11-19 Thread Jason Wang
On 2019/11/19 下午8:28, Zhang, Chen wrote: -Original Message- From: Lukas Straub Sent: Thursday, November 14, 2019 12:36 AM To: qemu-devel Cc: Zhang, Chen ; Jason Wang ; Wen Congyang ; Xie Changlong ; Kevin Wolf ; Max Reitz ; qemu-block Subject: Re: [PATCH v7 0/4] colo: Add support

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Kevin Wolf
Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > I wanted to understand, what is the real difference between > bdrv_block_status_above > and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above should work through > bdrv_block_status_above.. > > And I found

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Kevin Wolf
Am 19.11.2019 um 13:17 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.11.2019 15:05, Kevin Wolf wrote: > > Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> Hi all! > >> > >> I wanted to understand, what is the real difference between > >> bdrv_block_status_above and

[PULL 2/2] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-19 Thread Philippe Mathieu-Daudé
Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of hex characters to display (the dynamic field width). We don't need this anymore. Instead,

[PULL 1/2] hw/block/pflash: Remove dynamic field width from trace events

2019-11-19 Thread Philippe Mathieu-Daudé
Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of hex characters to display (the dynamic field width). We don't need this anymore. Instead,

[PULL 0/2] mips-next patches for 4.2-rc2

2019-11-19 Thread Philippe Mathieu-Daudé
+) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/mips-next-20191119 for you to fetch changes up to abc7cf36559f953777faf27d2e0dfb561ac533a5: hw/mips/gt64xxx: Remove dynamic field width from trace events (2019-11-19 14:46:01 +0100

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Kevin Wolf
Am 19.11.2019 um 13:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.11.2019 15:20, Max Reitz wrote: > > On 19.11.19 13:02, Denis V. Lunev wrote: > >> On 11/19/19 1:22 PM, Max Reitz wrote: > >>> On 16.11.19 17:34, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > I wanted to

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Vladimir Sementsov-Ogievskiy
19.11.2019 15:34, Vladimir Sementsov-Ogievskiy wrote: > 19.11.2019 15:32, Vladimir Sementsov-Ogievskiy wrote: >> 19.11.2019 15:17, Vladimir Sementsov-Ogievskiy wrote: >>> 19.11.2019 15:05, Kevin Wolf wrote: Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all!

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Vladimir Sementsov-Ogievskiy
19.11.2019 15:32, Vladimir Sementsov-Ogievskiy wrote: > 19.11.2019 15:17, Vladimir Sementsov-Ogievskiy wrote: >> 19.11.2019 15:05, Kevin Wolf wrote: >>> Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! I wanted to understand, what is the real difference

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Vladimir Sementsov-Ogievskiy
19.11.2019 15:17, Vladimir Sementsov-Ogievskiy wrote: > 19.11.2019 15:05, Kevin Wolf wrote: >> Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> Hi all! >>> >>> I wanted to understand, what is the real difference between >>> bdrv_block_status_above and

Re: [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-19 Thread Sergio Lopez
Kevin Wolf writes: > Am 19.11.2019 um 12:35 hat Sergio Lopez geschrieben: >> >> Kevin Wolf writes: >> >> > Am 19.11.2019 um 11:54 hat Sergio Lopez geschrieben: >> >> >> >> Max Reitz writes: >> >> >> >> > On 13.11.19 14:24, Sergio Lopez wrote: >> >> >> >> >> >> Sergio Lopez writes: >> >>

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Vladimir Sementsov-Ogievskiy
19.11.2019 15:20, Max Reitz wrote: > On 19.11.19 13:02, Denis V. Lunev wrote: >> On 11/19/19 1:22 PM, Max Reitz wrote: >>> On 16.11.19 17:34, Vladimir Sementsov-Ogievskiy wrote: Hi all! I wanted to understand, what is the real difference between bdrv_block_status_above

RE: [PATCH v7 0/4] colo: Add support for continuous replication

2019-11-19 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, November 14, 2019 12:36 AM > To: qemu-devel > Cc: Zhang, Chen ; Jason Wang > ; Wen Congyang ; > Xie Changlong ; Kevin Wolf > ; Max Reitz ; qemu-block > > Subject: Re: [PATCH v7 0/4] colo: Add support for continuous

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Max Reitz
On 19.11.19 13:02, Denis V. Lunev wrote: > On 11/19/19 1:22 PM, Max Reitz wrote: >> On 16.11.19 17:34, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> I wanted to understand, what is the real difference between >>> bdrv_block_status_above >>> and bdrv_is_allocated_above, IMHO

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Vladimir Sementsov-Ogievskiy
19.11.2019 15:05, Kevin Wolf wrote: > Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Hi all! >> >> I wanted to understand, what is the real difference between >> bdrv_block_status_above and bdrv_is_allocated_above, IMHO >> bdrv_is_allocated_above should work through

Re: [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-19 Thread Kevin Wolf
Am 19.11.2019 um 12:35 hat Sergio Lopez geschrieben: > > Kevin Wolf writes: > > > Am 19.11.2019 um 11:54 hat Sergio Lopez geschrieben: > >> > >> Max Reitz writes: > >> > >> > On 13.11.19 14:24, Sergio Lopez wrote: > >> >> > >> >> Sergio Lopez writes: > >> >> > >> >>> no-re...@patchew.org

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Vladimir Sementsov-Ogievskiy
19.11.2019 15:02, Denis Lunev wrote: > On 11/19/19 1:22 PM, Max Reitz wrote: >> On 16.11.19 17:34, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> I wanted to understand, what is the real difference between >>> bdrv_block_status_above >>> and bdrv_is_allocated_above, IMHO

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Kevin Wolf
Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > I wanted to understand, what is the real difference between > bdrv_block_status_above and bdrv_is_allocated_above, IMHO > bdrv_is_allocated_above should work through bdrv_block_status_above.. > > And I found the

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Denis V. Lunev
On 11/19/19 1:22 PM, Max Reitz wrote: > On 16.11.19 17:34, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> I wanted to understand, what is the real difference between >> bdrv_block_status_above >> and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above should work through >>

Re: [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-19 Thread Sergio Lopez
Kevin Wolf writes: > Am 19.11.2019 um 11:54 hat Sergio Lopez geschrieben: >> >> Max Reitz writes: >> >> > On 13.11.19 14:24, Sergio Lopez wrote: >> >> >> >> Sergio Lopez writes: >> >> >> >>> no-re...@patchew.org writes: >> >>> >> Patchew URL: >>

Re: [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-19 Thread Kevin Wolf
Am 19.11.2019 um 11:54 hat Sergio Lopez geschrieben: > > Max Reitz writes: > > > On 13.11.19 14:24, Sergio Lopez wrote: > >> > >> Sergio Lopez writes: > >> > >>> no-re...@patchew.org writes: > >>> > Patchew URL: > https://patchew.org/QEMU/20191112113012.71136-1-...@redhat.com/ >

Re: [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-19 Thread Sergio Lopez
Max Reitz writes: > On 13.11.19 14:24, Sergio Lopez wrote: >> >> Sergio Lopez writes: >> >>> no-re...@patchew.org writes: >>> Patchew URL: https://patchew.org/QEMU/20191112113012.71136-1-...@redhat.com/ Hi, This series failed the docker-quick@centos7

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-19 Thread Max Reitz
On 16.11.19 17:34, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > I wanted to understand, what is the real difference between > bdrv_block_status_above > and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above should work through > bdrv_block_status_above.. > > And I found the problem:

Re: [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-19 Thread Max Reitz
On 13.11.19 14:24, Sergio Lopez wrote: > > Sergio Lopez writes: > >> no-re...@patchew.org writes: >> >>> Patchew URL: https://patchew.org/QEMU/20191112113012.71136-1-...@redhat.com/ >>> >>> >>> >>> Hi, >>> >>> This series failed the docker-quick@centos7 build test. Please find the >>> testing

Re: [PATCH v3 1/8] blockdev: merge drive_backup_prepare with do_drive_backup

2019-11-19 Thread Max Reitz
On 12.11.19 12:30, Sergio Lopez wrote: > Consolidate drive_backup_prepare() with do_drive_backup() as a first > step towards streamlining all functionality through transactions. > > Signed-off-by: Sergio Lopez > --- > blockdev.c | 58 +++--- > 1