Re: [PULL for-4.2-rc2 0/2] Tracing patches

On 11/19/19 10:14 PM, Aleksandar Markovic wrote: On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi wrote: The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' into staging (2019-11-18 21:35:48

Re: [PULL for-4.2-rc2 0/2] Tracing patches

On 11/19/19 10:35 PM, Aleksandar Markovic wrote: On Tue, Nov 19, 2019 at 10:14 PM Aleksandar Markovic wrote: On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi wrote: The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: Merge remote-tracking branch 'remotes/awilliam

Re: [PATCH v2 13/20] nvme: refactor prp mapping

On Tue, Nov 12, 2019 at 03:23:43PM +, Beata Michalska wrote: > Hi Klaus, > > On Tue, 15 Oct 2019 at 11:57, Klaus Jensen wrote: > > > > Instead of handling both QSGs and IOVs in multiple places, simply use > > QSGs everywhere by assuming that the request does not involve the > > controller mem

Re: [RFC v5 000/126] error: auto propagated local_err

Okay... I think that: 1. A lot of efforts (not only my, I think reviewing is already exceeded generation efforts) are made, it would be sad to lose them. 2. It's safe enough to apply only part of generated patches: we just fix error_abort/error_fatal in more popular subsystems, what's wr

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

16.11.2019 19:34, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > I wanted to understand, what is the real difference between > bdrv_block_status_above > and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above should work through > bdrv_block_status_above.. > > And I found the problem: bdrv_

Re: [PULL for-4.2-rc2 0/2] Tracing patches

On Wed, Nov 20, 2019 at 10:33:35AM +0100, Philippe Mathieu-Daudé wrote: > On 11/19/19 10:35 PM, Aleksandar Markovic wrote: > > On Tue, Nov 19, 2019 at 10:14 PM Aleksandar Markovic > > wrote: > > > > > > On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi > > > wrote: > > > > > > > > The following

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

Am 20.11.2019 um 11:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > 16.11.2019 19:34, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > I wanted to understand, what is the real difference between > > bdrv_block_status_above > > and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above sh

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

20.11.2019 14:44, Kevin Wolf wrote: > Am 20.11.2019 um 11:20 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 16.11.2019 19:34, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> I wanted to understand, what is the real difference between >>> bdrv_block_status_above >>> and bdrv_is_allocated_

qcow2 preallocation and backing files

Hi, as we discussed yesterday on IRC there's an inconsistency in the way qcow2 preallocation works. Let's create an image and fill it with data: $ qemu-img create -f raw base.img 1M $ qemu-io -f raw -c 'write -P 0xFF 0 1M' base.img Now QEMU won't let us create a new image backed by base.i

Re: qcow2 preallocation and backing files

20.11.2019 15:06, Alberto Garcia wrote: > Hi, > > as we discussed yesterday on IRC there's an inconsistency in the way > qcow2 preallocation works. > > Let's create an image and fill it with data: > > $ qemu-img create -f raw base.img 1M > $ qemu-io -f raw -c 'write -P 0xFF 0 1M' base.im

Re: [RFC v5 000/126] error: auto propagated local_err

On 11/20/19 3:50 AM, Vladimir Sementsov-Ogievskiy wrote: Okay... I think that: 1. A lot of efforts (not only my, I think reviewing is already exceeded generation efforts) are made, it would be sad to lose them. 2. It's safe enough to apply only part of generated patches: we just fix erro

Re: [RFC v5 000/126] error: auto propagated local_err

Am 20.11.2019 um 13:59 hat Eric Blake geschrieben: > On 11/20/19 3:50 AM, Vladimir Sementsov-Ogievskiy wrote: > > Okay... > > > > I think that: > > > > 1. A lot of efforts (not only my, I think reviewing is already exceeded > > generation efforts) > > are made, it would be sad to lose them.

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

Am 20.11.2019 um 13:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > 20.11.2019 14:44, Kevin Wolf wrote: > > Am 20.11.2019 um 11:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 16.11.2019 19:34, Vladimir Sementsov-Ogievskiy wrote: > >>> Hi all! > >>> > >>> I wanted to understand, what is th

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

20.11.2019 15:04, Vladimir Sementsov-Ogievskiy wrote: > 20.11.2019 14:44, Kevin Wolf wrote: >> Am 20.11.2019 um 11:20 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> 16.11.2019 19:34, Vladimir Sementsov-Ogievskiy wrote: Hi all! I wanted to understand, what is the real difference be

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

20.11.2019 16:30, Kevin Wolf wrote: > Am 20.11.2019 um 13:04 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 20.11.2019 14:44, Kevin Wolf wrote: >>> Am 20.11.2019 um 11:20 hat Vladimir Sementsov-Ogievskiy geschrieben: 16.11.2019 19:34, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > >

[PATCH 1/6] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter

bdrv_co_do_pwrite_zeroes() can already cope with maximum request sizes by calling the driver in a loop until everything is done. Make the small remaining change that is necessary to let it accept a 64 bit byte count. Signed-off-by: Kevin Wolf --- block/io.c | 6 +++--- 1 file changed, 3 insertio

[PATCH for-4.2? 0/6] block: Fix resize (extending) of short overlays

Consider the following scenario where the overlay is shorter than its backing file: base.qcow2: overlay.qcow2: When resizing (extending) overlay.qcow2, the new blocks should not stay unallocated and make the additional As from base.qcow2 visible like before this series,

[PATCH 5/6] iotests: Support job-complete in run_job()

Automatically complete jobs that have a 'ready' state and need an explicit job-complete. Without this, run_job() would hang for such jobs. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-

[PATCH 2/6] block: truncate: Don't make backing file data visible

When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. The old behaviour made a difference in 'block_resize' (where showing the backing file data from

[PATCH 6/6] iotests: Test committing to short backing file

Signed-off-by: Kevin Wolf --- tests/qemu-iotests/274| 131 + tests/qemu-iotests/274.out| 150 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 2 +- 4 files changed, 283 insertions(+), 1 deletion(-)

[PATCH 3/6] iotests: Add qemu_io_log()

Add a function that runs qemu-io and logs the output with the appropriate filters applied. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 6a248472b9..330681ad

[PATCH 4/6] iotests: Fix timeout in run_job()

run_job() accepts a wait parameter for a timeout, but it doesn't actually use it. The only thing that is missing is passing it to events_wait(), so do that now. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/q

Re: [PATCH 1/6] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter

On 11/20/19 8:03 AM, Kevin Wolf wrote: bdrv_co_do_pwrite_zeroes() can already cope with maximum request sizes by calling the driver in a loop until everything is done. Make the small remaining change that is necessary to let it accept a 64 bit byte count. Signed-off-by: Kevin Wolf --- block/i

Re: [PATCH 2/6] block: truncate: Don't make backing file data visible

On 11/20/19 8:03 AM, Kevin Wolf wrote: When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. The old behaviour made a difference in 'block_resize'

Re: [PATCH 1/6] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter

20.11.2019 17:03, Kevin Wolf wrote: > bdrv_co_do_pwrite_zeroes() can already cope with maximum request sizes > by calling the driver in a loop until everything is done. Make the small > remaining change that is necessary to let it accept a 64 bit byte count. > > Signed-off-by: Kevin Wolf Reviewe

Re: [PATCH 4/6] iotests: Fix timeout in run_job()

On 11/20/19 8:03 AM, Kevin Wolf wrote: run_job() accepts a wait parameter for a timeout, but it doesn't actually use it. The only thing that is missing is passing it to events_wait(), so do that now. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 2 +- 1 file changed, 1 insert

Re: [PATCH 3/6] iotests: Add qemu_io_log()

On 11/20/19 8:03 AM, Kevin Wolf wrote: Add a function that runs qemu-io and logs the output with the appropriate filters applied. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 5 + 1 file changed, 5 insertions(+) Reviewed-by: Eric Blake -- Eric Blake, Principal Softwa

Re: [PATCH 2/6] block: truncate: Don't make backing file data visible

20.11.2019 17:03, Kevin Wolf wrote: > When extending the size of an image that has a backing file larger than > its old size, make sure that the backing file data doesn't become > visible in the guest, but the added area is properly zeroed out. > > The old behaviour made a difference in 'block_res

Re: [PATCH 3/6] iotests: Add qemu_io_log()

20.11.2019 17:03, Kevin Wolf wrote: > Add a function that runs qemu-io and logs the output with the > appropriate filters applied. > > Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 5/6] iotests: Support job-complete in run_job()

On 11/20/19 8:03 AM, Kevin Wolf wrote: Automatically complete jobs that have a 'ready' state and need an explicit job-complete. Without this, run_job() would hang for such jobs. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by:

Re: [PATCH 4/6] iotests: Fix timeout in run_job()

20.11.2019 17:03, Kevin Wolf wrote: > run_job() accepts a wait parameter for a timeout, but it doesn't > actually use it. The only thing that is missing is passing it to > events_wait(), so do that now. > > Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vl

Re: [PATCH 6/6] iotests: Test committing to short backing file

On 11/20/19 8:03 AM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- tests/qemu-iotests/274| 131 + tests/qemu-iotests/274.out| 150 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 2 +- 4 f

Re: [PATCH 5/6] iotests: Support job-complete in run_job()

20.11.2019 17:03, Kevin Wolf wrote: > Automatically complete jobs that have a 'ready' state and need an > explicit job-complete. Without this, run_job() would hang for such > jobs. > > Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/iotests.py |

Re: [PATCH 2/6] block: truncate: Don't make backing file data visible

Am 20.11.2019 um 15:47 hat Vladimir Sementsov-Ogievskiy geschrieben: > 20.11.2019 17:03, Kevin Wolf wrote: > > When extending the size of an image that has a backing file larger than > > its old size, make sure that the backing file data doesn't become > > visible in the guest, but the added area i

Re: qcow2 preallocation and backing files

On Wed 20 Nov 2019 01:27:53 PM CET, Vladimir Semeeausntsov-Ogievskiy wrote: > 3. Also, the latter way is inconsistent with discard. Discarded > regions returns zeroes, not clusters from backing. I think discard and > truncate should behave in the same safe zero way. But then PREALLOC_MODE_OFF imp

Re: [PATCH 6/6] iotests: Test committing to short backing file

20.11.2019 17:03, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/274| 131 + > tests/qemu-iotests/274.out| 150 ++ > tests/qemu-iotests/group | 1 + > tests/qemu-iotests/iotests.py | 2 +

Re: [PATCH for-4.2? 0/6] block: Fix resize (extending) of short overlays

20.11.2019 17:03, Kevin Wolf wrote: > Consider the following scenario where the overlay is shorter than its > backing file: > > base.qcow2: > overlay.qcow2: > > When resizing (extending) overlay.qcow2, the new blocks should not stay > unallocated and make the addition

Re: [RFC v5 031/126] xen: introduce ERRP_AUTO_PROPAGATE

On Fri, Oct 11, 2019 at 07:04:17PM +0300, Vladimir Sementsov-Ogievskiy wrote: > diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c > --- a/hw/block/xen-block.c > +++ b/hw/block/xen-block.c > @@ -915,15 +903,15 @@ static void xen_block_device_create(XenBackendInstance > *backend, > g

Re: qcow2 preallocation and backing files

20.11.2019 18:18, Alberto Garcia wrote: > On Wed 20 Nov 2019 01:27:53 PM CET, Vladimir Semeeausntsov-Ogievskiy wrote: > >> 3. Also, the latter way is inconsistent with discard. Discarded >> regions returns zeroes, not clusters from backing. I think discard and >> truncate should behave in the same

Re: [PATCH 6/6] iotests: Test committing to short backing file

20.11.2019 17:03, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf Tested-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 6/6] iotests: Test committing to short backing file

Am 20.11.2019 um 16:41 hat Vladimir Sementsov-Ogievskiy geschrieben: > 20.11.2019 17:03, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > tests/qemu-iotests/274| 131 + > > tests/qemu-iotests/274.out| 150 ++ > >

Re: [PATCH 1/6] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter

On Wed 20 Nov 2019 03:03:14 PM CET, Kevin Wolf wrote: > bdrv_co_do_pwrite_zeroes() can already cope with maximum request sizes > by calling the driver in a loop until everything is done. Make the small > remaining change that is necessary to let it accept a 64 bit byte count. > > Signed-off-by: Kev

[PATCH 5/4] iotests: add commit top->base cases to 274

These cases are fixed by previous patches around block_status and is_allocated. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/274 | 20 tests/qemu-iotests/274.out | 63 ++ 2 files changed, 83 insertions(+) diff --git a/te

Re: [PATCH 6/6] iotests: Test committing to short backing file

20.11.2019 19:11, Kevin Wolf wrote: > Am 20.11.2019 um 16:41 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 20.11.2019 17:03, Kevin Wolf wrote: >>> Signed-off-by: Kevin Wolf >>> --- >>>tests/qemu-iotests/274| 131 + >>>tests/qemu-iotests/274.out| 15

Re: qcow2 preallocation and backing files

On Wed 20 Nov 2019 04:58:38 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> But then PREALLOC_MODE_OFF implies that the L2 metadata should be >> preallocated (all clusters should be QCOW2_CLUSTER_ZERO_PLAIN), at >> least when there is a backing file. > > Kevin proposed a fix that alters PREALLOC_MOD

Re: qcow2 preallocation and backing files

Am 20.11.2019 um 16:58 hat Vladimir Sementsov-Ogievskiy geschrieben: > 20.11.2019 18:18, Alberto Garcia wrote: > > On Wed 20 Nov 2019 01:27:53 PM CET, Vladimir Semeeausntsov-Ogievskiy wrote: > > > >> 3. Also, the latter way is inconsistent with discard. Discarded > >> regions returns zeroes, not c

Re: qcow2 preallocation and backing files

20.11.2019 19:46, Kevin Wolf wrote: > Am 20.11.2019 um 16:58 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 20.11.2019 18:18, Alberto Garcia wrote: >>> On Wed 20 Nov 2019 01:27:53 PM CET, Vladimir Semeeausntsov-Ogievskiy wrote: >>> 3. Also, the latter way is inconsistent with discard. Discar

Re: [PATCH 2/6] block: truncate: Don't make backing file data visible

20.11.2019 17:03, Kevin Wolf wrote: > When extending the size of an image that has a backing file larger than > its old size, make sure that the backing file data doesn't become > visible in the guest, but the added area is properly zeroed out. > > The old behaviour made a difference in 'block_res

[PATCH for-4.2? v2 0/6] block: Fix resize (extending) of short overlays

See patch 2 for the description of the bug fixed. v2: - Switched order of bs->total_sectors update and zero write [Vladimir] - Fixed coding style [Vladimir] - Changed the commit message to contain what was in the cover letter - Test all preallocation modes - Test allocation status with qemu-io 'ma

[PATCH v2 1/6] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter

bdrv_co_do_pwrite_zeroes() can already cope with maximum request sizes by calling the driver in a loop until everything is done. Make the small remaining change that is necessary to let it accept a 64 bit byte count. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sements

[PATCH v2 2/6] block: truncate: Don't make backing file data visible

When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. Consider the following scenario where the overlay is shorter than its backing file: base.q

[PATCH v2 3/6] iotests: Add qemu_io_log()

Add a function that runs qemu-io and logs the output with the appropriate filters applied. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/i

[PATCH v2 5/6] iotests: Support job-complete in run_job()

Automatically complete jobs that have a 'ready' state and need an explicit job-complete. Without this, run_job() would hang for such jobs. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 2 ++ 1 file changed, 2 ins

[PATCH v2 4/6] iotests: Fix timeout in run_job()

run_job() accepts a wait parameter for a timeout, but it doesn't actually use it. The only thing that is missing is passing it to events_wait(), so do that now. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 2 +-

[PATCH v2 6/6] iotests: Test committing to short backing file

Signed-off-by: Kevin Wolf --- tests/qemu-iotests/274| 141 + tests/qemu-iotests/274.out| 227 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 2 +- 4 files changed, 370 insertions(+), 1 deletion(-) create

[PATCH 1/9] monitor: uninline add_init_drive

This is only used by hmp_drive_add. The code is just a bit shorter this way. No functional changes Signed-off-by: Maxim Levitsky --- device-hotplug.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/device-hotplug.c b/device-hotplug.c index

[PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups

This patch series is bunch of cleanups to the hmp monitor code. This series only touched blockdev related hmp handlers. No functional changes expected other that light error message changes by the last patch. This was inspired by this bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1719169

[PATCH 2/9] monitor: rename device-hotplug.c to blockdev-hmp-cmds.c

These days device-hotplug.c only contains the hmp_drive_add In the next patch, rest of hmp_drive* functions will be moved there. Signed-off-by: Maxim Levitsky --- MAINTAINERS | 1 + Makefile.objs | 4 ++-- device-hotplug.c => blockdev-hmp-cmd

[PATCH 5/9] monitor: move hmp_block_job* to blockdev-hmp-cmd.c

Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 52 + monitor/hmp-cmds.c | 52 - 2 files changed, 52 insertions(+), 52 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index 5ae899

[PATCH 6/9] monitor: move hmp_snapshot_* to blockdev-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 47 + monitor/hmp-cmds.c | 46 2 files changed, 47 insertions(+), 46 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index e333de2

[PATCH 4/9] monitor: move hmp_drive_mirror and hmp_drive_backup to blockdev-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 61 + monitor/hmp-cmds.c | 58 -- 2 files changed, 61 insertions(+), 58 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index 888461823

[PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 97 - blockdev.c | 95 2 files changed, 96 insertions(+), 96 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index 21ff6fa

[PATCH 9/9] monitor/hmp: Prefer to use hmp_handle_error for error reporting in block hmp commands

This way they all will be prefixed with 'Error:' which some parsers (e.g libvirt need) Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index

[PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 247 monitor/hmp-cmds.c | 245 --- 2 files changed, 247 insertions(+), 245 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index 76951

[PATCH 7/9] monitor: move remaining hmp_block* functions to blockdev-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 63 monitor/hmp-cmds.c | 64 - 2 files changed, 63 insertions(+), 64 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index f3d22c7

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

On 11/20/19 12:44 PM, Kevin Wolf wrote: When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. Consider the following scenario where the overlay is

Re: [PATCH v2 6/6] iotests: Test committing to short backing file

On 11/20/19 12:45 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- tests/qemu-iotests/274| 141 + tests/qemu-iotests/274.out| 227 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 2 +- 4 files ch