Re: [PATCH v2] migration/dirty-bitmaps: change bitmap enumeration method

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
14.05.2019 23:19, John Snow wrote: > Shift from looking at every root BDS to *every* BDS. This will migrate > bitmaps that are attached to blockdev created nodes instead of just ones > attached to emulated storage devices. > > Note that this will not migrate anonymous or internal-use bitmaps, as

Re: [PATCH for-5.0 v2 0/3] benchmark util

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 22:43, Cleber Rosa wrote: > On Tue, Nov 26, 2019 at 06:48:45PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is simple benchmarking utility, to generate performance >> comparison tables, like the following: >> >> -- - - -

Re: [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread Eric Blake
On 12/6/19 1:02 PM, John Snow wrote: I'm afraid that the only thing is not remove persistent bitmaps, which were never synced to the image. So, instead the sequence above, we need 1. create persistent bitmap A 2. shutdown vm 3. start vm 4. create persistent bitmap B 5. remember, that we want

Re: [PATCH for-5.0 v2 0/3] benchmark util

2019-12-06 Thread Cleber Rosa
On Tue, Nov 26, 2019 at 06:48:45PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is simple benchmarking utility, to generate performance > comparison tables, like the following: > > -- - - - > backup-1 backup-2

Re: Offline manipulation of Dirty Bitmaps by qemu-img

2019-12-06 Thread John Snow
On 12/6/19 5:37 AM, Vladimir Sementsov-Ogievskiy wrote: > 06.12.2019 1:37, John Snow wrote: >> This has come up in the past, and I believe we discussed this at KVM >> Forum, too: >> >> There have been requests from oVirt (via Nir Soffer) to add some offline >> bitmap manipulation functionality.

Re: [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread John Snow
On 12/6/19 9:36 AM, Eric Blake wrote: > [adding in Peter Maydell, as there is now potential talk of other > 4.2-worthy patches] > > On 12/6/19 4:18 AM, Vladimir Sementsov-Ogievskiy wrote: >> 05.12.2019 23:16, John Snow wrote: >>> >>> >>> On 12/5/19 3:09 PM, Eric Blake wrote: On 12/5/19

Re: [PATCH v8 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 18:58, Markus Armbruster wrote: > Eric Blake writes: > >> On 12/5/19 11:46 AM, Vladimir Sementsov-Ogievskiy wrote: >>> The local_err parameter is not here to return information about >>> nbd_iter_channel_error failure. Instead it's assumed to be filled when >>> passed to the function.

Re: [PATCH v8 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

2019-12-06 Thread Markus Armbruster
Eric Blake writes: > On 12/5/19 11:46 AM, Vladimir Sementsov-Ogievskiy wrote: >> The local_err parameter is not here to return information about >> nbd_iter_channel_error failure. Instead it's assumed to be filled when >> passed to the function. This is already stressed by its name >>

Re: [PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

2019-12-06 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 05.12.2019 20:14, Eric Blake wrote: >> On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> The local_err parameter is not here to return information about >>> nbd_iter_channel_error failure. Instead it's assumed to be filled when >>> passed to the

Re: [PATCH v2 3/7] iotests: Skip test 079 if it is not possible to create large files

2019-12-06 Thread Thomas Huth
On 04/12/2019 16.46, Thomas Huth wrote: > Test 079 fails in the arm64, s390x and ppc64le LXD containers on Travis For the record: It's working on s390x as noticed by Cleber. It's only failing on arm64 and ppc64le. After fixing the problem with 060 which fails on all three architectures, I did not

Re: [libvirt] Offline manipulation of Dirty Bitmaps by qemu-img

2019-12-06 Thread Peter Krempa
On Thu, Dec 05, 2019 at 17:37:11 -0500, John Snow wrote: > This has come up in the past, and I believe we discussed this at KVM > Forum, too: > > There have been requests from oVirt (via Nir Soffer) to add some offline > bitmap manipulation functionality. In the past, our stance has generally >

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Eric Blake
On 12/6/19 8:38 AM, Daniel P. Berrangé wrote: Mention that this is a PCI device address & give the format it is expected it. Also mention that it must be first unbound from any maybe s/expected it/expecting/ host kernel driver. Signed-off-by: Daniel P. Berrangé --- qapi/block-core.json |

Re: [PATCH v7 00/21] error: prepare for auto propagated local_err

2019-12-06 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 05.12.2019 18:26, Cornelia Huck wrote: >> On Thu, 5 Dec 2019 18:19:58 +0300 >> Vladimir Sementsov-Ogievskiy wrote: >> >>> Hi all! >>> >>> This is the first part of the bit series, which contains mostly simple >>> cleanups. >> >> What's the plan? Should

Re: [PATCH] qemu-img: fix info --backing-chain --image-opts

2019-12-06 Thread Alberto Garcia
On Thu 05 Dec 2019 02:46:46 PM CET, Stefan Hajnoczi wrote: > Only apply --image-opts to the topmost image when listing an entire > backing chain. It is incorrect to treat backing filenames as image > options. Assuming we have the backing chain t.IMGFMT.base <- > t.IMGFMT.mid <- t.IMGFMT,

Re: [PATCH for-5.0 v2 02/23] blockdev: Allow resizing everywhere

2019-12-06 Thread Alberto Garcia
On Mon 11 Nov 2019 05:01:55 PM CET, Max Reitz wrote: > @@ -3177,11 +3177,6 @@ void qmp_block_resize(bool has_device, const char > *device, > aio_context = bdrv_get_aio_context(bs); > aio_context_acquire(aio_context); > > -if (!bdrv_is_first_non_filter(bs)) { > -

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Daniel P . Berrangé
On Fri, Dec 06, 2019 at 08:51:15AM -0600, Eric Blake wrote: > On 12/6/19 8:38 AM, Daniel P. Berrangé wrote: > > Mention that this is a PCI device address & give the format it is > > expected it. Also mention that it must be first unbound from any > > maybe s/expected it/expecting/ It was

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Stefan Hajnoczi
On Fri, Dec 06, 2019 at 02:38:11PM +, Daniel P. Berrangé wrote: > Mention that this is a PCI device address & give the format it is > expected it. Also mention that it must be first unbound from any > host kernel driver. > > Signed-off-by: Daniel P. Berrangé > --- > qapi/block-core.json | 6

Re: [libvirt] [PATCH v2 20/25] qemu: Implement backup job APIs and qemu handling

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 21:13, Eric Blake wrote: > [adding some qemu visibility] > > On 12/5/19 7:34 AM, Peter Krempa wrote: > +    if (!(mergebitmapsstore = virJSONValueCopy(mergebitmaps))) +    return -1; + +    if (qemuMonitorTransactionBitmapAdd(actions, + 

[PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Daniel P . Berrangé
Mention that this is a PCI device address & give the format it is expected it. Also mention that it must be first unbound from any host kernel driver. Signed-off-by: Daniel P. Berrangé --- qapi/block-core.json | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread Eric Blake
[adding in Peter Maydell, as there is now potential talk of other 4.2-worthy patches] On 12/6/19 4:18 AM, Vladimir Sementsov-Ogievskiy wrote: 05.12.2019 23:16, John Snow wrote: On 12/5/19 3:09 PM, Eric Blake wrote: On 12/5/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: Here is double

Re: [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 23:09, Eric Blake wrote: > On 12/5/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: >> Here is double bug: >> >> First, return error but not set errp. This may lead to: >> qmp block-dirty-bitmap-remove may report success when actually failed >> >> block-dirty-bitmap-remove used in a

Re: [RFC v5 024/126] error: auto propagated local_err

2019-12-06 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 05.12.2019 17:58, Vladimir Sementsov-Ogievskiy wrote: >> 05.12.2019 15:36, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> 04.12.2019 17:59, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Here

Re: [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 23:16, John Snow wrote: > > > On 12/5/19 3:09 PM, Eric Blake wrote: >> On 12/5/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Here is double bug: >>> >>> First, return error but not set errp. This may lead to: >>> qmp block-dirty-bitmap-remove may report success when actually

Re: Offline manipulation of Dirty Bitmaps by qemu-img

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 1:37, John Snow wrote: > This has come up in the past, and I believe we discussed this at KVM > Forum, too: > > There have been requests from oVirt (via Nir Soffer) to add some offline > bitmap manipulation functionality. In the past, our stance has generally > been "Use QEMU without

Re: [PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 11:54, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 05.12.2019 20:14, Eric Blake wrote: >>> On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote: The local_err parameter is not here to return information about nbd_iter_channel_error failure. Instead