Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays

2019-12-10 Thread Max Reitz
On 10.12.19 18:46, Kevin Wolf wrote: > Am 22.11.2019 um 17:05 hat Kevin Wolf geschrieben: >> See patch 4 for the description of the bug fixed. > > I'm applying patches 3 and 5-7 to the block branch because they make > sense on their own. > > The real fix will need another approach because the err

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-10 Thread John Snow
On 12/10/19 8:24 AM, Max Reitz wrote: > On 10.12.19 09:11, Max Reitz wrote: >> On 09.12.19 23:03, Eric Blake wrote: >>> On 12/9/19 11:58 AM, Max Reitz wrote: On 09.12.19 17:30, Max Reitz wrote: > On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: >> Hi again! >> >> Still

Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays

2019-12-10 Thread Kevin Wolf
Am 22.11.2019 um 17:05 hat Kevin Wolf geschrieben: > See patch 4 for the description of the bug fixed. I'm applying patches 3 and 5-7 to the block branch because they make sense on their own. The real fix will need another approach because the error handling is broken in this one: If zeroing out

Re: [PATCH] qemu-img: fix info --backing-chain --image-opts

2019-12-10 Thread Kevin Wolf
Am 05.12.2019 um 14:46 hat Stefan Hajnoczi geschrieben: > Only apply --image-opts to the topmost image when listing an entire > backing chain. It is incorrect to treat backing filenames as image > options. Assuming we have the backing chain t.IMGFMT.base <- > t.IMGFMT.mid <- t.IMGFMT, qemu-img in

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-10 Thread Kevin Wolf
Am 06.12.2019 um 15:38 hat Daniel P. Berrangé geschrieben: > Mention that this is a PCI device address & give the format it is > expected it. Also mention that it must be first unbound from any > host kernel driver. > > Signed-off-by: Daniel P. Berrangé Thanks, applied to the block branch. Kevi

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-10 Thread Max Reitz
On 10.12.19 09:11, Max Reitz wrote: > On 09.12.19 23:03, Eric Blake wrote: >> On 12/9/19 11:58 AM, Max Reitz wrote: >>> On 09.12.19 17:30, Max Reitz wrote: On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: > Hi again! > > Still forgotten bug-fix :( > > Is it too late f

Re: [PATCH v8 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

2019-12-10 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 06.12.2019 18:58, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 12/5/19 11:46 AM, Vladimir Sementsov-Ogievskiy wrote: The local_err parameter is not here to return information about nbd_iter_channel_error failure. Instead it's assumed

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-10 Thread Max Reitz
On 09.12.19 23:03, Eric Blake wrote: > On 12/9/19 11:58 AM, Max Reitz wrote: >> On 09.12.19 17:30, Max Reitz wrote: >>> On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: Hi again! Still forgotten bug-fix :( Is it too late for 4.2? >>> >>> Sorry. :-/ >>> >>> Yes, I thin