[PATCH] qcow2: Use offset_into_cluster()

2019-12-12 Thread Alberto Garcia
There's a couple of places left in the qcow2 code that still do the calculation manually, so let's replace them. Signed-off-by: Alberto Garcia --- block/qcow2.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 7c18721741..3866b47946

Re: [RFC PATCH 00/18] Add qemu-storage-daemon

2019-12-12 Thread Stefan Hajnoczi
On Thu, Nov 21, 2019 at 12:08:16PM +0100, Kevin Wolf wrote: > Am 21.11.2019 um 11:32 hat Stefan Hajnoczi geschrieben: > > On Wed, Nov 06, 2019 at 03:58:00PM +0100, Kevin Wolf wrote: > > > Am 06.11.2019 um 15:37 hat Max Reitz geschrieben: > > > > On 17.10.19 15:01, Kevin Wolf wrote: > > > > The only

block-dirty-bitmap-add fails with "Operation not supported" in 4.2 rc5 (worked in 4.1)

2019-12-12 Thread Nir Soffer
We have a test for full backup flow testing that we can consume the data using our nbd client. The test[0] is starting a full backup flow, based on Eric examples from [1] and [2]. This used to work in 4.1, and broke when I upgraded to 4.2 rc5. Here is the error I get: E test.qmp.Co

Re: [PATCH] qcow2: Use offset_into_cluster()

2019-12-12 Thread Eric Blake
On 12/12/19 4:01 AM, Alberto Garcia wrote: There's a couple of places left in the qcow2 code that still do the calculation manually, so let's replace them. Signed-off-by: Alberto Garcia --- block/qcow2.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake

Re: block-dirty-bitmap-add fails with "Operation not supported" in 4.2 rc5 (worked in 4.1)

2019-12-12 Thread Nir Soffer
On Thu, Dec 12, 2019 at 2:04 PM Nir Soffer wrote: > > We have a test for full backup flow testing that we can consume the > data using our nbd client. > > The test[0] is starting a full backup flow, based on Eric examples > from [1] and [2]. Looking at qemu-iotests/256, I switch the order of the

Re: block-dirty-bitmap-add fails with "Operation not supported" in 4.2 rc5 (worked in 4.1)

2019-12-12 Thread John Snow
On 12/12/19 1:32 PM, Nir Soffer wrote: > On Thu, Dec 12, 2019 at 2:04 PM Nir Soffer wrote: >> >> We have a test for full backup flow testing that we can consume the >> data using our nbd client. >> >> The test[0] is starting a full backup flow, based on Eric examples >> from [1] and [2]. > > L

Re: block-dirty-bitmap-add fails with "Operation not supported" in 4.2 rc5 (worked in 4.1)

2019-12-12 Thread Eric Blake
On 12/12/19 3:04 PM, John Snow wrote: On 12/12/19 1:32 PM, Nir Soffer wrote: On Thu, Dec 12, 2019 at 2:04 PM Nir Soffer wrote: We have a test for full backup flow testing that we can consume the data using our nbd client. The test[0] is starting a full backup flow, based on Eric examples f

Re: block-dirty-bitmap-add fails with "Operation not supported" in 4.2 rc5 (worked in 4.1)

2019-12-12 Thread Nir Soffer
On Thu, Dec 12, 2019 at 11:34 PM Eric Blake wrote: > > On 12/12/19 3:04 PM, John Snow wrote: > > > > > > On 12/12/19 1:32 PM, Nir Soffer wrote: > >> On Thu, Dec 12, 2019 at 2:04 PM Nir Soffer wrote: > >>> > >>> We have a test for full backup flow testing that we can consume the > >>> data using o

Re: block-dirty-bitmap-add fails with "Operation not supported" in 4.2 rc5 (worked in 4.1)

2019-12-12 Thread John Snow
On 12/12/19 6:12 PM, Nir Soffer wrote: > > Thank you for the detailed answer! > > I'm sure blockdev is the greatest thing since sliced bread but it > looks like overkill > for our use case. I'm happy to use the node name generated by qemu. > Sometimes all you want is some toast, I agree. >

[PING]Re: [PATCH v0 2/2] block: allow to set 'drive' property on a realized block device

2019-12-12 Thread Denis Plotnikov
On 18.11.2019 13:50, Denis Plotnikov wrote: > > > On 10.11.2019 22:08, Denis Plotnikov wrote: >> >> On 10.11.2019 22:03, Denis Plotnikov wrote: >>> This allows to change (replace) the file on a block device and is >>> useful >>> to workaround exclusive file access restrictions, e.g. to implement