"Chubb, Peter (Data61, Kensington NSW)"
writes:
>> "Philippe" == Philippe Mathieu-Daudé writes:
>
> Philippe> Fix some trivial warnings when building with -O3.
>
> For compatibility with lint and other older checkers, it'd be good to keep
> this as /* FALLTHROUGH */ (which gcc should accept
On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused when building with CFLAG -O3:
>
> In function ‘help_oneline’,
> inlined from ‘help_all’ at qemu-io-cmds.c:2414:9,
> inlined from ‘help_f’ at qemu-io-cmds.c:2424:9:
> qemu-io-cmds.c:2389:9: error: ‘%s’ directive a
On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused when building with CFLAG -O3:
>
> hw/scsi/megasas.c: In function ‘megasas_scsi_realize’:
> hw/scsi/megasas.c:2387:26: error: duplicated ‘if’ condition
> [-Werror=duplicated-cond]
>2387 | } else if (s->fw_sge >= 128
Signed-off-by: Guoyi Tu
---
block/qcow2.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 7c18721..ce3db29 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1705,14 +1705,14 @@ static int coroutine_fn qcow2_do_open(BlockDriverSt
> "Philippe" == Philippe Mathieu-Daudé writes:
Philippe> Fix some trivial warnings when building with -O3.
For compatibility with lint and other older checkers, it'd be good to keep
this as /* FALLTHROUGH */ (which gcc should accept according to its
manual).
Fixing the comments' placement i
On 12/17/19 6:32 PM, Philippe Mathieu-Daudé wrote:
Fix some trivial warnings when building with -O3.
Philippe Mathieu-Daudé (6):
audio/audio: Add missing fall through comment
hw/display/tcx: Add missing fall through comments
hw/net/imx_fec: Rewrite fall through comments
hw/timer/aspe
GCC9 is confused when building with CFLAG -O3:
hw/scsi/megasas.c: In function ‘megasas_scsi_realize’:
hw/scsi/megasas.c:2387:26: error: duplicated ‘if’ condition
[-Werror=duplicated-cond]
2387 | } else if (s->fw_sge >= 128 - MFI_PASS_FRAME_SIZE) {
hw/scsi/megasas.c:2385:19: note: pre
GCC9 is confused when building with CFLAG -O3:
In function ‘help_oneline’,
inlined from ‘help_all’ at qemu-io-cmds.c:2414:9,
inlined from ‘help_f’ at qemu-io-cmds.c:2424:9:
qemu-io-cmds.c:2389:9: error: ‘%s’ directive argument is null
[-Werror=format-overflow=]
2389 | p
Fix some trivial warnings when building with -O3.
Philippe Mathieu-Daudé (6):
audio/audio: Add missing fall through comment
hw/display/tcx: Add missing fall through comments
hw/net/imx_fec: Rewrite fall through comments
hw/timer/aspeed_timer: Add a fall through comment
hw/scsi/megasas: S
Fix some trivial warnings when building with -O3.
Philippe Mathieu-Daudé (6):
audio/audio: Add missing fall through comment
hw/display/tcx: Add missing fall through comments
hw/net/imx_fec: Rewrite fall through comments
hw/timer/aspeed_timer: Add a fall through comment
hw/scsi/megasas: S
On 12/17/19 5:37 PM, Philippe Mathieu-Daudé wrote:
Hi,
After this chat on #qemu IRC:
13:20 so what is the difference between a IOReadHandler and
IOEventHandler?
13:25 stsquad: one is in-band and the other out-of-band?
13:26 f4bug: ahh yes it seems so - connect/disconnect etc...
13:27 see QE
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
CC s390x-softmmu/hw/char/terminal3270.o
hw/char/terminal3270.c: In function ‘ch
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
CC net/vhost-user.o
net/vhost-user.c: In function ‘net_vhost_user_event’:
net
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
CC s390x-softmmu/hw/block/vhost-user-blk.o
hw/block/vhost-user-blk.c: In functi
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
CC hw/usb/redirect.o
hw/usb/redirect.c: In function ‘usbredir_chardev_event’:
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
CC monitor/qmp.o
monitor/qmp.c: In function ‘monitor_qmp_event’:
monitor/qmp.
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
hw/usb/dev-serial.c: In function ‘usb_serial_event’:
hw/usb/dev-serial.c:468:5: error:
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
hw/usb/ccid-card-passthru.c: In function ‘ccid_card_vscard_event’:
hw/usb/ccid-card-pa
The Chardev events are listed in the QEMUChrEvent enum.
By using the enum in the IOEventHandler typedef we:
- make the IOEventHandler type more explicit (this handler
process out-of-band information, while the IOReadHandler
is in-band),
- help static code analyzers.
This patch was produced w
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
CC monitor/hmp.o
monitor/hmp.c: In function ‘monitor_event’:
monitor/hmp.c:13
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
hw/ipmi/ipmi_bmc_extern.c: In function ‘chr_event’:
hw/ipmi/ipmi_bmc_extern.c:389:5: e
Hi,
After this chat on #qemu IRC:
13:20 so what is the difference between a IOReadHandler and
IOEventHandler?
13:25 stsquad: one is in-band and the other out-of-band?
13:26 f4bug: ahh yes it seems so - connect/disconnect etc...
13:27 see QEMUChrEvent for IOEventHandler
I thought it might be
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
chardev/char.c: In function ‘qemu_chr_be_event’:
chardev/char.c:65:5: error: enumerati
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
CC hw/char/virtio-console.o
hw/char/virtio-console.c: In function ‘chr_event’:
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
CC backends/cryptodev-vhost-user.o
backends/cryptodev-vhost-user.c: In function
Since we don't use these methods before defining them,
no need to forward-declare them.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Corey Minyard
---
Cc: Corey Minyard
In case the other patches are rejected:
Cc: qemu-triv...@nongnu.org
---
hw/ipmi/ipmi_bmc_extern.c | 4
1 file changed
Am 17.12.19 um 16:52 schrieb Kevin Wolf:
Am 17.12.2019 um 15:14 hat Peter Lieven geschrieben:
I have a vserver running Qemu 4.0 that seems to reproducibly hit the
following assertion:
bdrv_co_pwritev: Assertion `!waited || !use_local_qiov' failed.
I noticed that the padding code was recently
Am 17.12.2019 um 15:14 hat Peter Lieven geschrieben:
> I have a vserver running Qemu 4.0 that seems to reproducibly hit the
> following assertion:
>
> bdrv_co_pwritev: Assertion `!waited || !use_local_qiov' failed.
>
> I noticed that the padding code was recently reworked in commit
> 2e2ad02f2c.
Eric Blake writes:
> On 12/17/19 1:36 AM, Markus Armbruster wrote:
>
>> Un-snipping the QAPI schema change:
>
> Sorry about that...
>
>>
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 0cf68fea14..bd651106bd 100644
--- a/qapi/block-core.json
+++ b/qapi/block-cor
The error message for a negative speed uses QERR_INVALID_PARAMETER,
which implies that the 'speed' option doesn't even exist:
{"error": {"class": "GenericError", "desc": "Invalid parameter 'speed'"}}
Make it use QERR_INVALID_PARAMETER_VALUE instead:
{"error": {"class": "GenericError", "d
This tests creating an external snapshot with VM state (which results in
an active overlay over an inactive backing file, which is also the root
node of an inactive BlockBackend), re-activating the images and
performing some operations to test that the re-activation worked as
intended.
Signed-off-
This fixes bdrv_invalidate_cache_all() for some kinds of graphs where
part of the nodes are active and others are inactive. This is a scenario
that happens when libvirt takes an external snapshot with VM state.
This was reported in:
https://bugzilla.redhat.com/show_bug.cgi?id=1781637
('qemu crashe
bdrv_invalidate_cache_all() assumes that all nodes in a given subtree
are either active or inactive when it starts. Therefore, as soon as it
arrives at an already active node, it stops.
However, this assumption is wrong. For example, it's possible to take a
snapshot of an inactive node, which resu
In order to issue requests on an existing BlockBackend with the
'qemu-io' HMP command, allow specifying the BlockBackend not only with a
BlockBackend name, but also with a qdev ID/QOM path for a device that
owns the (possibly anonymous) BlockBackend.
Because qdev names could be conflicting with Bl
On 07.11.19 17:36, Max Reitz wrote:
> Hi,
>
> The cover letter from v1 (explaining the motivation behind this series
> and the general structure) is here:
>
> https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01323.html
>
>
> For v2, I’ve addressed more of Maxim’s comments:
> - Patch
Hi all,
I have a vserver running Qemu 4.0 that seems to reproducibly hit the following
assertion:
bdrv_co_pwritev: Assertion `!waited || !use_local_qiov' failed.
I noticed that the padding code was recently reworked in commit 2e2ad02f2c.
In the new code I cannot find a similar assertion. W
On 26.11.19 14:42, Kevin Wolf wrote:
> The error message for a negative speed uses QERR_INVALID_PARAMETER,
> which implies that the 'speed' option doesn't even exist:
>
> {"error": {"class": "GenericError", "desc": "Invalid parameter 'speed'"}}
>
> Make it use QERR_INVALID_PARAMETER_VALUE ins
On 12/17/19 1:36 AM, Markus Armbruster wrote:
Un-snipping the QAPI schema change:
Sorry about that...
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 0cf68fea14..bd651106bd 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1752,6 +1752,8 @@
#
# Get the nam
On Fri, Dec 13, 2019 at 02:46:26PM +, Stefan Hajnoczi wrote:
> The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough
> support. Deprecate this feature in QEMU too.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> qemu-deprecated.texi | 11 +++
> 1 file changed, 11 inser
39 matches
Mail list logo
