Eric Blake writes:
> On 1/24/20 4:34 AM, David Edmondson wrote:
>> In many cases the target of a convert operation is a newly provisioned
>> target that the user knows is blank (filled with zeroes). In this
>> situation there is no requirement for qemu-img to wastefully zero out
>> the entire dev
Eric Blake writes:
> On 1/24/20 4:34 AM, David Edmondson wrote:
>> Texinfo defines @var for metasyntactic variables and such terms are
>> shown in upper-case or italics in the output of makeinfo. When
>> considering an option to a command, such as "-n", upper-casing is
>> undesirable as it may co
From: Alexander Popov
Fuzzing the Linux kernel with syzkaller allowed to find how to crash qemu
using a special SCSI_IOCTL_SEND_COMMAND. It hits the assertion in
ide_dma_cb() introduced in the commit a718978ed58a in July 2015.
Currently this bug is not reproduced by the unit tests.
Let's improve
From: Alexander Popov
The commit a718978ed58a from July 2015 introduced the assertion which
implies that the size of successful DMA transfers handled in ide_dma_cb()
should be multiple of 512 (the size of a sector). But guest systems can
initiate DMA transfers that don't fit this requirement.
Fo
The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into
staging (2020-01-27 13:02:36 +)
are available in the Git repository at:
https://github.com/jnsnow/qemu.git tags/ide-pull-reques
On 1/24/20 4:34 AM, David Edmondson wrote:
In many cases the target of a convert operation is a newly provisioned
target that the user knows is blank (filled with zeroes). In this
situation there is no requirement for qemu-img to wastefully zero out
the entire device.
Add a new option, --target-
On 1/27/20 3:43 PM, Peter Krempa wrote:
> On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote:
>>
>>
>> On 1/27/20 5:36 AM, Maxim Levitsky wrote:
>>> This patch series is bunch of cleanups
>>> to the hmp monitor code.
>>>
>>> This series only touched blockdev related hmp handlers.
>>>
>>> No
On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote:
>
>
> On 1/27/20 5:36 AM, Maxim Levitsky wrote:
> > This patch series is bunch of cleanups
> > to the hmp monitor code.
> >
> > This series only touched blockdev related hmp handlers.
> >
> > No functional changes expected other that
> >
On 1/27/20 5:36 AM, Maxim Levitsky wrote:
> This patch series is bunch of cleanups
> to the hmp monitor code.
>
> This series only touched blockdev related hmp handlers.
>
> No functional changes expected other that
> light error message changes by the last patch.
>
> This was inspired by thi
On 1/24/20 4:34 AM, David Edmondson wrote:
Texinfo defines @var for metasyntactic variables and such terms are
shown in upper-case or italics in the output of makeinfo. When
considering an option to a command, such as "-n", upper-casing is
undesirable as it may confuse the reader or be in conflic
From: Sergio Lopez
external_snapshot_abort() calls to bdrv_set_backing_hd(), which
returns state->old_bs to the main AioContext, as it's intended to be
used then the BDS is going to be released. As that's not the case when
aborting an external snapshot, return it to the AioContext it was
before t
From: Sergio Lopez
bdrv_try_set_aio_context() requires that the old context is held, and
the new context is not held. Fix all the occurrences where it's not
done this way.
Suggested-by: Max Reitz
Signed-off-by: Sergio Lopez
Signed-off-by: Kevin Wolf
---
blockdev.c | 68 ++
From: Felipe Franciosi
When querying an iSCSI server for the provisioning status of blocks (via
GET LBA STATUS), Qemu only validates that the response descriptor zero's
LBA matches the one requested. Given the SCSI spec allows servers to
respond with the status of blocks beyond the end of the LUN
From: Eiichi Tsukata
bdrv_open_driver() allocates bs->opaque according to drv->instance_size.
There is no need to allocate it and overwrite opaque in
bdrv_backup_top_append().
Reproducer:
$ QTEST_QEMU_BINARY=./x86_64-softmmu/qemu-system-x86_64 valgrind -q
--leak-check=full tests/test-replica
From: Sergio Lopez
All paths that lead to bdrv_backup_top_drop(), except for the call
from backup_clean(), imply that the BDS AioContext has already been
acquired, so doing it there too can potentially lead to QEMU hanging
on AIO_WAIT_WHILE().
An easy way to trigger this situation is by issuing
From: Sergio Lopez
Issuing a blockdev-backup from qmp_blockdev_backup takes a slightly
different path than when it's issued from a transaction. In the code,
this is manifested as some redundancy between do_blockdev_backup() and
blockdev_backup_prepare().
This change unifies both paths, merging d
From: Sergio Lopez
Issuing a drive-backup from qmp_drive_backup takes a slightly
different path than when it's issued from a transaction. In the code,
this is manifested as some redundancy between do_drive_backup() and
drive_backup_prepare().
This change unifies both paths, merging do_drive_back
In iscsi_co_block_status(), we may have received num_descriptors == 0
from the iscsi server. Therefore, we can't unconditionally access
lbas->descriptors[0]. Add the missing check.
Signed-off-by: Kevin Wolf
Reviewed-by: Felipe Franciosi
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: John Snow
From: Sergio Lopez
Includes the following tests:
- Adding a dirty bitmap.
* RHBZ: 1782175
- Starting a drive-mirror to an NBD-backed target.
* RHBZ: 1746217, 1773517
- Aborting an external snapshot transaction.
* RHBZ: 1779036
- Aborting a blockdev backup transaction.
* RHBZ:
From: Sergio Lopez
Dirty map addition and removal functions are not acquiring to BDS
AioContext, while they may call to code that expects it to be
acquired.
This may trigger a crash with a stack trace like this one:
#0 0x7f0ef146370f in __GI_raise (sig=sig@entry=6)
at ../sysdeps/unix
From: Sergio Lopez
Fix a couple of minor coding style issues in drive_backup_prepare.
Signed-off-by: Sergio Lopez
Reviewed-by: Max Reitz
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
blockdev.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/
From: Thomas Huth
The python code already contains a possibility to skip tests if the
corresponding driver is not available in the qemu binary - use it
in more spots to avoid that the tests are failing if the driver has
been disabled.
While we're at it, we can now also remove some of the old che
From: Max Reitz
The "migration completed" event may be sent (on the source, to be
specific) before the migration is actually completed, so the VM runstate
will still be "finish-migrate" instead of "postmigrate". So ask the
users of VM.wait_migration() to specify the final runstate they desire
an
The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into
staging (2020-01-27 13:02:36 +)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
Am 27.01.2020 um 14:33 hat Markus Armbruster geschrieben:
> Maxim Levitsky writes:
>
> > On Wed, 2019-11-27 at 09:08 +0100, Markus Armbruster wrote:
> >> I think it makes sense to collect *all* block HMP stuff here.
> >>
> >> Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(), ...
>
On Mon, 2020-01-27 at 14:33 +0100, Markus Armbruster wrote:
> Maxim Levitsky writes:
>
> > On Wed, 2019-11-27 at 09:08 +0100, Markus Armbruster wrote:
> > > I think it makes sense to collect *all* block HMP stuff here.
> > >
> > > Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(),
On Mon, 2020-01-27 at 14:44 +0100, Markus Armbruster wrote:
> Maxim Levitsky writes:
>
> > On Wed, 2019-11-27 at 09:38 +0100, Markus Armbruster wrote:
> > > Title is too long. blockdev-hmp-cmds.c will become
> > > block/monitor/block-hmp-cmds.c in v2. With this in mind, suggest
> > >
> > >
Maxim Levitsky writes:
> On Wed, 2019-11-27 at 09:38 +0100, Markus Armbruster wrote:
>> Title is too long. blockdev-hmp-cmds.c will become
>> block/monitor/block-hmp-cmds.c in v2. With this in mind, suggest
>>
>> block/monitor: Prefer to use hmp_handle_error() to report HMP errors
>>
>> M
Maxim Levitsky writes:
> On Wed, 2019-11-27 at 09:08 +0100, Markus Armbruster wrote:
>> I think it makes sense to collect *all* block HMP stuff here.
>>
>> Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(), ...
>>
>> I guess hmp_change() has to stay there, because it's both block
On Fri, 24 Jan 2020 10:01:59 +
Stefan Hajnoczi wrote:
> Automatically size the number of request virtqueues to match the number
> of vCPUs. This ensures that completion interrupts are handled on the
> same vCPU that submitted the request. No IPI is necessary to complete
> an I/O request and
On Fri, 24 Jan 2020 10:01:58 +
Stefan Hajnoczi wrote:
> Automatically size the number of request virtqueues to match the number
> of vCPUs. This ensures that completion interrupts are handled on the
> same vCPU that submitted the request. No IPI is necessary to complete
> an I/O request and
On Fri, 24 Jan 2020 10:01:57 +
Stefan Hajnoczi wrote:
> Automatically size the number of request virtqueues to match the number
"If the pci transport is used, ..." ?
> of vCPUs. This ensures that completion interrupts are handled on the
> same vCPU that submitted the request. No IPI is ne
On Fri, 24 Jan 2020 10:01:56 +
Stefan Hajnoczi wrote:
> The event and control virtqueues are always present, regardless of the
> multi-queue configuration. Define a constant so that virtqueue number
> calculations are easier to read.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> hw/scsi/vhos
On 19/12/2019 15.42, Max Reitz wrote:
> First, driver=qcow2 will not work so well with non-qcow2 formats (and
> this test claims to support qcow, qed, and vmdk).
>
> Second, vmdk will always report the backing file format to be vmdk.
> Filter that out so the output looks like for all other formats
On Wed, 2019-11-27 at 09:38 +0100, Markus Armbruster wrote:
> Title is too long. blockdev-hmp-cmds.c will become
> block/monitor/block-hmp-cmds.c in v2. With this in mind, suggest
>
> block/monitor: Prefer to use hmp_handle_error() to report HMP errors
>
> Maxim Levitsky writes:
>
> > Thi
On Wed, 2019-11-27 at 09:08 +0100, Markus Armbruster wrote:
> I think it makes sense to collect *all* block HMP stuff here.
>
> Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(), ...
>
> I guess hmp_change() has to stay there, because it's both block and ui.
>
> Left in blockdev.c:
On Wed, 2019-11-27 at 08:22 +0100, Markus Armbruster wrote:
> Maxim Levitsky writes:
>
> > Signed-off-by: Maxim Levitsky
> > ---
> > blockdev-hmp-cmds.c | 61 +
> > monitor/hmp-cmds.c | 58 --
> > 2 files chang
On Wed, 2019-11-27 at 08:50 +0100, Markus Armbruster wrote:
> Maxim Levitsky writes:
>
> > Signed-off-by: Maxim Levitsky
> > ---
> > blockdev-hmp-cmds.c | 97 -
> > blockdev.c | 95
> > 2 files cha
On Wed, 2019-11-27 at 08:24 +0100, Markus Armbruster wrote:
> Maxim Levitsky writes:
>
> > Signed-off-by: Maxim Levitsky
> > ---
> > blockdev-hmp-cmds.c | 52 +
> > monitor/hmp-cmds.c | 52 -
> > 2 files ch
On Wed, 2019-11-27 at 08:29 +0100, Markus Armbruster wrote:
> Maxim Levitsky writes:
>
> > Signed-off-by: Maxim Levitsky
> > ---
> > blockdev-hmp-cmds.c | 97 -
> > blockdev.c | 95
> > 2 files cha
On Wed, 2019-11-27 at 08:13 +0100, Markus Armbruster wrote:
> Maxim Levitsky writes:
>
> > This is only used by hmp_drive_add.
> > The code is just a bit shorter this way.
> >
> > No functional changes
> >
> > Signed-off-by: Maxim Levitsky
> > ---
> > device-hotplug.c | 33 +--
On Mon, 2020-01-27 at 02:55 -0800, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20200127103647.17761-1-mlevi...@redhat.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
All of these errors are either fr
Patchew URL:
https://patchew.org/QEMU/20200127103647.17761-1-mlevi...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200127103647.17761-1-mlevi...@redhat.com
Subject: [PATCH v3 00/13] RFC: [for 5.0]: HMP
On 1/27/20 11:36 AM, Maxim Levitsky wrote:
Signed-off-by: Maxim Levitsky
---
hw/usb/dev-storage.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index 8545193488..50d12244ab 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -19,7 +
Signed-off-by: Maxim Levitsky
---
block/monitor/block-hmp-cmds.c | 30
blockdev.c | 42 +++---
include/block/block_int.h | 5 ++--
3 files changed, 41 insertions(+), 36 deletions(-)
diff --git a/block/monitor/block-hm
This way they all will be prefixed with 'Error:' which some parsers
(e.g libvirt) need
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1719169
Signed-off-by: Maxim Levitsky
---
block/monitor/block-hmp-cmds.c | 35 --
1 file changed, 21 insertions(+), 14 del
Signed-off-by: Maxim Levitsky
---
block/monitor/block-hmp-cmds.c | 88 ++
include/block/block-hmp-commands.h | 5 ++
include/monitor/hmp.h | 4 --
monitor/hmp-cmds.c | 87 -
4 files changed, 93 insertions(+
Signed-off-by: Maxim Levitsky
---
block/monitor/block-hmp-cmds.c | 138 +
include/block/block-hmp-commands.h | 9 ++
include/monitor/hmp.h | 6 --
monitor/hmp-cmds.c | 137
4 files changed, 147 insertion
Signed-off-by: Maxim Levitsky
---
block/monitor/block-hmp-cmds.c | 388 +
include/block/block-hmp-commands.h | 4 +
include/monitor/hmp.h | 4 -
monitor/hmp-cmds.c | 388 -
4 files changed, 392 insertions
Signed-off-by: Maxim Levitsky
---
block/monitor/block-hmp-cmds.c | 97 +-
blockdev.c | 95 -
include/block/block-hmp-commands.h | 3 +
include/sysemu/blockdev.h | 4 --
4 files changed, 99 insertions(+)
Signed-off-by: Maxim Levitsky
---
block/monitor/block-hmp-cmds.c | 64 ++
include/block/block-hmp-commands.h | 3 ++
include/monitor/hmp.h | 2 -
monitor/hmp-cmds.c | 58 ---
4 files changed, 67 insertions(+),
Signed-off-by: Maxim Levitsky
---
block/monitor/block-hmp-cmds.c | 47 ++
include/block/block-hmp-commands.h | 4 +++
include/monitor/hmp.h | 3 --
monitor/hmp-cmds.c | 47 --
4 files changed, 51 insertions
This patch series is bunch of cleanups
to the hmp monitor code.
This series only touched blockdev related hmp handlers.
No functional changes expected other that
light error message changes by the last patch.
This was inspired by this bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=1719169
Signed-off-by: Maxim Levitsky
---
block/monitor/block-hmp-cmds.c | 52 ++
include/block/block-hmp-commands.h | 6
include/monitor/hmp.h | 5 ---
monitor/hmp-cmds.c | 52 --
4 files changed, 58 insertio
This is only used by hmp_drive_add.
The code is just a bit shorter this way.
No functional changes
Signed-off-by: Maxim Levitsky
Reviewed-by: Markus Armbruster
---
device-hotplug.c | 31 ---
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/device-hotp
These days device-hotplug.c only contains the hmp_drive_add
In the next patch, rest of hmp_drive* functions will be moved
there.
Also change the license of that file to GPL2+ since most
of the code that will be moved there is under that license
Also add block-hmp-commands.h to contain prototypes
Signed-off-by: Maxim Levitsky
---
hw/usb/dev-storage.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index 8545193488..50d12244ab 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -19,7 +19,6 @@
#include "hw/scsi/scsi.h"
#include "u
On Fri, Jan 24, 2020 at 10:01:55AM +, Stefan Hajnoczi wrote:
> v2:
> * Let the virtio-DEVICE-pci device select num-queues because the optimal
>multi-queue configuration may differ between virtio-pci, virtio-mmio, and
>virtio-ccw [Cornelia]
>
> Enabling multi-queue on virtio-pci storag
On 1/24/20 5:26 PM, Peter Maydell wrote:
We want to add support for including rST document fragments
in our .hx files, in the same way we currently have texinfo
fragments. These will be delimited by SRST and ERST directives,
in the same way the texinfo is delimited by STEXI/ETEXI.
The rST fragmen
59 matches
Mail list logo
