Alexander Bulekov writes:
> On 200313 1805, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>
>
>> index 1a99277d60..aa9eee6ebf 100644
>> --- a/tests/qtest/fuzz/qos_fuzz.c
>> +++ b/tests/qtest/fuzz/qos_fuzz.c
>> @@ -57,8 +57,7 @@ static void qos_set_machines_devices_available(void)
Hi
On Fri, Mar 13, 2020 at 7:42 PM Philippe Mathieu-Daudé
wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé
Without looking at the rest of the series, I fail to see the
improvement, quite the opposite. A bit of context?
> ---
> qapi/char.json | 32
>
On Fri, 13 Mar 2020, BALATON Zoltan wrote:
The pci_ide_create_devs() function takes a hd_table parameter but all
callers just pass what ide_drive_get() returns so we can do it locally
simplifying callers and removing hd_table parameter.
Signed-off-by: BALATON Zoltan
---
hw/alpha/dp264.c
On 3/13/20 4:54 PM, Markus Armbruster wrote:
I append my hacked up version of auto-propagated-errp.cocci. It
produces the same patch as yours for the complete tree.
// Use ERRP_AUTO_PROPAGATE (see include/qapi/error.h)
//
//
// Usage example:
// spatch --sp-file
On 3/2/20 4:05 AM, Vladimir Sementsov-Ogievskiy wrote:
NBD driver may has max_pwrite_zeroes but doesn't has
max_pwrite_zeroes_no_fallback limit. This means, that (when
BDRV_REQ_NO_FALLBACK is supported) it is beneficial to try send request
with BDRV_REQ_NO_FALLBACK instead of splitting the
Vladimir Sementsov-Ogievskiy writes:
> 13.03.2020 18:42, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 12.03.2020 19:36, Markus Armbruster wrote:
I may have a second look tomorrow with fresher eyes, but let's get this
out now as is.
Vladimir
On 3/2/20 4:05 AM, Vladimir Sementsov-Ogievskiy wrote:
It's wrong to update head using num in this place, as num may be
reduced during the iteration, and we'll have wrong head value on next
iteration.
Instead update head at iteration end.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Vladimir
On 3/12/20 4:22 AM, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that the compression type is set on the image creation and
can be
The pci_ide_create_devs() function takes a hd_table parameter but all
callers just pass what ide_drive_get() returns so we can do it locally
simplifying callers and removing hd_table parameter.
Signed-off-by: BALATON Zoltan
---
hw/alpha/dp264.c | 13 +++--
hw/i386/pc_piix.c
After previous patches we don't need hw/pci/pci.h any more in
hw/ide.h. Some files depended on implicit inclusion by this header
which are also fixed up here.
Signed-off-by: BALATON Zoltan
---
hw/ide/ahci_internal.h| 1 +
include/hw/ide.h | 1 -
include/hw/ide/pci.h
We can move it next to the MAX_IDE_BUS define now that less files use
it.
Signed-off-by: BALATON Zoltan
---
include/hw/ide.h | 2 --
include/hw/ide/internal.h | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/ide.h b/include/hw/ide.h
index
After previous clean ups we can drop direct inclusion of hw/ide.h from
several places.
Signed-off-by: BALATON Zoltan
---
hw/hppa/hppa_sys.h | 1 -
hw/hppa/machine.c | 1 -
hw/i386/pc_piix.c | 1 -
hw/isa/piix4.c | 1 -
hw/mips/mips_fulong2e.c | 1 -
This removes pci_piix4_ide_init() function similar to clean up done to
other ide devices.
Signed-off-by: BALATON Zoltan
---
hw/ide/piix.c| 12 +---
hw/isa/piix4.c | 5 -
include/hw/ide.h | 1 -
3 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/hw/ide/piix.c
These are some clean ups to remove more legacy init functions and
lessen dependence on include/hw/ide.h with some simplifications in
board code. There should be no functional change.
BALATON Zoltan (8):
hw/ide: Get rid of piix3_init functions
hw/ide: Get rid of piix4_init function
hw/ide:
Spaces are required around a + operator and if statements should have
braces even for single line. Also make it simpler by reversing the
condition instead of breaking the loop.
Signed-off-by: BALATON Zoltan
---
hw/ide/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
This removes pci_piix3_ide_init() and pci_piix3_xen_ide_init()
functions similar to clean up done to other ide devices.
Signed-off-by: BALATON Zoltan
---
hw/i386/pc_piix.c | 10 +-
hw/ide/pci.c | 1 +
hw/ide/piix.c | 21 +
include/hw/ide.h | 2 --
4 files
There are several definitions of MAX_IDE_BUS in different boards (some
of them unused) with the same value. Move it to include/hw/ide/internal.h
to have it in a central place.
Signed-off-by: BALATON Zoltan
---
hw/alpha/dp264.c | 2 --
hw/hppa/machine.c | 2 --
hw/i386/pc_piix.c
Patchew URL: https://patchew.org/QEMU/20200313184153.11275-1-phi...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
Patchew URL: https://patchew.org/QEMU/20200313184153.11275-1-phi...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
On 3/2/20 4:05 AM, Vladimir Sementsov-Ogievskiy wrote:
NBD spec is updated, so that max_block doesn't relate to
Maybe: The NBD spec was recently updated to clarify that max_block...
NBD_CMD_WRITE_ZEROES with NBD_CMD_FLAG_FAST_ZERO (which mirrors Qemu
flag BDRV_REQ_NO_FALLBACK). To drop the
On Fri, 13 Mar 2020, John Snow wrote:
On 3/13/20 4:24 AM, Mark Cave-Ayland wrote:
Following on from the earlier thread "Implement "non 100% native mode"
in via-ide", here is an updated patchset based upon the test cases
sent to me off-list.
The VIA IDE controller is similar to early versions
On 3/13/20 9:24 AM, Mark Cave-Ayland wrote:
Signed-off-by: Mark Cave-Ayland
---
hw/ide/via.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/ide/via.c b/hw/ide/via.c
index 096de8dba0..84f0efff94 100644
--- a/hw/ide/via.c
+++ b/hw/ide/via.c
@@ -190,8 +190,6 @@ static
On 3/13/20 6:05 PM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
hw/block/xen-block.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index 3885464513..7b3b6dee97 100644
--- a/hw/block/xen-block.c
+++
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/machine.json | 131 +++
qapi/misc.json | 132
include/hw/mem/memory-device.h | 1 +
include/hw/virtio/virtio-pmem.h | 2 +-
4 files changed, 133
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/machine.json| 154 +++
qapi/misc.json | 154 ---
include/hw/acpi/acpi_dev_interface.h | 2 +-
hw/acpi/core.c | 2 +-
hw/acpi/cpu.c
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/machine.json | 20
qapi/misc.json| 21 -
hw/acpi/vmgenid.c | 2 +-
stubs/vmgenid.c | 2 +-
4 files changed, 22 insertions(+), 23 deletions(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/machine.json | 304 ++
qapi/misc.json| 304 --
hw/pci/pci-stub.c | 2 +-
hw/pci/pci.c | 2 +-
4 files changed, 306 insertions(+), 306 deletions(-)
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/block-core.json | 30 ++
qapi/misc.json | 30 --
block/iscsi.c| 2 +-
stubs/uuid.c | 2 +-
4 files changed, 32 insertions(+), 32 deletions(-)
diff --git
Move out x86-specific structures from generic machine code.
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/machine-target.json | 45 ++
qapi/machine.json | 42 ---
target/i386/cpu.c | 2 +-
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/char.json | 32
qapi/misc.json | 32
monitor/qmp-cmds.c | 1 +
3 files changed, 33 insertions(+), 32 deletions(-)
diff --git a/qapi/char.json b/qapi/char.json
index
This is the second part of a series reducing user-mode
dependencies. By stripping out unused code, the build
and testing time is reduced (as is space used by objects).
Part 2:
- Extract code not related to user-mode from qapi/misc.json
Based-on: <20200313183652.10258-1-phi...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/machine.json | 83 ++
qapi/misc.json | 83 --
include/sysemu/balloon.h | 2 +-
balloon.c | 2 +-
hw/virtio/virtio-balloon.c | 2 +-
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/machine.json| 32
qapi/misc.json | 32
include/hw/rtc/mc146818rtc.h | 2 +-
hw/core/qdev-properties.c| 1 +
hw/i386/kvm/i8254.c | 2 +-
5
On 3/12/20 2:28 PM, Eric Blake wrote:
Creating an image that requires format probing of the backing image is
inherently unsafe (we've had several CVEs over the years based on
probes leaking information to the guest on a subsequent boot, although
these days tools like libvirt are aware of the
On 3/9/20 10:31 AM, Kashyap Chamarthy wrote:
On Fri, Mar 06, 2020 at 04:51:21PM -0600, Eric Blake wrote:
Creating an image that requires format probing of the backing image is
inherently unsafe (we've had several CVEs over the years based on
+qemu-img backing file without format (since
On 3/13/20 12:05 PM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
hw/block/xen-block.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization:
On 3/13/20 12:05 PM, Markus Armbruster wrote:
Commit fe44dc9180 "migration: disallow migrate_add_blocker during
migration" accidentally added a second Error * variable. Use the
first one instead.
Signed-off-by: Markus Armbruster
---
hw/misc/ivshmem.c | 7 +++
1 file changed, 3
On 3/13/20 12:37 PM, Alexander Bulekov wrote:
On 200313 1805, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
index 1a99277d60..aa9eee6ebf 100644
--- a/tests/qtest/fuzz/qos_fuzz.c
+++ b/tests/qtest/fuzz/qos_fuzz.c
@@ -57,8 +57,7 @@ static void
On 3/13/20 4:24 AM, Mark Cave-Ayland wrote:
> Following on from the earlier thread "Implement "non 100% native mode"
> in via-ide", here is an updated patchset based upon the test cases
> sent to me off-list.
>
> The VIA IDE controller is similar to early versions of the PIIX
> controller in
On 200313 1805, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> index 1a99277d60..aa9eee6ebf 100644
> --- a/tests/qtest/fuzz/qos_fuzz.c
> +++ b/tests/qtest/fuzz/qos_fuzz.c
> @@ -57,8 +57,7 @@ static void qos_set_machines_devices_available(void)
> QList *lst;
> Error *err
On Fri, 13 Mar 2020 at 17:06, Markus Armbruster wrote:
>
> Markus Armbruster (3):
> Use _abort instead of separate assert()
> hw/misc/ivshmem: Use one Error * variable instead of two
> xen-block: Use one Error * variable instead of two
>
> block/monitor/block-hmp-cmds.c | 4 +---
>
Hello,
On Fri, 13 Mar 2020, Aleksandar Markovic wrote:
Hi, Mark, could you just enumerate those test images, download
locations, etc. and whatever else is needed to reproduce the boot
processes in question - it would be useful not only for this patch
set, but for possible future work, wouldn't
Commit fe44dc9180 "migration: disallow migrate_add_blocker during
migration" accidentally added a second Error * variable. Use the
first one instead.
Signed-off-by: Markus Armbruster
---
hw/misc/ivshmem.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
Signed-off-by: Markus Armbruster
---
block/monitor/block-hmp-cmds.c | 4 +---
target/arm/monitor.c | 8 ++--
tests/qtest/fuzz/qos_fuzz.c| 6 ++
3 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c
Signed-off-by: Markus Armbruster
---
hw/block/xen-block.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index 3885464513..7b3b6dee97 100644
--- a/hw/block/xen-block.c
+++ b/hw/block/xen-block.c
@@ -998,14 +998,13 @@ static
Markus Armbruster (3):
Use _abort instead of separate assert()
hw/misc/ivshmem: Use one Error * variable instead of two
xen-block: Use one Error * variable instead of two
block/monitor/block-hmp-cmds.c | 4 +---
hw/block/xen-block.c | 5 +
hw/misc/ivshmem.c | 7
> From: Mark Cave-Ayland
> This patchset effectively updates the VIA IDE PCI device to follow the
> behaviour in the datasheet in two ways: fixing some PCI configuration
> space register defaults and behaviours, and always using legacy IRQ 14/15
> routing, and once applied allows all our known
13.03.2020 18:42, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
12.03.2020 19:36, Markus Armbruster wrote:
I may have a second look tomorrow with fresher eyes, but let's get this
out now as is.
Vladimir Sementsov-Ogievskiy writes:
Script adds ERRP_AUTO_PROPAGATE macro
Vladimir Sementsov-Ogievskiy writes:
> 12.03.2020 19:36, Markus Armbruster wrote:
>> I may have a second look tomorrow with fresher eyes, but let's get this
>> out now as is.
>>
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
Vladimir Sementsov-Ogievskiy writes:
> 13.03.2020 10:50, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>> [...]
>>> +// Warn several Error * definitions.
>>> +@check1 disable optional_qualifier exists@
>>> +identifier fn = rule1.fn, local_err, local_err2;
>>> +@@
>>> +
>>>
13.03.2020 17:58, Markus Armbruster wrote:
I tried this script on the whole tree. Observations:
* $ git-diff --shortstat \*.[ch]
333 files changed, 3480 insertions(+), 4586 deletions(-)
* Twelve functions have "several definitions of Error * local variable".
Eight declare such a
I tried this script on the whole tree. Observations:
* $ git-diff --shortstat \*.[ch]
333 files changed, 3480 insertions(+), 4586 deletions(-)
* Twelve functions have "several definitions of Error * local variable".
Eight declare such a variable within a loop. Reported because
On Fri, 13 Mar 2020, Mark Cave-Ayland wrote:
Following on from the earlier thread "Implement "non 100% native mode"
in via-ide", here is an updated patchset based upon the test cases
sent to me off-list.
The VIA IDE controller is similar to early versions of the PIIX
controller in that the
With a QEMU bug, it can happen that the QEMU process doesn't react to a
'quit' QMP command. If we got an exception during previous QMP
communication (e.g. iotests Timeout expiring), we could also be in an
inconsistent state where after sending 'quit' we immediately read an old
response and close
Waiting for only 1 second proved to be too short on a loaded system,
resulting in false positives when testing pull requests. Increase the
timeout a bit to make this less likely.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/iotests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
With this, you can send SIGABRT to a hanging test case and you'll get a
Python stack trace so you know where it was hanging.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/iotests.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py
Peter ran into a 030 hang while testing a pull request. This turned out
to be two bugs in the test suite at once: First was the test failing
because a timeout was apparently too short, second was that the timeout
would actually cause the test to hang instead of failing. This series
should fix
The existing code uses fixed PCI IRQ routing on IRQ 14 rather than legacy IRQ
14/15 routing as documented in the datasheet.
With the changes in this patchset guest OSs now correctly detect and configure
the VIA controller in legacy IRQ routing mode, allowing the incorrect fixed
PCI IRQ routing to
According to both the VT82C686B and VT8231 datasheets the VIA Southbridge IDE
controller is initialised in legacy mode.
This allows Linux to correctly determine that legacy rather than PCI IRQ routing
should be used since the boot console text in the fulong2e test image changes
from:
scsi0 :
Some firmwares accidentally write to PCI_INTERRUPT_LINE on startup which has
no effect on real hardware since it is hard-wired to its default value, but
causes the guest OS to become confused trying to initialise IDE devices
when running under QEMU.
Signed-off-by: Mark Cave-Ayland
---
From: BALATON Zoltan
The pci_do_device_reset() function (called from pci_device_reset)
clears the PCI_INTERRUPT_LINE config reg of devices on the bus but did
this without taking wmask into account. We'll have a device model now
that needs to set a constant value for this reg and this patch
Signed-off-by: Mark Cave-Ayland
---
hw/ide/via.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/ide/via.c b/hw/ide/via.c
index 096de8dba0..84f0efff94 100644
--- a/hw/ide/via.c
+++ b/hw/ide/via.c
@@ -190,8 +190,6 @@ static void via_ide_realize(PCIDevice *dev, Error
Following on from the earlier thread "Implement "non 100% native mode"
in via-ide", here is an updated patchset based upon the test cases
sent to me off-list.
The VIA IDE controller is similar to early versions of the PIIX
controller in that the primary and secondary IDE channels are hardwired
to
From: BALATON Zoltan
Follow example of CMD646 and remove via_ide_init function and do it
directly in board code instead.
Signed-off-by: BALATON Zoltan
Reviewed-by: Mark Cave-Ayland
---
hw/ide/via.c| 8
hw/mips/mips_fulong2e.c | 5 -
include/hw/ide.h| 1 -
3
MorphOS writes to PCI_CLASS_PROG during IDE initialisation to place the
controller in native mode, but thinks the initialisation has failed
because the native mode bits aren't set when reading the register back.
Signed-off-by: Mark Cave-Ayland
---
hw/ide/via.c | 1 +
1 file changed, 1
13.03.2020 10:50, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
[...]
+// Warn several Error * definitions.
+@check1 disable optional_qualifier exists@
+identifier fn = rule1.fn, local_err, local_err2;
+@@
+
+ fn(..., Error ** , ...)
+ {
+ ...
+ Error *local_err =
Vladimir Sementsov-Ogievskiy writes:
[...]
> +// Warn several Error * definitions.
> +@check1 disable optional_qualifier exists@
> +identifier fn = rule1.fn, local_err, local_err2;
> +@@
> +
> + fn(..., Error ** , ...)
> + {
> + ...
> + Error *local_err = NULL;
> + ... when any
>
12.03.2020 23:41, John Snow wrote:
On 3/12/20 1:59 AM, Vladimir Sementsov-Ogievskiy wrote:
11.03.2020 20:03, John Snow wrote:
On 3/11/20 9:58 AM, Vladimir Sementsov-Ogievskiy wrote:
11.03.2020 12:55, Max Reitz wrote:
On 11.03.20 07:17, Vladimir Sementsov-Ogievskiy wrote:
10.03.2020
13.03.2020 2:09, John Snow wrote:
On 3/12/20 4:19 AM, Vladimir Sementsov-Ogievskiy wrote:
Prior to 1143ec5ebf4 it was OK to qemu_iovec_from_buf() from aligned-up
buffer to original qiov, as qemu_iovec_from_buf() will stop at qiov end
anyway.
But after 1143ec5ebf4 we assume that
12.03.2020 17:24, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
v9
01: A lot of rewordings [thanks to Eric]
Still, keep all r-b marks, assuming that they are mostly about macro
definition
02: significant changes are:
1. Do not match double propagation pattern in
12.03.2020 19:36, Markus Armbruster wrote:
I may have a second look tomorrow with fresher eyes, but let's get this
out now as is.
Vladimir Sementsov-Ogievskiy writes:
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
does corresponding changes in code (look for details
71 matches
Mail list logo
