Re: [PATCH 7/7] block: apply COR-filter to block-stream jobs

2020-04-26 Thread Vladimir Sementsov-Ogievskiy
27.04.2020 7:08, Andrey Shinkevich wrote: 1. The mirror technology instantiates its own BLK, sets 0/BLK_PERM_ALL for it on exit and then, via subsequent call to bdrv_child_refresh_perms(), calls bdrv_child_try_set_perm(). We don't have the extra BLK for our filter in stream and do call the sam

Re: [PATCH 0/7] Apply COR-filter to the block-stream permanently

2020-04-26 Thread Andrey Shinkevich
I am going to do that in version 3. Please review the changes in the version 2 first. Thanks, Andrey From: Vladimir Sementsov-Ogievskiy Sent: Tuesday, April 21, 2020 4:12 PM To: Andrey Shinkevich ; qemu-block@nongnu.org Cc: qemu-de...@nongnu.org ; kw...@redhat.

Re: [PATCH 7/7] block: apply COR-filter to block-stream jobs

2020-04-26 Thread Andrey Shinkevich
1. The mirror technology instantiates its own BLK, sets 0/BLK_PERM_ALL for it on exit and then, via subsequent call to bdrv_child_refresh_perms(), calls bdrv_child_try_set_perm(). We don't have the extra BLK for our filter in stream and do call the same function directly. 2. The function remove

Re: [RFC PATCH v1 3/7] char-socket: initialize reconnect timer only if close is emitted

2020-04-26 Thread Li Feng
This patch is trying to fix the same issue with me. However, our fix is different. I think that check the s->reconnect_timer is better. Thanks, Feng Li Marc-André Lureau 于2020年4月24日周五 上午3:16写道: > > Hi > > On Thu, Apr 23, 2020 at 8:41 PM Dima Stepanov wrote: > > > > During vhost-user reconnec