On 6/5/20 4:56 PM, Markus Armbruster wrote:
> We always pass _abort. Drop the parameter, use _abort
> directly.
>
> Cc: Cédric Le Goater
> Cc: Peter Maydell
> Cc: Andrew Jeffery
> Cc: Joel Stanley
> Cc: qemu-...@nongnu.org
> Signed-off-by: Markus Armbruster
Reviewed-by: Philippe
On 6/8/20 7:20 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
>> On 6/5/20 4:56 PM, Markus Armbruster wrote:
>>> qdev_prop_set_drive() can fail. None of the other qdev_prop_set_FOO()
>>> can; they abort on error.
>>>
>>> To clean up this inconsistency, rename
From: Vladimir Sementsov-Ogievskiy
Sent: Saturday, June 6, 2020 11:18 AM
To: qemu-block@nongnu.org
Cc: qemu-de...@nongnu.org ; mre...@redhat.com
; kw...@redhat.com ; ebl...@redhat.com
; Denis Lunev ; Andrey Shinkevich
; Vladimir Sementsov-Ogievskiy
Philippe Mathieu-Daudé writes:
> On 6/5/20 4:56 PM, Markus Armbruster wrote:
>> qdev_prop_set_drive() can fail. None of the other qdev_prop_set_FOO()
>> can; they abort on error.
>>
>> To clean up this inconsistency, rename qdev_prop_set_drive() to
>> qdev_prop_set_drive_err(), and create a
Philippe Mathieu-Daudé writes:
[...]
> Why warn_reportf_err() doesn't take a 'Error **err' instead, to set err
> to NULL after freeing *err?
Why doesn't free() take a void ** argument, to set the pointer to null
after freeing what it points to? Why doesn't close() take an int *
argument?
On Sun, 2020-06-07 at 15:51 +0300, Maxim Levitsky wrote:
> On Tue, 2020-06-02 at 17:31 +0200, Kevin Wolf wrote:
> > Am 14.05.2020 um 06:45 hat Klaus Jensen geschrieben:
> > > From: Klaus Jensen
> > >
> > > Changes since v5
> > >
> > > * Prefixed all patches with "hw/block/nvme"
On Tue, 2020-06-02 at 18:29 +0200, Max Reitz wrote:
> On 18.05.20 14:20, Maxim Levitsky wrote:
> > Hi!
> > Here is the updated series of my patches, incorporating all the feedback I
> > received.
>
> You asked me on IRC what to do to get this series to move forward;
> considering I don’t think
On Tue, 2020-06-02 at 17:31 +0200, Kevin Wolf wrote:
> Am 14.05.2020 um 06:45 hat Klaus Jensen geschrieben:
> > From: Klaus Jensen
> >
> > Changes since v5
> >
> > * Prefixed all patches with "hw/block/nvme" to avoid confusion with the
> > nvme block driver.
> >
> > * Added
