Re: [PATCH v9 00/10] acpi: i386 tweaks

2020-06-18 Thread Michael S. Tsirkin
On Wed, Jun 17, 2020 at 09:11:28AM +0200, Gerd Hoffmann wrote: > First batch of microvm patches, some generic acpi stuff. > Split the acpi-build.c monster, specifically split the > pc and q35 and pci bits into a separate file which we > can skip building at some point in the future. Thanks for

Re: [PATCH v9 08/10] acpi: drop serial/parallel enable bits from dsdt

2020-06-18 Thread Michael S. Tsirkin
On Wed, Jun 17, 2020 at 09:11:36AM +0200, Gerd Hoffmann wrote: > The _STA methods for COM+LPT used to reference them, > but that isn't the case any more. > > piix4 DSDT changes: > > Scope (_SB.PCI0) > { > Device (ISA) > { > Name (_ADR, 0x0001) //

Re: [PATCH v9 02/10] acpi: move aml builder code for floppy device

2020-06-18 Thread Michael S. Tsirkin
On Wed, Jun 17, 2020 at 09:11:30AM +0200, Gerd Hoffmann wrote: > DSDT change: isa device order changes in case MI1 (ipmi) is present. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Igor Mammedov > --- Pls follow process outlined at the top of tests/qtest/bios-tables-test.c Don't change

Re: [PATCH v9 05/10] acpi: move aml builder code for i8042 (kbd+mouse) device

2020-06-18 Thread Michael S. Tsirkin
On Wed, Jun 17, 2020 at 09:11:33AM +0200, Gerd Hoffmann wrote: > DSDT change: isa device order changes in case MI1 (ipmi) is present. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c| 39

Re: [PATCH] iotests: don't test qcow2.py inside 291

2020-06-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200618154052.8629-1-vsement...@virtuozzo.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v9 4/5] vhost-user block device backend server

2020-06-18 Thread Kevin Wolf
Am 14.06.2020 um 20:39 hat Coiby Xu geschrieben: > By making use of libvhost-user, block device drive can be shared to > the connected vhost-user client. Only one client can connect to the > server one time. > > Since vhost-user-server needs a block drive to be created first, delay > the creation

Re: [PATCH] iotests: don't test qcow2.py inside 291

2020-06-18 Thread Eric Blake
On 6/18/20 10:40 AM, Vladimir Sementsov-Ogievskiy wrote: 820c6bee534ec3b added testing of qcow2.;y into 291, and it breaks 291 s/;y/py/ with external data file. Actually, 291 is bad place for qcow2.py testing, better add a separate test. Now, drop qcow2.py testing from 291 to fix

[PATCH] iotests: don't test qcow2.py inside 291

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
820c6bee534ec3b added testing of qcow2.;y into 291, and it breaks 291 with external data file. Actually, 291 is bad place for qcow2.py testing, better add a separate test. Now, drop qcow2.py testing from 291 to fix regression. Fixes: 820c6bee534ec3b Reported-by: Max Reitz Signed-off-by:

Re: [PULL 14/15] qcow2_format.py: dump bitmaps header extension

2020-06-18 Thread Max Reitz
On 18.06.20 15:28, Vladimir Sementsov-Ogievskiy wrote: > 18.06.2020 16:13, Max Reitz wrote: >> On 09.06.20 22:52, Eric Blake wrote: >>> From: Vladimir Sementsov-Ogievskiy >>> >>> Add class for bitmap extension and dump its fields. Further work is to >>> dump bitmap directory. >>> >>> Test new

[PATCH v3 1/2] iotests: Make _filter_img_create more active

2020-06-18 Thread Max Reitz
Right now, _filter_img_create just filters out everything that looks format-dependent, and applies some filename filters. That means that we have to add another filter line every time some format gets a new creation option. This can be avoided by instead discarding everything and just keeping

[PATCH v3 2/2] iotests: filter few more luks specific create options

2020-06-18 Thread Max Reitz
From: Maxim Levitsky This allows more tests to be able to have same output on both qcow2 luks encrypted images and raw luks images Signed-off-by: Maxim Levitsky Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/087.out | 6 +++--- tests/qemu-iotests/134.out

[PATCH v3 0/2] iotests: Make _filter_img_create more active

2020-06-18 Thread Max Reitz
v1 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00748.html v2 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00931.html Hi, I somehow missed running iotests where qemu-img create fails, like 111. v2 broke it because in contrast to v1, it

Re: [PATCH v3 08/17] block/io: support int64_t bytes in bdrv_aligned_preadv()

2020-06-18 Thread Eric Blake
On 6/18/20 9:35 AM, Alberto Garcia wrote: On Fri 22 May 2020 05:14:36 PM CEST, Eric Blake wrote: static int coroutine_fn bdrv_aligned_preadv(BdrvChild *child, -BdrvTrackedRequest *req, int64_t offset, unsigned int bytes, +BdrvTrackedRequest *req, int64_t offset, int64_t bytes,

Re: [PATCH v3 08/17] block/io: support int64_t bytes in bdrv_aligned_preadv()

2020-06-18 Thread Alberto Garcia
On Fri 22 May 2020 05:14:36 PM CEST, Eric Blake wrote: >> static int coroutine_fn bdrv_aligned_preadv(BdrvChild *child, >> -BdrvTrackedRequest *req, int64_t offset, unsigned int bytes, >> +BdrvTrackedRequest *req, int64_t offset, int64_t bytes, >> int64_t align, QEMUIOVector *qiov,

Re: [PULL 00/43] Block layer patches

2020-06-18 Thread Peter Maydell
On Wed, 17 Jun 2020 at 15:49, Kevin Wolf wrote: > > The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging > (2020-06-16 14:57:15 +0100) > > are available in the Git

Re: [PATCH v3 06/17] block/io: support int64_t bytes in bdrv_aligned_pwritev()

2020-06-18 Thread Alberto Garcia
On Thu 30 Apr 2020 01:10:22 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > >

Re: [PULL 14/15] qcow2_format.py: dump bitmaps header extension

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
18.06.2020 16:13, Max Reitz wrote: On 09.06.20 22:52, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Add class for bitmap extension and dump its fields. Further work is to dump bitmap directory. Test new functionality inside 291 iotest. Unfortunately, it also breaks 291 with an

Re: [PULL 14/15] qcow2_format.py: dump bitmaps header extension

2020-06-18 Thread Max Reitz
On 09.06.20 22:52, Eric Blake wrote: > From: Vladimir Sementsov-Ogievskiy > > Add class for bitmap extension and dump its fields. Further work is to > dump bitmap directory. > > Test new functionality inside 291 iotest. Unfortunately, it also breaks 291 with an external data file, which worked

Re: [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible

2020-06-18 Thread Paolo Bonzini
On 18/06/20 14:26, Philippe Mathieu-Daudé wrote: >> This is in principle a very good idea; however, util/qemu-timer.c does >> not use the scale to coalesce low-precision timers with nearby >> high-precision ones. > IOW this doesn't reduce the pressure, but simply makes the code easier? Easier, or

Re: [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible

2020-06-18 Thread Philippe Mathieu-Daudé
On 6/18/20 2:23 PM, Paolo Bonzini wrote: > On 16/06/20 09:51, Philippe Mathieu-Daudé wrote: >> This series contains few patches resulting from the notes I >> took while reviewing Mark ADB series last Sunday, in particular: >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg712078.html >> >>

Re: [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible

2020-06-18 Thread Paolo Bonzini
On 16/06/20 09:51, Philippe Mathieu-Daudé wrote: > This series contains few patches resulting from the notes I > took while reviewing Mark ADB series last Sunday, in particular: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg712078.html > > I have another patch for hw/input/hid.c but I

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-06-18 Thread Alberto Garcia
On Wed 03 Jun 2020 03:53:03 PM CEST, Max Reitz wrote: > Sorry for the long delay. :/ And sorry for my long delay as well. > The patch itself looks good, but I’m not sure whether it is extensive > enough. Let me just jump straight to the problem: > > $ ./qemu-img create -f qcow2 \ > -o

Re: [PATCH 5/5] block/io: improve savevm performance

2020-06-18 Thread Denis V. Lunev
On 6/18/20 1:56 PM, Vladimir Sementsov-Ogievskiy wrote: > 16.06.2020 19:20, Denis V. Lunev wrote: >> This patch does 2 standard basic things: >> - it creates intermediate buffer for all writes from QEMU migration code >>    to block driver, >> - this buffer is sent to disk asynchronously, allowing

Re: [PATCH 5/5] block/io: improve savevm performance

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
16.06.2020 19:20, Denis V. Lunev wrote: This patch does 2 standard basic things: - it creates intermediate buffer for all writes from QEMU migration code to block driver, - this buffer is sent to disk asynchronously, allowing several writes to run in parallel. Thus bdrv_vmstate_write() is

Re: [PATCH] block: Raise an error when backing file parameter is an empty string

2020-06-18 Thread Alberto Garcia
On Wed 17 Jun 2020 08:27:25 PM CEST, Connor Kuehl wrote: > Providing an empty string for the backing file parameter like so: > > qemu-img create -f qcow2 -b '' /tmp/foo > > allows the flow of control to reach and subsequently fail an assert > statement because passing an empty string to > >

Re: [PATCH 4/5] block, migration: add bdrv_flush_vmstate helper

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2020 00:29, Denis V. Lunev wrote:   if (ret < 0) {   return ret;   } ...attempting it here, at which point it looks like the only reason you need ret2 is to preserve ret long enough... no, I would like to be sure that intermediate state is always cleared at the end. In

Re: [PATCH 4/5] block, migration: add bdrv_flush_vmstate helper

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
16.06.2020 19:20, Denis V. Lunev wrote: Right now bdrv_fclose() is just calling bdrv_flush(). The problem is that migration code is working inefficently from black layer terms and are frequently called for very small pieces of not properly aligned data. Block layer is capable to work this way,

Re: [PATCH 2/5] block/aio_task: allow start/wait task from any coroutine

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
16.06.2020 19:20, Denis V. Lunev wrote: From: Vladimir Sementsov-Ogievskiy Currently, aio task pool assumes that there is a main coroutine, which creates tasks and wait for them. Let's remove the restriction by using CoQueue. Code becomes clearer, interface more obvious. Signed-off-by:

Re: [PATCH 3/5] block/aio_task: drop aio_task_pool_wait_one() helper

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
16.06.2020 19:20, Denis V. Lunev wrote: It is not used outside the module. Actually there are 2 kind of waiters: - for a slot and - for all tasks to finish This patch limits external API to listed types. Signed-off-by: Denis V. Lunev Suggested-by: Vladimir Sementsov-Ogievskiy Reviewed-by:

Re: [PATCH RESEND v2 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-06-18 Thread Klaus Jensen
On Jun 16 22:18, Andrzej Jakowski wrote: > So far it was not possible to have CMB and PMR emulated on the same > device, because BAR2 was used exclusively either of PMR or CMB. This > patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors. > > Signed-off-by: Andrzej Jakowski >

Re: [PATCH 0/7] python: create installable package

2020-06-18 Thread Kevin Wolf
Am 17.06.2020 um 22:27 hat John Snow geschrieben: > > In the Avocado project, we have a `make develop` rule that does that > > for the main setup.py file, and for all plugins we carry on the same > > tree, which is similar in some regards to the "not at the project root > > directory" situation

Re: [PATCH v2 1/2] iotests: Make _filter_img_create more active

2020-06-18 Thread Maxim Levitsky
On Thu, 2020-06-18 at 10:37 +0200, Max Reitz wrote: > Right now, _filter_img_create just filters out everything that looks > format-dependent, and applies some filename filters. That means that we > have to add another filter line every time some format gets a new > creation option. This can be

[PATCH v2 2/2] iotests: filter few more luks specific create options

2020-06-18 Thread Max Reitz
From: Maxim Levitsky This allows more tests to be able to have same output on both qcow2 luks encrypted images and raw luks images Signed-off-by: Maxim Levitsky Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/087.out | 6 +++--- tests/qemu-iotests/134.out

[PATCH v2 0/2] iotests: Make _filter_img_create more active

2020-06-18 Thread Max Reitz
v1 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00748.html Hi, Here in v2, I addressed Maxim’s comments for patch 1: - Separate _filter_img_create_in_qmp from _filter_img_create - Add a rough comment what the readarray invocation is for - Use $SED everywhere

[PATCH v2 1/2] iotests: Make _filter_img_create more active

2020-06-18 Thread Max Reitz
Right now, _filter_img_create just filters out everything that looks format-dependent, and applies some filename filters. That means that we have to add another filter line every time some format gets a new creation option. This can be avoided by instead discarding everything and just keeping

Re: [PATCH v3] block: Factor out bdrv_run_co()

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2020 16:46, Stefan Hajnoczi wrote: On Thu, May 28, 2020 at 08:38:04PM +0300, Vladimir Sementsov-Ogievskiy wrote: 28.05.2020 18:17, Stefan Hajnoczi wrote: On Wed, May 20, 2020 at 05:49:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: We have a few bdrv_*() functions that can either spawn