Re: [PATCH 08/46] error: Avoid unnecessary error_propagate() after error_setg()

2020-06-27 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> Replace >> >> error_setg(&err, ...); >> error_propagate(errp, err); >> >> by >> >> error_setg(errp, ...); >> >> Related pattern: >> >> if (...) { >> error_setg(&err, ...); >>

Re: [PATCH 06/46] error: Avoid error_propagate() when error is not used here

2020-06-27 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> When all we do with an Error we receive into a local variable is >> propagating to somewhere else, we can just as well receive it there >> right away. Coccinelle script: >> >> @@ >> identifier fun, err

Re: [PATCH 07/46] error: Avoid more error_propagate() when error is not used here

2020-06-27 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> When all we do with an Error we receive into a local variable is >> propagating to somewhere else, we can just as well receive it there >> right away. The previous commit did that for simple cases with >> Coccin

Re: [PATCH v2 00/16] Crazy shit around -global (pardon my french)

2020-06-27 Thread Markus Armbruster
Cc: David for insurance against me spewing nonsense about migration. John Snow writes: > On 6/25/20 12:45 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 6/22/20 5:42 AM, Markus Armbruster wrote: There are three ways to configure backends: * -nic, -serial, -drive, ..

Re: [PATCH v5] osdep: Make MIN/MAX evaluate arguments only once

2020-06-27 Thread Richard Henderson
On 6/25/20 9:26 AM, Eric Blake wrote: > I'm not aware of any immediate bugs in qemu where a second runtime > evaluation of the arguments to MIN() or MAX() causes a problem, but > proactively preventing such abuse is easier than falling prey to an > unintended case down the road. At any rate, here'

RE: [PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize()

2020-06-27 Thread Gonglei (Arei)
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Thursday, June 25, 2020 12:43 AM > To: qemu-de...@nongnu.org > Cc: pbonz...@redhat.com; berra...@redhat.com; ehabk...@redhat.com; > qemu-block@nongnu.org; peter.mayd...@linaro.org; > vsement...@virtuozzo.com