Description of problem:
Qemu core dump when stop guest with virtio-blk(remote storage) and
iothread
Version-Release number pf selected component (if applicable):
kernel version:4.19.36.bsk.9-amd64
qemu-kvm version:QEMU emulator version 2.12.1
How reproducible:
100
On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote:
> There are a number of unnecessary trailing whitespaces that have
> accumulated over time in the source code. They cause stray changes
> in patches if you use tools that automatically remove them.
>
> Tested by doing a `git d
07.07.2020 18:56, Stefan Hajnoczi wrote:
On Sat, Jun 20, 2020 at 05:36:45PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Introduce a function to mark the request serialising only if there are
no conflicting request to wait for.
The function is static, so mark it unused. The attribute is to be
dro
07.07.2020 19:10, Stefan Hajnoczi wrote:
On Sat, Jun 20, 2020 at 05:36:46PM +0300, Vladimir Sementsov-Ogievskiy wrote:
@@ -83,6 +84,12 @@ typedef struct BdrvTrackedRequest {
CoQueue wait_queue; /* coroutines blocked on this request */
struct BdrvTrackedRequest *waiting_for;
+
+
08.07.2020 15:07, Stefan Hajnoczi wrote:
On Sat, Jun 20, 2020 at 05:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote:
It may be used for file-systems with slow allocation.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 3 +-
block/preallocate.c | 255
On Tue, Jul 07, 2020 at 05:26:13PM +0200, Kevin Wolf wrote:
> Am 06.07.2020 um 21:43 hat Keith Busch geschrieben:
> > The nvme emulated device development pace has increased recently. Klaus
> > has offered to co-maintain, and since we have many new contributions
> > coming through, we're adding a
On 25.06.2020 18:21, Max Reitz wrote:
v6: https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html
Branch: https://github.com/XanClic/qemu.git child-access-functions-v7
Branch: https://git.xanclic.moe/XanClic/qemu.git child-access-functions-v7
I cloned the branch from the github
On 25.06.2020 18:21, Max Reitz wrote:
Add some helper functions for skipping filters in a chain of block
nodes.
Signed-off-by: Max Reitz
---
include/block/block_int.h | 3 +++
block.c | 55 +++
2 files changed, 58 insertions(+)
diff --
On 25.06.2020 18:21, Max Reitz wrote:
There are BDS children that the general block layer code can access,
namely bs->file and bs->backing. Since the introduction of filters and
external data files, their meaning is not quite clear. bs->backing can
be a COW source, or it can be a filtered chi
On 25.06.2020 18:21, Max Reitz wrote:
bdrv_has_zero_init() and the related bdrv_unallocated_blocks_are_zero()
should use bdrv_cow_child() if they want to check whether the given BDS
has a COW backing file.
Signed-off-by: Max Reitz
---
block.c | 4 ++--
1 file changed, 2 insertions(+), 2 de
On 25.06.2020 18:21, Max Reitz wrote:
bdrv_set_backing_hd() is a function that explicitly cares about the
bs->backing child. Highlight that in its description and use
child_bs(bs->backing) instead of backing_bs(bs) to make it more obvious.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sements
On 25.06.2020 18:21, Max Reitz wrote:
In order to make filters work in backing chains, the associated
functions must be able to deal with them and freeze both COW and filter
child links.
While at it, add some comments that note which functions require their
caller to ensure that a given child li
On 25.06.2020 18:21, Max Reitz wrote:
The original purpose of bdrv_is_encrypted() was to inquire whether a BDS
can be used without the user entering a password or not. It has not
been used for that purpose for quite some time.
Actually, it is not even fit for that purpose, because to answer tha
On 25.06.2020 18:21, Max Reitz wrote:
Filters cannot compress data themselves but they have to implement
.bdrv_co_pwritev_compressed() still (or they cannot forward compressed
writes). Therefore, checking whether
bs->drv->bdrv_co_pwritev_compressed is non-NULL is not sufficient to
know whether t
On 25.06.2020 18:21, Max Reitz wrote:
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/throttle.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/throttle.c b/block/throttle.c
index 0ebbad0743..f6e619aca2 100644
--- a/block/throttle.c
+++ b/b
On 25.06.2020 18:21, Max Reitz wrote:
Signed-off-by: Max Reitz
---
block/copy-on-read.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/block/copy-on-read.c b/block/copy-on-read.c
index a6e3c74a68..a6a864f147 100644
--- a/block/copy-on-read.c
+++ b/block/copy-on-read.c
@@ -10
On 25.06.2020 18:21, Max Reitz wrote:
Signed-off-by: Max Reitz
---
block/mirror.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/mirror.c b/block/mirror.c
index e8e8844afc..469acf4600 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -1480,6 +1480,15 @@ static int cor
On 25.06.2020 18:21, Max Reitz wrote:
Signed-off-by: Max Reitz
---
block/backup-top.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/backup-top.c b/block/backup-top.c
index af2f20f346..f304df8f26 100644
--- a/block/backup-top.c
+++ b/block/backup-top.c
@@ -99,6 +99,15 @
On 25.06.2020 18:21, Max Reitz wrote:
Places that use patterns like
if (bs->drv->is_filter && bs->file) {
... something about bs->file->bs ...
}
should be
BlockDriverState *filtered = bdrv_filter_bs(bs);
if (filtered) {
... something about @filtered ...
03.07.2020 20:35, Denis V. Lunev wrote:
This patch creates intermediate buffer for reading from block driver
state and performs read-ahead to this buffer. Snapshot code performs
reads sequentially and thus we know what offsets will be required
and when they will become not needed.
Results are fa
On 25.06.2020 18:21, Max Reitz wrote:
Use the child access functions in the block status inquiry functions as
appropriate.
Signed-off-by: Max Reitz
---
block/io.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/block/io.c b/block/io.c
index 385176b331
Looks good with a small nit (see below),
Reviewed-by: Dmitry Fomichev
>
On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add missing fields in the Identify Controller and Identify Namespace
> data structures to bring them in line with NVMe v1.3.
>
> This also a
Looks good,
Reviewed-by: Dmitry Fomichev
> On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add various additional tracing and streamline nvme_identify_ns and
> nvme_identify_nslist (they do not need to repeat the command, it is
> already in the trace name).
>
>
Looks good,
Reviewed-by: Dmitry Fomichev
> On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Fix a missing cpu_to conversion by moving conversion to just before
> returning instead.
>
> Signed-off-by: Klaus Jensen
> Suggested-by: Philippe Mathieu-Daudé
> ---
>
Looks good,
Reviewed-by: Dmitry Fomichev
On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add support for the Get Log Page command and basic implementations of
> the mandatory Error Information, SMART / Health Information and Firmware
> Slot Information log pages
Looks good,
Reviewed-by: Dmitry Fomichev
On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Since the device does not have any persistent state storage, no
> features are "saveable" and setting the Save (SV) field in any Set
> Features command will result in a Feat
Looks good,
Reviewed-by: Dmitry Fomichev
On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> It might seem weird to implement this feature for an emulated device,
> but it is mandatory to support and the feature is useful for testing
> asynchronous event request sup
Looks good,
Reviewed-by: Dmitry Fomichev
On Mon, 2020-07-06 at 08:13 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> The SUBNQN field is mandatory in NVM Express 1.3.
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/h
Looks good,
Reviewed-by: Dmitry Fomichev
On Mon, 2020-07-06 at 08:13 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Reject the nsid broadcast value (0x) and 0xfffe in the
> Active Namespace ID list.
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 10 ++
>
On 08.07.2020 20:32, Eric Blake wrote:
On 7/8/20 12:20 PM, Andrey Shinkevich wrote:
On 25.06.2020 18:21, Max Reitz wrote:
v6:
https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html
Branch: https://github.com/XanClic/qemu.git child-access-functions-v7
Branch: https://git.xanc
On Jul 8 19:19, Dmitry Fomichev wrote:
> Looks good with a small nit (see below),
>
> Reviewed-by: Dmitry Fomichev
>
> >
> On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> > +#define NVME_TEMP_TMPTH(temp) ((temp >> 0) & 0x)
>
> There is an extra space after temp >>
>
Good catch
On Mon, Jun 08, 2020 at 12:40:27PM +0300, Maxim Levitsky wrote:
> blockdev-amend will be used similiar to blockdev-create
> to allow on the fly changes of the structure of the format based block
> devices.
This one breaks the build:
In file included from
/home/kraxel/projects/qemu/include/block
On 7/8/20 12:20 PM, Andrey Shinkevich wrote:
On 25.06.2020 18:21, Max Reitz wrote:
v6:
https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html
Branch: https://github.com/XanClic/qemu.git child-access-functions-v7
Branch: https://git.xanclic.moe/XanClic/qemu.git
child-access-fun
On Mon, Jul 06, 2020 at 09:31:21AM -0700, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20200706162300.1084753-1-dinec...@redhat.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [PATCH] tri
Am 08.07.2020 um 06:07 hat 苏思婷 geschrieben:
> Description of problem:
> Qemu core dump when stop guest with virtio-blk(remote storage) and
> iothread
>
> Version-Release number pf selected component (if applicable):
> kernel version:4.19.36.bsk.9-amd64
> qemu-kvm version:QEMU em
> -Original Message-
> From: Klaus Jensen
> Sent: Wednesday, July 8, 2020 5:24 PM
> To: Dmitry Fomichev
> Cc: qemu-block@nongnu.org; qemu-de...@nongnu.org; f...@euphon.net;
> javier.g...@samsung.com; kw...@redhat.com; mre...@redhat.com;
> mlevi...@redhat.com; phi...@redhat.com; kbu...@ke
Am 08.07.2020 um 17:11 hat Maxim Levitsky geschrieben:
> On Tue, 2020-07-07 at 21:40 +0100, Peter Maydell wrote:
> > Applied, thanks.
> >
> > Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
> > for any user-visible changes.
>
> Since this includes my luks patches, I guess I nee
On 7/8/20 2:46 PM, Andrey Shinkevich wrote:
On 08.07.2020 20:32, Eric Blake wrote:
On 7/8/20 12:20 PM, Andrey Shinkevich wrote:
On 25.06.2020 18:21, Max Reitz wrote:
v6:
https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html
Branch: https://github.com/XanClic/qemu.git child-
On Wed, Jul 08, 2020 at 04:06:45PM +0300, Maxim Levitsky wrote:
> On Wed, 2020-07-08 at 14:33 +0200, Gerd Hoffmann wrote:
> > On Mon, Jun 08, 2020 at 12:40:27PM +0300, Maxim Levitsky wrote:
> > > blockdev-amend will be used similiar to blockdev-create
> > > to allow on the fly changes of the struct
On 7/8/20 12:20 PM, Andrey Shinkevich wrote:
On 25.06.2020 18:21, Max Reitz wrote:
v6:
https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html
Branch: https://github.com/XanClic/qemu.git child-access-functions-v7
Branch: https://git.xanclic.moe/XanClic/qemu.git
child-access-fun
On Wed, 2020-07-08 at 18:11 +0300, Maxim Levitsky wrote:
> On Tue, 2020-07-07 at 21:40 +0100, Peter Maydell wrote:
> > On Mon, 6 Jul 2020 at 11:04, Max Reitz wrote:
> > > The following changes since commit
> > > eb6490f544388dd24c0d054a96dd304bc7284450:
> > >
> > > Merge remote-tracking branch
On Wed, 8 Jul 2020 14:05:26 +0100
Stefan Hajnoczi wrote:
> On Tue, Jul 07, 2020 at 05:44:53PM +0200, Cornelia Huck wrote:
> > On Mon, 6 Jul 2020 14:56:48 +0100
> > Stefan Hajnoczi wrote:
> > > diff --git a/hw/virtio/virtio-scsi-pci.c b/hw/virtio/virtio-scsi-pci.c
> > > index 3ff9eb7ef6..fa4b3b
On Wed, Jul 08, 2020 at 06:59:41AM -0400, Michael S. Tsirkin wrote:
> On Mon, Jul 06, 2020 at 02:56:45PM +0100, Stefan Hajnoczi wrote:
> > v4:
> > * Sorry for the long delay. I considered replacing this series with a
> > simpler
> >approach. Real hardware ships with a fixed number of queues (
On Mon, Jul 06, 2020 at 02:56:45PM +0100, Stefan Hajnoczi wrote:
> v4:
> * Sorry for the long delay. I considered replacing this series with a simpler
>approach. Real hardware ships with a fixed number of queues (e.g. 128). The
>equivalent can be done in QEMU too. That way we don't need to
On Tue, Jul 07, 2020 at 05:44:53PM +0200, Cornelia Huck wrote:
> On Mon, 6 Jul 2020 14:56:48 +0100
> Stefan Hajnoczi wrote:
>
> Maybe mention 'pci' in the subject as well?
I think this patch does too many things. I'll split up the generic and
PCI parts so that the commit message is more accurat
On Sat, Jun 20, 2020 at 05:36:49PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/298 | 45 ++
> tests/qemu-iotests/298.out | 5 +
> tests/qemu-iotests/group | 1 +
> 3 files chang
On Wed, 2020-07-08 at 14:33 +0200, Gerd Hoffmann wrote:
> On Mon, Jun 08, 2020 at 12:40:27PM +0300, Maxim Levitsky wrote:
> > blockdev-amend will be used similiar to blockdev-create
> > to allow on the fly changes of the structure of the format based block
> > devices.
>
> This one breaks the bui
On Tue, 2020-06-30 at 13:04 +0200, Philippe Mathieu-Daudé wrote:
> At some point the URL changed, update it to avoid other
> developers to search for it.
>
> Reviewed-by: Klaus Jensen
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/block/nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 del
On Sat, Jun 20, 2020 at 05:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> It may be used for file-systems with slow allocation.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> qapi/block-core.json | 3 +-
> block/preallocate.c | 255 +++
>
On Sat, Jun 20, 2020 at 05:36:48PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> All users of QemuIoInteractive provides -f argument, so it's incorrect
> to use qemu_io_args, which contains -f too. Let's use
> qemu_io_args_no_fmt, which also makes possible to use --image-opts with
> QemuIoInteractiv
On Tue, 2020-07-07 at 21:40 +0100, Peter Maydell wrote:
> On Mon, 6 Jul 2020 at 11:04, Max Reitz wrote:
> > The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450:
> >
> > Merge remote-tracking branch
> > 'remotes/pmaydell/tags/pull-target-arm-20200703' into staging (2020-
On Tue, Jul 07, 2020 at 05:28:21PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/26/20 12:25 PM, Stefan Hajnoczi wrote:
> > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote:
> >> On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote:
> >>>
> >>> The following changes since commit
> >>>
On Tue, Jul 07, 2020 at 05:44:53PM +0200, Cornelia Huck wrote:
> On Mon, 6 Jul 2020 14:56:48 +0100
> Stefan Hajnoczi wrote:
>
> Maybe mention 'pci' in the subject as well?
Actually splitting up the patch is hard due to the nvectors dependency
on num_queues. I will leave it as a single patch and
On Wed, 2020-07-08 at 16:23 +0200, Gerd Hoffmann wrote:
> On Wed, Jul 08, 2020 at 04:06:45PM +0300, Maxim Levitsky wrote:
> > On Wed, 2020-07-08 at 14:33 +0200, Gerd Hoffmann wrote:
> > > On Mon, Jun 08, 2020 at 12:40:27PM +0300, Maxim Levitsky wrote:
> > > > blockdev-amend will be used similiar to
Am 08.07.2020 um 19:03 hat Keith Busch geschrieben:
> On Tue, Jul 07, 2020 at 05:26:13PM +0200, Kevin Wolf wrote:
> > Am 06.07.2020 um 21:43 hat Keith Busch geschrieben:
> > > The nvme emulated device development pace has increased recently. Klaus
> > > has offered to co-maintain, and since we hav
Daniel P. Berrangé writes:
> Create a "qemu_open_err" method which does the same as "qemu_open",
> but with a "Error **errp" for error reporting. There should be no
> behavioural difference for existing callers at this stage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> include/qemu/osdep.h |
On Wed, Jul 08, 2020 at 04:06:45PM +0300, Maxim Levitsky wrote:
> On Wed, 2020-07-08 at 14:33 +0200, Gerd Hoffmann wrote:
> > On Mon, Jun 08, 2020 at 12:40:27PM +0300, Maxim Levitsky wrote:
> > > blockdev-amend will be used similiar to blockdev-create
> > > to allow on the fly changes of the struct
Daniel P. Berrangé writes:
> Currently at startup if using cache=none on a filesystem lacking
> O_DIRECT such as tmpfs, at startup QEMU prints
>
> qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: file system may not
> support O_DIRECT
> qemu-system-x86_64: -drive file=/tmp/foo.img,cache=
Daniel P. Berrangé writes:
> Currently we suggest that a filesystem may not support O_DIRECT after
> seeing an EINVAL. Other things can cause EINVAL though, so it is better
> to do an explicit check, and then report a definitive error message.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> util/
On 6/16/20 12:51 AM, Philippe Mathieu-Daudé wrote:
> This series contains few patches resulting from the notes I
> took while reviewing Mark ADB series last Sunday, in particular:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg712078.html
>
> I have another patch for hw/input/hid.c but I
On 6/16/20 12:51 AM, Philippe Mathieu-Daudé wrote:
> +timer_mod(NVRAM->alrm_timer_ms,
> + qemu_clock_get_ms(rtc_clock) + next_time_s *
> + NANOSECONDS_PER_SECOND /
> SCALE_MS);
I'm not keen on this last.
I would much prefer a MILLISECO
On 6/16/20 12:51 AM, Philippe Mathieu-Daudé wrote:
> -reload = muldiv64(s->regs[WDT_RELOAD_VALUE], NANOSECONDS_PER_SECOND,
> +reload = muldiv64(s->regs[WDT_RELOAD_VALUE],
> + NANOSECONDS_PER_SECOND / SCALE_US,
>s->pclk_freq);
Sim
Daniel P. Berrangé writes:
> On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote:
>> There are a number of unnecessary trailing whitespaces that have
>> accumulated over time in the source code. They cause stray changes
>> in patches if you use tools that automatically remove t
On Jul 8 21:47, Dmitry Fomichev wrote:
>
> > -Original Message-
> > From: Klaus Jensen
> > Sent: Wednesday, July 8, 2020 5:24 PM
> > To: Dmitry Fomichev
> > Cc: qemu-block@nongnu.org; qemu-de...@nongnu.org; f...@euphon.net;
> > javier.g...@samsung.com; kw...@redhat.com; mre...@redhat.co
64 matches
Mail list logo
