Re: [PATCH v7 41/47] block: Leave BDS.backing_file constant

2020-07-27 Thread Andrey Shinkevich
On 25.06.2020 18:22, Max Reitz wrote: Parts of the block layer treat BDS.backing_file as if it were whatever the image header says (i.e., if it is a relative path, it is relative to the overlay), other parts treat it like a cache for bs->backing->bs->filename (relative paths are relative to the

Re: [PATCH v3 15/21] migration/block-dirty-bitmap: relax error handling in incoming part

2020-07-27 Thread Vladimir Sementsov-Ogievskiy
27.07.2020 14:23, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: Bitmaps data is not critical, and we should not fail the migration (or use postcopy recovering) because of dirty-bitmaps migration failure. Instead we should just lose unfinished

Re: [PATCH v3 15/21] migration/block-dirty-bitmap: relax error handling in incoming part

2020-07-27 Thread Vladimir Sementsov-Ogievskiy
27.07.2020 14:16, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: 24.07.2020 20:35, Eric Blake wrote: On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: Bitmaps data is not critical, and we should not fail the migration (or use postcopy

Re: [PATCH v3 15/21] migration/block-dirty-bitmap: relax error handling in incoming part

2020-07-27 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > Bitmaps data is not critical, and we should not fail the migration (or > use postcopy recovering) because of dirty-bitmaps migration failure. > Instead we should just lose unfinished bitmaps. > > Still we have to report io stream

Re: [PATCH v3 15/21] migration/block-dirty-bitmap: relax error handling in incoming part

2020-07-27 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 24.07.2020 20:35, Eric Blake wrote: > > On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: > > > Bitmaps data is not critical, and we should not fail the migration (or > > > use postcopy recovering) because of dirty-bitmaps

Re: [PATCH 2/2] qemu-iotests: Test convert to qcow2 compressed to NBD

2020-07-27 Thread Max Reitz
On 26.07.20 17:25, Nir Soffer wrote: > Add test for "qemu-img convert -O qcow2 -c" to NBD target. The use case > is writing compressed disk content to OVA archive. > > Signed-off-by: Nir Soffer > --- > tests/qemu-iotests/302 | 83 ++ >

Re: [PATCH v3 10/21] migration/block-dirty-bitmap: move mutex init to dirty_bitmap_mig_init

2020-07-27 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > No reasons to keep two public init functions. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Andrey Shinkevich Yes so I think that means the initialisation of that lock is a little later in startup, but OK

Re: [PATCH 00/16] hw/block/nvme: dma handling and address mapping cleanup

2020-07-27 Thread Klaus Jensen
On Jul 20 13:37, Klaus Jensen wrote: > From: Klaus Jensen > > This series consists of patches that refactors dma read/write and adds a > number of address mapping helper functions. > > Based-on: <20200706061303.246057-1-...@irrelevant.dk> > > Klaus Jensen (16): > hw/block/nvme: memset

Re: [PATCH 1/2] pci: pass along the return value of dma_memory_rw

2020-07-27 Thread Klaus Jensen
On Jul 22 07:48, Michael S. Tsirkin wrote: > On Mon, Jun 29, 2020 at 10:20:52PM +0200, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Some devices might want to know the return value of dma_memory_rw, so > > pass it along instead of ignoring it. > > > > There are no existing users of the

Re: [PATCH v5 3/3] nvme: allow cmb and pmr to be enabled on same device

2020-07-27 Thread Klaus Jensen
On Jul 23 09:03, Andrzej Jakowski wrote: > So far it was not possible to have CMB and PMR emulated on the same > device, because BAR2 was used exclusively either of PMR or CMB. This > patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors. > > Signed-off-by: Andrzej Jakowski >

Re: [PATCH 1/2] block: nbd: Fix convert qcow2 compressed to nbd

2020-07-27 Thread Max Reitz
On 26.07.20 17:25, Nir Soffer wrote: > When converting to qcow2 compressed format, the last step is a special > zero length compressed write, ending in call to bdrv_co_truncate(). This > call always fail for the nbd driver since it does not implement > bdrv_co_truncate(). > > For block devices,

Re: [PATCH v3 4/4] block: switch to use qemu_open/qemu_create for improved errors

2020-07-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > Currently at startup if using cache=none on a filesystem lacking > O_DIRECT such as tmpfs, at startup QEMU prints > > qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: file system may not > support O_DIRECT > qemu-system-x86_64: -drive

Re: [PATCH v3 2/4] util: introduce qemu_open and qemu_create with error reporting

2020-07-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > This introduces two new helper metohds Typo metohds. Suggest to be a bit more explicit on why we want to replace qemu_open(), perhaps like this: qemu_open_old() works like open(): set errno and return -1 on failure. It has even more failure modes, though.

<    1   2