[PATCH v2] qemu-img: Explicit number replaced by a constant

2020-08-18 Thread Yi Li
Signed-off-by: Yi Li --- qemu-img.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 5308773811..aa2e31c8ae 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1200,10 +1200,10 @@ static int is_allocated_sectors(const uint8_t *buf, int n, int

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-18 Thread Bin Meng
On Tue, Aug 18, 2020 at 9:55 PM Anup Patel wrote: > > On Tue, Aug 18, 2020 at 6:39 PM wrote: > > > > On 8/18/20 7:17 AM, Anup Patel wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > > the content is safe > > > > > > On Tue, Aug 18, 2020 at 1:23 AM wrote: >

[PATCH v6 0/4] Apply COR-filter to the block-stream permanently

2020-08-18 Thread Andrey Shinkevich
Note: this series is based on the another one "block: Deal with filters" by Max Reitz that could be found in the branches: https://git.xanclic.moe/XanClic/qemu child-access-functions-v6 https://github.com/XanClic/qemu child-access-functions-v6 v6: Re-based to the series

[PATCH v6 4/4] block: apply COR-filter to block-stream jobs

2020-08-18 Thread Andrey Shinkevich
The patch completes the series with the COR-filter insertion to any block-stream operation. It also makes changes to the iotests 030. The test case 'test_stream_parallel' was deleted due to multiple errors. Signed-off-by: Andrey Shinkevich --- block/stream.c | 76

[PATCH v6 2/4] copy-on-read: add filter append/drop functions

2020-08-18 Thread Andrey Shinkevich
Provide API for the COR-filter insertion/removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 103 +++ block/copy-on-read.h | 36

[PATCH v6 3/4] qapi: add filter-node-name to block-stream

2020-08-18 Thread Andrey Shinkevich
Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. That will be needed for further iotests implementations. Signed-off-by: Andrey Shinkevich --- block/monitor/block-hmp-cmds.c | 4 ++-- block/stream.c

[PATCH v6 1/4] copy-on-read: Support preadv/pwritev_part functions

2020-08-18 Thread Andrey Shinkevich
Add support for the recently introduced functions bdrv_co_preadv_part() and bdrv_co_pwritev_part() to the COR-filter driver. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-18 Thread Andrey Shinkevich
Reviewed-by: Andrey Shinkevich On 10.08.2020 14:04, Vladimir Sementsov-Ogievskiy wrote: 10.08.2020 11:12, Max Reitz wrote: On 07.08.20 12:29, Vladimir Sementsov-Ogievskiy wrote: 16.07.2020 17:59, Max Reitz wrote: On 10.07.20 19:41, Andrey Shinkevich wrote: On 10.07.2020 18:24, Max Reitz

Re: [RFC PATCH v3 2/5] util/vfio-helpers: Report error on unsupported host architectures

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 7:12 PM, Alex Williamson wrote: > On Tue, 18 Aug 2020 18:45:06 +0200 > Philippe Mathieu-Daudé wrote: > >> The vfio-helpers implementation expects a TYPEv1 IOMMU, see >> qemu_vfio_init_pci: >> >> 263 if (!ioctl(s->container, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU)) { >> 264

Re: [RFC PATCH v3 4/5] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-08-18 Thread Alex Williamson
On Tue, 18 Aug 2020 18:45:08 +0200 Philippe Mathieu-Daudé wrote: > qemu_vfio_pci_init_irq() allows us to initialize any type of IRQ, > but only one. Introduce qemu_vfio_pci_init_msix_irqs() which is > specific to MSIX IRQ type, and allow us to use multiple IRQs > (thus passing multiple eventfd

Re: [PATCH v2 0/3] hw/sd: Add Cadence SDHCI emulation

2020-08-18 Thread Philippe Mathieu-Daudé
Cc'ing Sai Pavan for patches 1 and 2. On 8/17/20 12:05 PM, Bin Meng wrote: > This series is spun off from the following series as it is hw/sd > centric, so that it can be picked up separately by Philippe. > > http://patchwork.ozlabs.org/project/qemu-devel/list/?series=195648 > > This series

[RFC PATCH v3 5/5] block/nvme: Use qemu_vfio_pci_init_msix_irqs() to initialize our IRQ

2020-08-18 Thread Philippe Mathieu-Daudé
Instead of initializing one MSIX IRQ with the generic qemu_vfio_pci_init_irq() function, use the MSIX specific one which will allow us to use multiple IRQs. For now we provide an array of a single IRQ. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 4 ++-- 1 file changed, 2

[RFC PATCH v3 4/5] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-08-18 Thread Philippe Mathieu-Daudé
qemu_vfio_pci_init_irq() allows us to initialize any type of IRQ, but only one. Introduce qemu_vfio_pci_init_msix_irqs() which is specific to MSIX IRQ type, and allow us to use multiple IRQs (thus passing multiple eventfd notifiers). Signed-off-by: Philippe Mathieu-Daudé ---

[RFC PATCH v3 3/5] util/vfio-helpers: Store eventfd using int32_t type

2020-08-18 Thread Philippe Mathieu-Daudé
Per the documentation in linux-headers/linux/vfio.h: VFIO_DEVICE_SET_IRQS * DATA_EVENTFD binds the specified ACTION to the provided __s32 eventfd. Replace the 'int' by an 'int32_t' to match the documentation. Fixes: 418026ca43 ("util: Introduce vfio helpers") Signed-off-by: Philippe

[RFC PATCH v3 0/5] util/vfio-helpers: Add support for multiple IRQs

2020-08-18 Thread Philippe Mathieu-Daudé
This series intends to setup the VFIO helper to allow binding notifiers on different IRQs. For the NVMe use case, we only care about MSIX interrupts. To not disrupt other users, introduce the qemu_vfio_pci_init_msix_irqs function to initialize multiple MSIX IRQs and attach eventfd to them. Since

[RFC PATCH v3 1/5] block/nvme: Use an array of EventNotifier

2020-08-18 Thread Philippe Mathieu-Daudé
In preparation of using multiple IRQ (thus multiple eventfds) make BDRVNVMeState::irq_notifier an array (for now of a single element, the admin queue notifier). Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 28 ++-- 1 file changed, 18 insertions(+), 10

[RFC PATCH v3 2/5] util/vfio-helpers: Report error on unsupported host architectures

2020-08-18 Thread Philippe Mathieu-Daudé
The vfio-helpers implementation expects a TYPEv1 IOMMU, see qemu_vfio_init_pci: 263 if (!ioctl(s->container, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU)) { 264 error_setg_errno(errp, errno, "VFIO IOMMU check failed"); Thus POWER SPAPR IOMMU is obviously not supported. The

[PATCH v6 7/7] vhost-user-blk-pci: default num_queues to -smp N

2020-08-18 Thread Stefan Hajnoczi
Automatically size the number of request virtqueues to match the number of vCPUs. This ensures that completion interrupts are handled on the same vCPU that submitted the request. No IPI is necessary to complete an I/O request and performance is improved. The maximum number of MSI-X vectors and

[PATCH v6 2/7] hw: add 5.2 machine types and 5.1 compat options

2020-08-18 Thread Stefan Hajnoczi
arm, i386, ppc, and s390x have versioned machine types and associated compatibility options. Introduce new ones now that QEMU 5.1 has been released. Signed-off-by: Stefan Hajnoczi --- include/hw/boards.h| 3 +++ include/hw/i386/pc.h | 3 +++ hw/arm/virt.c | 9

Re: [RFC PATCH 17/22] block/export: Add blk_exp_close_all(_type)

2020-08-18 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > This adds a function to shut down all block exports, and another one to > shut down the block exports of a single type. The latter is used for now > when stopping the NBD server. As soon as we implement support for > multiple NBD servers, we'll need a

[PATCH v6 0/7] virtio-pci: enable blk and scsi multi-queue by default

2020-08-18 Thread Stefan Hajnoczi
v6: * Rebased onto QEMU 5.1 and added the now-necessary machine compat opts. v4: * Sorry for the long delay. I considered replacing this series with a simpler approach. Real hardware ships with a fixed number of queues (e.g. 128). The equivalent can be done in QEMU too. That way we don't

Re: [PATCH v5 5/5] iotests: add commit top->base cases to 274

2020-08-18 Thread Alberto Garcia
On Wed 10 Jun 2020 02:04:26 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > These cases are fixed by previous patches around block_status and > is_allocated. Reviewed-by: Alberto Garcia Berto

Re: [RFC PATCH 18/22] block/export: Add 'id' option to block-export-add

2020-08-18 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > We'll need an id to identify block exports in monitor commands. This > adds one. > > Note that this is different from the 'name' option in the NBD server, > which is the externally visible export name. While block export ids need > to be unique in the whole

[PATCH v6 5/7] virtio-scsi-pci: default num_queues to -smp N

2020-08-18 Thread Stefan Hajnoczi
Automatically size the number of virtio-scsi-pci, vhost-scsi-pci, and vhost-user-scsi-pci request virtqueues to match the number of vCPUs. Other transports continue to default to 1 request virtqueue. A 1:1 virtqueue:vCPU mapping ensures that completion interrupts are handled on the same vCPU that

[PATCH v6 3/7] virtio-pci: add virtio_pci_optimal_num_queues() helper

2020-08-18 Thread Stefan Hajnoczi
Multi-queue devices achieve the best performance when each vCPU has a dedicated queue. This ensures that virtqueue used notifications are handled on the same vCPU that submitted virtqueue buffers. When another vCPU handles the the notification an IPI will be necessary to wake the submission vCPU

[PATCH v6 6/7] virtio-blk-pci: default num_queues to -smp N

2020-08-18 Thread Stefan Hajnoczi
Automatically size the number of virtio-blk-pci request virtqueues to match the number of vCPUs. Other transports continue to default to 1 request virtqueue. A 1:1 virtqueue:vCPU mapping ensures that completion interrupts are handled on the same vCPU that submitted the request. No IPI is

Re: [RFC PATCH 16/22] block/export: Allocate BlockExport in blk_exp_add()

2020-08-18 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > Instead of letting the driver allocate and return the BlockExport > object, allocate it already in blk_exp_add() and pass it. This allows us > to initialise the generic part before calling into the driver so that > the driver can just use these values instead

Re: [PATCH v6 2/7] hw: add 5.2 machine types and 5.1 compat options

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 15:33:43 +0100 Stefan Hajnoczi wrote: > arm, i386, ppc, and s390x have versioned machine types and associated > compatibility options. Introduce new ones now that QEMU 5.1 has been > released. > > Signed-off-by: Stefan Hajnoczi > --- > include/hw/boards.h| 3 +++ >

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-18 Thread Kevin Wolf
Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: > Because of the (not so recent anymore) changes that make the stream job > independent of the base node and instead track the node above it, we > have to split that "bottom" node into two cases: The bottom COW node, > and the node directly above

[PATCH v6 4/7] virtio-scsi: introduce a constant for fixed virtqueues

2020-08-18 Thread Stefan Hajnoczi
The event and control virtqueues are always present, regardless of the multi-queue configuration. Define a constant so that virtqueue number calculations are easier to read. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Reviewed-by: Pankaj Gupta Reviewed-by: Philippe Mathieu-Daudé

[PATCH v6 1/7] Open 5.2 development tree

2020-08-18 Thread Stefan Hajnoczi
From: Peter Maydell Signed-off-by: Peter Maydell --- VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION b/VERSION index 831446cbd2..7d40cb9d36 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -5.1.0 +5.1.50 -- 2.26.2

Re: [PATCH v5 4/5] block/io: fix bdrv_is_allocated_above

2020-08-18 Thread Alberto Garcia
On Wed 10 Jun 2020 02:04:25 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > bdrv_is_allocated_above wrongly handles short backing files: it reports > after-EOF space as UNALLOCATED which is wrong, as on read the data is > generated on the level of short backing file (if all overlays has >

Re: [PATCH v5 3/5] block/io: bdrv_common_block_status_above: support bs == base

2020-08-18 Thread Alberto Garcia
On Wed 10 Jun 2020 02:04:24 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > We are going to reuse bdrv_common_block_status_above in > bdrv_is_allocated_above. bdrv_is_allocated_above may be called with > include_base == false and still bs == base (for ex. from img_rebase()). > > So, support this

Re: [PATCH v5 2/5] block/io: bdrv_common_block_status_above: support include_base

2020-08-18 Thread Alberto Garcia
On Wed 10 Jun 2020 02:04:23 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > In order to reuse bdrv_common_block_status_above in > bdrv_is_allocated_above, let's support include_base parameter. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

Re: [PATCH v5 1/5] block/io: fix bdrv_co_block_status_above

2020-08-18 Thread Alberto Garcia
On Wed 10 Jun 2020 02:04:22 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > + * The top layer deferred to this layer, and because this layer > is > + * short, any zeroes that we synthesize beyond EOF behave as if > they > + * were allocated at this layer >

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-18 Thread Anup Patel
On Tue, Aug 18, 2020 at 6:39 PM wrote: > > On 8/18/20 7:17 AM, Anup Patel wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Tue, Aug 18, 2020 at 1:23 AM wrote: > >> On 8/17/20 8:28 PM, Alistair Francis wrote: > >>> EXTERNAL

[PATCH v4 0/4] migration: Add block-bitmap-mapping parameter

2020-08-18 Thread Max Reitz
RFC v1: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00912.html RFC v2: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00915.html v1: https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg09792.html v2:

[PATCH v4 2/4] iotests.py: Add wait_for_runstate()

2020-08-18 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 717b5b652c..ee93cf22db 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -833,6

[PATCH v4 4/4] iotests: Test node/bitmap aliases during migration

2020-08-18 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/300 | 595 + tests/qemu-iotests/300.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 601 insertions(+) create mode 100755 tests/qemu-iotests/300 create mode 100644

[PATCH v4 3/4] iotests.py: Let wait_migration() return on failure

2020-08-18 Thread Max Reitz
Let wait_migration() return on failure (with the return value indicating whether the migration was completed or has failed), so we can use it for migrations that are expected to fail, too. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 18 -- 1 file changed, 12

[PATCH v4 1/4] migration: Add block-bitmap-mapping parameter

2020-08-18 Thread Max Reitz
This migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node and bitmap names on the source and destination and pass the mapping of how bitmaps are to be transferred to qemu

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-18 Thread via
On 8/18/20 7:17 AM, Anup Patel wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, Aug 18, 2020 at 1:23 AM wrote: >> On 8/17/20 8:28 PM, Alistair Francis wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you

Re: [PATCH v7 0/8] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-08-18 Thread Lukas Straub
On Tue, 4 Aug 2020 10:11:22 +0200 Lukas Straub wrote: > Hello Everyone, > In many cases, if qemu has a network connection (qmp, migration, chardev, > etc.) > to some other server and that server dies or hangs, qemu hangs too. > These patches introduce the new 'yank' out-of-band qmp command to

Re: [PATCH] qemu-img: Explicit number replaced by a constant

2020-08-18 Thread Max Reitz
On 18.08.20 09:19, Stefano Garzarella wrote: > Hi Yi Li, > thanks for this patch! Just a comment below: > > On Mon, Aug 17, 2020 at 07:01:13PM +0800, Yi Li wrote: >> Signed-off-by: Yi Li >> --- >> qemu-img.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git

[RFC PATCH 0/9] block/curl: Add caching of data downloaded from the remote server

2020-08-18 Thread David Edmondson
When using qemu-img to convert an image that is hosted on an HTTP server to some faster local (or pseudo-local) storage, the overall performance can be improved by reading data from the HTTP server in larger blocks and by caching and re-using blocks already read. This set of patches implements

[RFC PATCH 1/9] block/curl: Add an 'offset' parameter, affecting all range requests

2020-08-18 Thread David Edmondson
A new 'offset' parameter affects all range requests that are sent to the remote server. The value, in bytes, is simply added to any byte offset values passed in to the driver. Signed-off-by: David Edmondson --- block/curl.c | 12 +++-

[RFC PATCH 9/9] block/curl: Add readahead support

2020-08-18 Thread David Edmondson
Re-add support for a readahead parameter, which is the number of bytes added to the request from the upper layer before breaking the request into blocks. The default is zero. The number of bytes specified has no alignment requirements. Signed-off-by: David Edmondson --- block/curl.c

[RFC PATCH 3/9] block/curl: Tracing

2020-08-18 Thread David Edmondson
Add some more trace functions to the IO path. Signed-off-by: David Edmondson --- block/curl.c | 10 +- block/io.c | 4 block/linux-aio.c | 6 ++ block/trace-events | 13 - 4 files changed, 31 insertions(+), 2 deletions(-) diff --git a/block/curl.c

[RFC PATCH 6/9] block/curl: Cache downloaded blocks

2020-08-18 Thread David Edmondson
In the hope that they will be referred to multiple times, cache the blocks downloaded from the remote server. Signed-off-by: David Edmondson --- block/curl.c | 321 +++-- block/trace-events | 3 + 2 files changed, 287 insertions(+), 37

[RFC PATCH 5/9] block/curl: Allow the blocksize to be specified by the user

2020-08-18 Thread David Edmondson
Rather than a fixed 256kB blocksize, allow the user to specify the size used. It must be a non-zero power of two, defaulting to 256kB. Signed-off-by: David Edmondson --- block/curl.c | 73 +-- docs/system/device-url-syntax.rst.inc | 7 +++

[RFC PATCH 2/9] block/curl: Remove readahead support

2020-08-18 Thread David Edmondson
Block based caching and the current readahead support do not interact well, so remove readahead support before adding block caching. Readahead will be re-added later. Signed-off-by: David Edmondson --- block/curl.c | 23 ---

[RFC PATCH 4/9] block/curl: Perform IO in fixed size chunks

2020-08-18 Thread David Edmondson
Do all IO requests to the remote server in 256kB chunks. Signed-off-by: David Edmondson --- block/curl.c | 151 - block/trace-events | 2 + 2 files changed, 109 insertions(+), 44 deletions(-) diff --git a/block/curl.c b/block/curl.c index

[RFC PATCH 8/9] block/curl: Allow 16 sockets/ACB

2020-08-18 Thread David Edmondson
qemu-img allows up to 16 coroutines when performing IO. Ensure that there is a Curl socket and ACB available to each of them. Signed-off-by: David Edmondson --- block/curl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/curl.c b/block/curl.c index

[RFC PATCH 7/9] block/curl: Allow the user to control the number of cache blocks

2020-08-18 Thread David Edmondson
Rather than using a fixed number, allow the user to specify the number of cache blocks allocated. This cannot be less than the number of Curl states and defaults to that value. Signed-off-by: David Edmondson --- block/curl.c | 20 +---

Re: [PATCH v7 10/47] mirror-top: Support compressed writes

2020-08-18 Thread Kevin Wolf
Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > block/mirror.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/block/mirror.c b/block/mirror.c > index e8e8844afc..469acf4600 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@

Re: [RFC PATCH 06/22] qemu-nbd: Use raw block driver for --offset

2020-08-18 Thread Nir Soffer
On Tue, Aug 18, 2020 at 11:47 AM Kevin Wolf wrote: > Am 17.08.2020 um 19:19 hat Nir Soffer geschrieben: > > On Thu, Aug 13, 2020 at 7:36 PM Kevin Wolf wrote: > > > > > Instead of implementing qemu-nbd --offset in the NBD code, just put a > > > raw block node with the requested offset on top of

Re: [RFC PATCH 06/22] qemu-nbd: Use raw block driver for --offset

2020-08-18 Thread Kevin Wolf
Am 17.08.2020 um 19:19 hat Nir Soffer geschrieben: > On Thu, Aug 13, 2020 at 7:36 PM Kevin Wolf wrote: > > > Instead of implementing qemu-nbd --offset in the NBD code, just put a > > raw block node with the requested offset on top of the user image and > > rely on that doing the job. > > > >

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-18 Thread Kevin Wolf
Am 17.08.2020 um 20:18 hat Alberto Garcia geschrieben: > On Mon 17 Aug 2020 05:53:07 PM CEST, Kevin Wolf wrote: > > Maybe the difference is in allocating 64k at once instead of doing a > > separate allocation for every 4k block? But with the extent size hint > > patches to file-posix, we should

Re: [PATCH] qemu-img: Explicit number replaced by a constant

2020-08-18 Thread Stefano Garzarella
Hi Yi Li, thanks for this patch! Just a comment below: On Mon, Aug 17, 2020 at 07:01:13PM +0800, Yi Li wrote: > Signed-off-by: Yi Li > --- > qemu-img.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 5308773811..a0fbc2757c

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-18 Thread Anup Patel
On Tue, Aug 18, 2020 at 1:23 AM wrote: > > On 8/17/20 8:28 PM, Alistair Francis wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Mon, Aug 17, 2020 at 11:12 AM via wrote: > >> Hi Anup, > >> > >> On 8/17/20 11:30 AM, Bin Meng

Re: What is bs->reqs_lock for?

2020-08-18 Thread Paolo Bonzini
On 13/08/20 18:34, Vladimir Sementsov-Ogievskiy wrote: > I thought bs is attached to one aio context and aio context attached to > one iothread. For now yes, but with multiqueue there would be many iothreads sending requests to the AioContext. The BDS would still have a "home" aiocontext to

Re: [PATCH] hw: add a number of SPI-flash's of m25p80 family

2020-08-18 Thread Cédric Le Goater
On 8/17/20 7:16 PM, i.kononenko wrote: > No, the ext ID wasn't be checked at a real HW. > Just copied it from the U-boot official repository > https://github.com/u-boot/u-boot/blob/789bfb52668ee609b2043de645e2f94bbd24fd1f/drivers/mtd/spi/spi-nor-ids.c#L183 OK. Reviewed-by: Cédric Le Goater >