Re: [PATCH for-5.2 3/3] hw/block/nvme: fix free of array-typed value

2020-11-04 Thread Max Reitz
On 04.11.20 11:22, Klaus Jensen wrote: > From: Klaus Jensen > > Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the > namespaces member of NvmeCtrl is no longer a dynamically allocated > array. Remove the free. > > Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple

Re: [PATCH for-5.2 1/3] hw/block/nvme: fix null ns in register namespace

2020-11-04 Thread Max Reitz
On 04.11.20 11:22, Klaus Jensen wrote: > From: Klaus Jensen > > Fix dereference after NULL check. > > Reported-by: Coverity (CID 1436128) > Fixes: b20804946bce ("hw/block/nvme: update nsid when registered") > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 3 +-- > 1 file changed, 1

Re: [PATCH for-5.2 2/3] hw/block/nvme: fix uint16_t use of uint32_t sgls member

2020-11-04 Thread Max Reitz
On 04.11.20 11:22, Klaus Jensen wrote: > From: Klaus Jensen > > nvme_map_sgl_data erroneously uses the sgls member of NvmeIdNs as a > uint16_t. > > Reported-by: Coverity (CID 1436129) > Fixes: cba0a8a344fe ("hw/block/nvme: add support for scatter gather lists") > Signed-off-by: Klaus Jensen >

Re: [PATCH for-5.2 3/3] hw/block/nvme: fix free of array-typed value

2020-11-04 Thread Philippe Mathieu-Daudé
On 11/4/20 11:22 AM, Klaus Jensen wrote: > From: Klaus Jensen > > Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the > namespaces member of NvmeCtrl is no longer a dynamically allocated > array. Remove the free. > > Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple

[PATCH for-5.2 3/3] hw/block/nvme: fix free of array-typed value

2020-11-04 Thread Klaus Jensen
From: Klaus Jensen Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the namespaces member of NvmeCtrl is no longer a dynamically allocated array. Remove the free. Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces") Reported-by: Coverity (CID 1436131)

[PATCH for-5.2 1/3] hw/block/nvme: fix null ns in register namespace

2020-11-04 Thread Klaus Jensen
From: Klaus Jensen Fix dereference after NULL check. Reported-by: Coverity (CID 1436128) Fixes: b20804946bce ("hw/block/nvme: update nsid when registered") Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/block/nvme.c

[PATCH for-5.2 2/3] hw/block/nvme: fix uint16_t use of uint32_t sgls member

2020-11-04 Thread Klaus Jensen
From: Klaus Jensen nvme_map_sgl_data erroneously uses the sgls member of NvmeIdNs as a uint16_t. Reported-by: Coverity (CID 1436129) Fixes: cba0a8a344fe ("hw/block/nvme: add support for scatter gather lists") Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 2 +- 1 file changed, 1

[PATCH for-5.2 0/3] hw/block/nvme: coverity fixes

2020-11-04 Thread Klaus Jensen
From: Klaus Jensen Fix three issues reported by coverity (CIDs 1436128, 1436129 and 1436131). Klaus Jensen (3): hw/block/nvme: fix null ns in register namespace hw/block/nvme: fix uint16_t use of uint32_t sgls member hw/block/nvme: fix free of array-typed value hw/block/nvme.c | 6

Re: [PULL 15/30] hw/block/nvme: support multiple namespaces

2020-11-04 Thread Max Reitz
On 27.10.20 11:49, Klaus Jensen wrote: > From: Klaus Jensen > > This adds support for multiple namespaces by introducing a new 'nvme-ns' > device model. The nvme device creates a bus named from the device name > ('id'). The nvme-ns devices then connect to this and registers > themselves with the

Re: [PULL 18/30] hw/block/nvme: update nsid when registered

2020-11-04 Thread Klaus Jensen
On Nov 4 10:32, Max Reitz wrote: > On 27.10.20 11:49, Klaus Jensen wrote: > > From: Klaus Jensen > > > > If the user does not specify an nsid parameter on the nvme-ns device, > > nvme_register_namespace will find the first free namespace id and assign > > that. > > > > This fix makes sure the

Re: [PULL 12/30] hw/block/nvme: add support for scatter gather lists

2020-11-04 Thread Max Reitz
On 27.10.20 11:49, Klaus Jensen wrote: > From: Klaus Jensen > > For now, support the Data Block, Segment and Last Segment descriptor > types. > > See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)"). > > Signed-off-by: Klaus Jensen > Reviewed-by: Keith Busch > --- >

Re: [PULL 18/30] hw/block/nvme: update nsid when registered

2020-11-04 Thread Max Reitz
On 27.10.20 11:49, Klaus Jensen wrote: > From: Klaus Jensen > > If the user does not specify an nsid parameter on the nvme-ns device, > nvme_register_namespace will find the first free namespace id and assign > that. > > This fix makes sure the assigned id is saved. > > Signed-off-by: Klaus

<    1   2