[PATCH v5 2/2] hw/block: m25p80: Implement AAI-WP command support for SST flashes

2020-12-22 Thread Bin Meng
From: Xuzhou Cheng Auto Address Increment (AAI) Word-Program is a special command of SST flashes. AAI-WP allows multiple bytes of data to be programmed without re-issuing the next sequential address location. Signed-off-by: Xuzhou Cheng Signed-off-by: Bin Meng --- Changes in v5: - remove the

[PATCH v5 1/2] hw/block: m25p80: Don't write to flash if write is disabled

2020-12-22 Thread Bin Meng
From: Bin Meng When write is disabled, the write to flash should be avoided in flash_write8(). Fixes: 82a2499011a7 ("m25p80: Initial implementation of SPI flash device") Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias --- (no changes since v2) Ch

Re: [PATCH 0/9] Alpine Linux build fix and CI pipeline

2020-12-22 Thread Jiaxun Yang
On Wed, Dec 23, 2020, at 2:41 AM, Wainer dos Santos Moschetta wrote: > Hi, > > On 12/21/20 5:25 AM, Jiaxun Yang wrote: > > > > On Mon, Dec 21, 2020, at 9:06 AM, no-re...@patchew.org wrote: > >> Patchew URL: > >> https://patchew.org/QEMU/20201221005318.11866-1-jiaxun.y...@flygoat.com/ > >> > >>

Re: [PATCH 0/9] Alpine Linux build fix and CI pipeline

2020-12-22 Thread Wainer dos Santos Moschetta
Hi, On 12/21/20 5:25 AM, Jiaxun Yang wrote: On Mon, Dec 21, 2020, at 9:06 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20201221005318.11866-1-jiaxun.y...@flygoat.com/ Hi, This series seems to have some coding style problems. See output below for more information:

Re: [PATCH 1/9] tests/docker: Add dockerfile for Alpine Linux

2020-12-22 Thread Wainer dos Santos Moschetta
Hi, On 12/20/20 9:53 PM, Jiaxun Yang wrote: Alpine Linux[1] is a security-oriented, lightweight Linux distribution based on musl libc and busybox. It it popular among Docker guests and embedded applications. Adding it to test against different libc. [1]: https://alpinelinux.org/ Signed-off-b

Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 21:00, Vladimir Sementsov-Ogievskiy wrote: We shouldn't have use-cases when backing-fmt is set to something another than final base node. I mean, we shouldn't have use-cases when backing-file is [...] -- Best regards, Vladimir

Re: [PATCH v15 13/13] block: apply COR-filter to block-stream jobs

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 19:20, Max Reitz wrote: On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich This patch completes the series with the COR-filter applied to block-stream operations. Adding the filter makes it possible in future implement discarding copied regions in backin

Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 19:07, Max Reitz wrote: On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: The code already don't freeze base node and we try to make it prepared for the situation when base node is changed during the operation. In other words, block-stream doesn't own base node. Let's introduce

Re: [PATCH v15 09/13] stream: rework backing-file changing

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 18:59, Max Reitz wrote: On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Stream in stream_prepare calls bdrv_change_backing_file() to change backing-file in the metadata of bs. It may use either backing-file parameter given by user or just take filenam

Re: [PATCH v15 13/13] block: apply COR-filter to block-stream jobs

2020-12-22 Thread Max Reitz
On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich This patch completes the series with the COR-filter applied to block-stream operations. Adding the filter makes it possible in future implement discarding copied regions in backing files during the block-stream job,

Re: [PATCH] iotests: fix _check_o_direct

2020-12-22 Thread Max Reitz
On 22.12.20 16:35, Vladimir Sementsov-Ogievskiy wrote: 22.12.2020 18:15, Max Reitz wrote: On 18.12.20 19:20, Vladimir Sementsov-Ogievskiy wrote: Unfortunately commit "iotests: handle tmpfs" break running iotests with -nbd -nocache, as _check_o_direct tries to create $TEST_IMG.test_o_direct, but

Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-22 Thread Max Reitz
On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: The code already don't freeze base node and we try to make it prepared for the situation when base node is changed during the operation. In other words, block-stream doesn't own base node. Let's introduce a new interface which should replace

Re: [PATCH v15 09/13] stream: rework backing-file changing

2020-12-22 Thread Max Reitz
On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Stream in stream_prepare calls bdrv_change_backing_file() to change backing-file in the metadata of bs. It may use either backing-file parameter given by user or just take filename of base on job start. Backing fil

Re: [PATCH v4 1/2] hw/block: m25p80: Don't write to flash if write is disabled

2020-12-22 Thread Francisco Iglesias
On [2020 Dec 22] Tue 14:45:19, Bin Meng wrote: > From: Bin Meng > > When write is disabled, the write to flash should be avoided > in flash_write8(). > > Fixes: 82a2499011a7 ("m25p80: Initial implementation of SPI flash device") > Signed-off-by: Bin Meng Reviewed-by: Francisco Iglesias > >

Re: [PATCH v4 2/2] hw/block: m25p80: Implement AAI-WP command support for SST flashes

2020-12-22 Thread Bin Meng
Hi Francisco, On Tue, Dec 22, 2020 at 11:43 PM Francisco Iglesias wrote: > > Hi Bin, > > A couple of minor comments only! > > On [2020 Dec 22] Tue 14:45:20, Bin Meng wrote: > > From: Xuzhou Cheng > > > > Auto Address Increment (AAI) Word-Program is a special command of > > SST flashes. AAI-WP al

Re: [PATCH v4 2/2] hw/block: m25p80: Implement AAI-WP command support for SST flashes

2020-12-22 Thread Francisco Iglesias
Hi Bin, A couple of minor comments only! On [2020 Dec 22] Tue 14:45:20, Bin Meng wrote: > From: Xuzhou Cheng > > Auto Address Increment (AAI) Word-Program is a special command of > SST flashes. AAI-WP allows multiple bytes of data to be programmed > without re-issuing the next sequential addres

Re: [PATCH] iotests: fix _check_o_direct

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 18:15, Max Reitz wrote: On 18.12.20 19:20, Vladimir Sementsov-Ogievskiy wrote: Unfortunately commit "iotests: handle tmpfs" break running iotests with -nbd -nocache, as _check_o_direct tries to create $TEST_IMG.test_o_direct, but in case of nbd TEST_IMG is smothing like s/smothing/s

Re: [PATCH v15 04/13] qapi: add filter-node-name to block-stream

2020-12-22 Thread Max Reitz
On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy [vseme

Re: [PATCH] iotests: fix _check_o_direct

2020-12-22 Thread Max Reitz
On 18.12.20 19:20, Vladimir Sementsov-Ogievskiy wrote: Unfortunately commit "iotests: handle tmpfs" break running iotests with -nbd -nocache, as _check_o_direct tries to create $TEST_IMG.test_o_direct, but in case of nbd TEST_IMG is smothing like nbd+unix:///... , and test fails with message

Re: [PATCH v2 1/2] block: report errno when flock fcntl fails

2020-12-22 Thread Philippe Mathieu-Daudé
On 12/21/20 2:49 PM, David Edmondson wrote: > When a call to fcntl(2) for the purpose of manipulating file locks > fails, report the error returned by fcntl. > > Signed-off-by: David Edmondson > --- > block/file-posix.c | 20 +- > tests/qemu-iotests/153.out | 76 +

Re: [PATCH v4 1/2] hw/block: m25p80: Don't write to flash if write is disabled

2020-12-22 Thread Philippe Mathieu-Daudé
On 12/22/20 7:45 AM, Bin Meng wrote: > From: Bin Meng > > When write is disabled, the write to flash should be avoided > in flash_write8(). > > Fixes: 82a2499011a7 ("m25p80: Initial implementation of SPI flash device") > Signed-off-by: Bin Meng > > --- > > (no changes since v2) > > Changes i

Re: [PATCH v12 1/7] Introduce yank feature

2020-12-22 Thread Marc-André Lureau
On Sun, Dec 13, 2020 at 3:48 PM Lukas Straub wrote: > The yank feature allows to recover from hanging qemu by "yanking" > at various parts. Other qemu systems can register themselves and > multiple yank functions. Then all yank functions for selected > instances can be called by the 'yank' out-of