Re: [RFC PATCH 3/5] hw/pci-host/bonito: Remap PCI "lo" regions when PCIMAP reg is modified

2021-01-02 Thread Philippe Mathieu-Daudé
On 1/2/21 12:19 AM, Peter Maydell wrote: > On Fri, 1 Jan 2021 at 23:12, Philippe Mathieu-Daudé wrote: >> >> Per the datasheet (Chapter 5.7.1. "PCI address regions"), >> the PCIMAP register: >> >> Map the 64Mbyte regions marked "PCI_Lo" in the CPU's memory map, >> each of which can be assigned

Re: [RFC PATCH 3/5] hw/pci-host/bonito: Remap PCI "lo" regions when PCIMAP reg is modified

2021-01-02 Thread Philippe Mathieu-Daudé
On 1/2/21 11:44 AM, Philippe Mathieu-Daudé wrote: > On 1/2/21 12:19 AM, Peter Maydell wrote: >> On Fri, 1 Jan 2021 at 23:12, Philippe Mathieu-Daudé wrote: >>> >>> Per the datasheet (Chapter 5.7.1. "PCI address regions"), >>> the PCIMAP register: >>> >>> Map the 64Mbyte regions marked "PCI_Lo" in

Re: [RFC PATCH 3/5] hw/pci-host/bonito: Remap PCI "lo" regions when PCIMAP reg is modified

2021-01-02 Thread BALATON Zoltan via
On Sat, 2 Jan 2021, Philippe Mathieu-Daudé wrote: On 1/2/21 12:19 AM, Peter Maydell wrote: On Fri, 1 Jan 2021 at 23:12, Philippe Mathieu-Daudé wrote: Per the datasheet (Chapter 5.7.1. "PCI address regions"), the PCIMAP register: Map the 64Mbyte regions marked "PCI_Lo" in the CPU's memory m

[PATCH] meson: Propagate gnutls dependency

2021-01-02 Thread Roman Bolshakov
crypto/tlscreds.h includes GnuTLS headers if CONFIG_GNUTLS is set, but GNUTLS_CFLAGS, that describe include path, are not propagated transitively to all users of crypto and build fails if GnuTLS headers reside in non-standard directory (which is a case for homebrew on Apple Silicon). Signed-off-by

Re: [RFC PATCH 3/5] hw/pci-host/bonito: Remap PCI "lo" regions when PCIMAP reg is modified

2021-01-02 Thread Peter Maydell
On Sat, 2 Jan 2021 at 11:22, BALATON Zoltan wrote: > I have similar code in the series I've just posted where I'm mapping > regions of serial devices. I did consider using set_enabled and > set_address but ended up with removing and adding regions because I'm not > sure what happens if guest tries

Re: [PATCH 00/22] hw/riscv: sifive_u: Add missing SPI support

2021-01-02 Thread Bin Meng
Hi Pragnesh, On Sat, Jan 2, 2021 at 8:27 PM Pragnesh Patel wrote: > > Hi BIn, > > 1) Please rebase this series on master. I remember I rebased it on master already. > > 2) When i tried to boot from SD card image it shows below, > > pragneshp:sifive-qemu$ ./build/riscv64-softmmu/qemu-system-risc

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-02 Thread Peter Maydell
On Sat, 2 Jan 2021 at 12:54, Roman Bolshakov wrote: > > crypto/tlscreds.h includes GnuTLS headers if CONFIG_GNUTLS is set, but > GNUTLS_CFLAGS, that describe include path, are not propagated > transitively to all users of crypto and build fails if GnuTLS headers > reside in non-standard directory

Re: [PATCH 00/22] hw/riscv: sifive_u: Add missing SPI support

2021-01-02 Thread Bin Meng
Hi Pragnesh, On Sat, Jan 2, 2021 at 9:30 PM Pragnesh Patel wrote: > > Hi Bin, > > On Sat, Jan 2, 2021 at 6:46 PM Bin Meng wrote: > > > > Hi Pragnesh, > > > > On Sat, Jan 2, 2021 at 8:27 PM Pragnesh Patel > > wrote: > > > > > > Hi BIn, > > > > > > 1) Please rebase this series on master. > > > >

Re: [RFC PATCH 3/5] hw/pci-host/bonito: Remap PCI "lo" regions when PCIMAP reg is modified

2021-01-02 Thread BALATON Zoltan via
On Sat, 2 Jan 2021, Peter Maydell wrote: On Sat, 2 Jan 2021 at 11:22, BALATON Zoltan wrote: I have similar code in the series I've just posted where I'm mapping regions of serial devices. I did consider using set_enabled and set_address but ended up with removing and adding regions because I'm

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-02 Thread Roman Bolshakov
On Sat, Jan 02, 2021 at 01:25:07PM +, Peter Maydell wrote: > On Sat, 2 Jan 2021 at 12:54, Roman Bolshakov wrote: > > > > crypto/tlscreds.h includes GnuTLS headers if CONFIG_GNUTLS is set, but > > GNUTLS_CFLAGS, that describe include path, are not propagated > > transitively to all users of cry

Re: [PATCH 03/22] hw/sd: ssi-sd: Fix incorrect card response sequence

2021-01-02 Thread Pragnesh Patel
On Thu, Dec 31, 2020 at 5:04 PM Bin Meng wrote: > > From: Bin Meng > > Per the "Physical Layer Specification Version 8.00" chapter 7.5.1, > "Command/Response", there is a minimum 8 clock cycles (Ncr) before > the card response shows up on the data out line. However current > implementation jumps

Re: [PATCH 05/22] hw/sd: sd: Drop sd_crc16()

2021-01-02 Thread Pragnesh Patel
On Thu, Dec 31, 2020 at 5:04 PM Bin Meng wrote: > > From: Bin Meng > > commit f6fb1f9b319f ("sdcard: Correct CRC16 offset in sd_function_switch()") > changed the 16-bit CRC to be stored at offset 64. In fact, this CRC > calculation is completely wrong. From the original codes, it wants > to calcu

Re: [PATCH 00/22] hw/riscv: sifive_u: Add missing SPI support

2021-01-02 Thread Pragnesh Patel
Hi BIn, 1) Please rebase this series on master. 2) When i tried to boot from SD card image it shows below, pragneshp:sifive-qemu$ ./build/riscv64-softmmu/qemu-system-riscv64 -M sifive_u,msel=11 -m 4G -nographic -bios ~/opensource/u-boot/spl/u-boot-spl.bin -device sd-card,spi=true,drive=mycard -d

Re: [PATCH 04/22] hw/sd: sd: Support CMD59 for SPI mode

2021-01-02 Thread Pragnesh Patel
On Thu, Dec 31, 2020 at 5:04 PM Bin Meng wrote: > > From: Bin Meng > > After the card is put into SPI mode, CRC check for all commands > including CMD0 will be done according to CMD59 setting. But this > command is currently unimplemented. Simply allow the decoding of > CMD59, but the CRC check i

Re: [PATCH 00/22] hw/riscv: sifive_u: Add missing SPI support

2021-01-02 Thread Pragnesh Patel
Hi Bin, On Sat, Jan 2, 2021 at 6:46 PM Bin Meng wrote: > > Hi Pragnesh, > > On Sat, Jan 2, 2021 at 8:27 PM Pragnesh Patel > wrote: > > > > Hi BIn, > > > > 1) Please rebase this series on master. > > I remember I rebased it on master already. It shows below, pragneshp:sifive-qemu$ git am hw-ri

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-02 Thread Paolo Bonzini
On 02/01/21 14:25, Peter Maydell wrote: Question to Paolo -- it seems pretty fragile to have to explicitly list "these source files need these extra CFLAGS" in half a dozen meson.build files, because it's pretty non-obvious that adding eg '#include "block/nbd.h"' to a .c file means that you also