On Jan 26 14:02, Dmitry Fomichev wrote:
> The code in nvme_check_zone_write() first checks for zone boundary
> condition violation and only after that it proceeds to verify that the
> zone state is suitable the write to happen. This is not consistent with
> nvme_check_zone_read() flow - in that fun
On Jan 26 14:02, Dmitry Fomichev wrote:
> It is observed that with the existing code it is possible to keep
> appending to a zone indefinitely. To fix, add the missing check to
> verify that the zone append is not going to write beyond zone capacity.
>
> Reported-by: Niklas Cassel
> Signed-off-by
On 1/24/21 10:41 PM, Richard Henderson wrote:
> On 1/24/21 10:24 AM, Philippe Mathieu-Daudé wrote:
>> On 1/24/21 9:07 PM, Richard Henderson wrote:
>>> Doesn't this get put in libutil, where it is only pulled from the archive
>>> when
>>> needed? Also, libutil is built once, not per-target.
>>
>>
On 1/26/21 8:08 AM, Philippe Mathieu-Daudé wrote:
> On 1/26/21 6:55 AM, Joelle van Dyne wrote:
>> Previously, the only case where sys/disk.h does not exist is on
>> platforms that define __DragonFly__. However, iOS also does not have
>> this header. Previously, I had it as
>>
>> #if defined(__Drago
Kevin Wolf writes:
> Am 25.01.2021 um 17:24 hat Markus Armbruster geschrieben:
>> The previous commit rendered the name fdctrl_realize_common() somewhat
>> misleading. Get rid of it by inlining the (now pretty simple)
>> function into its only caller.
>>
>> Signed-off-by: Markus Armbruster
>>
On 1/26/21 6:55 AM, Joelle van Dyne wrote:
> Previously, the only case where sys/disk.h does not exist is on
> platforms that define __DragonFly__. However, iOS also does not have
> this header. Previously, I had it as
>
> #if defined(__DragonFly__) || defined(CONFIG_IOS)
>
> But there was a code
On Jan 26 04:55, Dmitry Fomichev wrote:
> On Tue, 2021-01-19 at 14:54 +0100, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > When a zone append is processed the controller checks that validity of
> > the write before assigning the LBA to the append command. This causes
> > the boundary check t
Previously, the only case where sys/disk.h does not exist is on
platforms that define __DragonFly__. However, iOS also does not have
this header. Previously, I had it as
#if defined(__DragonFly__) || defined(CONFIG_IOS)
But there was a code review comment that we should use feature flags
instead
It is observed that with the existing code it is possible to keep
appending to a zone indefinitely. To fix, add the missing check to
verify that the zone append is not going to write beyond zone capacity.
Reported-by: Niklas Cassel
Signed-off-by: Dmitry Fomichev
---
hw/block/nvme.c | 8 +---
The code in nvme_check_zone_write() first checks for zone boundary
condition violation and only after that it proceeds to verify that the
zone state is suitable the write to happen. This is not consistent with
nvme_check_zone_read() flow - in that function, zone state is checked
before making any b
These patches solve a few problems that exist in zoned Write
ans Zone Append validation code.
Dmitry Fomichev (3):
hw/block/nvme: Check for zone boundary during append
hw/block/nvme: Check zone state before checking boundaries
hw/block/nvme: Add trace events for zone boundary violations
hw
Add three new trace events to be raised in case of zone boundary
violations during Read, Write(Zeroes) and Zone Append.
Signed-off-by: Dmitry Fomichev
---
hw/block/nvme.c | 8 ++--
hw/block/trace-events | 3 +++
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/hw/block/nv
On Mon, 2021-01-25 at 09:22 +0100, Klaus Jensen wrote:
> From: Gollu Appalanaidu
>
> Change status checks to align with the existing style and remove the
> explicit check against NVME_SUCCESS.
>
> Cc: Dmitry Fomichev
> Signed-off-by: Gollu Appalanaidu
> Reviewed-by: Klaus Jensen
Looks good.
On Tue, 2021-01-19 at 14:55 +0100, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Refactor the zone write check logic such that the most "meaningful"
> error is returned first. That is, first, if the zone is not writable,
> return an appropriate status code for that. Then, make sure we are
> actual
On Tue, 2021-01-19 at 14:54 +0100, Klaus Jensen wrote:
> From: Klaus Jensen
>
> When a zone append is processed the controller checks that validity of
> the write before assigning the LBA to the append command. This causes
> the boundary check to be wrong.
>
> Fix this by checking the write *aft
From: Bin Meng
The SEND_IF_COND command (CMD8) response is of format R7, but
current code returns R1 for CMD8. Fix it.
Fixes: 775616c3ae8c ("Partial SD card SPI mode support")
Signed-off-by: Bin Meng
---
When testing with VxWorks driver, this additional issue was exposed.
It looks like VxWorks
From: Michael Qiu
v3: reformat the commit log, remove duplicate content
v2: modify the coredump backtrace within commit log with the newest
qemu with master branch
Currently, if guest has workloads, IO thread will acquire aio_context
lock before do io_submit, it leads to segmentfault when d
From: Michael Qiu
v2: modify the coredump backtrace within commit log with the newest
qemu with master branch
Currently, if guest has workloads, IO thread will acquire aio_context
lock before do io_submit, it leads to segmentfault when do block commit
after snapshot. Just like below:
Progra
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure
will succeed with CONFIG_PREADV even when targeting a lower OS version.
We therefore need to check at run time if we can actually use these APIs.
Signed-off-by: Joelle van Dyne
---
block/file-posix.c | 33 +
On Darwin (iOS), there are no system level APIs for directly accessing
host block devices. We detect this at configure time.
Signed-off-by: Joelle van Dyne
---
meson.build | 6 +-
qapi/block-core.json | 10 +++---
block/file-posix.c | 33 ++---
3 f
Some BSD platforms do not have this header.
Signed-off-by: Joelle van Dyne
---
meson.build| 1 +
block.c| 2 +-
block/file-posix.c | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index 27110075df..6818d97df5 100644
--- a/meson.
On 21-01-25 21:29:58, Klaus Jensen wrote:
> On Jan 24 11:54, Minwoo Im wrote:
> > Hello,
> >
> > This is sixth patch series for the support of NVMe subsystem scheme with
> > multi-controller and namespace sharing in a subsystem.
> >
> > This version has a fix in nvme_init_ctrl() when 'cntlid' is
On 21-01-25 10:11:43, Keith Busch wrote:
> On Mon, Jan 25, 2021 at 07:03:32PM +0100, Klaus Jensen wrote:
> > On Jan 24 11:54, Minwoo Im wrote:
> > > We have nvme-subsys and nvme devices mapped together. To support
> > > multi-controller scheme to this setup, controller identifier(id) has to
> > >
The actual parameter name is 'cross_read' rather than 'cross_zone_read'.
Signed-off-by: Minwoo Im
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 21aec90637fa..bf9134f73d81 100644
--- a/hw/block/nvme.c
+++ b/hw/block
Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Add TestEnv class, which will handle test environment in a new python
> iotests running framework.
>
> Don't add compat=1.1 for qcow2 IMGOPTS, as v3 is default anyway.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
>
On Mon, 2021-01-25 at 08:25 +0100, Klaus Jensen wrote:
> On Jan 19 14:54, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2]
> > refactors the zone write check function to return status codes in a
> > different order if there are mul
From: Gollu Appalanaidu
Add support for using the broadcast nsid to issue a flush on all
namespaces through a single command.
Signed-off-by: Gollu Appalanaidu
Reviewed-by: Klaus Jensen
---
include/block/nvme.h | 8 +++
hw/block/nvme.c | 123 +++---
On Jan 24 11:54, Minwoo Im wrote:
> Hello,
>
> This is sixth patch series for the support of NVMe subsystem scheme with
> multi-controller and namespace sharing in a subsystem.
>
> This version has a fix in nvme_init_ctrl() when 'cntlid' is set to the
> Identify Controller data structure by makin
On Jan 24 11:54, Minwoo Im wrote:
> To support multi-path in QEMU NVMe device model, We need to have NVMe
> subsystem hierarchy to map controllers and namespaces to a NVMe
> subsystem.
>
> This patch introduced a simple nvme-subsys device model. The subsystem
> will be prepared with subsystem NQN
On Jan 24 11:54, Minwoo Im wrote:
> nvme-ns device is registered to a nvme controller device during the
> initialization in nvme_register_namespace() in case that 'bus' property
> is given which means it's mapped to a single controller.
>
> This patch introduced a new property 'subsys' just like t
Another possibility is to place the if in block/meson.build, using
subdir_done() to stop the processing of the directory.
Paolo
Il lun 25 gen 2021, 13:15 Kevin Wolf ha scritto:
> Am 22.01.2021 um 21:44 hat Philippe Mathieu-Daudé geschrieben:
> > Avoid generating module_block.h and block-gen.c i
check script will be stricter soon about whitespaces, so fix 146.out
now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/146.out | 780 ++---
1 file changed, 390 insertions(+), 390 deletions(-)
diff --git a/tests/qemu-iotests/146.out b/tests/q
Rename bitmaps migration tests and move them to tests subdirectory to
demonstrate new human-friendly test naming.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} | 0
.../{199.out => tests/migrate-bitmaps-postcopy-test.out}
Just use classes introduced in previous three commits. Behavior
difference is described in these three commits.
Drop group file, as it becomes unused.
Drop common.env: now check is in python, and for tests we use same
python interpreter that runs the check itself. Use build environment
PYTHON in
Add python script with new logic of searching for tests:
Current ./check behavior:
- tests are named [0-9][0-9][0-9]
- tests must be registered in group file (even if test doesn't belong
to any group, like 142)
Behavior of findtests.py:
- group file is dropped
- tests are all files in test
Add TestEnv class, which will handle test environment in a new python
iotests running framework.
Don't add compat=1.1 for qcow2 IMGOPTS, as v3 is default anyway.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/testenv.py | 279 ++
1 file change
Add TestRunner class, which will run tests in a new python iotests
running framework.
There are some differences with current ./check behavior, most
significant are:
- Consider all tests self-executable, just run them, don't run python
by hand.
- Elapsed time is cached in json file
- Elapsed tim
v9:
01: new, one more whitespace-fixing patch
testenv: allow case when we don't have system-arch emulator, but have several
for another architectures
change direct os.access(..., os.X_OK) calls to new helper function
which also check that path is a file
testrunner: s/fail/not run/ for 'N
On Mon, Jan 25, 2021 at 07:03:32PM +0100, Klaus Jensen wrote:
> On Jan 24 11:54, Minwoo Im wrote:
> > We have nvme-subsys and nvme devices mapped together. To support
> > multi-controller scheme to this setup, controller identifier(id) has to
> > be managed. Earlier, cntlid(controller id) used to
On Jan 25 10:02, Keith Busch wrote:
> On Mon, Jan 25, 2021 at 09:22:24AM +0100, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Misc fixes from Gollu.
>
> Looks good.
>
> Reviewed-by: Keith Busch
Thanks, applied!
signature.asc
Description: PGP signature
On Jan 24 11:54, Minwoo Im wrote:
> We have nvme-subsys and nvme devices mapped together. To support
> multi-controller scheme to this setup, controller identifier(id) has to
> be managed. Earlier, cntlid(controller id) used to be always 0 because
> we didn't have any subsystem scheme that contro
On Mon, Jan 25, 2021 at 09:22:24AM +0100, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Misc fixes from Gollu.
Looks good.
Reviewed-by: Keith Busch
Am 25.01.2021 um 17:24 hat Markus Armbruster geschrieben:
> The previous commit rendered the name fdctrl_realize_common() somewhat
> misleading. Get rid of it by inlining the (now pretty simple)
> function into its only caller.
>
> Signed-off-by: Markus Armbruster
> ---
> hw/block/fdc.c | 23 ++
Am 25.01.2021 um 17:36 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 25.01.2021 19:08, Kevin Wolf wrote:
> > Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > v8:
> > >
> > > about linters:
> > >
> > > I didn't modify 297, as Max already staged 297 modifications to test
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> From: Philippe Mathieu-Daudé
>
> Just for consistency, following the example documented since
> commit e3fe3988d7 ("error: Document Error API usage rules"),
> return a boolean value indicating an error is set or not.
>
> Acked-by: Pavel Dovgaly
25.01.2021 19:08, Kevin Wolf wrote:
Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
v8:
about linters:
I didn't modify 297, as Max already staged 297 modifications to test all files.
Also, now I have two complains:
+* Module testenv
+testenv.py:158:4: R0915: T
The previous commit rendered the name fdctrl_realize_common() somewhat
misleading. Get rid of it by inlining the (now pretty simple)
function into its only caller.
Signed-off-by: Markus Armbruster
---
hw/block/fdc.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate
configuring floppies with -global isa-fdc" (v5.1.0).
Signed-off-by: Markus Armbruster
---
docs/system/deprecated.rst | 26 --
docs/system/removed-features.rst | 26 ++
hw/block/fdc.c | 54 +--
tests/qemu-iot
Markus Armbruster (3):
fdc: Drop deprecated floppy configuration
fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()
blockdev: Drop deprecated bogus -drive interface type
docs/system/deprecated.rst | 33 --
docs/system/removed-features.rst | 33 ++
include/sysemu/blockd
25.01.2021 19:08, Kevin Wolf wrote:
Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
v8:
about linters:
I didn't modify 297, as Max already staged 297 modifications to test all files.
Also, now I have two complains:
+* Module testenv
+testenv.py:158:4: R0915: T
Drop the crap deprecated in commit a1b40bda08 "blockdev: Deprecate
-drive with bogus interface type" (v5.1.0).
Signed-off-by: Markus Armbruster
---
docs/system/deprecated.rst | 7 --
docs/system/removed-features.rst | 7 ++
include/sysemu/blockdev.h| 1 -
blockdev.c
Am 25.01.2021 um 17:01 hat Philippe Mathieu-Daudé geschrieben:
> On 1/25/21 4:43 PM, Kevin Wolf wrote:
> > Am 25.01.2021 um 16:05 hat Philippe Mathieu-Daudé geschrieben:
> >> Is it possible to restrict a block driver to a particular set of
> >> options? In my case I'd like to restrict the raw drive
Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
> v8:
>
> about linters:
>
> I didn't modify 297, as Max already staged 297 modifications to test all
> files.
>
> Also, now I have two complains:
> +* Module testenv
> +testenv.py:158:4: R0915: Too many statements
On Mon, 25 Jan 2021 at 16:03, Philippe Mathieu-Daudé wrote:
> The problem is when emulating devices such NOR Flash (parallel mapping
> or SD cards) we expect the block driver being a plain file (either "raw"
> format or another) but a "regular" file. When an user passes something
> else like a blo
On 1/25/21 4:43 PM, Kevin Wolf wrote:
> Am 25.01.2021 um 16:05 hat Philippe Mathieu-Daudé geschrieben:
>> Is it possible to restrict a block driver to a particular set of
>> options? In my case I'd like to restrict the raw driver to regular files.
>>
>> I noticed the NFS driver does it locally in n
Am 25.01.2021 um 16:05 hat Philippe Mathieu-Daudé geschrieben:
> Is it possible to restrict a block driver to a particular set of
> options? In my case I'd like to restrict the raw driver to regular files.
>
> I noticed the NFS driver does it locally in nfs_client_open(),
> and FUSE has is_regular
From: Michael Qiu
Currently, if guest has workloads, IO thread will acquire aio_context
lock before do io_submit, it leads to segmentfault when do block commit
after snapshot. Just like below:
[Switching to thread 2 (Thread 0x7f046c312700 (LWP 108791))]
#0 0x5573f57930db in bdrv_mirror_top_p
From: Michael Qiu
Currently, if guest has workloads, IO thread will acquire aio_context
lock before do io_submit, it leads to segmentfault when do block commit
after snapshot. Just like below:
[Switching to thread 2 (Thread 0x7f046c312700 (LWP 108791))]
#0 0x5573f57930db in bdrv_mirror_top_p
Hi,
Is it possible to restrict a block driver to a particular set of
options? In my case I'd like to restrict the raw driver to regular files.
I noticed the NFS driver does it locally in nfs_client_open(),
and FUSE has is_regular_file() -- which is POSIX specific however.
When a backend is a SCS
You forgot to Cc the subsystem maintainers...
./scripts/get_maintainer.pl -f hw/scsi/megasas.c
Hannes Reinecke (supporter:megasas)
Paolo Bonzini (supporter:SCSI)
Fam Zheng (reviewer:SCSI)
On 1/25/21 3:22 PM, Mauro Matteo Cascella wrote:
> Hello,
>
> Any updates on this little patch? Please fi
Hello,
Any updates on this little patch? Please find below a reproducer for
this bug (thanks Alexander):
https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg02567.html
Thank you,
On Thu, Dec 24, 2020 at 6:55 PM Mauro Matteo Cascella
wrote:
>
> Ensure that 'cmd->frame' is not NULL before
On Sun, 24 Jan 2021 at 20:13, Philippe Mathieu-Daudé wrote:
>
> The following changes since commit e93c65a6c64fa18b0c61fb9338d364cbea32b6ef:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/usb-20210122-pull-request' into staging (2021-01-23
> 14:40:45 +)
>
> are available in the Gi
24.01.2021 00:04, Vladimir Sementsov-Ogievskiy wrote:
Add TestEnv class, which will handle test environment in a new python
iotests running framework.
Don't add compat=1.1 for qcow2 IMGOPTS, as v3 is default anyway.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/testenv.py
25.01.2021 15:02, Kevin Wolf wrote:
Am 23.01.2021 um 16:08 hat Vladimir Sementsov-Ogievskiy geschrieben:
22.01.2021 19:08, Kevin Wolf wrote:
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben:
Just use classes introduced in previous three commits. Behavior
difference is descri
Am 22.01.2021 um 21:44 hat Philippe Mathieu-Daudé geschrieben:
> Avoid generating module_block.h and block-gen.c if we are
> not going to use them.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: qemu-block@nongnu.org
> ---
> meson.build | 4 +++-
> 1 file changed, 3 insertions(+), 1 delet
Am 23.01.2021 um 16:08 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 22.01.2021 19:08, Kevin Wolf wrote:
> > Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > Just use classes introduced in previous three commits. Behavior
> > > difference is described in these three comm
On Mon, Jan 25, 2021 at 6:41 PM Dr. David Alan Gilbert
wrote:
>
> * Bin Meng (bmeng...@gmail.com) wrote:
> > On Mon, Jan 25, 2021 at 12:59 AM Philippe Mathieu-Daudé
> > wrote:
> > >
> > > On 1/23/21 11:40 AM, Bin Meng wrote:
> > > > From: Bin Meng
> > > >
> > > > With all these fixes and improv
* Bin Meng (bmeng...@gmail.com) wrote:
> On Mon, Jan 25, 2021 at 12:59 AM Philippe Mathieu-Daudé
> wrote:
> >
> > On 1/23/21 11:40 AM, Bin Meng wrote:
> > > From: Bin Meng
> > >
> > > With all these fixes and improvements, there is no way for the
> > > VMStateDescription to keep backward compati
On 1/24/21 9:28 PM, Philippe Mathieu-Daudé wrote:
> These are Bin's SD patches from his v2, rebased on sd-next.
>
> v2:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg775712.html
>
> Based-on: <20210124201106.2602238-1-f4...@amsat.org>
>
> Bin Meng (6):
> hw/sd: ssi-sd: Support multip
From: Gollu Appalanaidu
Change status checks to align with the existing style and remove the
explicit check against NVME_SUCCESS.
Cc: Dmitry Fomichev
Signed-off-by: Gollu Appalanaidu
Reviewed-by: Klaus Jensen
---
hw/block/nvme.c | 20 ++--
1 file changed, 10 insertions(+), 10
From: Gollu Appalanaidu
Currently, no features are saveable, so the current check is not wrong,
but add a check against the feature capabilities to make sure this will
not regress if saveable features are added later.
Signed-off-by: Gollu Appalanaidu
Reviewed-by: Klaus Jensen
---
hw/block/nvm
From: Klaus Jensen
Misc fixes from Gollu.
Gollu Appalanaidu (3):
hw/block/nvme: fix set feature for error recovery
hw/block/nvme: fix set feature save field check
hw/block/nvme: align with existing style
hw/block/nvme.c | 26 ++
1 file changed, 14 insertions(+), 1
From: Gollu Appalanaidu
Only enable DULBE if the namespace supports it.
Signed-off-by: Gollu Appalanaidu
Reviewed-by: Klaus Jensen
---
hw/block/nvme.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 21aec90637fa..e7983ff422f2 1006
73 matches
Mail list logo
