On Fri, 29 Jan 2021 at 17:27, Daniel P. Berrangé wrote:
>
> The following changes since commit 5101d00d2f1138a73344dc4833587f76d7a5fa5c:
>
> Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.0-p=
> ull-request' into staging (2021-01-29 10:10:43 +)
>
> are available in
On 29/01/21 20:44, Philippe Mathieu-Daudé wrote:
xenpv machine requires USB, IDE_PIIX and PCI:
/usr/bin/ld:
libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function
`xen_be_register_common':
hw/xen/xen-legacy-backend.c:757: undefined reference to `xen_usb_ops'
On 29/01/21 20:44, Philippe Mathieu-Daudé wrote:
hw/ide/piix.c has a strong dependency on hw/isa/isa-bus.c:
/usr/bin/ld: libcommon.fa.p/hw_ide_piix.c.o: in function
`pci_piix_init_ports':
/usr/bin/ld: hw/ide/piix.c:141: undefined reference to `isa_get_irq'
Signed-off-by: Philippe
On 29/01/21 20:44, Philippe Mathieu-Daudé wrote:
hw/ide/ioport.c has a strong dependency on hw/isa/isa-bus.c:
/usr/bin/ld: libcommon.fa.p/hw_ide_ioport.c.o: in function `ide_init_ioport':
/usr/bin/ld: hw/ide/ioport.c:61: undefined reference to
`isa_register_portio_list'
Signed-off-by:
9pfs is not an accelerator feature but a machine one.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/Kconfig | 1 -
hw/xen/Kconfig | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/Kconfig b/accel/Kconfig
index 461104c7715..b9e9a2d35b0 100644
--- a/accel/Kconfig
+++
xenpv machine requires USB, IDE_PIIX and PCI:
/usr/bin/ld:
libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function
`xen_be_register_common':
hw/xen/xen-legacy-backend.c:757: undefined reference to `xen_usb_ops'
libqemu-i386-softmmu.fa.p/hw_i386_xen_xen_platform.c.o: in function
hw/ide/piix.c has a strong dependency on hw/isa/isa-bus.c:
/usr/bin/ld: libcommon.fa.p/hw_ide_piix.c.o: in function
`pci_piix_init_ports':
/usr/bin/ld: hw/ide/piix.c:141: undefined reference to `isa_get_irq'
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ide/Kconfig | 1 +
1 file changed, 1
hw/ide/ioport.c has a strong dependency on hw/isa/isa-bus.c:
/usr/bin/ld: libcommon.fa.p/hw_ide_ioport.c.o: in function `ide_init_ioport':
/usr/bin/ld: hw/ide/ioport.c:61: undefined reference to
`isa_register_portio_list'
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ide/Kconfig | 2 +-
1
Hi Alex,
These are the Xen patches I'm carrying to build the xenpv
machine alone. I haven't tried to build the xenfv one.
Tagged as RFC because this was part of a draft, so must be
think better, but I don't have much time to finish it.
Anyhow quick review appreciated.
Missing (out of scope of
On 1/29/21 4:06 AM, Vladimir Sementsov-Ogievskiy wrote:
We should drop final '\n' before comparing with python3 shebang.
Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
---
tests/qemu-iotests/testrunner.py | 2 +-
1
On 1/29/21 4:50 AM, Kevin Wolf wrote:
Am 28.01.2021 um 21:08 hat Vladimir Sementsov-Ogievskiy geschrieben:
28.01.2021 23:04, Vladimir Sementsov-Ogievskiy wrote:
Ignore two complains, which now lead to 297 failure on testenv.py and
testrunner.py.
Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
On 1/29/21 11:13 AM, Vladimir Sementsov-Ogievskiy wrote:
Ignore two complains, which now lead to 297 failure on testenv.py and
testrunner.py.
Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
^ Thanks for this
Signed-off-by: Vladimir
Primarily this is to pull in a fix for Win32 keycodes. The other useful
change is the removal of build timestamp from generated files which is
desirable for reproducable builds.
The make rules need updating due to slightly changed CLI syntax - more
args must now come after the command name.
From: shiliyang
I am reading crypto related code, find some code style problems while
using checkpatch.pl to check crypto folder. Fix the error style
problems.
Signed-off-by: Liyang Shi
Signed-off-by: Daniel P. Berrangé
---
crypto/aes.c| 4 ++--
crypto/desrfb.c | 2 +-
2 files changed, 3
From: Stefan Weil
This fixes several compiler warnings on MacOS with Homebrew. The
git development branch for forthcoming libtasn1 4.17.0 has introduced
deprecation warnings for several macros/types that we use.
Signed-off-by: Stefan Weil
Signed-off-by: Daniel P. Berrangé
---
From: Stefan Weil
A test with sanitizers on macOS shows this error:
authz/pamacct.c:50:25: runtime error: null pointer passed as argument 1,
which is declared to never be null
The distinction between short life and long life Linux distributions
turned out to be redundant. They can both be covered in a simple way
by noting support will target the current release, and the previous
release for a period of two years or until its EOL. This rule can also
apply to the other
On Fri, 29 Jan 2021 at 16:13, Peter Maydell wrote:
>
> On Fri, 29 Jan 2021 at 14:52, Kevin Wolf wrote:
> >
> > The following changes since commit 5101d00d2f1138a73344dc4833587f76d7a5fa5c:
> >
> > Merge remote-tracking branch
> > 'remotes/vivier2/tags/trivial-branch-for-6.0-pull-request' into
From: shiliyang
This patch fixes error style problems found by checkpatch.pl:
ERROR: spaces required around that '*'
ERROR: space required after that ','
ERROR: spaces required around that '|'
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Liyang Shi
Signed-off-by: Daniel P. Berrangé
---
Am 29.01.2021 um 17:13 hat Peter Maydell geschrieben:
> On Fri, 29 Jan 2021 at 14:52, Kevin Wolf wrote:
> >
> > The following changes since commit 5101d00d2f1138a73344dc4833587f76d7a5fa5c:
> >
> > Merge remote-tracking branch
> > 'remotes/vivier2/tags/trivial-branch-for-6.0-pull-request' into
Patchew URL:
https://patchew.org/QEMU/20210129165030.640169-1-vsement...@virtuozzo.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210129165030.640169-1-vsement...@virtuozzo.com
Subject: [PATCH 0/7] qcow2:
Patchew URL:
https://patchew.org/QEMU/20210129171102.4109641-1-berra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210129171102.4109641-1-berra...@redhat.com
Subject: [PULL 00/13] Misc patches
===
From: Dan Streetman
Replace the --enable-git-update and --disable-git-update configure params
with the param --with-git-submodules=(update|validate|ignore) to
allow 3 options for building from a git repo.
This is needed because downstream packagers, e.g. Debian, Ubuntu, etc,
also keep the
From: Kevin Wolf
If you set the loaded property to true when it was already true, the
state is overwritten without freeing the old state first. Change the
set_loaded callback so that it always frees the old state (which is a
no-op if nothing was loaded) and only then load if requestsd.
The -enable-fips option was added a long time ago to prevent the use of
single DES when VNC when FIPS mode is enabled. It should never have been
added, because apps are supposed to unconditionally honour FIPS mode
based on the '/proc/sys/crypto/fips_enabled' file contents.
In addition there is
From: Kevin Wolf
Instead of duplicating the code for user creatable objects in secret and
secret_keyring, move it to the common base clase secret_common. As the
base class is abstract, it won't become user creatable itself.
Signed-off-by: Kevin Wolf
Signed-off-by: Daniel P. Berrangé
---
Allow benchmark with different kinds of target cache.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/simplebench/bench-backup.py| 33 --
scripts/simplebench/bench_block_job.py | 10 +---
2 files changed, 33 insertions(+), 10 deletions(-)
diff --git
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
docs/system/tls.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/system/tls.rst b/docs/system/tls.rst
index dc2b94257f..b0973afe1b 100644
--- a/docs/system/tls.rst
+++ b/docs/system/tls.rst
@@ -64,7
Update some docs and test cases to use 'on' | 'off' as the preferred
value for bool options.
Reviewed-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
docs/system/vnc-security.rst | 10 +-
include/authz/listfile.h | 2 +-
qemu-options.hx
From: Kevin Wolf
qcrypto_secret_prop_set_loaded() forgets to reset secret->rawdata after
unloading a secret, which will lead to a double free at some point.
Because there is no use case for unloading an already loaded secret
(apart from deleting the whole secret object) and we know that nobody
The following changes since commit 5101d00d2f1138a73344dc4833587f76d7a5fa5c:
Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.0-p=
ull-request' into staging (2021-01-29 10:10:43 +)
are available in the Git repository at:
https://gitlab.com/berrange/qemu
Allow bench compressed backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/simplebench/bench-backup.py| 55 ++
scripts/simplebench/bench_block_job.py | 23 +++
2 files changed, 62 insertions(+), 16 deletions(-)
diff --git
statistics.stdev raises if sequence length is less than two. Support
that case by hand.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/simplebench/simplebench.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/simplebench/simplebench.py
Add QLIST_FOREACH_FUNC_SAFE(), QTAILQ_FOREACH_FUNC_SAFE() and
QTAILQ_POP_HEAD(), to be used in following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/qemu/queue.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/include/qemu/queue.h b/include/qemu/queue.h
Hi all!
I know, I have several series waiting for a resend, but I had to switch
to another task spawned from our customer's bug.
Original problem: we use O_DIRECT for all vm images in our product, it's
the policy. The only exclusion is backup target qcow2 image for
compressed backup, because
Compressed writes and O_DIRECT are not friends: they works too slow,
because compressed writes does many small unaligned to 512 writes.
Let's introduce an internal cache, so that compressed writes may work
well when O_DIRECT is on.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.h
Sometimes one of cells in a testing table runs too slow. And we really
don't want to wait so long. Limit number of runs in this case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/simplebench/simplebench.py | 29 +
1 file changed, 25 insertions(+), 4
Introduce a new option: compressed-cache-size, with default to 64
clusters (to be not less than 64 default max-workers for backup job).
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 8 +++-
block/qcow2.h | 4 ++
block/qcow2-refcount.c | 13 +++
Ignore two complains, which now lead to 297 failure on testenv.py and
testrunner.py.
Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/pylintrc | 2 ++
1 file changed, 2
On Fri, 29 Jan 2021 at 14:52, Kevin Wolf wrote:
>
> The following changes since commit 5101d00d2f1138a73344dc4833587f76d7a5fa5c:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/trivial-branch-for-6.0-pull-request' into staging
> (2021-01-29 10:10:43 +)
>
> are available in the
From: Vladimir Sementsov-Ogievskiy
We should drop final '\n' before comparing with python3 shebang.
Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20210129090616.84145-1-vsement...@virtuozzo.com>
Tested-by: Thomas Huth
Signed-off-by:
The following changes since commit 5101d00d2f1138a73344dc4833587f76d7a5fa5c:
Merge remote-tracking branch
'remotes/vivier2/tags/trivial-branch-for-6.0-pull-request' into staging
(2021-01-29 10:10:43 +)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git
From: Vladimir Sementsov-Ogievskiy
check-block.sh called by make check-block rely on PYTHON variable being
set.
Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20210129051346.56109-1-vsement...@virtuozzo.com>
Tested-by: Thomas Huth
Hi Bin,
On 1/29/21 9:51 AM, Bin Meng wrote:
> From: Bin Meng
>
> Unlike SD mode, when SD card is working in SPI mode, the argument
> of CMD13 is stuff bits. Hence we should bypass the RCA check.
Is this for detecting events by polling? From spec v8:
5.7.5 Event Indication Method
5.7.5.1
On 29/01/21 13:17, Daniel P. Berrangé wrote:
On this one, my vote would be "no". "Versioned machine names
include the QEMU version number" is pretty well entrenched,
and requiring users to remember that when they want version 4.2
they need to remember some other way of writing it than "4.2"
Markus Armbruster writes:
> QAPI has naming rules. docs/devel/qapi-code-gen.txt:
>
> === Naming rules and reserved names ===
>
> All names must begin with a letter, and contain only ASCII letters,
> digits, hyphen, and underscore. There are two exceptions: enum values
> may
On Fri, Jan 29, 2021 at 12:01:53PM +, Peter Maydell wrote:
> On Fri, 29 Jan 2021 at 08:15, Markus Armbruster wrote:
> > 2. We have some 550 type names containing '.'. QAPI's naming rules
> >could be relaxed to accept '.', but keyval_parse()'s can't.
> >
> >Aside: I wish
On Fri, 29 Jan 2021 at 08:15, Markus Armbruster wrote:
> 2. We have some 550 type names containing '.'. QAPI's naming rules
>could be relaxed to accept '.', but keyval_parse()'s can't.
>
>Aside: I wish keyval_parse() would use '/' instead of '.', but it's
>designed to be compatible
Am 29.01.2021 um 06:13 hat Vladimir Sementsov-Ogievskiy geschrieben:
> check-block.sh called by make check-block rely on PYTHON variable being
> set.
>
> Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Thanks, applied to the block branch.
Kevin
Am 29.01.2021 um 10:06 hat Vladimir Sementsov-Ogievskiy geschrieben:
> We should drop final '\n' before comparing with python3 shebang.
>
> Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Thanks, applied to the block branch.
Kevin
Am 28.01.2021 um 21:08 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 28.01.2021 23:04, Vladimir Sementsov-Ogievskiy wrote:
> > Ignore two complains, which now lead to 297 failure on testenv.py and
> > testrunner.py.
> >
> > Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
> > Fixes:
On 29/01/2021 06.13, Vladimir Sementsov-Ogievskiy wrote:
check-block.sh called by make check-block rely on PYTHON variable being
set.
Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Hi! As Peter reported, build fails on platforms where python3
On 29/01/2021 10.06, Vladimir Sementsov-Ogievskiy wrote:
We should drop final '\n' before comparing with python3 shebang.
Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/testrunner.py | 2 +-
1 file changed, 1 insertion(+),
On 1/29/21 9:23 AM, Max Reitz wrote:
> On 29.01.21 06:26, Vladimir Sementsov-Ogievskiy wrote:
>> 28.01.2021 21:38, Philippe Mathieu-Daudé wrote:
>>> Hi Andrey,
>>>
>>> On 1/26/21 3:19 PM, Max Reitz wrote:
From: Andrey Shinkevich
This patch completes the series with the COR-filter
Paolo Bonzini writes:
> On 29/01/21 09:15, Markus Armbruster wrote:
>> diff --git a/hw/block/fdc.c b/hw/block/fdc.c
>> index 7fc547c62d..0dd158bf73 100644
>> --- a/hw/block/fdc.c
>> +++ b/hw/block/fdc.c
>> @@ -2547,7 +2547,7 @@ void sun4m_fdctrl_init(qemu_irq irq, hwaddr io_base,
>>
From: Klaus Jensen
Add support for TP 4065a ("Simple Copy Command"), v2020.05.04
("Ratified").
The implementation uses a bounce buffer to first read in the source
logical blocks, then issue a write of that bounce buffer. The default
maximum number of source logical blocks is 128, translating to
Forgot to mention:
Based-on: <20210125162402.1807394-1-arm...@redhat.com>
[PATCH 0/3] Drop deprecated floppy config & bogus -drive if=T
From: Klaus Jensen
Zone transition handling and resource management is open coded (and
semi-duplicated in the case of open, close and finish).
In preparation for Simple Copy command support (which also needs to open
zones for writing), consolidate into a set of 'nvme_zrm' functions and
in the
From: Klaus Jensen
Add support for TP 4065 ("Simple Copy Command").
Changes for v5
* rebased on nvme-next (support for zoned namespaces)
Changes for v4
* merge for-loops (Keith)
Changes for v3
* rebased on nvme-next
* changed the default msrc value to a more reasonable 127 from 255
From: Klaus Jensen
In preparation for Simple Copy, pull write pointer advancement into a
separate function that is independent on an NvmeRequest.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git
From: Klaus Jensen
Add new data structures and types for the Simple Copy command.
Signed-off-by: Klaus Jensen
Reviewed-by: Minwoo Im
Acked-by: Stefan Hajnoczi
---
include/block/nvme.h | 45 ++--
1 file changed, 43 insertions(+), 2 deletions(-)
diff
From: Klaus Jensen
Remove the unused NvmeCtrl parameter in nvme_check_zone_write.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 8ac997735041..79d9563a17bd 100644
---
We should drop final '\n' before comparing with python3 shebang.
Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/testrunner.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/testrunner.py
On 29/01/21 09:15, Markus Armbruster wrote:
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index 7fc547c62d..0dd158bf73 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -2547,7 +2547,7 @@ void sun4m_fdctrl_init(qemu_irq irq, hwaddr io_base,
DeviceState *dev;
FDCtrlSysBus *sys;
-
29.01.2021 11:25, Thomas Huth wrote:
On 29/01/2021 06.13, Vladimir Sementsov-Ogievskiy wrote:
check-block.sh called by make check-block rely on PYTHON variable being
set.
Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Hi! As Peter reported,
From: Bin Meng
Unlike SD mode, when SD card is working in SPI mode, the argument
of CMD13 is stuff bits. Hence we should bypass the RCA check.
Signed-off-by: Bin Meng
---
Based-on: http://patchwork.ozlabs.org/project/qemu-devel/list/?series=226787
hw/sd/sd.c | 3 ++-
1 file changed, 2
On 29/01/2021 06.13, Vladimir Sementsov-Ogievskiy wrote:
check-block.sh called by make check-block rely on PYTHON variable being
set.
Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Hi! As Peter reported, build fails on platforms where python3
On 29.01.21 06:26, Vladimir Sementsov-Ogievskiy wrote:
28.01.2021 21:38, Philippe Mathieu-Daudé wrote:
Hi Andrey,
On 1/26/21 3:19 PM, Max Reitz wrote:
From: Andrey Shinkevich
This patch completes the series with the COR-filter applied to
block-stream operations.
Adding the filter makes it
29.01.2021 10:35, Roman Kagan wrote:
On Fri, Jan 29, 2021 at 08:51:39AM +0300, Vladimir Sementsov-Ogievskiy wrote:
28.01.2021 23:14, Roman Kagan wrote:
During the final phase of migration the NBD reconnection logic may
encounter situations it doesn't expect during regular operation.
This
Several QOM type names contain ',':
ARM,bitband-memory
etraxfs,pic
etraxfs,serial
etraxfs,timer
fsl,imx25
fsl,imx31
fsl,imx6
fsl,imx6ul
fsl,imx7
grlib,ahbpnp
grlib,apbpnp
grlib,apbuart
grlib,gptimer
grlib,irqmp
qemu,register
SUNW,bpp
QAPI has naming rules. docs/devel/qapi-code-gen.txt:
=== Naming rules and reserved names ===
All names must begin with a letter, and contain only ASCII letters,
digits, hyphen, and underscore. There are two exceptions: enum values
may start with a digit, and names that are
71 matches
Mail list logo
