[PULL for-6.0 0/4] emulated nvme docs and fixes for -rc3

2021-04-12 Thread Klaus Jensen
at: git://git.infradead.org/qemu-nvme.git tags/nvme-fixes-20210412-pull-request for you to fetch changes up to 98f84f5a4eca5c03e32fff20f246d9b4b96d6422: hw/block/nvme: drain namespaces on sq deletion (2021-04-12 08:55:23 +0200) emulated nvme docs

[PULL for-6.0 1/4] docs: add nvme emulation documentation

2021-04-12 Thread Klaus Jensen
From: Klaus Jensen Remove the docs/specs/nvme.txt and replace it with proper documentation in docs/system/nvme.rst. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé --- docs/specs/nvme.txt | 23 - docs/system/index.rst | 1 + docs/system/nvme.rst | 225 +++

[PULL for-6.0 4/4] hw/block/nvme: drain namespaces on sq deletion

2021-04-12 Thread Klaus Jensen
From: Klaus Jensen For most commands, when issuing an AIO, the BlockAIOCB is stored in the NvmeRequest aiocb pointer when the AIO is issued. The main use of this is cancelling AIOs when deleting submission queues (it is currently not used for Abort). However, some commands like Dataset Managemen

[PULL for-6.0 2/4] hw/block/nvme: map prp fix if prp2 contains non-zero offset

2021-04-12 Thread Klaus Jensen
From: Padmakar Kalghatgi nvme_map_prp needs to calculate the number of list entries based on the offset value. For the subsequent PRP2 list, need to ensure the number of entries is within the MAX number of PRP entries for a page. Signed-off-by: Padmakar Kalghatgi Signed-off-by: Klaus Jensen --

[PULL for-6.0 3/4] hw/block/nvme: store aiocb in compare

2021-04-12 Thread Klaus Jensen
From: Klaus Jensen nvme_compare() fails to store the aiocb from the blk_aio_preadv() call. Fix this. Fixes: 0a384f923f51 ("hw/block/nvme: add compare command") Cc: Gollu Appalanaidu Signed-off-by: Klaus Jensen Reviewed-by: Gollu Appalanaidu Reviewed-by: Minwoo Im --- hw/block/nvme.c | 3 ++-

Re: [PATCH for-6.0 v2 6/8] hw/block/nvme: update dmsrl limit on namespace detachment

2021-04-12 Thread Klaus Jensen
On Apr 9 19:39, Thomas Huth wrote: On 06/04/2021 09.24, Klaus Jensen wrote: On Apr 6 09:10, Philippe Mathieu-Daudé wrote: On 4/5/21 7:54 PM, Klaus Jensen wrote: From: Klaus Jensen The Non-MDTS DMSRL limit must be recomputed when namespaces are detached. Fixes: 645ce1a70cb6 ("hw/block/nvme

Re: [PATCH v3] hw/block/nvme: add device self test command support

2021-04-12 Thread Gollu Appalanaidu
On Mon, Apr 12, 2021 at 01:57:49PM +0530, Gollu Appalanaidu wrote: On Sat, Apr 10, 2021 at 12:35:20AM +0900, Keith Busch wrote: On Wed, Mar 31, 2021 at 02:54:27PM +0530, Gollu Appalanaidu wrote: This is to add support for Device Self Test Command (DST) and DST Log Page. Refer NVM Express specif

Re: [PATCH for-6.0] block/nbd: fix possible use after free of s->connect_thread

2021-04-12 Thread Roman Kagan
On Tue, Apr 06, 2021 at 06:51:14PM +0300, Vladimir Sementsov-Ogievskiy wrote: > If on nbd_close() we detach the thread (in > nbd_co_establish_connection_cancel() thr->state becomes > CONNECT_THREAD_RUNNING_DETACHED), after that point we should not use > s->connect_thread (which is set to NULL), as

Re: [PATCH for-6.0] block/nbd: fix possible use after free of s->connect_thread

2021-04-12 Thread Vladimir Sementsov-Ogievskiy
12.04.2021 11:45, Roman Kagan wrote: On Tue, Apr 06, 2021 at 06:51:14PM +0300, Vladimir Sementsov-Ogievskiy wrote: If on nbd_close() we detach the thread (in nbd_co_establish_connection_cancel() thr->state becomes CONNECT_THREAD_RUNNING_DETACHED), after that point we should not use s->connect_th

Re: [PULL for-6.0 0/4] emulated nvme docs and fixes for -rc3

2021-04-12 Thread Peter Maydell
into staging (2021-04-10 > 16:58:56 +0100) > > are available in the Git repository at: > > git://git.infradead.org/qemu-nvme.git tags/nvme-fixes-20210412-pull-request > > for you to fetch changes up to 98f84f5a4eca5c03e32fff20f246d9b4b96d6422: > > hw/block/

[PULL 1/1] block/nbd: fix possible use after free of s->connect_thread

2021-04-12 Thread Vladimir Sementsov-Ogievskiy
If on nbd_close() we detach the thread (in nbd_co_establish_connection_cancel() thr->state becomes CONNECT_THREAD_RUNNING_DETACHED), after that point we should not use s->connect_thread (which is set to NULL), as running thread may free it at any time. Still nbd_co_establish_connection() does exac

[PULL 0/1] NBD fix for 6.0-rc3

2021-04-12 Thread Vladimir Sementsov-Ogievskiy
The following changes since commit 555249a59e9cdd6b58da103aba5cf3a2d45c899f: Merge remote-tracking branch 'remotes/ehabkost-gl/tags/x86-next-pull-request' into staging (2021-04-10 16:58:56 +0100) are available in the Git repository at: https://src.openvz.org/scm/~vsementsov/qemu.git tags/pu

Re: [PATCH v3 06/36] block: drop ctx argument from bdrv_root_attach_child

2021-04-12 Thread Alberto Garcia
On Wed 17 Mar 2021 03:34:59 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Passing parent aio context is redundant, as child_class and parent > opaque pointer are enough to retrieve it. Drop the argument and use new > bdrv_child_get_parent_aio_context() interface. > > Signed-off-by: Vladimir Semen

Re: [PATCH v3 05/36] block: BdrvChildClass: add .get_parent_aio_context handler

2021-04-12 Thread Alberto Garcia
On Wed 17 Mar 2021 03:34:58 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Add new handler to get aio context and implement it in all child > classes. Add corresponding public interface to be used soon. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

Re: [PULL 0/1] NBD fix for 6.0-rc3

2021-04-12 Thread Peter Maydell
On Mon, 12 Apr 2021 at 13:19, Vladimir Sementsov-Ogievskiy wrote: > > The following changes since commit 555249a59e9cdd6b58da103aba5cf3a2d45c899f: > > Merge remote-tracking branch > 'remotes/ehabkost-gl/tags/x86-next-pull-request' into staging (2021-04-10 > 16:58:56 +0100) > > are available in

Re: [PATCH v3 09/36] block: bdrv_refresh_perms: check for parents permissions conflict

2021-04-12 Thread Alberto Garcia
On Wed 17 Mar 2021 03:35:02 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Add additional check that node parents do not interfere with each > other. This should not hurt existing callers and allows in further > patch use bdrv_refresh_perms() to update a subtree of changed > BdrvChild (check that

Re: [PULL 0/1] NBD fix for 6.0-rc3

2021-04-12 Thread Vladimir Sementsov-Ogievskiy
12.04.2021 18:48, Peter Maydell wrote: On Mon, 12 Apr 2021 at 13:19, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit 555249a59e9cdd6b58da103aba5cf3a2d45c899f: Merge remote-tracking branch 'remotes/ehabkost-gl/tags/x86-next-pull-request' into staging (2021-04-10 16: