Am 19.04.2021 um 19:12 hat Peter Lieven geschrieben:
>
>
> Von meinem iPhone gesendet
>
> > Am 19.04.2021 um 14:31 schrieb Kevin Wolf :
> >
> > Am 19.04.2021 um 11:13 hat Peter Lieven geschrieben:
> >>
> >>
> Am 19.04.2021 um 10:36 schrieb Peter Lieven :
> >>>
> >>>
> >>>
> Am 1
On 19/04/2021 21.27, Klaus Jensen wrote:
From: Klaus Jensen
Get rid of the (reserved) double underscore use.
Cc: Philippe Mathieu-Daudé
Cc: Thomas Huth
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 47 +++
1 file changed, 23 insertions(+),
On 19/04/2021 21.27, Klaus Jensen wrote:
From: Klaus Jensen
Get rid of the (reserved) double underscore use.
Cc: Philippe Mathieu-Daudé
Cc: Thomas Huth
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvm
On 19/04/2021 21.27, Klaus Jensen wrote:
From: Klaus Jensen
Get rid of the (reserved) double underscore use.
Cc: Philippe Mathieu-Daudé
Cc: Thomas Huth
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
I think it wou
On Wed, Apr 07, 2021 at 04:34:57PM +0200, Greg Kurz wrote:
> Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU,
> a serious slow down may be observed on setups with a big enough number
> of vCPUs.
>
> Exemple with a pseries guest on a bi-POWER9 socket system (128 HW threads):
>
From: Klaus Jensen
Add an nvme_moff() helper.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 7 ++-
hw/block/nvme-dif.c | 4 ++--
hw/block/nvme-ns.c | 2 +-
hw/block/nvme.c | 12 ++--
4 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/hw/block/nvme.h b/
From: Klaus Jensen
It is not an error to report more active/open zones supported than the
number of zones in the namespace.
Signed-off-by: Klaus Jensen
---
hw/block/nvme-ns.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c
index 84f6026
From: Klaus Jensen
There is no need to look up the lba size and metadata size in the LBA
Format structure everytime we want to use it. And we use it a lot.
Cache the values in the NvmeNamespace and update them if the namespace
is formatted.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h
From: Klaus Jensen
Streamline namespace array indexing such that both the subsystem and
controller namespaces arrays are 1-indexed.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 4 ++--
hw/block/nvme.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.h
From: Klaus Jensen
Remove non-shared defines from the shared header.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h| 2 --
hw/block/nvme-ns.c | 1 +
hw/block/nvme.c| 1 +
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/nvme.h b/hw/block/nvme.h
index d9374d3e33e
From: Klaus Jensen
The inline nvme_ns_status() helper only has a single call site. Remove
it from the header file and inline it for real.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 5 -
hw/block/nvme.c | 15 ---
2 files changed, 8 insertions(+), 12 deletions(-)
diff --
From: Klaus Jensen
In preparation for moving the nvme device into its own subtree, merge
the header files into one.
Also add missing copyright notice and add list of authors with
substantial contributions.
Signed-off-by: Klaus Jensen
---
hw/block/nvme-dif.h| 63 ---
hw/block/nvme-ns.
From: Klaus Jensen
Clean up includes.
Signed-off-by: Klaus Jensen
---
hw/block/nvme-dif.c| 7 +++
hw/block/nvme-ns.c | 11 ++-
hw/block/nvme-subsys.c | 12 +---
hw/block/nvme.c| 22 +-
4 files changed, 15 insertions(+), 37 deletions(-)
From: Klaus Jensen
Get rid of the (reserved) double underscore use.
Cc: Philippe Mathieu-Daudé
Cc: Thomas Huth
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 47 +++
1 file changed, 23 insertions(+), 24 deletions(-)
diff --git a/hw/block/nvme.c
From: Klaus Jensen
This series consists of various clean up patches.
The final patch moves nvme emulation from hw/block to hw/nvme.
Klaus Jensen (14):
hw/block/nvme: rename __nvme_zrm_open
hw/block/nvme: rename __nvme_advance_zone_wp
hw/block/nvme: rename __nvme_select_ns_iocs
hw/block/
From: Klaus Jensen
With the introduction of the nvme-subsystem device we are really
cluttering up the hw/block directory.
As suggested by Philippe previously, move the nvme emulation to hw/nvme.
Suggested-by: Philippe Mathieu-Daudé
Signed-off-by: Klaus Jensen
---
meson.build
From: Klaus Jensen
The NvmeCtrl num_namespaces member is just an indirection for the
NVME_MAX_NAMESPACES constant.
Remove the indirection.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 1 -
hw/block/nvme.c | 30 +++---
2 files changed, 15 insertions(+), 16 deletio
From: Klaus Jensen
Validation of the max_active and max_open zoned parameters are
independent of any other state, so move them to the early
nvme_ns_check_constraints parameter checks.
Signed-off-by: Klaus Jensen
---
hw/block/nvme-ns.c | 52 +-
1 file
From: Klaus Jensen
Get rid of the (reserved) double underscore use.
Cc: Philippe Mathieu-Daudé
Cc: Thomas Huth
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 624a143
From: Klaus Jensen
Get rid of the (reserved) double underscore use.
Cc: Philippe Mathieu-Daudé
Cc: Thomas Huth
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 002c0672b397..d1b
Von meinem iPhone gesendet
> Am 19.04.2021 um 14:31 schrieb Kevin Wolf :
>
> Am 19.04.2021 um 11:13 hat Peter Lieven geschrieben:
>>
>>
Am 19.04.2021 um 10:36 schrieb Peter Lieven :
>>>
>>>
>>>
Am 15.04.2021 um 17:22 schrieb Kevin Wolf :
Peter, three years ago you ch
Ping ?
On Wed, 7 Apr 2021 16:34:57 +0200
Greg Kurz wrote:
> Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU,
> a serious slow down may be observed on setups with a big enough number
> of vCPUs.
>
> Exemple with a pseries guest on a bi-POWER9 socket system (128 HW threads):
Am 19.04.2021 um 07:06 hat Thomas Huth geschrieben:
> On 16/04/2021 22.34, Nir Soffer wrote:
> > On Fri, Apr 16, 2021 at 8:23 AM Thomas Huth wrote:
> > >
> > > A customer reported that running
> > >
> > > qemu-img convert -t none -O qcow2 -f qcow2 input.qcow2 output.qcow2
> > >
> > > fails fo
Am 19.04.2021 um 11:13 hat Peter Lieven geschrieben:
>
>
> > Am 19.04.2021 um 10:36 schrieb Peter Lieven :
> >
> >
> >
> >> Am 15.04.2021 um 17:22 schrieb Kevin Wolf :
> >>
> >> Peter, three years ago you changed 'qemu-img convert' to sacrifice some
> >> sparsification in order to get aligned
Am 19.04.2021 um 10:36 hat Peter Lieven geschrieben:
>
>
> > Am 15.04.2021 um 17:22 schrieb Kevin Wolf :
> >
> > Peter, three years ago you changed 'qemu-img convert' to sacrifice some
> > sparsification in order to get aligned requests on the target image. At
> > the time, I thought the impact
On Apr 19 16:18, Gollu Appalanaidu wrote:
Currently IO Command Set Profile feaure is supported, but
feature support flag not set and this feature is changable
add support for that.
Remove filling default value of feature in CQE CDW0 with zero,
since it fallbacks to default case and it is zero in
Currently IO Command Set Profile feaure is supported, but
feature support flag not set and this feature is changable
add support for that.
Remove filling default value of feature in CQE CDW0 with zero,
since it fallbacks to default case and it is zero initialized,
if feature default value not set
19.04.2021 12:34, Daniel P. Berrangé wrote:
On Fri, Apr 16, 2021 at 11:08:59AM +0300, Vladimir Sementsov-Ogievskiy wrote:
Detecting monitor by current coroutine works bad when we are not in
coroutine context. And that's exactly so in nbd reconnect code, where
qio_channel_socket_connect_sync() is
All boards calling pflash_cfi02_register() use nb_mappings=1,
which does not do any mapping:
$ git grep -wl pflash_cfi02_register hw/
hw/arm/xilinx_zynq.c
hw/block/pflash_cfi02.c
hw/lm32/lm32_boards.c
hw/ppc/ppc405_boards.c
hw/sh4/r2d.c
We can remove this now unneeded code.
Reviewed-
Instead of using a device specific feature for mapping the
flash memory multiple times over a wider region, use the
generic memory_region_add_subregion_aliased() helper.
There is no change in the memory layout.
* before:
$ qemu-system-arm -M canon-a1100 -S -monitor stdio
QEMU 5.2.90 monitor
The previous commit removed the mapping code from TYPE_PFLASH_CFI02.
pflash_cfi02_register() doesn't use the 'nb_mappings' argument
anymore. Simply remove it to simplify.
Reviewed-by: David Gibson
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/block/flash.h | 1 -
hw/arm/digic_boards.c
To be able to manually map the flash region on the main memory
(in the next commit), first expand the pflash_cfi02_register
in place.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/digic_boards.c | 27 +--
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/h
Instead of using a device specific feature for mapping the
flash memory multiple times over a wider region, use the
generic memory_region_add_subregion_aliased() helper.
There is no change in the memory layout:
- before:
(qemu) info mtree
fe00- (prio 0, i/o): pfla
To be able to manually map the flash region on the main memory
(in the next commit), first expand the pflash_cfi02_register
in place.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/musicpal.c | 27 +--
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/hw/ar
// TODO explain here how buses work? when some address lines are
// not bound we get memory aliasing, high addresses are masked.
// etc...
Add a helper to manage this use case easily.
For example a having @span_size = @region_size / 4 we get such mapping:
^---^
|
Hi,
This series introduce the memory_region_add_subregion_aliased()
helper which basically create a device which maps a subregion
multiple times.
Since v1:
- Split series in 2, keeping the I/O regions (showed with the q800
machine) part for 2nd part
- Added R-b tags
Examples are easier, so hav
On Fri, Apr 16, 2021 at 11:08:59AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Detecting monitor by current coroutine works bad when we are not in
> coroutine context. And that's exactly so in nbd reconnect code, where
> qio_channel_socket_connect_sync() is called from thread.
>
> Add a possibili
On 3/25/21 1:09 PM, Philippe Mathieu-Daudé wrote:
> Simplify memory layout when no pflash_cfi02 mapping requested.
> Philippe Mathieu-Daud=C3=A9 (2):
> hw/block/pflash_cfi02: Set romd mode in pflash_cfi02_realize()
> hw/block/pflash_cfi02: Do not create aliases when not necessary
Thanks, seri
> Am 19.04.2021 um 10:36 schrieb Peter Lieven :
>
>
>
>> Am 15.04.2021 um 17:22 schrieb Kevin Wolf :
>>
>> Peter, three years ago you changed 'qemu-img convert' to sacrifice some
>> sparsification in order to get aligned requests on the target image. At
>> the time, I thought the impact would
Make the (only) caller do it.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
Signed-off-by: Emanuele Giuseppe Esposito
---
block.c | 22 +-
blockdev.c| 7 ++-
include/block/block.h | 1 +
3 files changed, 12 insertions(+), 18 delet
Replication functions are mostly called when the BDS is quiescent and
does not have any pending I/O. They do not need to synchronize on
anything since BDS and BB are now thread-safe.
Signed-off-by: Paolo Bonzini
Signed-off-by: Emanuele Giuseppe Esposito
---
block/replication.c | 54 ++-
Reopen needs to handle AioContext carefully due to calling
bdrv_drain_all_begin/end. By not taking AioContext around calls to
bdrv_reopen_multiple, we can drop the function's release/acquire
pair and the AioContext argument too.
Signed-off-by: Paolo Bonzini
Signed-off-by: Emanuele Giuseppe Espos
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
Signed-off-by: Emanuele Giuseppe Esposito
---
include/block/block_int.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index a1aad5ad2d..67a0777e12 100644
---
Note that calling rcu_read_lock() is left to the caller. In fact,
if the notifier is really only used within the BQL, it's unnecessary.
Even outside the BQL, RCU accessors can also be used with any API that has
the same contract as synchronize_rcu, i.e. it stops until all concurrent
readers compl
Reads access the list in RCU style, so be careful to avoid use-after-free
scenarios in the backup block job. Apart from this, all that's needed
is protecting updates with a mutex.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
Signed-off-by: Emanuele Giuseppe Esposito
---
block.c
For simplicity, use bdrv_drained_begin/end to avoid concurrent
writes to the write threshold, or reading it while it is being set.
qmp_block_set_write_threshold is protected by the BQL.
Reviewed-by: Stefan Hajnoczi
Co-developed-by: Paolo Bonzini
Signed-off-by: Emanuele Giuseppe Esposito
---
bl
This and the following serie of patches are based on Paolo's
v1 patches sent in 2017[*]. They have been ported to the current QEMU
version, but the goal remains the same:
- make the block layer thread-safe (patches 1-5), and
- remove aio_context_acquire/release (patches 6-8).
[*] = https://lists.
Reviewed-by: Stefan Hajnoczi
Co-developed-by: Paolo Bonzini
Signed-off-by: Emanuele Giuseppe Esposito
---
block/write-threshold.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/block/write-threshold.c b/block/write-threshold.c
index 85b78dc2a9
> Am 15.04.2021 um 17:22 schrieb Kevin Wolf :
>
> Peter, three years ago you changed 'qemu-img convert' to sacrifice some
> sparsification in order to get aligned requests on the target image. At
> the time, I thought the impact would be small, but it turns out that
> this can end up wasting gi
49 matches
Mail list logo
