Re: [PATCH 2/3] hw/ide: Add Kconfig dependency MICRODRIVE -> PCMCIA

2021-04-24 Thread Warner Losh
On Sat, Apr 24, 2021 at 4:24 PM Philippe Mathieu-Daudé wrote: > The Microdrive Compact Flash can be plugged on a PCMCIA bus. > Express the dependency using the 'depends on' Kconfig expression. > Reviewed-by: Warner Losh > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ide/Kconfig | 1 + >

Re: [PATCH 1/3] hw/arm/pxa2xx: Declare PCMCIA bus with Kconfig

2021-04-24 Thread Warner Losh
On Sat, Apr 24, 2021 at 4:22 PM Philippe Mathieu-Daudé wrote: > The Intel XScale PXA chipsets provide a PCMCIA controller, > which expose a PCMCIA (IDE) bus. Express this dependency using > the Kconfig 'select' expression. > I'd consider dropping the (IDE) in the description of the PCMCIA bus

Re: [PATCH 0/3] hw: Restrict PCMCIA to ARM target

2021-04-24 Thread Richard Henderson
On 4/24/21 3:20 PM, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (3): hw/arm/pxa2xx: Declare PCMCIA bus with Kconfig hw/ide: Add Kconfig dependency MICRODRIVE -> PCMCIA hw/pcmcia: Do not register PCMCIA type if not required Reviewed-by: Richard Henderson r~

[PATCH 1/3] hw/arm/pxa2xx: Declare PCMCIA bus with Kconfig

2021-04-24 Thread Philippe Mathieu-Daudé
The Intel XScale PXA chipsets provide a PCMCIA controller, which expose a PCMCIA (IDE) bus. Express this dependency using the Kconfig 'select' expression. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig

[PATCH 2/3] hw/ide: Add Kconfig dependency MICRODRIVE -> PCMCIA

2021-04-24 Thread Philippe Mathieu-Daudé
The Microdrive Compact Flash can be plugged on a PCMCIA bus. Express the dependency using the 'depends on' Kconfig expression. Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index

[PATCH 3/3] hw/pcmcia: Do not register PCMCIA type if not required

2021-04-24 Thread Philippe Mathieu-Daudé
If the Kconfig 'PCMCIA' value is not selected, it is pointless to build the PCMCIA core components. (Currently only one machine of the ARM targets requires this). Signed-off-by: Philippe Mathieu-Daudé --- hw/pcmcia/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/3] hw: Restrict PCMCIA to ARM target

2021-04-24 Thread Philippe Mathieu-Daudé
Only a pair of ARM PXA machines requires the PCMCIA type. Complete the Kconfig dependencies to only build the PCMCIA related devices when required. Philippe Mathieu-Daudé (3): hw/arm/pxa2xx: Declare PCMCIA bus with Kconfig hw/ide: Add Kconfig dependency MICRODRIVE -> PCMCIA hw/pcmcia: Do

[PATCH 3/5] hw/block/nand: Register machine reset handler

2021-04-24 Thread Philippe Mathieu-Daudé
The TYPE_NAND device is bus-less, thus isn't reset automatically. Register a reset handler to get reset with the machine. Fixed: 7426aa72c36 ("nand: Don't inherit from Sysbus") Signed-off-by: Philippe Mathieu-Daudé --- hw/block/nand.c | 14 ++ 1 file changed, 14 insertions(+) diff

[PATCH 5/5] hw/arm/armsse: Manually reset the OR_IRQ devices

2021-04-24 Thread Philippe Mathieu-Daudé
The OR_IRQ device is bus-less, thus isn't reset automatically. Manually reset the OR IRQs in the armsse_reset() handler. Fixes: bb75e16d5e6 ("hw/arm/iotkit: Wire up MPC interrupt lines") Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/armsse.c | 4 1 file changed, 4 insertions(+) diff

[PATCH 4/5] hw/pci-host/raven: Manually reset the OR_IRQ device

2021-04-24 Thread Philippe Mathieu-Daudé
The OR_IRQ device is bus-less, thus isn't reset automatically. Add the raven_pcihost_reset() handler to manually reset the OR IRQ. Fixes: f40b83a4e31 ("40p: use OR gate to wire up raven PCI interrupts") Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/prep.c | 10 ++ 1 file

[PATCH 2/5] hw/pcmcia/microdrive: Register machine reset handler

2021-04-24 Thread Philippe Mathieu-Daudé
The abstract PCMCIA_CARD is a bus-less TYPE_DEVICE, so devices implementing it are not reset automatically. Register a reset handler so children get reset on machine reset. Note, the DSCM-1 device (TYPE_DSCM1) which inherits TYPE_MICRODRIVE and PCMCIA_CARD reset itself when a disk is

[PATCH 1/5] hw/ppc/spapr_iommu: Register machine reset handler

2021-04-24 Thread Philippe Mathieu-Daudé
The TYPE_SPAPR_TCE_TABLE device is bus-less, thus isn't reset automatically. Register a reset handler to get reset with the machine. It doesn't seem to be an issue because it is that way since the device QDev'ifycation 8 years ago, in commit a83000f5e3f ("spapr-tce: make sPAPRTCETable a proper

[PATCH 0/5] hw: Fix reset of bus-less devices

2021-04-24 Thread Philippe Mathieu-Daudé
Hi, This series is the result of a code audit of the DeviceClass::reset() method uses, having Markus following explanation in mind [1]: "Propagating reset from the root of the qtree to the leaves won't reach a bus-less device, because the qtree contains only the devices that plug into a