Re: [PATCH 0/7] floppy: build as modules.

2021-08-16 Thread John Snow
On Thu, Aug 5, 2021 at 3:12 AM Gerd Hoffmann wrote: > On Wed, Aug 04, 2021 at 05:19:02PM +0200, Philippe Mathieu-Daudé wrote: > > +Mark > > > > On 8/4/21 4:27 PM, Gerd Hoffmann wrote: > > > Some code shuffling needed beforehand due to floppy being part of > > > several platforms. While being at

Re: [PATCH v3 2/6] block: block-status cache for data regions

2021-08-16 Thread Eric Blake
On Thu, Aug 12, 2021 at 10:41:44AM +0200, Hanna Reitz wrote: > As we have attempted before > (https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html, > "file-posix: Cache lseek result for data regions"; > https://lists.nongnu.org/archive/html/qemu-block/2021-02/msg00934.html, >

Re: [PATCH] qemu-storage-daemon: Only display FUSE help when FUSE is built-in

2021-08-16 Thread Eric Blake
On Mon, Aug 16, 2021 at 08:04:42PM +0200, Philippe Mathieu-Daudé wrote: > When configuring QEMU with --disable-fuse, the qemu-storage-daemon > still reports FUSE command line options in its help: > > $ qemu-storage-daemon -h > Usage: qemu-storage-daemon [options] > QEMU storage daemon > >

Re: [PATCH] spec: Clarify STARTTLS vs. SET_META_CONTEXT interaction

2021-08-16 Thread Wouter Verhelst
On Mon, Aug 16, 2021 at 01:02:55PM -0500, Eric Blake wrote: > On Mon, Aug 16, 2021 at 05:31:10PM +0200, Wouter Verhelst wrote: > > > > +++ b/doc/proto.md > > > @@ -1165,6 +1165,14 @@ of the newstyle negotiation. > > > permitted by this document (for example, `NBD_REP_ERR_INVALID` if > > >

[PATCH] spec: Relax NBD_OPT_LIST_META_CONTEXTS

2021-08-16 Thread Eric Blake
Using OPT_SET_META_CONTEXTS is stateful (it is documented to wipe out any previously-requested contexts, and we just tightened the spec to clarify that starting TLS also wipes it out). But OPT_LIST_META_CONTEXTS is not stateful; and in fact, with a SELECTIVETLS server, it can be handy to list the

[PATCH] include/block.h: remove outdated comment in bdrv_drained_begin

2021-08-16 Thread Emanuele Giuseppe Esposito
There are a couple of errors in bdrv_drained_begin header comment: - block_job_pause does not exist anymore, it has been replaced with job_pause in b15de82867 - job_pause is automatically invoked as a .drained_begin callback (child_job_drained_begin) by the child_job BdrvChildClass struct in

[PATCH] qemu-storage-daemon: Only display FUSE help when FUSE is built-in

2021-08-16 Thread Philippe Mathieu-Daudé
When configuring QEMU with --disable-fuse, the qemu-storage-daemon still reports FUSE command line options in its help: $ qemu-storage-daemon -h Usage: qemu-storage-daemon [options] QEMU storage daemon --export [type=]fuse,id=,node-name=,mountpoint=

Re: [PATCH] spec: Clarify STARTTLS vs. SET_META_CONTEXT interaction

2021-08-16 Thread Eric Blake
On Mon, Aug 16, 2021 at 05:31:10PM +0200, Wouter Verhelst wrote: > > +++ b/doc/proto.md > > @@ -1165,6 +1165,14 @@ of the newstyle negotiation. > > permitted by this document (for example, `NBD_REP_ERR_INVALID` if > > the client included data). > > > > +When this command succeeds,

Re: [PATCH] qemu-nbd: Change default cache mode to writeback

2021-08-16 Thread Eric Blake
On Fri, Aug 13, 2021 at 11:55:19PM +0300, Nir Soffer wrote: > Both qemu and qemu-img use writeback cache mode by default, which is > already documented in qemu(1). qemu-nbd uses writethrough cache mode by > default, and the default cache mode is not documented. > > According to the qemu-nbd(8): >

Re: [PATCH] spec: Clarify STARTTLS vs. SET_META_CONTEXT interaction

2021-08-16 Thread Wouter Verhelst
On Thu, Aug 12, 2021 at 10:20:40AM -0500, Eric Blake wrote: > Consider a SELECTIVETLS server and a MitM attacker, under the > following NBD_OPT_ handshake scenario: > > client: mitm:server: > > _STARTTLS > > _SET_META_CONTEXT("A") >

Re: [PATCH] docs: Link to protocol security considerations in uri docs

2021-08-16 Thread Wouter Verhelst
On Thu, Aug 12, 2021 at 09:39:24AM -0500, Eric Blake wrote: > On Tue, Aug 10, 2021 at 01:08:59PM -0500, Eric Blake wrote: > > Especially useful in light of the recent publishing of > > https://nostarttls.secvuln.info/, which documents a variety of > > implementations vulnerable to downgrade