Re: [PATCH] block/file-posix: Fix return value translation for AIO discards.

2021-10-18 Thread Philippe Mathieu-Daudé
+Stefan On 10/18/21 20:07, Ari Sundholm wrote: > AIO discards regressed as a result of the following commit: > 0dfc7af2 block/file-posix: Optimize for macOS > > When trying to run blkdiscard within a Linux guest, the request would > fail, with some errors in dmesg: > > [ snip ]

Re: [PATCH] block/file-posix: Fix return value translation for AIO discards.

2021-10-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki On Tue, Oct 19, 2021 at 3:08 AM Ari Sundholm wrote: > > AIO discards regressed as a result of the following commit: > 0dfc7af2 block/file-posix: Optimize for macOS > > When trying to run blkdiscard within a Linux guest, the request would > fail, with some

[PATCH] block/file-posix: Fix return value translation for AIO discards.

2021-10-18 Thread Ari Sundholm
AIO discards regressed as a result of the following commit: 0dfc7af2 block/file-posix: Optimize for macOS When trying to run blkdiscard within a Linux guest, the request would fail, with some errors in dmesg: [ snip ] [4.010070] sd 2:0:0:0: [sda] tag#0 FAILED Result:

Re: [RFC PATCH 0/4] Replace custom test harness with "meson test"

2021-10-18 Thread Paolo Bonzini
On 18/10/21 11:51, Thomas Huth wrote: * CTRL+C will only interrupt the longest running test.  Pressing    CTRL+C repeatedly three times (which you would likely do anyway,    that's how things work) interrupts the whole run I tried this, and while hitting CTRL-C multiple times brought me back

Re: [PATCH 10/15] hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime

2021-10-18 Thread Łukasz Gieryk
On Mon, Oct 18, 2021 at 12:06:22PM +0200, Philippe Mathieu-Daudé wrote: > On 10/7/21 18:24, Lukasz Maniak wrote: > > From: Łukasz Gieryk > > > > The Nvme device defines two properties: max_ioqpairs, msix_qsize. Having > > them as constants is problematic for SR-IOV support. > > > > The SR-IOV

Re: [PATCH] block: Fail gracefully when blockdev-snapshot creates loops

2021-10-18 Thread Vladimir Sementsov-Ogievskiy
18.10.2021 16:47, Kevin Wolf wrote: Using blockdev-snapshot to append a node as an overlay to itself, or to any of its parents, causes crashes. Catch the condition and return an error for these cases instead. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1824363 Signed-off-by: Kevin Wolf

[PATCH] block: Fail gracefully when blockdev-snapshot creates loops

2021-10-18 Thread Kevin Wolf
Using blockdev-snapshot to append a node as an overlay to itself, or to any of its parents, causes crashes. Catch the condition and return an error for these cases instead. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1824363 Signed-off-by: Kevin Wolf --- block.c| 10

Re: regression on s390: was Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-18 Thread Markus Armbruster
Christian Borntraeger writes: [...] > The 2nd thing to do is to fix the regression. Does anyone have an idea what > is broken? I do: "device ID or QOM path" arguments where the device ID contains '/'. Undocumented feature, as far as I can tell. I'll fix it anyway. Affects device_del,

Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-18 Thread Markus Armbruster
Christian Borntraeger writes: > Am 13.10.21 um 11:07 schrieb Paolo Bonzini: >> From: Markus Armbruster >> Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" >> extended find_device_state() to accept QOM paths in addition to qdev >> IDs. This added a checked conversion to

regression on s390: was Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-18 Thread Christian Borntraeger
Am 15.10.21 um 21:15 schrieb Richard Henderson: On 10/15/21 4:08 AM, Christian Borntraeger wrote: Am 13.10.21 um 11:07 schrieb Paolo Bonzini: From: Markus Armbruster Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" extended find_device_state() to accept QOM paths in

Re: [PATCH 10/15] hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime

2021-10-18 Thread Philippe Mathieu-Daudé
On 10/7/21 18:24, Lukasz Maniak wrote: > From: Łukasz Gieryk > > The Nvme device defines two properties: max_ioqpairs, msix_qsize. Having > them as constants is problematic for SR-IOV support. > > The SR-IOV feature introduces virtual resources (queues, interrupts) > that can be assigned to PF

Re: [PATCH 11/15] hw/nvme: Calculate BAR atributes in a function

2021-10-18 Thread Philippe Mathieu-Daudé
Hi Łukasz, On 10/7/21 18:24, Lukasz Maniak wrote: > From: Łukasz Gieryk > > An Nvme device with SR-IOV capability calculates the BAR size > differently for PF and VF, so it makes sense to extract the common code > to a separate function. > > Also: it seems the n->reg_size parameter

Re: [RFC PATCH 0/4] Replace custom test harness with "meson test"

2021-10-18 Thread Thomas Huth
On 15/10/2021 12.07, Paolo Bonzini wrote: Hi all, Starting with Meson 0.57, "meson test" has all features of QEMU's makefile-based harness and more. I just gave it a try, and basically I like this ... but I also encountered two issues: * CTRL+C will only interrupt the longest running